From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BE5F7740034 for ; Tue, 7 Nov 2023 02:57:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=AbvMUjIX5udccJ2sqdbhjYrK7jZmvjzXpqdktwWKipA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699325861; v=1; b=pVWRa95sIAEQUgU34wADl60r6x3boHiAcf+clbekpme4QdmEGpgpNKtEofvEwy0rW4Nt6mGY RWhS+zp1YKSZybQn8ziDA+/1MNS9e20+8uE/BcNGMIsmdGZ8sIuZy+X1vzz/z9twi4xRIqw4mn1 IFkr5Ji6RE/NtUST45W0E3Yk= X-Received: by 127.0.0.2 with SMTP id 5ntiYY7687511xH7H8ns6kK5; Mon, 06 Nov 2023 18:57:41 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web10.2536.1699325860282297188 for ; Mon, 06 Nov 2023 18:57:40 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10886"; a="8053442" X-IronPort-AV: E=Sophos;i="6.03,282,1694761200"; d="scan'208";a="8053442" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 18:57:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10886"; a="797501746" X-IronPort-AV: E=Sophos;i="6.03,282,1694761200"; d="scan'208";a="797501746" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Nov 2023 18:57:39 -0800 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 6 Nov 2023 18:57:39 -0800 X-Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 6 Nov 2023 18:57:38 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Mon, 6 Nov 2023 18:57:38 -0800 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 6 Nov 2023 18:57:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eZx8TCcrBOlNPpuWIeL2OW0EN3YWhLPqJo2FkCEpg2FuzUfJJvhdTyS5oqxBb42R1DTEPq8NB3f2j2cnkakVtVSDr/3Ez42Q43nu9zk2PK5+5bpo+L6LYdE/qmfzgSTWV8Csri5o9viyVEqEMxpO5hWTHviwAqfeb/jcb+QPb3WZZKOWFY8JU3Td8fkkA/VTig2Vo7Bm7zAVTj6ppDZERqEU/2wI7tHW0anV4irBu2z/ODKz+1mRz7ZgYQotn0VppeIWCM+t++U1h0uU8kPJ7d7Vkegd7YF+QK0Fv3WwmFg7AGCP4el/mfmwyTekjDTlXECvqBPhORdzZjpnLvwcMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PZcViV5nzYMFkGqEkcZNZ7zkGNXhPf0lgB1NeM4Jnpk=; b=NMa6FbY7k8XZEOKTS97tg2le6Kv/C9PMPKssUqbIRP/w9OrXbCVh3nUlB9tOdu9z4b3/w5kN03RZzTU5O8U56ug+tyhj+rEVkA0rPGB/kqm5hjKUgkfkhp9JI8U1oMxKbQmseJ0HHB3jmoYNTrDIgAE3xJpWQvpR7hwFPtgx/vWx2GHoHzrPaDGH4wwrkvAl6lrtguhoIgtzCb6pAtErBNWYkawD9XYFylt+nMnVouz6OBU6Tg1FRFkZ8epdO7ik/RCnTz3XWu5w5ofNIxKRIaRpRq6RAIb4845+MaVAw7huMWIzQqUMRNBiCyQOfS+JEIIwF+xGhRT9s8m26ybbFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CH3PR11MB8137.namprd11.prod.outlook.com (2603:10b6:610:15c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Tue, 7 Nov 2023 02:57:35 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2f2f:41ab:b556:7257]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2f2f:41ab:b556:7257%3]) with mapi id 15.20.6954.027; Tue, 7 Nov 2023 02:57:35 +0000 From: "Yao, Jiewen" To: "Li, Yi1" , Pierre Gondois , "devel@edk2.groups.io" CC: "Lu, Xiaoyu1" , "Jiang, Guomin" , Leif Lindholm , "Ard Biesheuvel" , Sami Mujawar , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH v1 0/7] CryptoPkg: Enable Openssl native instruction support for AARCH64 Thread-Topic: [PATCH v1 0/7] CryptoPkg: Enable Openssl native instruction support for AARCH64 Thread-Index: AQHaDZQkdnLB6VWMRECBXSQ8cLD7vbBuK+AAgAAE0dA= Date: Tue, 7 Nov 2023 02:57:34 +0000 Message-ID: References: <20231102135417.336334-1-pierre.gondois@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|CH3PR11MB8137:EE_ x-ms-office365-filtering-correlation-id: c7f909b1-1e11-4f8f-938d-08dbdf3d4b2b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: B3lcCch7ORSS0HRtL5tiEp0Fc4FRyJMcXsw/v+dcs+RZ1Q6/uW4a0qoJXkprYBAVixXvcDfbDdzTg2ytRlN//mmVm0XySEdE9TxGeieM1X+GNrtR2AyshrGhj19ERzEEgYWMoAgOnje8opQ77FWpmfvm438s3C64CHkm1WzAOafaOeLqxGp2AjEIg9obYWnlTPI+RC8GCHGYiMMxs3aEapjjqM9DB6+JEAMTaXYLktHmKa1sYxtkHJTeBBvSWw8Fkos/HShDLBDh1j/KOg4371YaBXELWpti/HHp3akQ0Aui36hysjm22Ib4/9pp0FbljQbm2hfQUihjO3NdFxNn+3rYTFS/ysrH+HmvJIBbspB3fFSzVtIkRElN3e1VphDQ/4wkQXXvLjJiMciGGFHnCr0G+2Dm11WIh5TbJd+OL6NY2XOGNbA5rTtPvUFdJg47zWSrhU4AySkE5N8Zalh7aTeRR2Lw9e4tfH1SBLHvCcW/fwPENoca3F4G0iuHP5HzTY/TLQOVuCzrdK5LWGs10rRX7BGMbOg/1MDNRjoYLItfGJek/wLLCiIDcEjM3UwlU2wDEJC6bp/BtZ9/0/y9ciwjtOUkYV5TSLsz164mirHO+WFIjBz7HsiPgxFaKInK x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Z4tzYYZ6r0ukF95lWsPqH5HL4/1vWt6TgtyOCFMfesS1msprPfC/vKnz5dAJ?= =?us-ascii?Q?QoOG5qJ6n95lXH2k/OqcAXM19o0J1XBMIiZVkFSCzLDcsW56aNJnFm/eqJ1Y?= =?us-ascii?Q?+r42st4umWxg3CTGFmKtFbBypSwVqYPX9l4x/zWHH1kzXEgnvQZ25pJMQMdm?= =?us-ascii?Q?csV4d1lYN0XTQeHU3jMSogpcR2mA/Anfje6K3bcypg976NU5a1/bk7LKVsMh?= =?us-ascii?Q?1Bg5o3IJVzFrzQQvW4ahzRQa2iv7yuD57jpe58WIQEGoNKu5aqco6n7+UgAW?= =?us-ascii?Q?1Hcc/x0IEvmfgroZFp0R+Nc3V2EHZyG0woG+3tY6p0FBH1cQsrrcT39ythwc?= =?us-ascii?Q?FgqnnXx3M/Z87YWU5BWDRs4yOGw8hPNlEdOX7cR3rAqUi7QPm/fGY88AjjJJ?= =?us-ascii?Q?2WNSP+yusxM/q1cW9oKOG0PNuuuHdVN/3DiObwRidxqoMzM++UzEdQsNFUoT?= =?us-ascii?Q?3ik5pwQXiz1XfUdEn2rOnGSG/EQQB5kUsbzNsibtoKsinlNINRHWjKvC+nch?= =?us-ascii?Q?KnVn7Y90W5B29e8vGwa15qdcOBlOXYnMZ+RjFCyuiyvgz74eUwVloFbqgKvZ?= =?us-ascii?Q?QVdGxGfPp6iq0ZaIe0YtQd4CxISboafYMw50OdOG1elWnRLBIcZoP7MnYQk9?= =?us-ascii?Q?K/NdOftfKWyv+T+pMaQrXRacOqjSmVVahhNLqaYsKQhf1ke29mpn4zRKPhew?= =?us-ascii?Q?G/RUewo4TskC3ju5gA+zsdxnZxDk8jq0mDC7FQiop/B/O6rpl2JyLtp4TAst?= =?us-ascii?Q?KehU4srLfOA0l0366Dknb74C/r6QVJ5c6+u2XW8rbV0CPSbtYWD9nVcU4Ll5?= =?us-ascii?Q?M1GDECITROL76iJ9nerjx8r7DDFUbYdIQKwQ3i4RHOED2Rz5ZVej3Af1nSh+?= =?us-ascii?Q?4B+fW9B31S566zUe2B48j9gismkkk2L9M9p1vOOKPd1cNG/aW03tuNJsXTJL?= =?us-ascii?Q?anCMbqr3HjoIMHp/iI6SBV/SHEDgHHI/BVYZKZMhfRQT4+ULwHUnx/KC35bO?= =?us-ascii?Q?A6pQeCjq4XfHqV+ATECmIay1triokgG7RYOc9cmTDBvDMdmA5ayTkw8obyhG?= =?us-ascii?Q?FYxQ4EYB1iw+tpFBX6tnpOCLqFdJ10XGPg9bQ9S0XimzSt+MAA5/+El+KzLv?= =?us-ascii?Q?cyo+Vwzx9AoPiDmj96WGWM94vHkNKYAWWHW9GgkEc6AAWJ9KiwmvwPiJ0Tp4?= =?us-ascii?Q?TcGkyxmDpNFshobW6N2vfialjOBfKiZHWSt/sj+uU01cRswq38aGK0hGKlib?= =?us-ascii?Q?q1GAF/4MMlLQR/vSQjMA5M9obscRxQvvvnPzp2lLHuQQY4+On1DZ2wR26HjK?= =?us-ascii?Q?/doYNSOMD4Dr23cHxVZ1Y/sBh0AAwSRBdakZJhkocy+bor0ZaNnLdDkyOw35?= =?us-ascii?Q?dnqus7h2eJltohv755IxtSbVZ0Z91Zu2IacuhCetx3R941CqnRb24oP7Jxmu?= =?us-ascii?Q?qTROKp0swmROrsp4Vi76YCchGi9v9UP6rb/YyqFsVzJJydmdX0Mjd6+eWXuC?= =?us-ascii?Q?A0DZ+1FZRnbhL4qiLbtD3KUHsUugO/sr0TbhFN0DAR70wSpsGLkUTPIw1gAx?= =?us-ascii?Q?C2Gt6HJR4C3MRopPKcEXyrXthlliSvrzLKkqmSYg?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7f909b1-1e11-4f8f-938d-08dbdf3d4b2b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2023 02:57:34.9921 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0Mjvvf+lHVUKWbhHVUKfGmYHpMVWVMEwnuJSP/14H0Q2K1d9E5Y9YRXqj08lEchGDyynCILtb+6UL9zvF8dFDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8137 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YUofJxgCOq89mzxQn3CiVTwPx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=pVWRa95s; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Leif/Ard/Sami I would expect ARM/AARCH64 maintainers to review the ARM specific files, ev= en they are in CryptoPkg. Please help on that. Thank you Yao, Jiewen > -----Original Message----- > From: Li, Yi1 > Sent: Tuesday, November 7, 2023 10:39 AM > To: Pierre Gondois ; devel@edk2.groups.io > Cc: Yao, Jiewen ; Lu, Xiaoyu1 ; > Jiang, Guomin ; Leif Lindholm > ; Ard Biesheuvel ; > Sami Mujawar ; Gerd Hoffmann > > Subject: RE: [PATCH v1 0/7] CryptoPkg: Enable Openssl native instruction = support > for AARCH64 >=20 > Hi Pierre, >=20 > Could you share what tests you did and the test results? >=20 > Regards, > Yi >=20 > -----Original Message----- > From: Pierre Gondois > Sent: Thursday, November 2, 2023 9:54 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Li, Yi1 ; Lu, X= iaoyu1 > ; Jiang, Guomin ; Leif Lind= holm > ; Ard Biesheuvel ; > Sami Mujawar ; Gerd Hoffmann > > Subject: [PATCH v1 0/7] CryptoPkg: Enable Openssl native instruction supp= ort for > AARCH64 >=20 > Various OpensslLib implementations are available in edk2. The > OpensslLibAccel.inf and OpensslLibFullAccel.inf ones use architecture spe= cific > instructions, e.g. AESE, PMULL, SHA256H, ..., allowing to improve speed. >=20 > Enable support for Aarch64's native instructions: > - Add ArmReadCntPctReg() and ArmReadIdAA64Isar0Reg() to > Aarch64's BaseLib. > - Generate Aarch64's specific Openssl functions. > - Add a OpensslStub/AArch64Cap.c file to allow Openssl > to probe Aarch64 native instruction support. >=20 > This patch-set only enable support for GCC for now (MSFT support not adde= d). >=20 > Pierre Gondois (7): > MdePkg/BaseLib: AARCH64: Add ArmReadCntPctReg() > MdePkg/BaseLib: AARCH64: Add ArmReadIdAA64Isar0Reg() > MdePkg/BaseRngLib: Prefer ArmReadIdAA64Isar0Reg() over > ArmReadIdIsar0() > CryptoPkg/OpensslLib: Add native instruction support for AARCH64 > CryptoPkg/OpensslLib: Generate files for AARCH64 native support > CryptoPkg/OpensslLib: Add AArch64Cap for arch specific hooks > CryptoPkg: Enable Openssl Accel builds for AARCH64 >=20 > CryptoPkg/CryptoPkg.dsc | 23 +- > .../AARCH64-GCC/crypto/aes/aesv8-armx.S | 3180 ++++++++ > .../AARCH64-GCC/crypto/aes/vpaes-armv8.S | 1196 +++ > .../AARCH64-GCC/crypto/arm64cpuid.S | 129 + > .../AARCH64-GCC/crypto/bn/armv8-mont.S | 2124 ++++++ > .../crypto/ec/ecp_nistz256-armv8.S | 4242 +++++++++++ > .../crypto/modes/aes-gcm-armv8_64.S | 6389 +++++++++++++++++ > .../AARCH64-GCC/crypto/modes/ghashv8-armx.S | 552 ++ > .../AARCH64-GCC/crypto/sha/keccak1600-armv8.S | 1009 +++ > .../AARCH64-GCC/crypto/sha/sha1-armv8.S | 1211 ++++ > .../AARCH64-GCC/crypto/sha/sha256-armv8.S | 2051 ++++++ > .../AARCH64-GCC/crypto/sha/sha512-armv8.S | 1606 +++++ > .../Library/OpensslLib/OpensslLibAccel.inf | 642 +- > .../OpensslLib/OpensslLibFullAccel.inf | 691 +- > .../OpensslLib/OpensslStub/AArch64Cap.c | 107 + > CryptoPkg/Library/OpensslLib/UefiAsm.conf | 6 + > CryptoPkg/Library/OpensslLib/configure.py | 5 +- > CryptoPkg/Readme.md | 14 +- > MdePkg/Include/Library/BaseLib.h | 86 + > .../BaseLib/AArch64/ArmReadCntPctReg.S | 30 + > .../BaseLib/AArch64/ArmReadCntPctReg.asm | 30 + > .../AArch64/ArmReadIdAA64Isar0Reg.S} | 10 +- > .../AArch64/ArmReadIdAA64Isar0Reg.asm} | 10 +- > MdePkg/Library/BaseLib/BaseLib.inf | 6 +- > MdePkg/Library/BaseRngLib/AArch64/ArmRng.h | 12 - > MdePkg/Library/BaseRngLib/AArch64/Rndr.c | 14 +- > MdePkg/Library/BaseRngLib/BaseRngLib.inf | 2 - > 27 files changed, 25320 insertions(+), 57 deletions(-) create mode 1006= 44 > CryptoPkg/Library/OpensslLib/OpensslGen/AARCH64-GCC/crypto/aes/aesv8- > armx.S > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslGen/AARCH64- > GCC/crypto/aes/vpaes-armv8.S > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslGen/AARCH64- > GCC/crypto/arm64cpuid.S > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslGen/AARCH64- > GCC/crypto/bn/armv8-mont.S > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslGen/AARCH64- > GCC/crypto/ec/ecp_nistz256-armv8.S > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslGen/AARCH64- > GCC/crypto/modes/aes-gcm-armv8_64.S > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslGen/AARCH64- > GCC/crypto/modes/ghashv8-armx.S > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslGen/AARCH64- > GCC/crypto/sha/keccak1600-armv8.S > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslGen/AARCH64- > GCC/crypto/sha/sha1-armv8.S > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslGen/AARCH64- > GCC/crypto/sha/sha256-armv8.S > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslGen/AARCH64- > GCC/crypto/sha/sha512-armv8.S > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslStub/AArch64Cap.c > create mode 100644 MdePkg/Library/BaseLib/AArch64/ArmReadCntPctReg.S > create mode 100644 MdePkg/Library/BaseLib/AArch64/ArmReadCntPctReg.asm > rename MdePkg/Library/{BaseRngLib/AArch64/ArmReadIdIsar0.S =3D> > BaseLib/AArch64/ArmReadIdAA64Isar0Reg.S} (70%) rename > MdePkg/Library/{BaseRngLib/AArch64/ArmReadIdIsar0.asm =3D> > BaseLib/AArch64/ArmReadIdAA64Isar0Reg.asm} (72%) >=20 > -- > 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110787): https://edk2.groups.io/g/devel/message/110787 Mute This Topic: https://groups.io/mt/102342394/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-