From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.2877.1665377140247079332 for ; Sun, 09 Oct 2022 21:45:40 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=C1QyAPYC; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665377140; x=1696913140; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9W0MNAdcWl6Tf/OTfhs+0bh6PRKu61lIXVYRmkib2Zc=; b=C1QyAPYCkMRmxxSHJcnflURz6h0tfn9gwc3Z9Y3gZVeFzQIUTWbFF1ea 28OgImrxAGwdypOOErrPpbyMo13FPDAMF75HKhq2OO4Yb5nIWe23px+UT x3SjTdWr72Bj2kWIUCc3mgiF1HqUxMeVqOs4/wXrj6Bz7Sw0SkzJs3pVi SpiABWZC7GI7X9OzGjrw2oweUBMg7CSCon71Jvye0+vB5tbJrMEmCKXgA /uPp6aXLwmXwOG7n1m+11AUNjEOE1W93NKizGceRLcam9NJR8DuL1k1qs +dL+dgrVEqAR8TCQVH8T3Jc0ZGgOEdC0Z2iX9gJUSSIByOHbLQeJP2Zy3 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="287378348" X-IronPort-AV: E=Sophos;i="5.95,172,1661842800"; d="scan'208";a="287378348" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2022 21:45:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10495"; a="768256524" X-IronPort-AV: E=Sophos;i="5.95,172,1661842800"; d="scan'208";a="768256524" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga001.fm.intel.com with ESMTP; 09 Oct 2022 21:45:39 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 9 Oct 2022 21:45:38 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 9 Oct 2022 21:45:38 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 9 Oct 2022 21:45:38 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 9 Oct 2022 21:45:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aI3AWgT1BepXKt0g+7FrYgMLhjXFyJeqTXVIeOES0RV9v7IOWwx5HlkfvNb0L4hlNv+u4LdlOAdxJ9EFb1lBGDr5QGB6tzHWJ77pONlOYDJ0qh6uI1jCFPx5Lc0gSdUB/Ag86IqNmb2HF8iV95/eDCuYjnks21judcYgsax3F4KX7Vhg17Sz0ywhUe3p7Gexm2m++z5RY9KRpvXXIeqbQiiVkL9C1+1PLokSdSgSleBpdCt/PTAm9sFTApHJkUv5ZQeHzBuxuB13poNBiZpWop00YlhSBr5l7BKK4cfNu2CDcb1tuavYSqeVvMTHAAIcfRwbpeCxRAGou5E7tH2ljg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k+YdaLyxZdWbXdpnuWpR+RPfYYYcnVwcTNI2t4j9ho0=; b=AJwYd4ufk/E+UUWw7xDga3IrtTHoHik8tQNlIoMa1pZ9uHabrWpEUIrShiceQWRumvrpOzTaRxO0U3K5abQJGstlmTg3HRJV0QoSOmMBdlObPCFmJ+A/hnV+h9DTxo7fVi/efxu6OxoThARGvX7vEO6Ai1RZc8Ca7aThjbTJU3wN91F3QFTAS5aP+T9zwTVspJ12Nxq2mysxf1iFBaS0eISC3uOkTh8R9QZh2CA7ymREzH3cTuypDk2noL4OQiuYw5+h7FX8bwROw1FMsf3xwGXWCrCgm3l6u3Pj4Twsyo97SEI74ena4xpius8QqaGu7ZjJFAOA2xjYSC8JzctOpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CH0PR11MB5315.namprd11.prod.outlook.com (2603:10b6:610:be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Mon, 10 Oct 2022 04:45:35 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::76b0:750c:a322:5acf]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::76b0:750c:a322:5acf%6]) with mapi id 15.20.5709.015; Mon, 10 Oct 2022 04:45:35 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "Li, Yi1" CC: "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" , "Kinney, Michael D" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH V3 0/3] CryptoPkg: Extend Tls library Thread-Topic: [edk2-devel] [PATCH V3 0/3] CryptoPkg: Extend Tls library Thread-Index: AQHY3FGsSRLTJWwvK02JJCfsi+Tz1q4G6+xAgAAhShA= Date: Mon, 10 Oct 2022 04:45:35 +0000 Message-ID: References: <171C9530E5033AAA.32766@groups.io> In-Reply-To: <171C9530E5033AAA.32766@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|CH0PR11MB5315:EE_ x-ms-office365-filtering-correlation-id: 4c953e1b-dc9f-4e3b-6d31-08daaa7a457c x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AH8b2gOc8VVqOsXhsOlpas3OyhMkofDUDGeV0+lmbm7syoCnrGVFjWZ5GexPVZm4ePwBM3jzew8E8IzrkZ6fom4fWlxKe8CtkuTgnR6cmsVfD/lKQVeUIXCbcd/5RucLuLNDX9lSqzfNUpDWn3u90dCHOKp9cYNZCCMSMN3176PaxH7eo6O2nrHvccXy8UVJZHKirkNS+0RVXP9hwvv3NPJayJg02NoMFZyG/ozH5ikrPNiT4XAUlnk1xwm5uPoBhlXarZ2KWGBd9KneJUhoreJqy0vMIWetVGBbJb6+MaurPGhOoK48RVbLmsFEGMElLT82UotKVN7Na8zLq2lFjRo4LMiZDzmAsVB4dvNYe/lf8z+Tr4/LvlDGyvKYEFqoUCBKDwvhinEdDKpxQUXonApTbWHkRFJicogzP1HhbGic0U83uH878YDjyohVhizes7CVEbUflnY/GobtrmY9yQNRj0CyjX74+OmCz4QVRzrAyu7dyUoFWzFUlIP+rw8OvzVmA8cBj3W3ATKOL6+FZIMlYh0lEU+Rrm9Z9KA203PJrsRsz81asZXSLcE+Mgo3SH9HS960fG3KuG7V/EmZpgQKf30j5mqDTgvYj/1uWFbhr6zKldEMAW3b3hNu2EX+qkrZ9RBnZ9kgPp7lY6UJZDyvXMvOEs1DGrei9P9juqqaBYVEpmWpWDR7BBnpbeq5uIga6/lqDROFk/HN9PMhxyR8akfvib9kZWEgZL0fuMBmAIISzoD4DvTuDJj2MZcQjhmz1akCAklIe4LJSaJk+FqfBt/S1Z//SW55Alj/3Khv2+1vgXuk91evt1Tmvimqd+CaINdQgsRa9uvyRpP19A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(136003)(346002)(376002)(366004)(451199015)(41300700001)(7696005)(2906002)(186003)(53546011)(26005)(8936002)(52536014)(9686003)(5660300002)(82960400001)(122000001)(33656002)(38100700002)(86362001)(55016003)(38070700005)(83380400001)(6506007)(110136005)(316002)(19627235002)(54906003)(66899015)(6636002)(71200400001)(966005)(478600001)(66476007)(8676002)(66946007)(66556008)(66446008)(64756008)(4326008)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+618NEArVevqKeQtHvfvURXnzLEs7ON25+vpxxdA0L0GhnCOcJ3P6VSFX7Ca?= =?us-ascii?Q?B7jMuowgqT2v3cL01R3Q54luVFyD0KymYWzqAuE1Bee1L7Xh3eILqsi0JKVY?= =?us-ascii?Q?95N4Bg9/mbM+pvSOxWV2mo7HQwjE/Grd4VnRh4Z0i3AL7a3dRBIwN+4VzlKa?= =?us-ascii?Q?O5p9uzHkTmu2TJ/U+TnXKQkSjQtd3YDo/BVe/hE23MjDdlJxXBuLW1nVhfJN?= =?us-ascii?Q?yb13gPlHFOBAy453ebVIUF3FCUboGBLi+/qaSyfKdnD7K6qlfOa/NgJDH5og?= =?us-ascii?Q?G5VgKBMk+nXNqhokN8Aq3Mss6JN5EEV+JPNhHXLWBxN+kqAWBMHuDM4+RyG+?= =?us-ascii?Q?GXhdZUftYgsJoa+nchYvXmmpGSAq36R2CykH0uBE+rCcsTp3N9BABCbIIl5f?= =?us-ascii?Q?0LEmsKYkpNQEUtBjaHXDeGIg25+oN1PxR8WQtBVod0E/nnP+zXlRFhotjwJl?= =?us-ascii?Q?5eudeMJHH0CcjE6SPvBSmBDOhXKuwWLGq6JJVykEqm2ZliWz7va7qWruDY1J?= =?us-ascii?Q?q2r4zTTlqG+362zZggHZWyi/Di1q5CPx51U8L36LPaZnYZR5SnT1ddIKejPS?= =?us-ascii?Q?qwJCugOH6pSku1S3Sd+s84Cr+an0PI5iCyuXsQfluCND/hM589wCjj69g4cL?= =?us-ascii?Q?gTwnRdtnle2VpfVXhno/+fliZlBemELv+j28y1OwXOZ6pUXjuBw5kn26Vck0?= =?us-ascii?Q?7L8qEUodVx1ayzvP3rmdGjS5eoYFSQt/1T4Pa2Ktifxaw33udDHNugt9k4j6?= =?us-ascii?Q?I69JXmp5aauxpWjaORr6B1H9Fm279GCE8/NmtloEiVYjvVW/xsHtTXVZFYrR?= =?us-ascii?Q?I93MAJUvH+mQDX8zBqDzq06YLRNcMPdFkpOm3sRg2FQs1DvuHofrj2oSfmLL?= =?us-ascii?Q?DvWAooT5CaAWOZe89DBZThpQ3tBR3CnVDjufD2xGhEY9rx5wmMW/6ugK295H?= =?us-ascii?Q?EHkRSfqAR5XXFHt8kP4IVwWO/nvIiI/hFMgDaxMVAXf65dfcZLAwK0OW/n5A?= =?us-ascii?Q?qcjcbG2oE3MYCYjS2dM9FSd3PT9FTHDUmqDVVkW9VBAhYHG7VocCiFqvZwFG?= =?us-ascii?Q?31wb2U7+t9nAgQYGoh9VfcoxA7P0RWe2+mnfKEjTrvF6V9Rf+Iez5shZoCab?= =?us-ascii?Q?gFrcbLLCRSKA+Xxa92LGc+E9xYBJF27CyWvb9PM/JJbCy5qJInq+ebbc25TW?= =?us-ascii?Q?bfKqYeb4/ZztJbQcZ8gDpRmdMVt4f+20pSPh0vVz+WcwA1po1Rt7gGXurjLB?= =?us-ascii?Q?Ix9ASvyyweAaiu2Mjuq9JXMiRAJSmh/JYX4Wmjm4XTiIU+ZPC2SDyejFp5wf?= =?us-ascii?Q?rDSJxNaV/IiBsewpSy0+P/jMQyftJKA0biiBN8p0SnJ80WZJu8fPIKvYVMWr?= =?us-ascii?Q?YpRhuuYmSfzmUIbRvYFotQ8V9rTKyZyPWwrp7Fdpm+DGc2x0wqbLJMeNCpyp?= =?us-ascii?Q?mF8FqWK/gkNKI4U2YG5NYCqW4tbtVhXJmJGcfIiWn6mrNWlXtkZBjqfWjnr8?= =?us-ascii?Q?8iaPQkGPsLQWmY5HA6BMI09zyW2ccCY0J8h6CPexfcJOhClfcuLO1ewHU3H9?= =?us-ascii?Q?qwmyPfCDVlxNRGDKWA1H4kY2RjRs/oSnrouOFxZZ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c953e1b-dc9f-4e3b-6d31-08daaa7a457c X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 04:45:35.4704 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EJRZ5N5EHgvxZs1CVyzWB0zaI0XiEHzoTb8ttodXd/Z9Qahd2ZolCtFzU4c7OpOpk6knbszPQ+/0zy3cwD+QMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5315 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Yi Is this patch based on latest EDKII? I failed to apply the patch 2/3. The 1/3 and 3/3 are good. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Monday, October 10, 2022 10:47 AM > To: Li, Yi1 ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin ; Kinney, > Michael D ; Gao, Liming > > Subject: Re: [edk2-devel] [PATCH V3 0/3] CryptoPkg: Extend Tls library >=20 > Thanks for the update. > For all patches, reviewed-by: Jiewen Yao >=20 > I think we need MdePkg owner to give R-B or A-B for TLS definition in > MdePkg. Mike or Liming? >=20 > Thank you > Yao Jiewen >=20 >=20 > > -----Original Message----- > > From: Li, Yi1 > > Sent: Monday, October 10, 2022 10:40 AM > > To: devel@edk2.groups.io > > Cc: Li, Yi1 ; Yao, Jiewen ; Wan= g, > > Jian J ; Lu, Xiaoyu1 ; Jia= ng, > > Guomin ; Kinney, Michael D > > ; Gao, Liming > > Subject: [PATCH V3 0/3] CryptoPkg: Extend Tls library > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3892 > > > > Review PR: https://github.com/tianocore/edk2/pull/3400 > > This patch sequence is used to extend Tls library, which are wrapped > > over OpenSSL. The implementation provides library functions for EFI > > DXE dirver and Protocol. > > > > All APIs passed unit test and fuzzing test, detail as: > > 1. Unit test: > > New Tls APIs tested on Intel platform as part of WIFI WPA3 feature. > > 2. Fuzzing test: > > Various Fuzz Testing are employed across the all introduced APIs, and t= he > > test is used AFL (2.52b) and Libfuzzer (clang+llvm-11.0.0) as the fuzze= r, > > based on HBFA. > > Fuzzing Pass Rate is 100%; > > The Code Coverage of new APIs is 91%. > > All test case show in: > > https://github.com/liyi77/edk2- > > staging/tree/HBFA/HBFA/UefiHostFuzzTestCasePkg/TestCase/CryptoPkg > > > > V2 change: > > Move the newly added APIs to the end of struct PCD. > > V3 change: > > Corrected tls specification reference and tls cipher suite names. > > > > Tested-by: Yi Li > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Xiaoyu Lu > > Cc: Guomin Jiang > > Cc: Michael D Kinney > > Cc: Liming Gao > > > > Signed-off-by: Yi Li > > > > Yi Li (3): > > MdePkg: Add Tls configuration related define > > CryptoPkg: Extend Tls function library > > CryptoPkg: Add new Tls APIs to DXE and protocol > > > > CryptoPkg/Driver/Crypto.c | 155 +++++++- > > CryptoPkg/Include/Library/TlsLib.h | 126 +++++- > > .../Pcd/PcdCryptoServiceFamilyEnable.h | 5 + > > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 146 ++++++- > > CryptoPkg/Library/TlsLib/InternalTlsLib.h | 4 + > > CryptoPkg/Library/TlsLib/TlsConfig.c | 366 +++++++++++++++++- > > CryptoPkg/Library/TlsLib/TlsProcess.c | 32 ++ > > CryptoPkg/Library/TlsLibNull/TlsConfigNull.c | 123 +++++- > > CryptoPkg/Library/TlsLibNull/TlsProcessNull.c | 23 ++ > > CryptoPkg/Private/Protocol/Crypto.h | 136 ++++++- > > MdePkg/Include/IndustryStandard/Tls1.h | 112 ++++-- > > 11 files changed, 1177 insertions(+), 51 deletions(-) > > > > -- > > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20