Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning

["Yao, Jiewen" <jiewen.yao@intel.com>]

Hey Brijesh

CI fails - https://github.com/tianocore/edk2/pull/2301
Would you please take a look?

Please remember to submit patch after you run CI next time.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> Sent: Tuesday, December 14, 2021 10:11 AM
> To: Brijesh Singh <brijesh.singh@amd.com>; devel@edk2.groups.io
> Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M <min.m.xu@intel.com>;
> Tom Lendacky <thomas.lendacky@amd.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Aktas, Erdem <erdemaktas@google.com>; Michael Roth
> <Michael.Roth@amd.com>; Gerd Hoffmann <kraxel@redhat.com>; Rebecca
> Cran <rebecca@bsdio.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized
> variable warning
> 
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> > -----Original Message-----
> > From: Brijesh Singh <brijesh.singh@amd.com>
> > Sent: Tuesday, December 14, 2021 3:39 AM
> > To: devel@edk2.groups.io
> > Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M
> <min.m.xu@intel.com>;
> > Yao, Jiewen <jiewen.yao@intel.com>; Tom Lendacky
> > <thomas.lendacky@amd.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> > Ard Biesheuvel <ardb+tianocore@kernel.org>; Aktas, Erdem
> > <erdemaktas@google.com>; Michael Roth <Michael.Roth@amd.com>; Gerd
> > Hoffmann <kraxel@redhat.com>; Brijesh Singh <brijesh.singh@amd.com>;
> > Rebecca Cran <rebecca@bsdio.com>
> > Subject: [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning
> >
> > The XCODE5 reported the below warning
> >
> > OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: uninitialized
> > use occurs here
> >            Compacted
> >            ^^^^^^^^^
> >
> > Initialize the 'Compacted' variable to fix the warning.
> >
> > Fixes: d2b998fbdca4 (OvmfPkg/VmgExitLib: use SEV-SNP-validated CPUID
> values)
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Min Xu <min.m.xu@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Cc: Michael Roth <Michael.Roth@amd.com>
> > Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> > ---
> >  OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> > b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> > index a40a31f7c275..ff367411cc59 100644
> > --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> > +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> > @@ -1872,6 +1872,7 @@ GetCpuidFw (
> >      UINT32                 XSaveSize;
> >
> >      XssMsr.Uint64 = 0;
> > +    Compacted = FALSE;
> >      if (EcxIn == 1) {
> >        /*
> >         * The PPR and APM aren't clear on what size should be encoded in
> > --
> > 2.25.1
> 
> 
> 
> 
>