From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.20799.1639449295121938561 for ; Mon, 13 Dec 2021 18:34:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.com header.s=intel header.b=K1xXM+OP; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639449295; x=1670985295; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2mEPL7WQc8GvOR9ggCV2XZXoElOlYiz7pYk9f85QVR0=; b=K1xXM+OPH7KYw3IyD1OmHGqyVuRXIwywXZxAeZUfFKSQJ/TIAxHctFfi djMX6joBU/N0WPtCHUWg2z8G5AUGL2N1Xn7KnudFZrPXPaNi/l1mGTsFK kHTFluT985aSeXRoZ1VibMw5AXJ5qedyHbQkYQknSGC2uIjPgkX97AOKA YxfNQvONYSLZ3y0N0Ab7i8x2JTrvv4fknxdGMbNikWLcbAVWeGC4nF8kr 19PW9UAckpFBy+SIKmYHknWcAwuDYAtE32zIY3/FugPJyekc6oiPbnWUF Y0QRQB2x1lzFRcGwf+GcmX2t+ZcQOaacF34hKcyDadKWF/GEC6FZ6I/aS A==; X-IronPort-AV: E=McAfee;i="6200,9189,10197"; a="299660767" X-IronPort-AV: E=Sophos;i="5.88,204,1635231600"; d="scan'208";a="299660767" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2021 18:34:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,204,1635231600"; d="scan'208";a="518029315" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 13 Dec 2021 18:34:54 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 13 Dec 2021 18:34:53 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 13 Dec 2021 18:34:53 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 13 Dec 2021 18:34:53 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 13 Dec 2021 18:34:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AqN8tSnNOZeoc65qyJrmXtEkee5hICzJoqoarrzAaE09Y1ohn/PLW6ieqcDuHD/xKfwLNHMuRWdwkS5W38r7VC9CGZJsPaf+s+EmQdg0+Fv5D/dr6HSzYK1Bwns41rLMAoH/jluvVIyeF138zO0c94Q6K+PvGSNl/B0vUHwMFc6OZ2msfcoybl0Na2PHq8UBso9NmLWz9JIppFKXwTKG53d/ZcMWIx5JeIS1qiCzkaMaEtwgdwhQ9Ici68gRBrWFUGo6HnUr8QEYLYfGWg+smfw8WzWTqV5oae7zp5VSsRaqGmqmjsqGbOpNdAz7GzjTplc/6nKUlGhOU6zAJEhKfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=73VKtna1RDjflsQ1+/+LNyXjIILR8Mw+cd2FZWh9KBA=; b=cEGbL/+HefbukR4BrqbaXcIBAXmyeY7ADS7cC4uh/qKCDaOfw2sirlUyhwqgsAh3SY7IjEc+lULDNc5bU3HB7txbqptxttWF0dDT4hisIKnjBnFEuFafJA2UMxkVnQCtkzVOW1UjFUD5jgc1Fg9db8yk8Gu8dZTkxlBe+OyypsO8kbgtfuGQcn9DExCaH4FhlN3FDuyYMVc44qxx8Sa5qsj0PibBDwrFfnveLv9gFv7g0bRiFzbg3YYj6HIkQVU7ZK2tp2enVjtHFl+2DQI69GRE1QBZLzs40kHORdgnU0wlmNQLiRLpWYNo/Ki1hTj8fsLDjIkQQInUAY3UumbmCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=73VKtna1RDjflsQ1+/+LNyXjIILR8Mw+cd2FZWh9KBA=; b=WEpzQ2JGVg5DP3mySHdPbvsY8fpDjtN3Up8Ztvu+PL5KVsZi4w48g894ZVGDQsUqJrVsggA/GLMIiJs/Wkel8AdEH5RehJBWFREudpCfFyYUEDEVbCDQlWzrX5DjRPOOZx6/KiQle4LZ+oiKd8gZFcEqaMyhoxQMsYoXtHiArQc= Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by MW3PR11MB4521.namprd11.prod.outlook.com (2603:10b6:303:55::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec 2021 02:34:50 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::447f:7fbc:72f5:fbae]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::447f:7fbc:72f5:fbae%5]) with mapi id 15.20.4778.012; Tue, 14 Dec 2021 02:34:50 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , Brijesh Singh CC: James Bottomley , "Xu, Min M" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , "Aktas, Erdem" , Michael Roth , Gerd Hoffmann , Rebecca Cran Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning Thread-Topic: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning Thread-Index: AQHX8FkYECbityo96UymUeX0fk099qwxPt7ggAAGitA= Date: Tue, 14 Dec 2021 02:34:49 +0000 Message-ID: References: <20211213193839.143953-1-brijesh.singh@amd.com> <16C07D237B4BFD37.18377@groups.io> In-Reply-To: <16C07D237B4BFD37.18377@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 899682cc-bf76-49d3-4155-08d9beaa4d5e x-ms-traffictypediagnostic: MW3PR11MB4521:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1FEi5WoRX/VJ8BY3xywX0Bq9eguR485fhcLcNHVUDYM7lW8v/igjLmOGhVIVT8nUXK8y7oAxpB3zgy4A5V5irgcmNsyoKyN824fngrVG9dJ5wb632Tk6IMGQYZEoA5ztBFQa0K7/SjZDIspDZ+tsgT0HCSN46lXMbWYG3LbxSRVvo8aU7MZE+j+IUWL61wJzzGkTlXOQvi4UgbgSzaXdkaLwJvKKEbCTCpBL5jwmwFErptlH72q1GRYhYR+t0UhIgMj4z+cEh6BJIt6PebdzqO36xaMqT3foJ42mdsjDNgEhmhAHcMFlDLbzIoTDutzChk2HAbUxvgKtYmqMQE9ma/3xTwnChrO77QetuJwqWhMz5rM9GozzwHC/Kx6gFWQly5zF1oFxLqvkQ8+VlLeI+YbmmkECvCb119VA5YTenbudmTTP/Zro0YHEX4WGfspVdLAM7KqELIjw1lr5+GgIoy2NWvqTRLXwN217l/tKcg+E5ZXmMWzsQy/ifuQ8Rfr9cw14NLmLQNViyicKlOlm4hGey0Xqmeryjp3QbAHGee/spPNcrwx8Rk2Zj00R++JH1Ccu1UhtF12TlN9BEX+kKsazeh3ck2xJLICgmrWpbaC2yfIzSgLqmt3ldAJ7RalOQT6wDOAmkBb3I3E6nt+j4QcWeNB4gVh2wag2M3E+VQZgoaJ9aIz5/7oBUHwqR2KkhxUDtmXJbrQZkOns9zBIm7EJMogQyEKDOIxDq+FLkhfO1IQ30cACcPcydvNQH6cBqLfkEb7cGN7WjBWlOL1cGG1F3bd+VnMkPZKQnOvKu6BIXJoPnHYG/dJdEKOCqNGHqbofX9McheMU3QCSqTWZLQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(186003)(7696005)(122000001)(966005)(54906003)(26005)(110136005)(508600001)(33656002)(83380400001)(9686003)(316002)(66556008)(8936002)(86362001)(4326008)(8676002)(38070700005)(53546011)(66476007)(2906002)(6506007)(71200400001)(82960400001)(66446008)(5660300002)(66946007)(52536014)(76116006)(55016003)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RT6RyXs37diXl4EVSI8XpzBjKNIF2Hc1apg9j1dh8/2hmahX62NMRRTWYfRH?= =?us-ascii?Q?q5dqH8vHMmPetWinifH2MptuUOkBKo15aG3dqXJCr362UQUQHPZ02b1lZPEY?= =?us-ascii?Q?rZ3XyC98+CnyHyz1JM4tvT5Rr3HFaaEiuhmwIBqypo1UzUT2Jw2k5SPK3E7y?= =?us-ascii?Q?iVfwM2rItEpPfGuMa6WqVrQyPHgVuxQz2hF/cAR3chchSU4e86RKFU967MFy?= =?us-ascii?Q?Y7AaF4XskiPqFQ5+rseAZwsDB6/tXAmfZWpMb6B3khF9LIJS3G3R+Qq3JrhZ?= =?us-ascii?Q?z39g4lfgBeA7cz5OpRpmaKqmWKB1nX7ihRxQwSJGb4abQURvJeHXRtXjzbRi?= =?us-ascii?Q?B1i8COHsDOeQ+BCFC4PyEZbj+4sLzCekTrdBN+1iDEKCm0LTjpU4uO2as8JM?= =?us-ascii?Q?XgQj40CQuB4ONpMInHuGHth7mHowieHg+xvSTJ7XRslLTiTDA4nmH7cnu+5R?= =?us-ascii?Q?ccxT1L9pPptx6Rxsn82YkbSFKSvuNeoBfFJlVqurQUtVsLsQRAqjyepAVON1?= =?us-ascii?Q?HxDsqo0U/hw0MSvV17w4/U5IISWojWXk8PXBL4hr/C8NMnUfyfnOxXmh1os0?= =?us-ascii?Q?/pQv6mYFTmwGQ1XJKEhkE0fh8x1n79OYcy9F4RmunXkUeFjm44Riu2zhjZJ4?= =?us-ascii?Q?ZvFq6AOeAa/cXCjZYuRTDqMDVhNI0NNJkXt4Ndv/jhq8Vgxvf7qdQfyb5UEE?= =?us-ascii?Q?r8ZuF7pPGZ/yqK2Of7+AmVknt9prNjDBaDefztiJcEfFIRB4g2hOIsFUxuNG?= =?us-ascii?Q?VOf0mVMb8vexSFyKcBZoTOH3DoFvuQ3kYQgH+qmXofzCdvAoWgJ3E0hkTcnb?= =?us-ascii?Q?2QeaJ6OLObJTEHXEDMkwniqKuWRYEOD6894gjnijwBhdT+4dlQ0E6iRWntuD?= =?us-ascii?Q?P0uzQCp6ND2WP9KzPqZ55Oa6OCLTMkxxohkahIJOc8SxMzjXOO6uLZkqG+Vv?= =?us-ascii?Q?Pr11vboPaCKY+2+ze11/PzsfFJQZYLe6uHulUMoTaQr/dPFAc1UGF+pOy0SI?= =?us-ascii?Q?YtfzYq53U3FxJJ6yxB+D1mswiaCLB3WGoMGxzzN6qY7JWAFLR14+9KQ1pVc1?= =?us-ascii?Q?e1PoNn6qPx+NH3iWJzdcVq6fiYDKSxSA48ym8+iXXSc0x5cHLvPopWWlF4AX?= =?us-ascii?Q?5cH3Rg/aJhNiXVq6DFxQOy2pZBgt2GvNbGrrIzukMbIZ+KxmY4RG7lvTE7zL?= =?us-ascii?Q?31x9B8Iat6ZZk3p6XjeHekwjvsCeZSHkDTuThy3RJlKd6zqETpeICHq+1gCg?= =?us-ascii?Q?ccdfE265EKOrFDHgjf8CkTjpgnM82SByBu5jtFker6pQpAUCvydo8s9+bqhm?= =?us-ascii?Q?GHLLh73hyg51GW/LRv6eJgmbwBHdpdDpffl4kY3xkgJe8UaMAInnsjMmSJ4F?= =?us-ascii?Q?vQpQ8onazTcE+LIJne6d9/+VU/8Tq305xwx4VQfYSOW+46rTuz965Qr/vg1+?= =?us-ascii?Q?iFWGSiILEbogF86AaxfLOPjdz3TIw4WFkl5yuDNRLv4oYMs8RxiK08FTmDBL?= =?us-ascii?Q?aofPShJ6cFJkh6qbN6caeKx8gKyQ1wARYy6g7cx2qvClnTVrxK7ESCv51Ukg?= =?us-ascii?Q?ahW3/4T0dlXQGiuy4K9/wo9bBf7WCbIpcus+sXv4wec1b97nDNox76LD1VQ+?= =?us-ascii?Q?KCBFrooKAzP8XMwG0Bc1gTc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 899682cc-bf76-49d3-4155-08d9beaa4d5e X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 02:34:50.0126 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: arcLao2Uiet3nYYFPwFByowaKPjqSqj2eG7k1acyiPYLVgr1pdhsKuEeOPA5R9vmOCMyahWG4DCMQMJH6u2GSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4521 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hey Brijesh CI fails - https://github.com/tianocore/edk2/pull/2301 Would you please take a look? Please remember to submit patch after you run CI next time. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewe= n > Sent: Tuesday, December 14, 2021 10:11 AM > To: Brijesh Singh ; devel@edk2.groups.io > Cc: James Bottomley ; Xu, Min M ; > Tom Lendacky ; Justen, Jordan L > ; Ard Biesheuvel ; > Aktas, Erdem ; Michael Roth > ; Gerd Hoffmann ; Rebecca > Cran > Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitializ= ed > variable warning >=20 > Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: Brijesh Singh > > Sent: Tuesday, December 14, 2021 3:39 AM > > To: devel@edk2.groups.io > > Cc: James Bottomley ; Xu, Min M > ; > > Yao, Jiewen ; Tom Lendacky > > ; Justen, Jordan L = ; > > Ard Biesheuvel ; Aktas, Erdem > > ; Michael Roth ; Gerd > > Hoffmann ; Brijesh Singh ; > > Rebecca Cran > > Subject: [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable war= ning > > > > The XCODE5 reported the below warning > > > > OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: uninitiali= zed > > use occurs here > > Compacted > > ^^^^^^^^^ > > > > Initialize the 'Compacted' variable to fix the warning. > > > > Fixes: d2b998fbdca4 (OvmfPkg/VmgExitLib: use SEV-SNP-validated CPUID > values) > > Cc: James Bottomley > > Cc: Min Xu > > Cc: Jiewen Yao > > Cc: Tom Lendacky > > Cc: Jordan Justen > > Cc: Ard Biesheuvel > > Cc: Erdem Aktas > > Cc: Gerd Hoffmann > > Cc: Rebecca Cran > > Cc: Michael Roth > > Signed-off-by: Brijesh Singh > > --- > > OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c > > b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c > > index a40a31f7c275..ff367411cc59 100644 > > --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c > > +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c > > @@ -1872,6 +1872,7 @@ GetCpuidFw ( > > UINT32 XSaveSize; > > > > XssMsr.Uint64 =3D 0; > > + Compacted =3D FALSE; > > if (EcxIn =3D=3D 1) { > > /* > > * The PPR and APM aren't clear on what size should be encoded i= n > > -- > > 2.25.1 >=20 >=20 >=20 >=20 >=20