From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.1992.1663808034737157027 for ; Wed, 21 Sep 2022 17:53:55 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=SR2kJLrF; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663808034; x=1695344034; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2WoSFaZlkhybCV88SQpUJQTG9xC/1MudqZrhfh9RyXo=; b=SR2kJLrFwF41PcSizNYGn325DOlDH/7mbetWZXgtD+hcuEAgHTOTTEt7 BvX2lDuxYbB12xYkOjfF38vwxsyzlBnDGNcaGU6nXdMdqVG8lu5XEIaP5 EkWARak3t3aLkVLhdvs2Qf5AauSOq1M78GX+iF/07V/h62hyexkG2Yhkv jor2sHq0ivvMIP5x+ZX9U5xjWGWw9AMr74I9nKFAxGzCkWrk22ARMCACO nILM3s1oxdLJ8NZwullNJEXRCWm2WRA/Tw/PvV8+yAhOytfqrxNoEsgUp sVa7tHf1tXrxje9fOt58mWdKjL84QTKoBJQy6OXC260avXYprV0Xss02q Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10477"; a="300149311" X-IronPort-AV: E=Sophos;i="5.93,334,1654585200"; d="scan'208";a="300149311" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2022 17:53:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,334,1654585200"; d="scan'208";a="621900432" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 21 Sep 2022 17:53:46 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 21 Sep 2022 17:53:47 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 21 Sep 2022 17:53:47 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 21 Sep 2022 17:53:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f93RPuoA1y6kDw3hi+SHpY141m8HFgPVgw8WL6OawLVpzVK6NzHAPXBty+VY0dYI229YmNhYS8h9y5JlYEM23ASLovWZZsjtfGO3X0LHDTRDrRiYCyCsayHwixslluX3BiHHMBfbfykWpRv+4hY1tZ9nEoGzrJNJ5zf2KHrChdULNupHXHUxgV6ATUevLPsKmttgoLbgh1rJOKkHmUFWCM0D6kZSMcXp4IT1ofQ3qxgvGJ8NqMtYJGVIzRbPltcXD9ChhEwSwI3ngiWRzJsOGqV2A5S6tX5UDanP0W84LfO9mEJgDSgHRT6atI8ln8/yRyLIJ7Ia1Sar7uX9OOg0Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JWiaB0CXiEodltEpkIScv4zifSYAUY6p8jbtTGZfSgY=; b=CKWqivrAe4mOg4I+iDcbEg0AgaZ+8ty7TTdpPM3nMwBdEBc/zMfSUXdDicuQgw6MXB6ZSr/pObSDn2movkOZi2wgVyKNJfQhWLhiVeTtrmqgt36k0EOE4W7TXuRmoLd+otDWvAOaQYHZkd5uM71Z1rl8h5dWN6qPfRc/qnAsG7agk0rMRf4rArxQHb7EMM4yDwOt/VlhtxplZTO/J0AbYoirB5gKLxnPsQwFS2kyd259fDNwL4e1uFtGCa9sXz2JYcsfHFmZtT6rpSZ+meK5VtQa16p7GmCbdVoLFlWpzkz1SW9aK+K8Z86f/KrPxACjCQCqt60yA9KVvwYM+vklYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by PH8PR11MB7024.namprd11.prod.outlook.com (2603:10b6:510:220::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18; Thu, 22 Sep 2022 00:53:43 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%6]) with mapi id 15.20.5632.016; Thu, 22 Sep 2022 00:53:43 +0000 From: "Yao, Jiewen" To: Christopher Zurcher , "devel@edk2.groups.io" CC: "Li, Yi1" , "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" Subject: Re: [PATCH v1 0/3] CryptoPkg/OpensslLib: Add native instruction support for IA32 Thread-Topic: [PATCH v1 0/3] CryptoPkg/OpensslLib: Add native instruction support for IA32 Thread-Index: AQHYzfheptyDuCFRp0ioipL+EyYW163qnvVg Date: Thu, 22 Sep 2022 00:53:43 +0000 Message-ID: References: <20220921202541.3691-1-christopher.zurcher@microsoft.com> In-Reply-To: <20220921202541.3691-1-christopher.zurcher@microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|PH8PR11MB7024:EE_ x-ms-office365-filtering-correlation-id: 69a5aa09-2d32-46bd-8f84-08da9c34e5c3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +jNDnVVmmKcELgOahQ4lQDnuMy8MNHCmt2HgBexJE+C1X45Rsb7c30CuKP2iUaHM/wZUPdNbDRrTTppbgqIbqsm5RGNjjY4cKkCJo+Jo40VoQV1ZzJHk4SfoRDrXZViZDoyPJuEj6Dqq24Cz+N7AVJsoLORwMp0Caj1Dd053cgaKeHXhGEeRHlYKVUb1yiRReH5NsbTCqRiN/3hfEqGKb9udfxB9XGrd2B7AwI81rdzl79wtGzGi3V30pc7UuvkcXAa/Q14+eZyY0AitC3xj+xhUqZxShnL3jEabbq5b2TPYMGO4PUGq+i1/WYQRL8OHOFY4EefqRku33UfwK+rSg1hlcTaxb2Y+toX5Tl/qGn0IDyl9PjNUFHvs3HygRQ8NFwtjsENi9362/2zA+DbDRP1uz/xRMQO/F7tQ9TmMTT8obdiEhdoCTsCY1PCbDhH7SaBahwiWcm3hc9yq96aLfm9Q6oVEwcNcVa2VUhJK37axv0/Ud6ypcyX8TOty+jA4eE3VN0IBmfRPd5R0blcne1S1M1EfjIcj66s/k4EbROISLEqNT04smTvmNfczDVB0AmjOdoc/8/Nso8f9GFIW/s4e8ZDO4mJfQhwel/0UJMIcRKm38s9kGCRLwMAC3s5wL3PwwspcPyBU0iUlZYrrP9N9SV0efMKz0mevkO0VP4+XD0trFawY+2fdgpZVYtcVyg1pI3hRHa1RDXNG4h9dpgZ5Tu1jilfwWztav06bbgJHi1iGwLNVCfwI7ormUZyrh4FlyIiKGfvH7iOtq4sx7V0vB0s8MKz0tcryo8Ww+hG+IafTEolSGyma1fDLQ4zlLlW9Q3Plc2gM4NTSd2ft+A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(396003)(39860400002)(366004)(136003)(451199015)(66476007)(4326008)(66446008)(64756008)(8676002)(76116006)(66946007)(66556008)(316002)(478600001)(19627235002)(966005)(52536014)(26005)(8936002)(7696005)(33656002)(5660300002)(53546011)(41300700001)(6506007)(2906002)(9686003)(107886003)(38070700005)(38100700002)(82960400001)(122000001)(55016003)(86362001)(186003)(83380400001)(71200400001)(110136005)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wTQWt/2sfkT1smsKGemklSrQ2t8IK96l2QjHks2qey9biIc55cmWXriw3A+3?= =?us-ascii?Q?1gsogfNI2pWz3ad0SPi78X2+4fkzo0lmaA7/jt/fh4dCiacjX5TSBJh31hSp?= =?us-ascii?Q?50CdBkkAQPad6EupT24uW8Uu1Kv13JfOExPCuT6rbhbtQE8OnlSbgswLsV3v?= =?us-ascii?Q?bQ4Z81hkabBqKIXwhbWTgMh93SRJAh0vYYoAOS8xchXS1BMyhV5TLMn5R+KI?= =?us-ascii?Q?UHdG+o6Iy8LzteOlGVpI/bJhvpB3sjYzM1wkZ3ByWmyRvU889zW/x6d508uk?= =?us-ascii?Q?i4lakDkowYSP6y7M/L3DlGHN00mH7jd5lYNigtcqYwzyyzi6vkw4m6IB2QRh?= =?us-ascii?Q?FXT8gkYgUXwYrTy02itbDDCK4uITe3sKbJko5Qnb18ZlC594q7c4V2bD7gxb?= =?us-ascii?Q?xHF21zTFx/qH4FX5pyiluGt8Wo3gG1HrQgjXcSRFeSBGhWEjEIJ0uyRE+keE?= =?us-ascii?Q?/olRzJeK87dNS8h5D/M/jT+sq3LKoTU73Cvdf57eN1ubJGcP+Rb8HbZLXbSd?= =?us-ascii?Q?Ke8lWLunIYioBynDEAHXWIO8/IEhN8PxgMrZu0voQumfZVZNRltnQ9HOuQI5?= =?us-ascii?Q?ikgljbApZZG4CYgxPLCBg7tfotkkIVTS9jupxTWCgjDCSeDZigG5XwW0iBw0?= =?us-ascii?Q?hTOl071C86TwVMFlBDrszFfed9S96hS7CLe7D3VjFTiigbMvSfWXG9GKyN2h?= =?us-ascii?Q?EadSXzeyqMY/pWHGstxJxdWQl7VzB93rgyMzH0GsJ1/jdQJAWqjc3k6+MOmG?= =?us-ascii?Q?A/I32L7RM6pgNagV5tgKsve2EbafUqylI4OI0DKFiMpeMZObdpNGSkn6/xek?= =?us-ascii?Q?Gr7buIQHOP6AUxNQGp3XtW6IDrSmhpcyQYOWH7P5tuA+Wtr9DF+06XpNVtu2?= =?us-ascii?Q?LyjFPPYE2/n4oH2Aud9ClJ71RMuYoZLhKa2jQOFuL1mY0MZtw0a/jK7uyMGa?= =?us-ascii?Q?tCqqt/ibnsCXizdUWXqsNvGGq08C/0QoBdnQ/D8Gj5XY9TJ+piBfyWFOshlz?= =?us-ascii?Q?9U3jCAiQbispfs5Q18mvfgJA9hJAw3AbWHZgz3g52cyTUUVROJEi1j3npFma?= =?us-ascii?Q?wwFcmFU3imA3eDVR/M9d92hLGp7TCZKT3H+Kh/bJ4p0vJo30eNMExR0JDQLb?= =?us-ascii?Q?rCRacM9ofKaYol2D/UISwdLJAn0c+yTlCVCXBEYAWBk2/V4nPBBtOx4lKhyC?= =?us-ascii?Q?ZOeS0GGbhcwKj8hbtI+1CzgVXxgrxec6uurkPJq5aQT/1w0zoGm93xNR//VA?= =?us-ascii?Q?ojo9lNGUcEmKWCvysTZvRvkNDZCo9o3/PEatSZE8ILzy3EE5Ae53gllBUbzU?= =?us-ascii?Q?NFuAfeVpnWt3KzCrB5pnNR3Noy/JSWyzMt+xkwuQagbDyUquhj9VIkaaDvw0?= =?us-ascii?Q?WABwB2JqzMJd2bTZAZKyP5f8gch3StLZuTyVUJuBNbRjOc8IMsucHMaV91VQ?= =?us-ascii?Q?s5Ki+diVZ6rCUjdtF5W6qoeZizrGy2VdOjcX1nq0zAfMPcGFPJ7BrKZ7XPRw?= =?us-ascii?Q?NjGKg09Kv38SaJOcE8nmAJyDMIKto0ahdEMH2sFfMhv5bKyF1DD0rXMzpnyi?= =?us-ascii?Q?QdWAX2hYA+uByHgMg9ukhL25qNlY9WiPXuk3NZhK?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69a5aa09-2d32-46bd-8f84-08da9c34e5c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2022 00:53:43.3221 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cAzvJ2/eglZqv3N5YmnA8E1rHm5wROGHzNbLJabcHatdJ5TRXnECz4QaWgA7ZaeEVSFAGqzGrvf9nayr8yA4Fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7024 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks. Would you please add more detailed description on what test you have done? e.g. Real platform? Unit Test? Etc. > -----Original Message----- > From: Christopher Zurcher > Sent: Thursday, September 22, 2022 4:26 AM > To: devel@edk2.groups.io > Cc: Li, Yi1 ; Yao, Jiewen ; Wang, > Jian J ; Lu, Xiaoyu1 ; Jiang= , > Guomin > Subject: [PATCH v1 0/3] CryptoPkg/OpensslLib: Add native instruction > support for IA32 >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3654 > PR: https://github.com/tianocore/edk2/pull/3352 >=20 > This patch adds support for building the native instruction algorithms fo= r > the IA32 architecture in OpensslLib. The base variant has been tested > with VS2019 and CLANGPDB toolchains, and a GCC variant is also provided. >=20 > The implementation here follows the previous implementation of X64 > native instructions as committed in 878a92a887. >=20 > Cc: Yi Li > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang >=20 > Christopher Zurcher (3): > CryptoPkg/OpensslLib: Add native instruction support for IA32 > CryptoPkg/OpensslLib: Commit the auto-generated assembly files for > IA32 > CryptoPkg/OpensslLib: Update generated files for native X64 >=20 > CryptoPkg/CryptoPkg.ci.yaml | 4 + > CryptoPkg/Library/OpensslLib/IA32/crypto/aes/aesni-x86.nasm | 3212 > +++++++++++++++++++ > CryptoPkg/Library/OpensslLib/IA32/crypto/aes/vpaes-x86.nasm | 651 > ++++ > CryptoPkg/Library/OpensslLib/IA32/crypto/modes/ghash-x86.nasm | 700 > ++++ > CryptoPkg/Library/OpensslLib/IA32/crypto/sha/sha1-586.nasm | 1394 > ++++++++ > CryptoPkg/Library/OpensslLib/IA32/crypto/sha/sha256-586.nasm | 3364 > ++++++++++++++++++++ > CryptoPkg/Library/OpensslLib/IA32/crypto/sha/sha512-586.nasm | 579 > ++++ > CryptoPkg/Library/OpensslLib/IA32/crypto/x86cpuid.nasm | 433 +++ > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/aes/aesni-x86.S | 3247 > +++++++++++++++++++ > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/aes/vpaes-x86.S | 670 > ++++ > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/modes/ghash-x86.S | 703 > ++++ > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/sha/sha1-586.S | 1389 > ++++++++ > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/sha/sha256-586.S | 3356 > +++++++++++++++++++ > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/sha/sha512-586.S | 574 > ++++ > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/x86cpuid.S | 449 +++ > CryptoPkg/Library/OpensslLib/OpensslLibIa32.inf | 699 +++= + > CryptoPkg/Library/OpensslLib/OpensslLibIa32Gcc.inf | 699 +++= + > CryptoPkg/Library/OpensslLib/OpensslLibX64.inf | 53 + > CryptoPkg/Library/OpensslLib/OpensslLibX64Gcc.inf | 53 + > CryptoPkg/Library/OpensslLib/UefiAsm.conf | 18 + > CryptoPkg/Library/OpensslLib/process_files.pl | 12 + > 21 files changed, 22259 insertions(+) > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32/crypto/aes/aesni-x86.nasm > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32/crypto/aes/vpaes-x86.nasm > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32/crypto/modes/ghash-x86.nasm > create mode 100644 CryptoPkg/Library/OpensslLib/IA32/crypto/sha/sha1- > 586.nasm > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32/crypto/sha/sha256-586.nasm > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32/crypto/sha/sha512-586.nasm > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32/crypto/x86cpuid.nasm > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/aes/aesni-x86.S > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/aes/vpaes-x86.S > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/modes/ghash-x86.S > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/sha/sha1-586.S > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/sha/sha256-586.S > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/sha/sha512-586.S > create mode 100644 > CryptoPkg/Library/OpensslLib/IA32Gcc/crypto/x86cpuid.S > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslLibIa32.inf > create mode 100644 CryptoPkg/Library/OpensslLib/OpensslLibIa32Gcc.inf >=20 > -- > 2.29.2.windows.2