From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.8607.1688721255271678431 for ; Fri, 07 Jul 2023 02:14:15 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Dhlan3Q/; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688721255; x=1720257255; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tAxrV8VjsndyCiBF0i8OaX6mickFrE36cb86III4lH4=; b=Dhlan3Q/peeatm9iKjZTFjgTB4dDKsj8oSkeRdfXGVwecIJHshAvAWby HSCcA7qsfhP9YLE6brRcAnHcx6hhUIkuhx6pxX2CXQOUnQ2+nBAVFxXTu aAtpuMMO5a3pu6sxRtgjBfVSW+7DuYOmUxvBkll1TDlt0RPr5ChtZ+LSu zQrzk9u/S+qdXVh3cT+1n4AKPhuM169vpKWe6g4kzmbZL4TSnQjSrid8F cM2RhnSoVVJhVz5fHVOfOLRLPbOPn/sdn6CZJfohPrcHNBKXbahy/Gnyd DsEITW5AamE46CZFOs7wmiGzKn3yFic9h5T7j+YThas8c1wKoWL7anpJo A==; X-IronPort-AV: E=McAfee;i="6600,9927,10763"; a="363883199" X-IronPort-AV: E=Sophos;i="6.01,187,1684825200"; d="scan'208";a="363883199" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2023 02:14:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10763"; a="719896697" X-IronPort-AV: E=Sophos;i="6.01,187,1684825200"; d="scan'208";a="719896697" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 07 Jul 2023 02:14:14 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 7 Jul 2023 02:14:14 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 7 Jul 2023 02:14:13 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 7 Jul 2023 02:14:13 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 7 Jul 2023 02:14:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mXmBT7ztnzXrHLDJrq+bFoXBpmV+IAUEAgMGZU2RxzW5Rf1ICmFY+igTNPPAxYDin//B5pho9xUMzeenGnzP9AdQU9i9VIprvXImWveqrSGX2wXJwkj9e0i0KgJ64ukTv+xXX3az7Yyar8pBx34DpJ2w6AkzDKoKxy9NAjuV3LmX1pgwci75sn8jmR4X3ThTjniHHgnSZE48wN2iE1F0b6TnjxLy9+sNw33c9vzYrsvZlZto3SkKEnQ4/HpydGYbSOdnUk8tGirBi4y0YEVm/8jK+pHExmBmdmIsI9asomekLjTjGO/WCARbn6bPd+kITfVZG21e4iuCt9iz+QXlKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pq1BlcfQhnN5lp0T81Pjq64xTI9nh0c+q6WZF6ol7zU=; b=CJNAbe3B60hCsNWVnVVJ0GmIXHia2n+KeM6e+ELWcaWGKSXNQNpW0thoYfsSDbhGwPomjRvb4w4UD7aZXem4DRKPYj3rnp9xbK+kVLwCZcB32f1EL0M/Eu4UxRLHKlqcu5VWZ4yc2gLViQo4Q61wKcYx+9mI8zNGd8AACQ2xoXJ+SPAoaMdUThO0GmnpM76Ax+4w/Czs4CY/LGbFwD0QWR5ioIMvFnjVasTrL5oIo3kG6SPcq7OaFQMO6ORpdGnEgiSzJXTMGWUAbXqhEX1fmRyRgvgG7XoNDjqQW334KdWYO6lKgQOWDTYYFCizwnOeuilkphaWU6SytDNLtcTTog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CY5PR11MB6257.namprd11.prod.outlook.com (2603:10b6:930:26::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Fri, 7 Jul 2023 09:14:06 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::3caa:6866:1037:5388]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::3caa:6866:1037:5388%7]) with mapi id 15.20.6565.025; Fri, 7 Jul 2023 09:14:06 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "pierre.gondois@arm.com" CC: "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , "Wang, Jian J" , Ard Biesheuvel , Sami Mujawar , Jose Marinho , "Kun Qin" Subject: Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rng algorithms Thread-Topic: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rng algorithms Thread-Index: AQHZr+c/Fhml2NUr/0q+gzZ2oHCVHq+uBsUQ Date: Fri, 7 Jul 2023 09:14:05 +0000 Message-ID: References: <20230706085159.626374-1-pierre.gondois@arm.com> <20230706085159.626374-4-pierre.gondois@arm.com> In-Reply-To: <20230706085159.626374-4-pierre.gondois@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|CY5PR11MB6257:EE_ x-ms-office365-filtering-correlation-id: 5ebefb32-b238-413d-8880-08db7eca83a5 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zpO1S/6v2noyJn74kL6S8kXTPD0/HPo3M58VukDrJgqE2YrK8XutU/ZByc9ge98o4uhCYGocP7z1TADfANYjroCEAfTryVgMdZg7Obt1HOseUs2NyLZenhjAz+o+gS61RYNPBPwq+cwAAYqJgArjXH0GEj68GniAo4NiiwBX/WYeQN9C3Xz/DTJdhQbolYAxrkeMRJYv1ji0xOrNVlisp6QciynoqPVOUSHnaQwcytpWC7rGneCUBAVCeyIT0/yHwnCK3nefAsMo5KUqBGrWw58e6wumjifsN5fbhhyG+hR49m8J0GdHcWmgS4WZM+VxptD/5u25APmC6icTJFkOOBl+6Es+0Y/Th3YkpEvFJO////TZ2yhYoq3WmhGIXYqnnEe5pysJPBSFGNAKQv+eLrhJmu110gPED9oQWRUYyQGD3cNiWH9chwYRyQQ0w/W+VUeZKDbU6kVUujzyHRXTjY62SQ0wpy0jBzdI9cZueP8hMLL2FWc6a2lVPNcCgXuNb4+xPtRCK28VxrQpUlhlZvQfTuxd6j9R7X98UBZa6b9WRE0yqQKQUItBMrZ7iD72MK76S2me8+ikVl31aDltPtEdNTBreWent3B7Rb8DQRK3rv9viScBOLK8MLpvxPR7oR+pxthhWDF8YPmikJznlw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(346002)(366004)(396003)(136003)(376002)(451199021)(110136005)(54906003)(9686003)(966005)(7696005)(478600001)(19627235002)(53546011)(122000001)(64756008)(71200400001)(26005)(186003)(33656002)(2906002)(6506007)(8936002)(82960400001)(316002)(76116006)(5660300002)(66556008)(8676002)(41300700001)(66476007)(52536014)(66946007)(4326008)(66446008)(38100700002)(38070700005)(55016003)(83380400001)(86362001)(66899021);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8uA5gvY7Wn2Z5eRNN/l7l8zratK4nxb1kZL0RhG3uZD4BFDMXcX0Lc+oGmvq?= =?us-ascii?Q?e5yosS8zeErsk4pcLdxOYo7XKnun5okQ/SgFuoCkmGn3mhuGcdE1O8WgspEI?= =?us-ascii?Q?u705Ur/oh2nmHhV+5bCTRw/ZPA8yJZI12iSxjRx6rAPTNJwMmSETtcGEoqbg?= =?us-ascii?Q?/54Ha63Q/U69K+LVjam7yYTXq14D277niC/ANFPvPoxo6VEj+NMWEYHrJ0Kw?= =?us-ascii?Q?zdxt0hgf8Mnptx05DWzGA10nxSUu3ZLKjUyS3hL5FF1lcHlukTF4IN3Wm+vp?= =?us-ascii?Q?bb/EnKXag7N7L/fwBurHkzGCw4dqHnxC0nOaBEw82gmBkB699DvD7vkZi/fT?= =?us-ascii?Q?eqYvqYxTqN+Z0oW9ZbhXHjWlrZ8XUB55DT1J7jn09gUPcNeJnI2v75cMhrNC?= =?us-ascii?Q?yC3p0Vw/RVMMme+sRxTgTzOvna3HtCC0H0oiUhNseY2V90W1WqsLw99Tb901?= =?us-ascii?Q?48zU2dW5UMsw5zKmJygLJ0w+fukzbrJof1DoP1kGSQnkOdaEbAxkBVMyeEdv?= =?us-ascii?Q?LeEa9Jn4ZBkmf8IsNbMjlv6k2+bmhZWs6RZ/EKpf/Gg7l/dC+nf2W7dr+8F8?= =?us-ascii?Q?V+dDZNtIKvTw7udDJhcXlWfIo7SlQls3QX7/EjA8ZD5kuYq6BmFq/A+Zkat2?= =?us-ascii?Q?0iY6+O4FnRR+OrooCk7g12u6lTtIM9LnR+G8t9v1wIWm7XV3bQkwWsVsRNBd?= =?us-ascii?Q?jBctJcg9RRyDA5mq0AImD9IvZTLvANK6AHMC3RZYvi2CNkQPe9RE1/5y5e2K?= =?us-ascii?Q?Ioohm3fys2PEtCtGA8tYa3dZTJnixG+WoOjTKK3z5ONxTcyMsV3zAQU1am3F?= =?us-ascii?Q?V+uL2kupsvkkzK7L3HUQfXVGDIt2ydUn5iEBiXsTKPLcQvfvEQdZUSDCbTKQ?= =?us-ascii?Q?G74E0ErKAJoO4jatUfSZcL4+SrJU7hAGSI5VGfOlYclZ7X2ewPbm3vUxTDU+?= =?us-ascii?Q?vX3snxxgm6pUurMFM2Q183qLhry93TzHPzzG00/TweiBkU98ISSgsgVabimH?= =?us-ascii?Q?ACJx4oP/sxBhxSePO7WNpIHPLx5Ogmy1LOzO3uCM045O4LnuAKqs5yGZ0Qlh?= =?us-ascii?Q?N7/eZuECq4+RZUe4E6JEEFQhkIO58Cv59w5uFl7Ou5lqYVIL93Yd52ITt/5q?= =?us-ascii?Q?htMU0RxbIqvp/OIOq3UEbTZVrIUvcSEQcL2iqrvIbdqXOLJ6VuKBlyf/JgrX?= =?us-ascii?Q?zaByC4ib2CsA9wwoV0CJZtEjGYsbTmc9JEslaKH8QytiTYnkWsnopIYsuCLX?= =?us-ascii?Q?08NqyhRk5pRrUk1qKsBBMYcP+YTkuOgHAsnrx02Mk1JMdYZkAxmDiFu7rvKu?= =?us-ascii?Q?hv+TvAt5ZtSG25Sm4x6FiYPi8wEc+RQ88B69vWx2nr1OoAw4O7nriIX1HncB?= =?us-ascii?Q?u8IKH6GYWDFjHuQPRjt9qJLo+xpcwbq8eCfdI6dPtFL78jRKg5w8Pm5+pFLF?= =?us-ascii?Q?y6y7/6g0HBzDeFkqlkbGUF/sIDWsA77HN10lrQtGvvQnMN0ue5Np+HwPaPsi?= =?us-ascii?Q?w4t0hkCBB0JrSc/O476De5bVN/35k8TIJOeYq13DNMiHiN1K4uluhKXTsjEC?= =?us-ascii?Q?CSDJXeOkFCybmsd2BSXOwkNM80VSh3wgxeyi60eH?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ebefb32-b238-413d-8880-08db7eca83a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2023 09:14:05.9788 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yYN29MtpawjmdhM4Y0/f+PRvgnuJ7lcCrNn4Rlh+L9MFr7XajEg2vBA4MVIpvHgixTE+aOjisuGEGKA2DBfDCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6257 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MdePkg can only add UEFI defined API. Is below defined by UEFI? Thank you Yao, Jiewen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > PierreGondois > Sent: Thursday, July 6, 2023 4:52 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Yao, > Jiewen ; Wang, Jian J ; Ard > Biesheuvel ; Sami Mujawar > ; Jose Marinho ; Kun Qin > > Subject: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rn= g > algorithms >=20 > From: Pierre Gondois >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4441 >=20 > The EFI_RNG_PROTOCOL can rely on the RngLib. The RngLib has multiple > implementations, some of them are unsafe (e.g. BaseRngLibTimerLib). > To allow the RngDxe to detect when such implementation is used, > a GetRngGuid() function is added in a following patch. >=20 > Prepare GetRngGuid() return values and add GUIDs describing > Rng algorithms: > - gEfiRngAlgorithmArmRndr > to describe a Rng algorithm accessed through Arm's RNDR instruction. > [1] states that the implementation of this algorithm should be > compliant to NIST SP900-80. The compliance is not guaranteed. > - gEdkiiRngAlgorithmUnSafe > to describe an unsafe implementation, cf. the BaseRngLibTimerLib. >=20 > [1] Arm Architecture Reference Manual Armv8, for A-profile architecture > sK12.1 'Properties of the generated random number' >=20 > Signed-off-by: Pierre Gondois > Reviewed-by: Sami Mujawar > --- > MdePkg/Include/Protocol/Rng.h | 20 ++++++++++++++++++++ > MdePkg/MdePkg.dec | 2 ++ > 2 files changed, 22 insertions(+) >=20 > diff --git a/MdePkg/Include/Protocol/Rng.h b/MdePkg/Include/Protocol/Rng.= h > index baf425587b3c..ceae77ba9c73 100644 > --- a/MdePkg/Include/Protocol/Rng.h > +++ b/MdePkg/Include/Protocol/Rng.h > @@ -67,6 +67,24 @@ typedef EFI_GUID EFI_RNG_ALGORITHM; > { \ > 0xe43176d7, 0xb6e8, 0x4827, {0xb7, 0x84, 0x7f, 0xfd, 0xc4, 0xb6, 0x8= 5, 0x61 } > \ > } > +/// > +/// The Arm Architecture states the RNDR that the DRBG algorithm should = be > compliant > +/// with NIST SP800-90A, while not mandating a particular algorithm, so = as to > be > +/// inclusive of different geographies. > +/// > +#define EFI_RNG_ALGORITHM_ARM_RNDR \ > + { \ > + 0x43d2fde3, 0x9d4e, 0x4d79, {0x02, 0x96, 0xa8, 0x9b, 0xca, 0x78, 0x= 08, > 0x41} \ > + } > +/// > +/// The implementation of a Random Number Generator might be unsafe, > when using > +/// a dummy implementation for instance. Allow identifying such > implementation > +/// with this GUID. > +/// > +#define EDKII_RNG_ALGORITHM_UNSAFE \ > + { \ > + 0x869f728c, 0x409d, 0x4ab4, {0xac, 0x03, 0x71, 0xd3, 0x09, 0xc1, 0xb= 3, > 0xf4 } \ > + } >=20 > /** > Returns information about the random number generation implementation. > @@ -146,5 +164,7 @@ extern EFI_GUID gEfiRngAlgorithmSp80090Ctr256Guid; > extern EFI_GUID gEfiRngAlgorithmX9313DesGuid; > extern EFI_GUID gEfiRngAlgorithmX931AesGuid; > extern EFI_GUID gEfiRngAlgorithmRaw; > +extern EFI_GUID gEfiRngAlgorithmArmRndr; > +extern EFI_GUID gEdkiiRngAlgorithmUnSafe; >=20 > #endif > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index 5b8477f4cb8f..2c8f985f253e 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -643,6 +643,8 @@ [Guids] > gEfiRngAlgorithmX9313DesGuid =3D { 0x63c4785a, 0xca34, 0x4012, {= 0xa3, > 0xc8, 0x0b, 0x6a, 0x32, 0x4f, 0x55, 0x46 }} > gEfiRngAlgorithmX931AesGuid =3D { 0xacd03321, 0x777e, 0x4d3d, {= 0xb1, > 0xc8, 0x20, 0xcf, 0xd8, 0x88, 0x20, 0xc9 }} > gEfiRngAlgorithmRaw =3D { 0xe43176d7, 0xb6e8, 0x4827, {= 0xb7, 0x84, > 0x7f, 0xfd, 0xc4, 0xb6, 0x85, 0x61 }} > + gEfiRngAlgorithmArmRndr =3D { 0x43d2fde3, 0x9d4e, 0x4d79, {= 0x02, 0x96, > 0xa8, 0x9b, 0xca, 0x78, 0x08, 0x41 }} > + gEdkiiRngAlgorithmUnSafe =3D { 0x869f728c, 0x409d, 0x4ab4, {= 0xac, 0x03, > 0x71, 0xd3, 0x09, 0xc1, 0xb3, 0xf4 }} >=20 > ## Include/Protocol/AdapterInformation.h > gEfiAdapterInfoMediaStateGuid =3D { 0xD7C74207, 0xA831, 0x4A26, = {0xB1, > 0xF5, 0xD1, 0x93, 0x06, 0x5C, 0xE8, 0xB6 }} > -- > 2.25.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#106688): https://edk2.groups.io/g/devel/message/10668= 8 > Mute This Topic: https://groups.io/mt/99981855/1772286 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [jiewen.yao@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20