From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Xu, Min M" <min.m.xu@intel.com>
Cc: "Aktas, Erdem" <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit
Date: Wed, 18 Jan 2023 06:22:40 +0000 [thread overview]
Message-ID: <MW4PR11MB587243C6090935D059B82E798CC79@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <173B3EFD07CF1467.24231@groups.io>
Merged https://github.com/tianocore/edk2/pull/3922
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> Jiewen
> Sent: Wednesday, January 18, 2023 8:16 AM
> To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io
> Cc: Aktas, Erdem <erdemaktas@google.com>; James Bottomley
> <jejb@linux.ibm.com>; Gerd Hoffmann <kraxel@redhat.com>; Tom
> Lendacky <thomas.lendacky@amd.com>; Michael Roth
> <michael.roth@amd.com>
> Subject: Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status
> in IoExit
>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>
> > -----Original Message-----
> > From: Xu, Min M <min.m.xu@intel.com>
> > Sent: Wednesday, January 18, 2023 7:53 AM
> > To: devel@edk2.groups.io
> > Cc: Xu, Min M <min.m.xu@intel.com>; Aktas, Erdem
> > <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Yao,
> > Jiewen <jiewen.yao@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> > Tom Lendacky <thomas.lendacky@amd.com>; Michael Roth
> > <michael.roth@amd.com>
> > Subject: [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit
> >
> > From: Min M Xu <min.m.xu@intel.com>
> >
> > Status should be initialized otherwise it may return unexpected value.
> >
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Cc: Michael Roth <michael.roth@amd.com>
> > Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
> > Signed-off-by: Min Xu <min.m.xu@intel.com>
> > ---
> > OvmfPkg/Library/CcExitLib/CcExitVeHandler.c | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> > b/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> > index 30d547d5fe55..872f772a5ac8 100644
> > --- a/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> > +++ b/OvmfPkg/Library/CcExitLib/CcExitVeHandler.c
> > @@ -105,10 +105,11 @@ IoExit (
> > UINT64 RepCnt;
> > UINT64 Status;
> >
> > - Val = 0;
> > - Write = Veinfo->ExitQualification.Io.Direction ? FALSE : TRUE;
> > - Size = Veinfo->ExitQualification.Io.Size + 1;
> > - Port = Veinfo->ExitQualification.Io.Port;
> > + Val = 0;
> > + Status = 0;
> > + Write = Veinfo->ExitQualification.Io.Direction ? FALSE : TRUE;
> > + Size = Veinfo->ExitQualification.Io.Size + 1;
> > + Port = Veinfo->ExitQualification.Io.Port;
> >
> > if (Veinfo->ExitQualification.Io.String) {
> > //
> > --
> > 2.29.2.windows.2
>
>
>
>
>
prev parent reply other threads:[~2023-01-18 6:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 23:53 [PATCH V2 1/1] OvmfPkg/CcExitLib: Initialize Status in IoExit Min Xu
2023-01-18 0:15 ` Yao, Jiewen
[not found] ` <173B3EFD07CF1467.24231@groups.io>
2023-01-18 6:22 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB587243C6090935D059B82E798CC79@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox