From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Chen, Gang C" <gang.c.chen@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl
Date: Tue, 7 Feb 2023 02:02:27 +0000 [thread overview]
Message-ID: <MW4PR11MB587246BFD0F6CA3673496FDE8CDB9@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CH0PR11MB5690762DF219522A51F09EBCA3D69@CH0PR11MB5690.namprd11.prod.outlook.com>
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Chen, Gang C <gang.c.chen@intel.com>
> Sent: Thursday, February 2, 2023 11:29 AM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>
> Subject: RE: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for
> openssl
>
> Hi Jiewen,
>
> Here is the bug link: https://bugzilla.tianocore.org/show_bug.cgi?id=4334.
> Thanks.
>
> Best Regards
> Gang
>
> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Friday, January 6, 2023 5:45 PM
> To: Chen, Gang C <gang.c.chen@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>
> Subject: RE: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for
> openssl
>
> Would you please file a Bugzilla to describe the issue?
>
> > -----Original Message-----
> > From: Chen, Gang C <gang.c.chen@intel.com>
> > Sent: Thursday, January 5, 2023 11:20 AM
> > To: devel@edk2.groups.io
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> > <jian.j.wang@intel.com>; Chen, Gang C <gang.c.chen@intel.com>
> > Subject: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable
> > for openssl
> >
> > The GCC warning fix is not in 1.1.1x. Ignore the warning type
> > -Wno-unused-but-set-variable with GCC compiler in the build option.
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Signed-off-by: Gang Chen <gang.c.chen@intel.com>
> > ---
> > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 ++
> > CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 2 ++
> > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 ++
> > CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 2 ++
> > CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 2 ++
> > 5 files changed, 10 insertions(+)
> >
> > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > index 60c6c24b0a..8daab2fe55 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > @@ -641,6 +641,8 @@
> > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> > + # Revisit after switching to 3.0 branch
> > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable
> >
> > # suppress the following warnings in openssl so we don't break the
> > build with warnings-as-errors:
> > # 1295: Deprecated declaration <entity> - give arg types diff --git
> > a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> > b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> > index 103ef7bda2..b7e553df17 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf
> > @@ -689,6 +689,8 @@
> > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> > + # Revisit after switching to 3.0 branch
> > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable
> >
> > # suppress the following warnings in openssl so we don't break the
> > build with warnings-as-errors:
> > # 1295: Deprecated declaration <entity> - give arg types diff --git
> > a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> > b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> > index c4eaea888c..2472c1f663 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> > @@ -591,6 +591,8 @@
> > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> > + # Revisit after switching to 3.0 branch
> > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable
> >
> > # suppress the following warnings in openssl so we don't break the
> > build with warnings-as-errors:
> > # 1295: Deprecated declaration <entity> - give arg types diff --git
> > a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> > b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> > index 309e43055c..94c53a07c0 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
> > @@ -696,6 +696,8 @@
> > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> > + # Revisit after switching to 3.0 branch
> > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable
> >
> > # suppress the following warnings in openssl so we don't break the
> > build with warnings-as-errors:
> > # 1295: Deprecated declaration <entity> - give arg types diff --git
> > a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> > b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> > index 4eeeeb79bd..78e6f0e112 100644
> > --- a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf
> > @@ -744,6 +744,8 @@
> > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized
> > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-
> > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-
> > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize
> > + # Revisit after switching to 3.0 branch
> > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable
> >
> > # suppress the following warnings in openssl so we don't break the
> > build with warnings-as-errors:
> > # 1295: Deprecated declaration <entity> - give arg types
> > --
> > 2.38.1
prev parent reply other threads:[~2023-02-07 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 3:20 [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl Chen, Gang C
2023-01-06 9:45 ` Yao, Jiewen
2023-02-02 3:29 ` Chen, Gang C
2023-02-07 2:02 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB587246BFD0F6CA3673496FDE8CDB9@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox