* [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl @ 2023-01-05 3:20 Chen, Gang C 2023-01-06 9:45 ` Yao, Jiewen 0 siblings, 1 reply; 4+ messages in thread From: Chen, Gang C @ 2023-01-05 3:20 UTC (permalink / raw) To: devel; +Cc: jiewen.yao, jian.j.wang, Gang Chen The GCC warning fix is not in 1.1.1x. Ignore the warning type -Wno-unused-but-set-variable with GCC compiler in the build option. Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Jian J Wang <jian.j.wang@intel.com> Signed-off-by: Gang Chen <gang.c.chen@intel.com> --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 ++ CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 2 ++ CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 ++ CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 2 ++ CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 2 ++ 5 files changed, 10 insertions(+) diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf index 60c6c24b0a..8daab2fe55 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf @@ -641,6 +641,8 @@ GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize + # Revisit after switching to 3.0 branch + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable # suppress the following warnings in openssl so we don't break the build with warnings-as-errors: # 1295: Deprecated declaration <entity> - give arg types diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf index 103ef7bda2..b7e553df17 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf +++ b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf @@ -689,6 +689,8 @@ GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize + # Revisit after switching to 3.0 branch + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable # suppress the following warnings in openssl so we don't break the build with warnings-as-errors: # 1295: Deprecated declaration <entity> - give arg types diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf index c4eaea888c..2472c1f663 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf @@ -591,6 +591,8 @@ GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize + # Revisit after switching to 3.0 branch + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable # suppress the following warnings in openssl so we don't break the build with warnings-as-errors: # 1295: Deprecated declaration <entity> - give arg types diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf index 309e43055c..94c53a07c0 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf @@ -696,6 +696,8 @@ GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize + # Revisit after switching to 3.0 branch + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable # suppress the following warnings in openssl so we don't break the build with warnings-as-errors: # 1295: Deprecated declaration <entity> - give arg types diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf index 4eeeeb79bd..78e6f0e112 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf @@ -744,6 +744,8 @@ GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize + # Revisit after switching to 3.0 branch + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable # suppress the following warnings in openssl so we don't break the build with warnings-as-errors: # 1295: Deprecated declaration <entity> - give arg types -- 2.38.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl 2023-01-05 3:20 [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl Chen, Gang C @ 2023-01-06 9:45 ` Yao, Jiewen 2023-02-02 3:29 ` Chen, Gang C 0 siblings, 1 reply; 4+ messages in thread From: Yao, Jiewen @ 2023-01-06 9:45 UTC (permalink / raw) To: Chen, Gang C, devel@edk2.groups.io; +Cc: Wang, Jian J Would you please file a Bugzilla to describe the issue? > -----Original Message----- > From: Chen, Gang C <gang.c.chen@intel.com> > Sent: Thursday, January 5, 2023 11:20 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J > <jian.j.wang@intel.com>; Chen, Gang C <gang.c.chen@intel.com> > Subject: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for > openssl > > The GCC warning fix is not in 1.1.1x. Ignore the warning type > -Wno-unused-but-set-variable with GCC compiler in the build option. > > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > Signed-off-by: Gang Chen <gang.c.chen@intel.com> > --- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 ++ > CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 2 ++ > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 ++ > CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 2 ++ > CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 2 ++ > 5 files changed, 10 insertions(+) > > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > index 60c6c24b0a..8daab2fe55 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -641,6 +641,8 @@ > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > + # Revisit after switching to 3.0 branch > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > # suppress the following warnings in openssl so we don't break the build > with warnings-as-errors: > # 1295: Deprecated declaration <entity> - give arg types > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > index 103ef7bda2..b7e553df17 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > @@ -689,6 +689,8 @@ > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > + # Revisit after switching to 3.0 branch > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > # suppress the following warnings in openssl so we don't break the build > with warnings-as-errors: > # 1295: Deprecated declaration <entity> - give arg types > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > index c4eaea888c..2472c1f663 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > @@ -591,6 +591,8 @@ > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > + # Revisit after switching to 3.0 branch > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > # suppress the following warnings in openssl so we don't break the build > with warnings-as-errors: > # 1295: Deprecated declaration <entity> - give arg types > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > index 309e43055c..94c53a07c0 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > @@ -696,6 +696,8 @@ > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > + # Revisit after switching to 3.0 branch > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > # suppress the following warnings in openssl so we don't break the build > with warnings-as-errors: > # 1295: Deprecated declaration <entity> - give arg types > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > index 4eeeeb79bd..78e6f0e112 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > @@ -744,6 +744,8 @@ > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > + # Revisit after switching to 3.0 branch > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > # suppress the following warnings in openssl so we don't break the build > with warnings-as-errors: > # 1295: Deprecated declaration <entity> - give arg types > -- > 2.38.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl 2023-01-06 9:45 ` Yao, Jiewen @ 2023-02-02 3:29 ` Chen, Gang C 2023-02-07 2:02 ` Yao, Jiewen 0 siblings, 1 reply; 4+ messages in thread From: Chen, Gang C @ 2023-02-02 3:29 UTC (permalink / raw) To: Yao, Jiewen, devel@edk2.groups.io; +Cc: Wang, Jian J Hi Jiewen, Here is the bug link: https://bugzilla.tianocore.org/show_bug.cgi?id=4334. Thanks. Best Regards Gang -----Original Message----- From: Yao, Jiewen <jiewen.yao@intel.com> Sent: Friday, January 6, 2023 5:45 PM To: Chen, Gang C <gang.c.chen@intel.com>; devel@edk2.groups.io Cc: Wang, Jian J <jian.j.wang@intel.com> Subject: RE: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl Would you please file a Bugzilla to describe the issue? > -----Original Message----- > From: Chen, Gang C <gang.c.chen@intel.com> > Sent: Thursday, January 5, 2023 11:20 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J > <jian.j.wang@intel.com>; Chen, Gang C <gang.c.chen@intel.com> > Subject: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable > for openssl > > The GCC warning fix is not in 1.1.1x. Ignore the warning type > -Wno-unused-but-set-variable with GCC compiler in the build option. > > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > Signed-off-by: Gang Chen <gang.c.chen@intel.com> > --- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 ++ > CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 2 ++ > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 ++ > CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 2 ++ > CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 2 ++ > 5 files changed, 10 insertions(+) > > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > index 60c6c24b0a..8daab2fe55 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -641,6 +641,8 @@ > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > + # Revisit after switching to 3.0 branch > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > # suppress the following warnings in openssl so we don't break the > build with warnings-as-errors: > # 1295: Deprecated declaration <entity> - give arg types diff --git > a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > index 103ef7bda2..b7e553df17 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > @@ -689,6 +689,8 @@ > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > + # Revisit after switching to 3.0 branch > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > # suppress the following warnings in openssl so we don't break the > build with warnings-as-errors: > # 1295: Deprecated declaration <entity> - give arg types diff --git > a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > index c4eaea888c..2472c1f663 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > @@ -591,6 +591,8 @@ > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > + # Revisit after switching to 3.0 branch > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > # suppress the following warnings in openssl so we don't break the > build with warnings-as-errors: > # 1295: Deprecated declaration <entity> - give arg types diff --git > a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > index 309e43055c..94c53a07c0 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > @@ -696,6 +696,8 @@ > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > + # Revisit after switching to 3.0 branch > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > # suppress the following warnings in openssl so we don't break the > build with warnings-as-errors: > # 1295: Deprecated declaration <entity> - give arg types diff --git > a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > index 4eeeeb79bd..78e6f0e112 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > @@ -744,6 +744,8 @@ > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > + # Revisit after switching to 3.0 branch > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > # suppress the following warnings in openssl so we don't break the > build with warnings-as-errors: > # 1295: Deprecated declaration <entity> - give arg types > -- > 2.38.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl 2023-02-02 3:29 ` Chen, Gang C @ 2023-02-07 2:02 ` Yao, Jiewen 0 siblings, 0 replies; 4+ messages in thread From: Yao, Jiewen @ 2023-02-07 2:02 UTC (permalink / raw) To: Chen, Gang C, devel@edk2.groups.io; +Cc: Wang, Jian J Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > -----Original Message----- > From: Chen, Gang C <gang.c.chen@intel.com> > Sent: Thursday, February 2, 2023 11:29 AM > To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.wang@intel.com> > Subject: RE: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for > openssl > > Hi Jiewen, > > Here is the bug link: https://bugzilla.tianocore.org/show_bug.cgi?id=4334. > Thanks. > > Best Regards > Gang > > -----Original Message----- > From: Yao, Jiewen <jiewen.yao@intel.com> > Sent: Friday, January 6, 2023 5:45 PM > To: Chen, Gang C <gang.c.chen@intel.com>; devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.wang@intel.com> > Subject: RE: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for > openssl > > Would you please file a Bugzilla to describe the issue? > > > -----Original Message----- > > From: Chen, Gang C <gang.c.chen@intel.com> > > Sent: Thursday, January 5, 2023 11:20 AM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J > > <jian.j.wang@intel.com>; Chen, Gang C <gang.c.chen@intel.com> > > Subject: [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable > > for openssl > > > > The GCC warning fix is not in 1.1.1x. Ignore the warning type > > -Wno-unused-but-set-variable with GCC compiler in the build option. > > > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > Cc: Jian J Wang <jian.j.wang@intel.com> > > Signed-off-by: Gang Chen <gang.c.chen@intel.com> > > --- > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 ++ > > CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 2 ++ > > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 ++ > > CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 2 ++ > > CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 2 ++ > > 5 files changed, 10 insertions(+) > > > > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > > index 60c6c24b0a..8daab2fe55 100644 > > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > > @@ -641,6 +641,8 @@ > > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > > + # Revisit after switching to 3.0 branch > > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > > > # suppress the following warnings in openssl so we don't break the > > build with warnings-as-errors: > > # 1295: Deprecated declaration <entity> - give arg types diff --git > > a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > > b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > > index 103ef7bda2..b7e553df17 100644 > > --- a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > > @@ -689,6 +689,8 @@ > > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > > + # Revisit after switching to 3.0 branch > > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > > > # suppress the following warnings in openssl so we don't break the > > build with warnings-as-errors: > > # 1295: Deprecated declaration <entity> - give arg types diff --git > > a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > > b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > > index c4eaea888c..2472c1f663 100644 > > --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > > @@ -591,6 +591,8 @@ > > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > > + # Revisit after switching to 3.0 branch > > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > > > # suppress the following warnings in openssl so we don't break the > > build with warnings-as-errors: > > # 1295: Deprecated declaration <entity> - give arg types diff --git > > a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > > b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > > index 309e43055c..94c53a07c0 100644 > > --- a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > > @@ -696,6 +696,8 @@ > > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > > + # Revisit after switching to 3.0 branch > > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > > > # suppress the following warnings in openssl so we don't break the > > build with warnings-as-errors: > > # 1295: Deprecated declaration <entity> - give arg types diff --git > > a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > > b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > > index 4eeeeb79bd..78e6f0e112 100644 > > --- a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > > @@ -744,6 +744,8 @@ > > GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > > GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno- > > error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- > > error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > > + # Revisit after switching to 3.0 branch > > + GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > > > > # suppress the following warnings in openssl so we don't break the > > build with warnings-as-errors: > > # 1295: Deprecated declaration <entity> - give arg types > > -- > > 2.38.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-07 2:02 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-01-05 3:20 [PATCH] CryptoPkg/Library: add -Wno-unused-but-set-variable for openssl Chen, Gang C 2023-01-06 9:45 ` Yao, Jiewen 2023-02-02 3:29 ` Chen, Gang C 2023-02-07 2:02 ` Yao, Jiewen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox