public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
	Oliver Steffen <osteffen@redhat.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	"Jiang, Guomin" <guomin.jiang@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH 1/1] CryptoPkg/Crt: fix strcpy build on older VS compilers
Date: Wed, 20 Apr 2022 07:00:43 +0000	[thread overview]
Message-ID: <MW4PR11MB587248311D52E534639536EC8CF59@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220420061656.822368-1-kraxel@redhat.com>

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Wednesday, April 20, 2022 2:17 PM
> To: devel@edk2.groups.io
> Cc: Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Oliver Steffen <osteffen@redhat.com>;
> Pawel Polawski <ppolawsk@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Jiang, Guomin <guomin.jiang@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
> Subject: [PATCH 1/1] CryptoPkg/Crt: fix strcpy build on older VS compilers
> 
> Drop 'restrict' keyword which older visual studio compiler
> versions complain about.
> 
> Fixes: fab6285a73c4 ("CryptoPkg/CrtLibSupport: fix strcpy")
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  CryptoPkg/Library/Include/CrtLibSupport.h           | 4 ++--
>  CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h
> b/CryptoPkg/Library/Include/CrtLibSupport.h
> index bdc2654b6eef..e49060124ff6 100644
> --- a/CryptoPkg/Library/Include/CrtLibSupport.h
> +++ b/CryptoPkg/Library/Include/CrtLibSupport.h
> @@ -397,8 +397,8 @@ inet_pton   (
> 
>  char *
>  strcpy (
> -  char *restrict  strDest,
> -  const char      *strSource
> +  char        *strDest,
> +  const char  *strSource
>    );
> 
>  //
> diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
> b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
> index 6fcbe5885e7b..c1fc33538f9b 100644
> --- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
> +++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
> @@ -267,8 +267,8 @@ strcspn (
> 
>  char *
>  strcpy (
> -  char *restrict  strDest,
> -  const char      *strSource
> +  char        *strDest,
> +  const char  *strSource
>    )
>  {
>    AsciiStrCpyS (strDest, MAX_STRING_SIZE, strSource);
> --
> 2.35.1


  reply	other threads:[~2022-04-20  7:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  6:16 [PATCH 1/1] CryptoPkg/Crt: fix strcpy build on older VS compilers Gerd Hoffmann
2022-04-20  7:00 ` Yao, Jiewen [this message]
     [not found] ` <16E788A8F8121061.23693@groups.io>
2022-04-20 11:09   ` [edk2-devel] " Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB587248311D52E534639536EC8CF59@MW4PR11MB5872.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox