From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web09.4891.1650438046936356147 for ; Wed, 20 Apr 2022 00:00:47 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=dMX04zE1; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650438046; x=1681974046; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8ywkaAFrNsJnh8jAu5rUACKEccUIF85WxPzwPPrSFkE=; b=dMX04zE1H8jFmSu+jVL5qiW3bkZiDW1pLN1CuPbO5CuOq4xx+jnbdRbu /uNVAbnjlxmdX/W8mRVMHt7e3XPLF2W6knkXKdJYYwdm+QcEscwGPvmi8 dPBI9phEKz7denpzW11rjsmjVCSvVMM01r2gnWKXqey+ApnPuFNy4LWCo L8tvnqZ+mrYctVhSp4lHIK5w64xe9EUUCNM/TxTbPv5FzNjKIqjaIr2HO i3TE1QbD5++8SabCEVdRB1jX3x6rMF+BBuderLlS2jr9vcbMvpUfwkjZa ldwS/CBLJMoAKxxTBCDaXaPX/mppfSSjlTgO63Q3UBc5jCbW6FhNEP2um w==; X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="243889018" X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; d="scan'208";a="243889018" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2022 00:00:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; d="scan'208";a="804945225" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga006.fm.intel.com with ESMTP; 20 Apr 2022 00:00:45 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 20 Apr 2022 00:00:45 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 20 Apr 2022 00:00:45 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 20 Apr 2022 00:00:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N3oIhh8X2XuiYB2Q6ZGOFobkC3C3khj+Hw58BY1aPZr5j3CJFA92H7jlXbjyNjSxfgBdFyJZIBtZYcSnNSLA+OfjBaRzgP9Uxf4D0+8ijKJiNB7IM2tVS7BdgCho7DrOJnZfcUkxu5Qr7bMsZ1GPthYerHQVIjNM9QbmK0coUzdrlWozB26vFG067DOf0bkLGB3tRje7y8zdahziONQ7JrYfVcLgxUyMtFmUDNulejL0RxweazItekmKkqsbhRgHIyyhDTKmrPl9vYgxpvGQpze3/b5HjDGWqRVg33GdkA99NsTjEYSx7MtbOzCR+mUOriAGtrLHCqffXEGTVF+e2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GYlzZs7N73yix2oe2RLBLKtpafwzi91od+7DQ10C1CU=; b=ksUS7PTtKwy3ITVT8iVPud6nFlGW02Flf4aapp2RSYQrxOjqDb2OTFByYBgWHOHHb7dYek3Od9ijyzlVWwS91c9IsIxTqLlU0VHVBrx3pcQyIEyOWBNPtluVjWSTeBhPEqwUnqcknmklIfiHyd4yFJ6Opys9ZJBAy7RJvmf4eULsmd3Rch+iu63eJkde+wh4d9BHCsAnze55HUB+mDyhFHAk/P9XdLmzFvs/3XMAeAr3PsVn0Q/3CRjr/F96JYR+NSFoHWwMDTODHmb7jvxRcSdKfs/kltiXxBggpgY3D8u1UV04Og65BoaieN4FS48Mahds7VAjt/UDeuWvp+Rk/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BYAPR11MB2757.namprd11.prod.outlook.com (2603:10b6:a02:cb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr 2022 07:00:43 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::d55d:28c1:bfab:3dd]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::d55d:28c1:bfab:3dd%5]) with mapi id 15.20.5186.013; Wed, 20 Apr 2022 07:00:43 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: "Lu, Xiaoyu1" , Oliver Steffen , Pawel Polawski , "Jiang, Guomin" , "Wang, Jian J" Subject: Re: [PATCH 1/1] CryptoPkg/Crt: fix strcpy build on older VS compilers Thread-Topic: [PATCH 1/1] CryptoPkg/Crt: fix strcpy build on older VS compilers Thread-Index: AQHYVH5Mu0kXOTGVakaHSh9Y892O+qz4X6XA Date: Wed, 20 Apr 2022 07:00:43 +0000 Message-ID: References: <20220420061656.822368-1-kraxel@redhat.com> In-Reply-To: <20220420061656.822368-1-kraxel@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5bdc8764-7b68-471d-f010-08da229b7ca7 x-ms-traffictypediagnostic: BYAPR11MB2757:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dkZZ0kBBv43Fe3wPWRx+pgM8xsYfjNTtChkWnTgDYoAfUxiBdGP9NCL93fUVTmAy4R+S2AiVIIoiG3eyW+uTsiDiFQDi7ccQmi7s8NMI81Vt1HNHfgMlakr35lqBFiwgoodwQwS0zfVcJ6Ccf5by+OKuf6gwmnvgQ9XF0uEyPP+PQgBTNhgO7ZxwLgsGYysm5dOzO1puStKhYHfP3DJ/A/t15xvz/5WCR8nics0UKLF8qo8DIqF/INLgISz2iWr0WlQot7yPnFMf0zUxqHOUsZqnochYmRAJWpdv1kP+ekmlBN+B55Z3wKThswKZ94MZV9YA3ffN7tqW13o5URDU3KpBHnoUGnJ159DmBcoh3dhIr3Y3hEpte4zXMy9o2Ib5W8YnzJPxz1bY1vL0W2Pd9cwGoxYhCLb5F1dRtS2bLFfI8X3tF/oZNSjBmAMXdYstQuPBTmZ14c+nCDA9b99Z+o9snsaiEpJKKTuSIlRuiiLhiqsqcEy9IPhkeeZr8df9P/K5ScNtoDRPkrrg6OXxQiN1ilX/8oCnPlakEnix30KT/Iajk1ev3ybpW6OMz/aZxu1Yvr1j/Z7lQUAQzLObDpxP8rr3rLgx7nBoiASGbFK52f5Q8cWR7ysUbq7/RczvaDSKZp+9G473A5VOpNrMp1SfDitYGuu8XWCZwR/HU/hY17P9XHyQFYxV6aP7XZXtsn0XMgcLHfIe2LWjcX6zeA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(110136005)(83380400001)(122000001)(5660300002)(52536014)(53546011)(86362001)(26005)(71200400001)(82960400001)(8936002)(54906003)(9686003)(6506007)(7696005)(316002)(38070700005)(186003)(66946007)(66556008)(8676002)(64756008)(66476007)(107886003)(4326008)(66446008)(38100700002)(2906002)(508600001)(76116006)(55016003)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JK5CoCl9h7dV4oCLkfi4diDWmMj4mmzBY1xvUfOrNKtR2B2jIxW1vpB6Xxii?= =?us-ascii?Q?vp973E+MIlc1/g/Z4hJMJkN0z6RmcztovcgJO4F0J0TKlfVs+KhkC6rW72nz?= =?us-ascii?Q?JIz3bH1NHg7dPP3fLljO98MGIKmO9DxknvffoOre7clhGFn/Xx+BI+gsDKHP?= =?us-ascii?Q?dbejH6xCaPqfV6VAYkDgwyveFuxoeWF1nVUMxUh0JoL+0VpTbB0Kkw91X4vX?= =?us-ascii?Q?Xf6g9MtsOcmM8oTnxtMJFGjk/uXe/w/zw+aIZ4e0gwQ8msF8inzxlYzBXpyC?= =?us-ascii?Q?t2ytjW3LL7SLlFH/WMtnkOS7uAWrcjVZe9XmkVBDbZNonbbZSIPeMu/VM72s?= =?us-ascii?Q?P5+yEGRYMTmeXEQPaCubv21V+Id6jDdvMpECSnrhYaKV5hbHAxuJNEey5udk?= =?us-ascii?Q?IkPtaPghqyhaDhBp3Dmzr500qsPkycxExjz523t3yv8IIjQH/pa7kQYYa32/?= =?us-ascii?Q?GDFekvC40R/oIYzue4x/jjZ3OYnpGYoWUNJhtWbtqQ9HosWfn7/vQlWcGV5n?= =?us-ascii?Q?UQcQNp0OQXwYtlYEk45BKIztIV76QAh5pwvIgMPewFzeUEy6CYnyHqlcOvf+?= =?us-ascii?Q?7O6JB0W8Q5iIKMyAz6sb5sQrB0Z1GVj1USgt03L2IIVuaWPkoF7vW3IPJw3E?= =?us-ascii?Q?brhPSNtXlznlpDyLkmxjNj93MP9S2KYLwbZUkR9V7XbBVMbN+sVMaA7k+S17?= =?us-ascii?Q?Mjb/6LFT1Gx0MNUsnIqFrp2WzGLoyiW0LIJzwiBqmySqzKANfY/mJSlixK97?= =?us-ascii?Q?i+uSALW4K87YFfsSA+hdC5sgFdtSrOZgjZ107Xz9RcSat9dlKRS0mPyLhfrI?= =?us-ascii?Q?g97hZzFW9P3qrWhLgqkEigNvPlt6SF4/pGFyRJNvG72omFcqiytg1CWlsEef?= =?us-ascii?Q?/rzPoeGSOOXELjdSGqp0zv2/UFjl41jDFoLSi1zOJ9hFHuU9uJohf3yWi6an?= =?us-ascii?Q?D0ebBpsj66sasvgMwj0N8me2RXo96PZIy9WXszGn1ngV2UL69hB9viho+lrr?= =?us-ascii?Q?cg3MHfF3LixMa57rV1xrcMG1ZlKA4WDGRX2uYXjyyr+uiB6Zjk36Y6pcfqU1?= =?us-ascii?Q?M354wQoPhSlCks/31VCI9fJ08EnusQexSdtbuBrc6rNsCBaE5YObfPnttp3m?= =?us-ascii?Q?pyvPtzlHaN53Vxi6ADOeDzsdKU9yLEbSUrBWHTiIhA21lHoC1fmxLixPKrN3?= =?us-ascii?Q?fIgZD+D3MWR5lvWHbx5qgqSGyuZRGUsaO4qpBOWt4OPHZRleH9yK2ORhPpgj?= =?us-ascii?Q?WBo0xPIYVcy+MKKmdddP0p/rasVmoikI57VHMTfJJ48psKePyyw4ja9tYvG7?= =?us-ascii?Q?Rkr3hXDBBDYEWGBOJ/CMOmw1fIbGZk0nACJd+Eorszzxk6HL29DBWswOitUO?= =?us-ascii?Q?cl9HeKp/PcpRvLfZDo7lXcxJHINYZY7G0HUwX+16UGt7fEobOJO+Gv6+A0NW?= =?us-ascii?Q?P5VXozPm3pR7gnbUPwDz81WvAsiPxzkhkRxPNheqI5m3r/qvHgOP0HcSyn0A?= =?us-ascii?Q?/HqGafHCa92XsKhZe6r6u9NzXKWL14yI5gbmN7KXrm1Ozp0S1gFa8VdYma15?= =?us-ascii?Q?GLhs9EAz9qIQFFa+BaoGySqXOYboyLtXYAbAi2Ypyy2mL3sIchn8fXDDUvBk?= =?us-ascii?Q?4YAPHXsswP3vSYkiT2DRcC16gMBuiFPd72xAOWpfsQJ6xx4At4VhkZVR4JbT?= =?us-ascii?Q?v8bGeOWR8vW4KnXg8199TZ9qT7/GcSYsYGpaTQr7nZDZY/9isA0bD0lB2nqy?= =?us-ascii?Q?b/AgxKDHWA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bdc8764-7b68-471d-f010-08da229b7ca7 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 07:00:43.2377 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GNhIMddR3MRdZpSjXxnr8x64gcTMPmVCrFFlH/PnVKyGygmxacnPN1lz1xkusAAuXJmrrs7Wb1UGexPl+M9JJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2757 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Gerd Hoffmann > Sent: Wednesday, April 20, 2022 2:17 PM > To: devel@edk2.groups.io > Cc: Lu, Xiaoyu1 ; Oliver Steffen ; > Pawel Polawski ; Yao, Jiewen ; > Jiang, Guomin ; Wang, Jian J > ; Gerd Hoffmann > Subject: [PATCH 1/1] CryptoPkg/Crt: fix strcpy build on older VS compiler= s >=20 > Drop 'restrict' keyword which older visual studio compiler > versions complain about. >=20 > Fixes: fab6285a73c4 ("CryptoPkg/CrtLibSupport: fix strcpy") > Signed-off-by: Gerd Hoffmann > --- > CryptoPkg/Library/Include/CrtLibSupport.h | 4 ++-- > CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h > b/CryptoPkg/Library/Include/CrtLibSupport.h > index bdc2654b6eef..e49060124ff6 100644 > --- a/CryptoPkg/Library/Include/CrtLibSupport.h > +++ b/CryptoPkg/Library/Include/CrtLibSupport.h > @@ -397,8 +397,8 @@ inet_pton ( >=20 > char * > strcpy ( > - char *restrict strDest, > - const char *strSource > + char *strDest, > + const char *strSource > ); >=20 > // > diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > index 6fcbe5885e7b..c1fc33538f9b 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > +++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > @@ -267,8 +267,8 @@ strcspn ( >=20 > char * > strcpy ( > - char *restrict strDest, > - const char *strSource > + char *strDest, > + const char *strSource > ) > { > AsciiStrCpyS (strDest, MAX_STRING_SIZE, strSource); > -- > 2.35.1