From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 28FD3AC093C for ; Wed, 17 Apr 2024 03:18:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SegIVzSh0/JD4KI+SPSyy2Lt14d+N6Or5zsNiN8caJE=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713323903; v=1; b=Q4TeaWbfqyoRq8c5MyomqBbijvY9fbekqbcF8G7WKhSssnavfZGSNgvdrbzv67rG28wv7xwZ dGSmrpsWYVAZ204WfTjaLkVG8wfl8PiXPSaz1MbJZs2u2P+OoFWl0E514I80dVSHQ5pruGAAL5g sSWKifsQ4Bg8Lv43/AssB2tmYnMbUbrE9paOeJ5Ibmew0gHnJwpt4RZaqNe7NZAZFhSpwoymD5Z Ipfj7M9B8sgotpofM4QvQqie7EY2vzReQ5UzaTZHCYhsqI6I0wvMo7f56VFNLfPPMDVfxWxdOql Cx1B8/BS2evoY+t4mc/Urj21XDhR1RrfQbTXKR0QptXZg== X-Received: by 127.0.0.2 with SMTP id jmkAYY7687511xos3SvYS6qH; Tue, 16 Apr 2024 20:18:23 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mx.groups.io with SMTP id smtpd.web11.4217.1713323902797718876 for ; Tue, 16 Apr 2024 20:18:23 -0700 X-CSE-ConnectionGUID: x9wQ5gNXR8uf5q/VMZjM9g== X-CSE-MsgGUID: SjQMNeaUSsSQRygmfP/MtA== X-IronPort-AV: E=McAfee;i="6600,9927,11046"; a="26311591" X-IronPort-AV: E=Sophos;i="6.07,208,1708416000"; d="scan'208";a="26311591" X-Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2024 20:18:23 -0700 X-CSE-ConnectionGUID: Jw/lmbygRPS7M+wnfH+1Eg== X-CSE-MsgGUID: BSIfIBSsR8mkF83CAA1ZwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,208,1708416000"; d="scan'208";a="53682512" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Apr 2024 20:18:22 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 16 Apr 2024 20:18:22 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 16 Apr 2024 20:18:22 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 16 Apr 2024 20:18:21 -0700 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by PH7PR11MB7662.namprd11.prod.outlook.com (2603:10b6:510:27d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26; Wed, 17 Apr 2024 03:18:19 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9%4]) with mapi id 15.20.7472.027; Wed, 17 Apr 2024 03:18:19 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann , "devel@edk2.groups.io" , "Xu, Min M" CC: Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg Thread-Topic: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg Thread-Index: AQHajwpr1QjfEYCpX0Oq46ZMYZOE17FqsAaAgABZWXCAAMJBwA== Date: Wed, 17 Apr 2024 03:18:19 +0000 Message-ID: References: <20240415075555.499-1-min.m.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|PH7PR11MB7662:EE_ x-ms-office365-filtering-correlation-id: 0faaed46-c796-46e2-5298-08dc5e8d0818 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 3+NkpZhiu+rQsxyz6y2q1rAKedRzXMCxvSwwvyTAYchve6IUas2NhA5nbzqg62/71RKvLtWnYMOCXiZvFqzlaJTjyChYkE8trASzWdbTkPb6cn0hMdHFHebg+GdYybIhLYEIXVQNfmrbnq6/MBF5ZhlyGckIN0+2OyQqQfiWjEQtM55g0k3URBVodi1eXH+dmy0gSK8cwKJt7AZzA2gfyVlSbww2wHmDcNjyijnE/Grf+jGna4QwH87w7ipb5jIDxFOWJbihS0kMglF3ivOiBIRI+gqpTh6IFyapLZ1pLPMIIIGWdH92Izk80CuQWfDpsabJLAqiDfr14YosPTgb81xPUuYN31kzvePSKMrsH2QEfF6do2KoHg0D/dIrh7/sFXuxNFx7kU+IB5ikZrnqKI/UzCCT53AvgsCAvweLl9/uQdwRKGaJer5KZxy2UeSGx6prwAxzxSoIRmx3nbLizF1jMU74ZU03jABkZEAD2Q1rEDEHhAAkPifmvktwcMQLqV5iCYgReSGPyCWDQKAxw/4pSeFWNahSyWO2wNK4Yb3W6J6DulZw+7FMJhNbY6iQW2CMlpaEkkUtzjQa2h3b5ubZGY18VzIGhVUN5UBSPd+H4fxOywDZQm/PwTHnyk+x5jDws7IjNLIoV2HBQ3gT2N5ezm8M9TbRPZkfKos8Zny+YdoCDXf6kT5VABC1OL4W x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LAfT2BavK89wHtRa10u/J7ZLtNdIkYL4JkcdDKZCLbQ+VQDUzPGwt9mnV46N?= =?us-ascii?Q?/oIxYqx3daS/A1SEnBUOMoEyD4N1qT5lheuVm/hbxnyetRPvkfTskNXi01ng?= =?us-ascii?Q?awCJWK6XXLN9k9XGyu+obyi2teAsRqZeTFSwTAYKSR33GpbsdVpqNWTR3vi5?= =?us-ascii?Q?zRNC51fZ3WJEWKx04cu+M1viy6cMUtL2uG3Dvoxb8kq6RUWZU3Bk3++r8cxa?= =?us-ascii?Q?reqItdfe5RvUoovqaNefZPA30pRiwPssyD4+lY2CYupHy+lkdexRMNrEyyxw?= =?us-ascii?Q?qdaODlw+bNFdvFw0OirO2DyzZMh0ZoEP+Q9w8RGKRh5y9cT6gS+Co3tdUY0l?= =?us-ascii?Q?3fpi1IxRUCe1mvfeCTHT4JxyC+H/HCxmWuy0USlQo68kXDt1t9oewjnxjDNR?= =?us-ascii?Q?EwYnZTVVatIM6xHN/afU63OdXAINayBpEYN6jdcaaIDmez3OzxrLwYh7z+eg?= =?us-ascii?Q?ruCaBzVvFEU7KmsEsZBmtW86pxapskGjcIojAlb0Qgrdj3/fGlQwd7BI2yzj?= =?us-ascii?Q?NXQSXKbA7s0DshQx0KbcNlswDrywwt20JjNlA/IEU4DUe51kthjs+rWaIuas?= =?us-ascii?Q?L9qNK5AmDZjO8tf6QBOQQT/r3p8qOAeHJky9k8wWYAlvR7aX+LXouH/vZbFN?= =?us-ascii?Q?rx9PTp02HGKlj7aYPT97BqPo36WUqTYcY/0u2poR3e75hsBipXwofyQ3KyD+?= =?us-ascii?Q?D9oEvVADGJ51e4vsbNA0G8VCmdvVRvFuTYwbdDjFFmP5TH1grvHcbS5+CTES?= =?us-ascii?Q?YlL7jJfiuIdjuhPuj4lJLMplhdD9hX1hltHY02fa0PmCgd11TocVDZdy/2cn?= =?us-ascii?Q?V1Bml0d0Yt+gt7/d46mEKzvcOGpJLOrMjA8VQyNlL+vnavFXMPE6mPR8E4C2?= =?us-ascii?Q?KrXSPiEG06r4JFr4QuCzf6BYFVeUIrIWH54mWUkk9rIrCFi5GSFiYN2Cjm50?= =?us-ascii?Q?r47CQUjoaEiiHoCQUp52DeIuLwfp/XaAd/83AdUTIXij0+vkDQUDCwOxPJrH?= =?us-ascii?Q?T8nF0KMFliAMQqWTXwEx+oSaPyD11ib6A2PZttll92ReynzZQcj1ivEJgZq2?= =?us-ascii?Q?1Q8TfRBJRoNPLec5ThBdxDklQBf957DXbyKVqbYu10Azdi5zflPW3nA4wyqA?= =?us-ascii?Q?glL4hOtprlRUsMmW5l+dnxDASwiMEcf+1i8IENsjsMj7sJtizqof5ZSnfA1w?= =?us-ascii?Q?/KYC9HU6FvLXAjoGGSLCGjxjPUymGZiKNdRV4SqcWmbYYr013rk9dKS87spY?= =?us-ascii?Q?pEOUlW2YS0YL4kuJXdnBf6hfytMEfEzSkFIAdAzHhU6Gwn5ztVRPLGPVaobh?= =?us-ascii?Q?eZTZSbueb6UPESUJRfqE8xReqo5hcJ7T1ftvC6JAFuIvRdpfy2SJwkF9cNm5?= =?us-ascii?Q?X9lrcAANf+/W/SL+0BsnY+nQr0T8/SnzQ2gtX+EEm1c22dwKaYGEfAWwNzbi?= =?us-ascii?Q?ejrGH+5N0wf2AT4q2eNsKYiZxTWwyao9aBCaS+WS7BmX0jxtmz9L9Bp9+v3g?= =?us-ascii?Q?wTee3zPQf7iDw75jq66rK6BQACKo4ThYptaKC8Z3S66WnbZOsyrcIlRHs+Sr?= =?us-ascii?Q?ygQzO+CZPX6NiS/9X8ks86WeeAz2TASAJAE7L82w?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0faaed46-c796-46e2-5298-08dc5e8d0818 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2024 03:18:19.8523 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CDKuPxc05HxFUBv3MUTUxdp1JPHA50YW7P7o/V4Gtin74mpyyThxEcMvahMexXoRLOYxbrE2SI/rxloLRzJJjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7662 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 16 Apr 2024 20:18:23 -0700 Resent-From: jiewen.yao@intel.com Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vox78o8ED76E0qynPPkdjcdYx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Q4TeaWbf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io I have merged this one https://github.com/tianocore/edk2/pull/5566 Hi Gerd If you prefer that we move all TDX / SEV specific component to IntelTdx and= AmdSev, I am OK with that. Personally, I like your idea. Please submit Bugzilla and work on it, if you= would like to. Thank you Yao, Jiewen > -----Original Message----- > From: Yao, Jiewen > Sent: Tuesday, April 16, 2024 11:40 PM > To: Gerd Hoffmann ; devel@edk2.groups.io; Xu, Min M > > Cc: Ard Biesheuvel > Subject: RE: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from Secur= ityPkg > to OvmfPkg >=20 > Yeah, I also considered that before. But after look at current code struc= ture, I give > up. >=20 > Since following SEV component are NOT in AmdSev directory (especially the= TCG > one), I do not see a strong reason to put them to IntelTdx dir. > https://github.com/tianocore/edk2/tree/master/OvmfPkg/AmdSevDxe > https://github.com/tianocore/edk2/tree/master/OvmfPkg/Tcg/TpmMmioSevDec > ryptPei > https://github.com/tianocore/edk2/tree/master/OvmfPkg/Library/BaseMemEncr > yptSevLib >=20 > I think we can follow the existing code structure in this patch set. >=20 > Thank you > Yao, Jiewen >=20 >=20 > > -----Original Message----- > > From: Gerd Hoffmann > > Sent: Tuesday, April 16, 2024 6:16 PM > > To: devel@edk2.groups.io; Xu, Min M > > Cc: Ard Biesheuvel ; Yao, Jiewen > > > > Subject: Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from Sec= urityPkg > > to OvmfPkg > > > > On Mon, Apr 15, 2024 at 03:55:49PM +0800, Min Xu wrote: > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4752 > > > > > > HashLibTdx and TdTcg2Dxe are designed for Intel TDX enlightened OVMF. > > > They're more reasonable to be put in OvmfPkg than in SecurityPkg. > > > > > > SecTpmMeasurementLibTdx is not used anymore. So it is deleted in this > > > patch-set. > > > > > > > > rename {SecurityPkg =3D> OvmfPkg}/Library/HashLibTdx/HashLibTdx.c (1= 00%) > > > rename {SecurityPkg =3D> OvmfPkg}/Library/HashLibTdx/HashLibTdx.inf = (100%) > > > rename {SecurityPkg =3D> OvmfPkg}/Tcg/TdTcg2Dxe/MeasureBootPeCoff.c > > (100%) > > > rename {SecurityPkg =3D> OvmfPkg}/Tcg/TdTcg2Dxe/TdTcg2Dxe.c (100%) > > > rename {SecurityPkg =3D> OvmfPkg}/Tcg/TdTcg2Dxe/TdTcg2Dxe.inf (100%) > > > > Better place them in OvmfPkg/IntelTdx ? > > > > Otherwise looks fine to me. > > > > take care, > > Gerd -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117892): https://edk2.groups.io/g/devel/message/117892 Mute This Topic: https://groups.io/mt/105531957/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-