From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Justen, Jordan L" <jordan.l.justen@intel.com>,
"kraxel@redhat.com" <kraxel@redhat.com>
Subject: Re: [PATCH 0/3] CloudHv: Rely on PVH boot specification
Date: Wed, 23 Feb 2022 00:00:31 +0000 [thread overview]
Message-ID: <MW4PR11MB58724959CC0AA4311763BAA08C3C9@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <cover.1645534975.git.sebastien.boeuf@intel.com>
HI Sebastien
Here is some feedback.
1) Since this seems a new feature, would you please file a Bugzilla https://bugzilla.tianocore.org/ ?
2) Please also include this new feature in release plan - https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning ?
3) A clarification question: Do you want to *only* support PVH boot in CloudHv, or PVH is one option and you still support old way?
4) Please clarify if that impacts the support for TDVF.
Thank you
Yao, Jiewen
> -----Original Message-----
> From: Boeuf, Sebastien <sebastien.boeuf@intel.com>
> Sent: Tuesday, February 22, 2022 11:53 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; kraxel@redhat.com; Boeuf, Sebastien
> <sebastien.boeuf@intel.com>
> Subject: [PATCH 0/3] CloudHv: Rely on PVH boot specification
>
> From: Sebastien Boeuf <sebastien.boeuf@intel.com>
>
> Cloud Hypervisor aims at emulating the minimal amount of legacy devices
> and this is why the PVH boot specification is supported. The point is to
> be able to share some information with the guest without the need for
> emulating devices that would be present on real hardware.
>
> Since Cloud Hypervisor supports loading a PVH ELF binary, the CloudHv
> target is updated to be generated as such. Relying on the PVH boot
> specification, we don't need to hardcode the location of the ACPI tables
> anymore since we can retrieve the RSDP address from the hvm_start_info
> structure. Same thing for the RAM below 4G, we can find this information
> through the PVH memmap entries rather than relying on the emulated CMOS.
>
> Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
>
> Sebastien Boeuf (3):
> OvmfPkg: Generate CloudHv as a PVH ELF binary
> OvmfPkg: CloudHv: Retrieve RSDP address from PVH
> OvmfPkg: CloudHv: Rely on PVH memmap instead of CMOS
>
> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +
> OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c | 39 +++--
> OvmfPkg/CloudHv/CloudHvElfHeaderGenerator.c | 150
> ++++++++++++++++++++
> OvmfPkg/CloudHv/CloudHvX64.dsc | 2 +-
> OvmfPkg/CloudHv/CloudHvX64.fdf | 95 ++++++++++++-
> OvmfPkg/Include/IndustryStandard/CloudHv.h | 5 -
> OvmfPkg/PlatformPei/MemDetect.c | 73 ++++++++++
> OvmfPkg/PlatformPei/PlatformPei.inf | 2 +
> 8 files changed, 348 insertions(+), 20 deletions(-)
> create mode 100644 OvmfPkg/CloudHv/CloudHvElfHeaderGenerator.c
>
> --
> 2.32.0
next prev parent reply other threads:[~2022-02-23 0:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 15:53 [PATCH 0/3] CloudHv: Rely on PVH boot specification Boeuf, Sebastien
2022-02-23 0:00 ` Yao, Jiewen [this message]
2022-02-23 9:59 ` Boeuf, Sebastien
2022-02-23 12:02 ` [edk2-devel] " Gerd Hoffmann
2022-02-23 12:20 ` Boeuf, Sebastien
2022-02-23 13:11 ` Yao, Jiewen
2022-02-23 14:03 ` Boeuf, Sebastien
2022-02-23 14:14 ` Yao, Jiewen
2022-02-23 16:54 ` Boeuf, Sebastien
2022-02-25 11:09 ` Boeuf, Sebastien
2022-02-25 14:21 ` Yao, Jiewen
2022-02-25 14:22 ` Boeuf, Sebastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB58724959CC0AA4311763BAA08C3C9@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox