From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.5901.1645613352824245984 for ; Wed, 23 Feb 2022 02:49:14 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=GQlXRMk+; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645613352; x=1677149352; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8WgX5XFWWQRg3mLKqE3yQDYgZpRLqJosWLcXp3MSIZQ=; b=GQlXRMk+SxNulQhNnaPPHCkHg103Vy+GWqeQLm3bUigJFFggvzSOej5D hncsE2zxMem7w2uUQTKdJj43zjaE/tT+Iis0FZ5W0pNuXWleqAxgxcmdL nXaV/CV3OpR6pCa3u8iW48FhyxbdiswBp1jMVilvL2TmILBHy666193Hv L/JpSYzGkIYoD7f/TnGSwa7ge07Kl54W+gkQU8L8wC9AS2mbibGy20G/X YXL8AmyAj5SnhLe+dFvbaAw8RNMjy73p91YxArag0gJi6zbcjaKtEyf0e 9SLlUPHCfBcOXb74+9GohI96iRISzigsfi7at6U2Xvv5T+uckiEbrhhD8 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10266"; a="239326329" X-IronPort-AV: E=Sophos;i="5.88,390,1635231600"; d="scan'208";a="239326329" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 02:49:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,390,1635231600"; d="scan'208";a="706985700" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 23 Feb 2022 02:49:11 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 02:49:11 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 23 Feb 2022 02:49:10 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 23 Feb 2022 02:49:10 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 02:49:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KNjVvwDdoans20271zxPKThXbXB3qieZQ3WDOuAUvTTXvZ7YSiST/uOuPSTivo56msFNBeWUOBM3+BP5Rtlh4DPCgst8bUAMMtQGXVst772C+UAabMop00DvPriTWljMRAyGz8uYYBy4QStTJUditTXrgbOTUP/1nytMDgEPzwtjXyJ4OizsmaLv/A1vPUZBXekO9U3v3ACExD3hthxoSPPRpLvTNoCbT1crIUtbQkzMbne+7yFYFwSxd049KNxxHPD9Vyx5zbGmEl44de8LfQOUdxoIDk8qpKxPiK4xST5C/sUrevFzctbbFHXGfiHYBDutKBlb219cTCgFHlg5rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=avC8gTytjPKtCgAufcj0/uW3rdWipl2A356bZMUGhw0=; b=ZCGdU8x84N3iFiRGBQsPVd9QZHluuK/Xflopejr1hQLDtumJJx8bM3EzSfyv7oGYhNQ9E1he2pjvFzNpD+sAbl82oYtdhnYmrviy2wFWW1lgWk6a71qMHLL8YgAK3X8HInB3ZeXVOrbM3lblmBBBRxUhPmEt+l4yy34EqXU1MOkS8o8OshfNAsmT27/bLHaqWjVSQxeVm5qdSYBUyMaV7MQJn0CbhHeayy0HPqdO3dlKx+A4smbENvyKjIgqcRUYl2ZhnTamTSBNWU9q6uzHX9W/bya6TdplJaksoHo8yS8BTH2NkrGhOLEdcGbj4he+jlIVGG9+Yq2cUXSWLKPdWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM6PR11MB3067.namprd11.prod.outlook.com (2603:10b6:5:6a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Wed, 23 Feb 2022 10:49:08 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::21db:e2fd:b9a3:9292]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::21db:e2fd:b9a3:9292%5]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022 10:49:08 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "kraxel@redhat.com" , "Xu, Min M" CC: Ard Biesheuvel , "Justen, Jordan L" , Brijesh Singh , "Aktas, Erdem" , James Bottomley , "Tom Lendacky" Subject: Re: [edk2-devel] [PATCH V6 33/42] OvmfPkg: Update PlatformInitLib for Tdx guest to publish ram regions Thread-Topic: [edk2-devel] [PATCH V6 33/42] OvmfPkg: Update PlatformInitLib for Tdx guest to publish ram regions Thread-Index: AQHYJYgiOahgjQuq+0K6mXZLMfOf1Kyg7z4AgAAJqbA= Date: Wed, 23 Feb 2022 10:49:08 +0000 Message-ID: References: <6b6241dda6d4a672e4602ddae095963c0e127edc.1645261991.git.min.m.xu@intel.com> <20220223100724.5wqr3lmso43n3yhc@sirius.home.kraxel.org> In-Reply-To: <20220223100724.5wqr3lmso43n3yhc@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f88c46bf-ece4-4ad0-4f49-08d9f6ba1ea9 x-ms-traffictypediagnostic: DM6PR11MB3067:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pSoMxJcXWBAKhNEt1rZlXiat/xgRbuzYG1Amp9Uj/Fg2PjUzJp2BdYlQyiSRCSmxrWnnj9QTl1zwZXnmFcsmKLHNr9MOtoysKaHU0gSdNDVNvOab2k8Em1IqYeI0sEl4rfazNjUYfPNZKpW4LTGYGCAEtP6WqwTyRZ8h68mCF77Ge6QdiP/h4QSGJUauMjTkGlgyDPdRam36W0dNrSbBWvRJQZyp4fSCVlUYC9F4PJppCy6qvt2WfoTYa0rvg8O91tLw8PnNT8dWw9wbO7V7aMNi5Yzh3u1Z8IhGZ3LwE+xq2VPZE2w6tp9fTEreLrhAUJ493Lx1PKmu8CyiutbcpgypNhHTU0+3MI4lftZxmwNgeTvfioo0LbcK99JAteRpJzFsLs3KcNUBAfxq2qtsyx6tzgL9rU/4Uu4gOTC3YM71SxI+r7yzvmA6ZapqfWTcvdPP9bE6V+UVxQqSkqgNie+nKE3fsHNsqVf2+znBzVh1Smotbh1NxU7omeD+Uhe15lJQpn0ODGW45/Cz6f8qDkjZ5OWpLMWDgW6mcZZDrpg7yKUF4lXpcopuIbDTU2LW2Cl44hEnGsvaU7EMYiq0/z/dPOP/Xt0WNGKrUR5j6/H4rj8RUhltbXoeRAVD3iUdNEnZmL5GmA5hVeLs1Z3zSvWmdmUWui+uW0czdE477WCUxE97/SYIyGxSBGolFQrDphoZMboeT5H9eXFGce0JjwYZo5ukIRzmb373DfGHNC70ttAXbTqx6IZZ3u+qip9utpOpppd60h6r9xdHWoGNnWey7z67cWBF99Y2xSoz6zGBLvht0vn8h+pwtPkJlzo1Hd3gysa361gImAlERW39+Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38070700005)(4326008)(64756008)(66946007)(76116006)(66556008)(26005)(66446008)(122000001)(66476007)(8676002)(966005)(186003)(508600001)(9686003)(33656002)(38100700002)(71200400001)(82960400001)(86362001)(316002)(6506007)(15650500001)(2906002)(83380400001)(55016003)(8936002)(6636002)(54906003)(52536014)(7696005)(5660300002)(110136005)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g7dCwGtc92qiRvtI/jL2p863Kut7ePZDGGe9DFRPbtobT/jmtaE3t1Afx9wb?= =?us-ascii?Q?CfXF/lrcVKV3kN1DP9KsMEMoBdwjhp/1eQSyiOTJ/pcyK+CLJE3cX2jYUQNg?= =?us-ascii?Q?SaoDPZao/MJBcZYNrQoBXIizIFi6Fw/1KKlOrF7KMtDNcMjeFo7L5CB8dxyx?= =?us-ascii?Q?xGNfucQiR7NEylfDr/cMJlMlNhXwab8bxat3/ujXYn4GXQimSAFPuCMLVKWH?= =?us-ascii?Q?6QKolR0tHj15XowUGl4XEXVU+TJYtc1GWpxmhOMq1MHxpynnBHLHmK9CmvzH?= =?us-ascii?Q?kvjJeebg2t/lI85y68Nmrny0KnDBJB3rdZJtUwAN0mCZJganCCBtKWjmrcf0?= =?us-ascii?Q?2FiFFsFY1btRaHsl2OkZ02wRcHW1jwmAmMl/FP7U+OXH/oTAbZ98vZs4Av+T?= =?us-ascii?Q?v9ko1xSAgpZcS8ysrUjfmg1exTcVgayCeEvfDP6ekaNE/6okdmBCr/kuQYP2?= =?us-ascii?Q?Vp2xXdPgEtMn3FKZm1AVE4EVoWfjgtUQqwjT+FOTmYz4VMXTvqFWcx4Sha7Q?= =?us-ascii?Q?aWwbcrv0KqxLNgJEpqvqv2yr436uKcOalW7FRUcuICmfAHkCd3uQgt0yPX+i?= =?us-ascii?Q?t7YPxdSuIHqWx+zd6oCnXy/d0dHo13SgXT7gfFE8ArhPtQKSqonsxVtilFi9?= =?us-ascii?Q?tywqOVHqQYkON2Hc3XIvYEoGJ8bysBprScnllxnbMAAHz1MLExdPL/x7/VT/?= =?us-ascii?Q?e7D7p4XbekNF5CIxnQ+kn4kdPvQ3wZC4E7q+Lt3sDl/TvcgVS+VoD/Og4cdt?= =?us-ascii?Q?IdTNHJe+AGhNVakncfuJA0T20DdBy71b60/sTJidcOjthqkjp1MTMPcCg5Yo?= =?us-ascii?Q?34arqOx1DSEeBRCBD7v0OLAyqcMd4BJPJN1TNbKQ+DT0Th2nfJr0LBtEkK7S?= =?us-ascii?Q?UQK5+rCo0btvAgvFjdxaSDjmazxc7LBqhrtxcwuJk7E/Kq/b18bbRjs8I3gr?= =?us-ascii?Q?lI7NdK0+IgoAljk9wyVvtCbMgdOAQZTY7KLc0WVScmQo+c+DH5X/z5udGukB?= =?us-ascii?Q?Lt32xUFjUrzhvQ753ApZ+nNLlJmfsXyQPl4CN+S3b9T+zCqK/hBBrr4Bq0e8?= =?us-ascii?Q?DXr65zaTZ6+daEGGGsfmq449G8KpUuAcnjHhJEF5G4kkZfth2nRAToEmJ/9Q?= =?us-ascii?Q?v47sMRYJtP/Kj5hfHD/hLzLIp3TRFP3/2ac7WxZL0/1sU9aWRxiW8SpMuydj?= =?us-ascii?Q?OrsGCSs6WzOzY2bbLe7Env4+4oi5uiOtSoV1dcpYEaGEtCtudE2qaKXQ3WxN?= =?us-ascii?Q?9dGCm99Gg9dLc/uznKA9sn0Gq+xnSeUqlOovE2NTJbUglKo1/7i58mOEn4kO?= =?us-ascii?Q?QWIEhx3EMjSycU5wCJf8wKNN33FuheBxWza7XD1h3BJffvrvfpoKR7QvYnI2?= =?us-ascii?Q?BwaaEpON6E2zIIh1CwmPSTFn4ZyZhO5BEPvjPNetCpFMMnsiiyoTzd9hm6Y+?= =?us-ascii?Q?BlT0kmDuu3yzS9f6mYZ4RGEeM6WUF53CNHYvhStfgmTFggYxa0zk+8efD7QP?= =?us-ascii?Q?RYESUHXd5EDN8mEHqnhjAXhrQFLLNcKImAL+Xc0476OnV+yiMf6vkaSVPyqt?= =?us-ascii?Q?qR5ryPnPNAPezqHcYyqrLsVg1hI2E3cbtafkx6EiE0sIq+C9SzKFd1U9XPTR?= =?us-ascii?Q?NwJ6WBWVT6uZB7g+5qXcrT0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f88c46bf-ece4-4ad0-4f49-08d9f6ba1ea9 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 10:49:08.7460 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wOoxrpxiNyvde2H41pcvAsBn02rrV7+TRyVp+EgzRpz2Lx/5JnRX3/xoBnt2EGhW5io9XszltLij+60NCyxrTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3067 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I think both are correct. The dump info is from a *client* machine in old generation - kabylake. 39 b= its physical is good enough. GPAW in TD is enforced by TDX-module. Please refer to https://www.intel.com/content/dam/develop/external/us/en/documents/tdx-modu= le-1.0-public-spec-v0.931.pdf,=20 Section 10.1.2, Table 10.1 - RBX[5:0] is GPAW - only 48 and 52 are possible= . Thank you Yao Jiewen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Wednesday, February 23, 2022 6:07 PM > To: Xu, Min M > Cc: devel@edk2.groups.io; Ard Biesheuvel ; Jus= ten, > Jordan L ; Brijesh Singh ; > Aktas, Erdem ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > > Subject: Re: [edk2-devel] [PATCH V6 33/42] OvmfPkg: Update PlatformInitLi= b > for Tdx guest to publish ram regions >=20 > Hi, >=20 > > Another update is in PlatformAddressWidthInitialization. The physical > > address width that Tdx guest supports is either 48 or 52. >=20 > Hmm. Sure this is correct? >=20 > 48 is the max _virtual_ address space possible with 4-level paging. > The _physical_ address space might be much smaller, like this > (kaby lake desktop system): >=20 > # lscpu > Architecture: x86_64 > CPU op-mode(s): 32-bit, 64-bit > Address sizes: 39 bits physical, 48 bits virtual > Byte Order: Little Endian >=20 > Maybe all TDX-capable Intel CPUs actually have >=3D 48 bits physical, > so this could be fine, but please double-check. >=20 > thanks, > Gerd >=20 >=20 >=20 >=20 >=20