* [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in SmmCryptLib.inf
@ 2023-01-25 19:21 Jake Garver
2023-01-25 19:44 ` Michael D Kinney
0 siblings, 1 reply; 5+ messages in thread
From: Jake Garver @ 2023-01-25 19:21 UTC (permalink / raw)
To: devel
Cc: jbrasen, ashishsingha, jiewen.yao, jian.j.wang, xiaoyu1.lu,
guomin.jiang, michael.d.kinney, Jake Garver
These sections were removed mistakenly. SmmCryptLib.inf supports these
architectures.
Signed-off-by: Jake Garver <jake@nvidia.com>
---
CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
index 55df99f843..ab19930871 100644
--- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
+++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
@@ -75,6 +75,12 @@
[Sources.X64]
Rand/CryptRandTsc.c
+[Sources.ARM]
+ Rand/CryptRand.c
+
+[Sources.AARCH64]
+ Rand/CryptRand.c
+
[Packages]
MdePkg/MdePkg.dec
CryptoPkg/CryptoPkg.dec
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in SmmCryptLib.inf
2023-01-25 19:21 [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in SmmCryptLib.inf Jake Garver
@ 2023-01-25 19:44 ` Michael D Kinney
2023-01-26 1:41 ` Yao, Jiewen
0 siblings, 1 reply; 5+ messages in thread
From: Michael D Kinney @ 2023-01-25 19:44 UTC (permalink / raw)
To: Jake Garver, devel@edk2.groups.io
Cc: jbrasen@nvidia.com, ashishsingha@nvidia.com, Yao, Jiewen,
Wang, Jian J, Lu, Xiaoyu1, Jiang, Guomin, Kinney, Michael D
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: Jake Garver <jake@nvidia.com>
> Sent: Wednesday, January 25, 2023 11:22 AM
> To: devel@edk2.groups.io
> Cc: jbrasen@nvidia.com; ashishsingha@nvidia.com; Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>; Kinney, Michael
> D <michael.d.kinney@intel.com>; Jake Garver <jake@nvidia.com>
> Subject: [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in SmmCryptLib.inf
>
> These sections were removed mistakenly. SmmCryptLib.inf supports these
> architectures.
>
> Signed-off-by: Jake Garver <jake@nvidia.com>
> ---
> CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> index 55df99f843..ab19930871 100644
> --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> @@ -75,6 +75,12 @@
> [Sources.X64]
> Rand/CryptRandTsc.c
>
> +[Sources.ARM]
> + Rand/CryptRand.c
> +
> +[Sources.AARCH64]
> + Rand/CryptRand.c
> +
> [Packages]
> MdePkg/MdePkg.dec
> CryptoPkg/CryptoPkg.dec
> --
> 2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in SmmCryptLib.inf
2023-01-25 19:44 ` Michael D Kinney
@ 2023-01-26 1:41 ` Yao, Jiewen
2023-01-26 8:03 ` [edk2-devel] " Ard Biesheuvel
0 siblings, 1 reply; 5+ messages in thread
From: Yao, Jiewen @ 2023-01-26 1:41 UTC (permalink / raw)
To: Kinney, Michael D, Jake Garver, devel@edk2.groups.io
Cc: jbrasen@nvidia.com, ashishsingha@nvidia.com, Wang, Jian J,
Lu, Xiaoyu1, Jiang, Guomin
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Thursday, January 26, 2023 3:44 AM
> To: Jake Garver <jake@nvidia.com>; devel@edk2.groups.io
> Cc: jbrasen@nvidia.com; ashishsingha@nvidia.com; Yao, Jiewen
> <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1
> <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: RE: [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in
> SmmCryptLib.inf
>
> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> Mike
>
>
> > -----Original Message-----
> > From: Jake Garver <jake@nvidia.com>
> > Sent: Wednesday, January 25, 2023 11:22 AM
> > To: devel@edk2.groups.io
> > Cc: jbrasen@nvidia.com; ashishsingha@nvidia.com; Yao, Jiewen
> <jiewen.yao@intel.com>; Wang, Jian J
> > <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin
> <guomin.jiang@intel.com>; Kinney, Michael
> > D <michael.d.kinney@intel.com>; Jake Garver <jake@nvidia.com>
> > Subject: [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in
> SmmCryptLib.inf
> >
> > These sections were removed mistakenly. SmmCryptLib.inf supports these
> > architectures.
> >
> > Signed-off-by: Jake Garver <jake@nvidia.com>
> > ---
> > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > index 55df99f843..ab19930871 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > @@ -75,6 +75,12 @@
> > [Sources.X64]
> > Rand/CryptRandTsc.c
> >
> > +[Sources.ARM]
> > + Rand/CryptRand.c
> > +
> > +[Sources.AARCH64]
> > + Rand/CryptRand.c
> > +
> > [Packages]
> > MdePkg/MdePkg.dec
> > CryptoPkg/CryptoPkg.dec
> > --
> > 2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in SmmCryptLib.inf
2023-01-26 1:41 ` Yao, Jiewen
@ 2023-01-26 8:03 ` Ard Biesheuvel
2023-01-26 9:08 ` Ard Biesheuvel
0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2023-01-26 8:03 UTC (permalink / raw)
To: devel, jiewen.yao
Cc: Kinney, Michael D, Jake Garver, jbrasen@nvidia.com,
ashishsingha@nvidia.com, Wang, Jian J, Lu, Xiaoyu1, Jiang, Guomin
On Thu, 26 Jan 2023 at 02:42, Yao, Jiewen <jiewen.yao@intel.com> wrote:
>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>
Thanks, I'll go and merge this.
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Thursday, January 26, 2023 3:44 AM
> > To: Jake Garver <jake@nvidia.com>; devel@edk2.groups.io
> > Cc: jbrasen@nvidia.com; ashishsingha@nvidia.com; Yao, Jiewen
> > <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1
> > <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>
> > Subject: RE: [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in
> > SmmCryptLib.inf
> >
> > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Mike
> >
> >
> > > -----Original Message-----
> > > From: Jake Garver <jake@nvidia.com>
> > > Sent: Wednesday, January 25, 2023 11:22 AM
> > > To: devel@edk2.groups.io
> > > Cc: jbrasen@nvidia.com; ashishsingha@nvidia.com; Yao, Jiewen
> > <jiewen.yao@intel.com>; Wang, Jian J
> > > <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin
> > <guomin.jiang@intel.com>; Kinney, Michael
> > > D <michael.d.kinney@intel.com>; Jake Garver <jake@nvidia.com>
> > > Subject: [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in
> > SmmCryptLib.inf
> > >
> > > These sections were removed mistakenly. SmmCryptLib.inf supports these
> > > architectures.
> > >
> > > Signed-off-by: Jake Garver <jake@nvidia.com>
> > > ---
> > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > index 55df99f843..ab19930871 100644
> > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > @@ -75,6 +75,12 @@
> > > [Sources.X64]
> > > Rand/CryptRandTsc.c
> > >
> > > +[Sources.ARM]
> > > + Rand/CryptRand.c
> > > +
> > > +[Sources.AARCH64]
> > > + Rand/CryptRand.c
> > > +
> > > [Packages]
> > > MdePkg/MdePkg.dec
> > > CryptoPkg/CryptoPkg.dec
> > > --
> > > 2.17.1
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in SmmCryptLib.inf
2023-01-26 8:03 ` [edk2-devel] " Ard Biesheuvel
@ 2023-01-26 9:08 ` Ard Biesheuvel
0 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2023-01-26 9:08 UTC (permalink / raw)
To: devel, jiewen.yao
Cc: Kinney, Michael D, Jake Garver, jbrasen@nvidia.com,
ashishsingha@nvidia.com, Wang, Jian J, Lu, Xiaoyu1, Jiang, Guomin
On Thu, 26 Jan 2023 at 09:03, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Thu, 26 Jan 2023 at 02:42, Yao, Jiewen <jiewen.yao@intel.com> wrote:
> >
> > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> >
>
> Thanks, I'll go and merge this.
>
>
Merged as #3947, thanks
> > > -----Original Message-----
> > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Sent: Thursday, January 26, 2023 3:44 AM
> > > To: Jake Garver <jake@nvidia.com>; devel@edk2.groups.io
> > > Cc: jbrasen@nvidia.com; ashishsingha@nvidia.com; Yao, Jiewen
> > > <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1
> > > <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>; Kinney,
> > > Michael D <michael.d.kinney@intel.com>
> > > Subject: RE: [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in
> > > SmmCryptLib.inf
> > >
> > > Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> > >
> > > Mike
> > >
> > >
> > > > -----Original Message-----
> > > > From: Jake Garver <jake@nvidia.com>
> > > > Sent: Wednesday, January 25, 2023 11:22 AM
> > > > To: devel@edk2.groups.io
> > > > Cc: jbrasen@nvidia.com; ashishsingha@nvidia.com; Yao, Jiewen
> > > <jiewen.yao@intel.com>; Wang, Jian J
> > > > <jian.j.wang@intel.com>; Lu, Xiaoyu1 <xiaoyu1.lu@intel.com>; Jiang, Guomin
> > > <guomin.jiang@intel.com>; Kinney, Michael
> > > > D <michael.d.kinney@intel.com>; Jake Garver <jake@nvidia.com>
> > > > Subject: [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in
> > > SmmCryptLib.inf
> > > >
> > > > These sections were removed mistakenly. SmmCryptLib.inf supports these
> > > > architectures.
> > > >
> > > > Signed-off-by: Jake Garver <jake@nvidia.com>
> > > > ---
> > > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > index 55df99f843..ab19930871 100644
> > > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> > > > @@ -75,6 +75,12 @@
> > > > [Sources.X64]
> > > > Rand/CryptRandTsc.c
> > > >
> > > > +[Sources.ARM]
> > > > + Rand/CryptRand.c
> > > > +
> > > > +[Sources.AARCH64]
> > > > + Rand/CryptRand.c
> > > > +
> > > > [Packages]
> > > > MdePkg/MdePkg.dec
> > > > CryptoPkg/CryptoPkg.dec
> > > > --
> > > > 2.17.1
> >
> >
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-26 9:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-25 19:21 [PATCH] CryptoPkg/Library: Replace ARM/AARCH64 sections in SmmCryptLib.inf Jake Garver
2023-01-25 19:44 ` Michael D Kinney
2023-01-26 1:41 ` Yao, Jiewen
2023-01-26 8:03 ` [edk2-devel] " Ard Biesheuvel
2023-01-26 9:08 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox