From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"anthony.perard@citrix.com" <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei
Date: Wed, 21 Dec 2022 08:12:52 +0000 [thread overview]
Message-ID: <MW4PR11MB587252947F0A12743B81D0AC8CEB9@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221220072558.6af73qvo43gngqvs@sirius.home.kraxel.org>
Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Tuesday, December 20, 2022 3:26 PM
> To: devel@edk2.groups.io; anthony.perard@citrix.com
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen
> <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info
> HOB in XenPlatformPei
>
> On Mon, Dec 19, 2022 at 04:36:20PM +0000, Anthony PERARD via groups.io
> wrote:
> > From: Anthony PERARD <anthony.perard@citrix.com>
> >
> > Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei.
> >
> > QemuFwCfgLib expect this HOB to be present, or fails to do anything.
> > InternalQemuFwCfgIsAvailable() from QemuFwCfgPeiLib module will not
> > check if the HOB is actually present for example and try to use a NULL
> > pointer.
> >
> > Fixes: cda98df16228 ("OvmfPkg/QemuFwCfgLib: remove
> mQemuFwCfgSupported + mQemuFwCfgDmaSupported")
> > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>
> You might also consider moving global variables to the PlatformInfoHob
> or use PlatformInitLib functions instead of your own copy or both.
>
> take care,
> Gerd
next prev parent reply other threads:[~2022-12-21 8:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 16:36 [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei Anthony PERARD
2022-12-20 7:25 ` [edk2-devel] " Gerd Hoffmann
2022-12-21 8:12 ` Yao, Jiewen [this message]
[not found] ` <1732C0C7E7695AF7.27785@groups.io>
2022-12-21 8:54 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB587252947F0A12743B81D0AC8CEB9@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox