From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.14218.1671610376406600284 for ; Wed, 21 Dec 2022 00:12:56 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=PVDwene0; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671610376; x=1703146376; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=cqw6Suo3WSCyw8gqI6Af3xt9K+OIr6EkU1vwB06Y/9I=; b=PVDwene0X5IclQTRvYX3f0bbClZR4mhuzHnBSxrIFSpNZmP6DD2wJEjy VQgBSulxcuTP9DNMEpDTOQfgpecC+4WJ/b1AdPFhRb7wmm+TyApBQaH8t 1oQRuJsiJwen46f7D5RpMnAxetJmi5r/Yr9qNOcAfYdmaiGIbFC9LZdap +O/llgZR+cZtptzwHOackbw5ZFcN6Isf3iBS7L7+t/cqT7RRwPryhdSI2 hi1lh13qflWNSJEB0AkegiUeJRz/w+tPWiCP0dDl8191ZFPH5GNrDuzEQ +afYcmrbpuuAOaZA9qYRAL2qThe0dtIsLSTcSMCMZvLZyog8cOL6fW0K6 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="319870012" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="319870012" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 00:12:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="601404559" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="601404559" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 21 Dec 2022 00:12:55 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 21 Dec 2022 00:12:55 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 21 Dec 2022 00:12:55 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 21 Dec 2022 00:12:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g8kRRq1YcPGqHaaIFgoTN2W2Psj0LBKRqqyCQqcRewnRx9PIOiZ7IEUK7zyf9LTv/6oE3achXpcMdrb1JoLrwFkY2HcuvaT6BFnKDoXttulY0SCTl/ZiE7CBkV+is8kEOpkFzve69ZsggpQj8qN7Gt2L5iyyw7fye8by3W6JkarWGU8hRFvatfeoaglFKqoTDFAzMl1rXoqgKAfaH/boxveAj3UnTwDzmjmbvQ+DA4Cde+o2C/ii5I/R/Y1m4r/zXfi6X32PQe/i1fp4Bv6fmmvBP5lZ5K/JGuEHF79gUC9PPbeHzlX5Im6WMSWy47LzFhIsM8ll8d5tK2zCCp+bQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jkwzEW6Nlwj3jpYkkzZj88DV8sJ8vfTLVmio5LGOW+A=; b=IUX34obKKHoQoI3jItwelNVkgLO+ZcUa07KAl2+VRZ9XBzBh1ux9O2StgusMksQ4kOEmu8dkZrxCCYEl++Wy2chlJ1q/QGeVbErSJzaKRJk4HagEmBtvm7rwJ14IGRro8wW/RwlYMAnNj6P0Y3nyjcegXNDwO9Uw1ww7fQvWcGs6nmECxmU/mtbbsY2mHFzvvxmB7rtQsmkeR608KLCT+Hh8GahWb1gJmof81b/sgjgBZG5d3JopvpkpYKATyUx08jta6GKvOP9UlOLf0m3Q1TabZSacCHcV6+jtBtlNZYQv4CNLYCgahtXRlSDYJJ0ygHceiQ/kH/tRJ/7rurESSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DS0PR11MB6423.namprd11.prod.outlook.com (2603:10b6:8:c5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Wed, 21 Dec 2022 08:12:53 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%8]) with mapi id 15.20.5924.016; Wed, 21 Dec 2022 08:12:52 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann , "devel@edk2.groups.io" , "anthony.perard@citrix.com" CC: Ard Biesheuvel , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei Thread-Topic: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform info HOB in XenPlatformPei Thread-Index: AQHZE8gaMgMXFf0lHkG82YPVos7wqq52YQsAgAGfYWA= Date: Wed, 21 Dec 2022 08:12:52 +0000 Message-ID: References: <20221219163620.20155-1-anthony.perard@citrix.com> <20221220072558.6af73qvo43gngqvs@sirius.home.kraxel.org> In-Reply-To: <20221220072558.6af73qvo43gngqvs@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|DS0PR11MB6423:EE_ x-ms-office365-filtering-correlation-id: 42e609b4-77f2-4518-4da5-08dae32b287f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GmNTxpBEG5ptikSbypFRoau+jcIOya+IW/M9XeoCalJUDcd5xuzEvhN8gAQB4RCkUaz6/M7BnbIE8p13A7byAj1QxkLG5CV1ve9efNot7Q6AtLsXGbzr2DbaA9hMuxF39Xxa0lfvhub0yLiiKLAw7U/5WPzygR8l6iHmSxTnsz6AECDJInRdl7JOU8dyr/8gpP8+TXtoGwZuIT0z97rDKTJhS95tYM41VdW3E9VGsGWLUt+TmY2qdgD9UCqPUThe5kYS+M/l4FLOZnq9+bNZx5GUtdshEN3BHqHuUpQb9Z5jMT659Vwp8zWRFBknLoeUP4jegeZIF+9s4GcuXbsjUwM6kW1aq5thsMxPs6qv2/1ZexaLEWgSLkrXVnJaFgh8xAqfXYBM2+73Qi8Jtzoo2YL7HuPc/U9qkZ7LcHJwfuGAO8H9NsCqBnnFM3e1r6INhsf1wkhUDcBeEqlscI+nHXAVXJQHfj5D9MervjAh4wcXYPL8ssb8PesU/edAAZv3GJof18YQMyMD0su8NazeVtvrd0zvyVyeaWd7qLlY3/69w16CAsE9Bu0gXsuHw5PQfLNj1f7LMQC0EQ0vt5KNS5ewoaQAKaC5tIxyp1GdqnGiClF9Vt20jXzFszAo6LeNC67vBja9zA6R/tBULyxbjmnTliBCU/YDUka6PWLAL4WQOrX52wuP9B0XGdJM63LjVYcAjJjIu51brg89vsTU3A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(366004)(346002)(376002)(39860400002)(136003)(451199015)(26005)(9686003)(38070700005)(478600001)(186003)(53546011)(71200400001)(33656002)(55016003)(110136005)(54906003)(6506007)(107886003)(7696005)(2906002)(316002)(86362001)(82960400001)(122000001)(41300700001)(38100700002)(8676002)(83380400001)(4326008)(66556008)(66446008)(64756008)(76116006)(66476007)(5660300002)(66946007)(8936002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8hgNfxQtIzITXKPvvxz0xNi0Ci2kxLBn0b++YiQDWaZ6EY2Gd1FHVKMT0ub1?= =?us-ascii?Q?TkrgVJweW5UxAzDBEPUAeJSaTF07Gg37a2PxRhY10lTXtPw3reBN55IFMwOx?= =?us-ascii?Q?guOVg7k+Tjs3+89gtvAp3qXunr2grWp4ju9gsYZFcX4+podJte5mUtr9TLcK?= =?us-ascii?Q?QFjlSk7Kxf7cY74Kd4wqRi3BECRTz5En9PR+9QEXzYxjyp7ShruiEguurRBx?= =?us-ascii?Q?NfdSE6JMwKhdgN9cT2Dfkza455NNJijnXKDTimTlcfT0vQjkO/dw7fBQPA7h?= =?us-ascii?Q?ErVflJHPPvNDUpUqcf/H4CYiJNTwBJP41sNLLo0qOYe3kRdNiMhz2JrstqBj?= =?us-ascii?Q?O69TB04V0KcsaKLYNdqShkLeuZ1DlmLNxog9zOz1nJeozeS3h/sBw3whN3Fw?= =?us-ascii?Q?Qp2R4rMj70AMK9LACg/OBw6IyGhVlGu9Lbu98A+gF5EVz+gPvqfhdQzmI5SY?= =?us-ascii?Q?vlndzw45mE7YrA2hOxzc1Lv/YqTxwDFPuGd1rjH4KDDBx6hFX/WAmKwRGfY9?= =?us-ascii?Q?K83uG+J1vyh2Vrd9bNR7qOlcMbSZ2/H8xZLsD7UthM8NgbzJQQfg7w/rzMp9?= =?us-ascii?Q?SNEYXSrVkUuvwn1eqQEZYVM3UBeCJ4UkrwuMiCE3Pp5EOPjIXNHcZJAJK0Ny?= =?us-ascii?Q?MQOAp0xtjf8SRTsKt9mL9AF3O+RIFCJ/AlkCQ4LCnEJDkP+dEILS6DxoiOkB?= =?us-ascii?Q?QkT4JxnLU58Uikk+dYYgT5QaTVDT4aGbPRGnMdeDE2n2N4EMMFed8WJ3zgEM?= =?us-ascii?Q?HD25cKTeMEA5VKnCcjO8MRl76iaiGV03ZLbLP5CmAOKJamR9J3VQZs4ruHlM?= =?us-ascii?Q?FmFGlMIUCcaJ3jRJlCmqqMCPbi9W8MzEqBZJss3QXvdqxflzThy1XADSX0oe?= =?us-ascii?Q?ALmDVeOeTG0QX4lYiq3F28vE7OhgNWVkxavZ8EoisNzCPlYgubs3MrNAcZ7x?= =?us-ascii?Q?lAjfHsn/L/0gVOzMpqsSwbkvki8VXdnxkS+pOfGVNFjEc2rkRpjxVE3lC6Ij?= =?us-ascii?Q?/zG3g77a2IhliPWxY0EhbfU/tgsdBClvtckRfHDRCkTuJ3OcqCBhPLpyTxRg?= =?us-ascii?Q?jCDwznk2vFYry08FvI2S0M1vx3BzFZwiVI7SDiSoRetXUyEyqmBz+DUAe/ma?= =?us-ascii?Q?Nsxi65MzqOV3k2ngTHgn8XMla/edr8XDfRPBZNJHNvSvrK1yYDeGzghYsJbR?= =?us-ascii?Q?qooB8a66/51AhoMa0Gr7Jke+/Z+yw8tP1pFlrscYjD828XepflQI96AW34sc?= =?us-ascii?Q?oa9/uxvefABnQd8hP9NXqaApXx8HzuxNB2KDfPyjuSfTFKiy608GUm8dMW0K?= =?us-ascii?Q?2iXrkhNnnN1l+PWjcg8c4/U04SmFim7wSDXur48Ue6Dl8dTMdxSC6uRQe8vi?= =?us-ascii?Q?AFTyo1e13HQF4Qnlgw2eBWH2sN4JZqfmzZx/F5xavYiinHv61/3Av/U32hDX?= =?us-ascii?Q?i0Dx0iqMGI37fz9DcQdPOqP8ryNnMNhuWYSJgVCU2fUBSin81Sb4RxzZO0Yy?= =?us-ascii?Q?da5eSTQ0JASslsfs+ajuLF7qVJH8oIffV3krEqezZnjErJJfSattldomHhHo?= =?us-ascii?Q?hz7fWN3ZpTAmUodWhYMa3Sjn1UJgfL9zS9bPph56?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42e609b4-77f2-4518-4da5-08dae32b287f X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2022 08:12:52.8251 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: As1Z/AtqfiFMAmiS+qWnWxgJ2Zlf7ig5bSEOHFUCOOLW/GHePl1LcGUvPcdI6xGDnroMlF/ivkJwxRnuv1J/Rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6423 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Jiewen Yao > -----Original Message----- > From: Gerd Hoffmann > Sent: Tuesday, December 20, 2022 3:26 PM > To: devel@edk2.groups.io; anthony.perard@citrix.com > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L > Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/OvmfXen: Build platform inf= o > HOB in XenPlatformPei >=20 > On Mon, Dec 19, 2022 at 04:36:20PM +0000, Anthony PERARD via groups.io > wrote: > > From: Anthony PERARD > > > > Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei. > > > > QemuFwCfgLib expect this HOB to be present, or fails to do anything. > > InternalQemuFwCfgIsAvailable() from QemuFwCfgPeiLib module will not > > check if the HOB is actually present for example and try to use a NULL > > pointer. > > > > Fixes: cda98df16228 ("OvmfPkg/QemuFwCfgLib: remove > mQemuFwCfgSupported + mQemuFwCfgDmaSupported") > > Signed-off-by: Anthony PERARD >=20 > Reviewed-by: Gerd Hoffmann >=20 > You might also consider moving global variables to the PlatformInfoHob > or use PlatformInitLib functions instead of your own copy or both. >=20 > take care, > Gerd