public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Shang, Qingyu" <qingyu.shang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH v4 3/3] SecurityPkg: Update ReceiveData and SendData function description
Date: Wed, 28 Feb 2024 05:57:39 +0000	[thread overview]
Message-ID: <MW4PR11MB587256AF2B1A27B8ABDA665E8C582@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <299a57fcbbb7dbf39962bbe88ad09aa35344e2e7.1708915895.git.qingyu.shang@intel.com>

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Shang, Qingyu <qingyu.shang@intel.com>
> Sent: Monday, February 26, 2024 11:06 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH v4 3/3] SecurityPkg: Update ReceiveData and SendData function
> description
> 
> Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId'
> description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function
> ReceiveData
> and SendData.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Qingyu <qingyu.shang@intel.com>
> ---
>  SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
> b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
> index 0fb6b1bf41d5..1ee55105e435 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c
> @@ -49,7 +49,9 @@ EFI_GUID  mOpalDeviceLockBoxGuid =
> OPAL_DEVICE_LOCKBOX_GUID;
>    function shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the calling context.
> -  @param  MediaId                      ID of the medium to receive data from.
> +  @param  MediaId                      ID of the medium to receive data from. If there is
> no
> +                                       block IO protocol supported by the physical device, the
> +                                       value of MediaId is undefined.
>    @param  Timeout                      The timeout, in 100ns units, to use for the
> execution
>                                         of the security protocol command. A Timeout value of 0
>                                         means that this function will wait indefinitely for the
> @@ -148,7 +150,9 @@ SecurityReceiveData (
>    shall return EFI_DEVICE_ERROR.
> 
>    @param  This                         Indicates a pointer to the calling context.
> -  @param  MediaId                      ID of the medium to receive data from.
> +  @param  MediaId                      ID of the medium to receive data from. If there is
> no
> +                                       block IO protocol supported by the physical device, the
> +                                       value of MediaId is undefined.
>    @param  Timeout                      The timeout, in 100ns units, to use for the
> execution
>                                         of the security protocol command. A Timeout value of 0
>                                         means that this function will wait indefinitely for the
> --
> 2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116091): https://edk2.groups.io/g/devel/message/116091
Mute This Topic: https://groups.io/mt/104581211/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-02-28  5:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26  3:05 [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData function description Qingyu
2024-02-26  3:05 ` [edk2-devel] [PATCH v4 1/3] MdePkg: " Qingyu
2024-03-06 14:10   ` 回复: " gaoliming via groups.io
2024-02-26  3:05 ` [edk2-devel] [PATCH v4 2/3] MdeModulePkg: " Qingyu
2024-03-06 14:10   ` 回复: " gaoliming via groups.io
2024-02-26  3:05 ` [edk2-devel] [PATCH v4 3/3] SecurityPkg: " Qingyu
2024-02-28  5:57   ` Yao, Jiewen [this message]
2024-03-13  4:24 ` [edk2-devel] [PATCH v4 0/3] " Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB587256AF2B1A27B8ABDA665E8C582@MW4PR11MB5872.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox