From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2D17DD80A20 for ; Wed, 28 Feb 2024 05:57:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=vGC+87xFQeg1452Hxc7Rclnk+Mo2FOHtIiE/2BjVh0I=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709099864; v=1; b=JrBvo+rfDs7+lZXh9K3tYdGrPQIPPIyU9XvjbCCZp0XNsZNC4bmJDphuO3DfP2mkQ7lfwohA KoxVw137+h4627CVlua9sKBSzs8/F0+QVpPMuCotb4ipjU1k0mMI2BkNgB5tFqgCiNRAvtn9rro hD22mRkgsyN5Ko8y5YK+6c0c= X-Received: by 127.0.0.2 with SMTP id j5EmYY7687511x6NyCqYRbsa; Tue, 27 Feb 2024 21:57:44 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mx.groups.io with SMTP id smtpd.web11.7196.1709099864181475431 for ; Tue, 27 Feb 2024 21:57:44 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="3604314" X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="3604314" X-Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 21:57:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,190,1705392000"; d="scan'208";a="7686798" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Feb 2024 21:57:44 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 27 Feb 2024 21:57:43 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 27 Feb 2024 21:57:42 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 27 Feb 2024 21:57:42 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 27 Feb 2024 21:57:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n6MEQakQgCqpCYqmNdFrFS2hRR1vjqtmX3O47/Li9j5EH0vEDf1NHQ2Q7DMD2ZM1hVNPwhwuWmyQvK/hWYHQAWWK+t/HbvuFNuATxXLQrIMnWX+dVopcQmUKLy3JQga9Zp6MhEecjPE0J8cyCLCIjcenIceO+zQNKZxxGH0VhyKf2RFqywNhRgZyWZOa9BB/yOVvm57E2K9XIg69oTJLREJcIml45eVmKwxYu+ZxmIGjyWpRkwfxnRFqjGVAVHve4ylatbZc5u5jk0AxcwMi1jEQUdtjONzYNV8fzFpbMV9ElLZt8BezxICAm9PMjUjZ1E8t3eq3dW1yJGD7P+SxfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kJ16P/0NDnvq9HSBgccbxH6Tz6paW6cT5aeypQClFnQ=; b=BHRT4s3RoHAL7s9JCwP/Gd5ueQMar3rDJbzjSxGRaYQTP+f1DtmJARb8f3O45c1NbtigftCjZK0sCQt3bo+wwLKZhKJUB2qqtIanm839nM6FLqEpbFl71KuPQ9kgmFKyUPLjuCF3TX/KadihRhlzLsIC5v1wie8V+OONBx8fI80bIK0b0PNcerGw0IsSVVM+TwMUc5tayzFAYNJrjxaccj6kdawwpgfXUbOTHgWxp7iZsRvYINATZ8Q+RUSfhIPbJt9N7D0kghgWgA9k+q2LnrrVKjjmv7DvY4ZrIWcaSC3g8M461I7y7MYMlHVKt0zA2/W4vURPcyJp3AWzYMzVJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BL1PR11MB5288.namprd11.prod.outlook.com (2603:10b6:208:316::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.25; Wed, 28 Feb 2024 05:57:39 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::92a7:f6a2:9262:d150]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::92a7:f6a2:9262:d150%3]) with mapi id 15.20.7339.024; Wed, 28 Feb 2024 05:57:39 +0000 From: "Yao, Jiewen" To: "Shang, Qingyu" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v4 3/3] SecurityPkg: Update ReceiveData and SendData function description Thread-Topic: [PATCH v4 3/3] SecurityPkg: Update ReceiveData and SendData function description Thread-Index: AQHaaGDrzEiPIiokZUyMTekW7O62oLEfRUUA Date: Wed, 28 Feb 2024 05:57:39 +0000 Message-ID: References: <299a57fcbbb7dbf39962bbe88ad09aa35344e2e7.1708915895.git.qingyu.shang@intel.com> In-Reply-To: <299a57fcbbb7dbf39962bbe88ad09aa35344e2e7.1708915895.git.qingyu.shang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|BL1PR11MB5288:EE_ x-ms-office365-filtering-correlation-id: 95fd833b-353b-4a80-803a-08dc38222bfc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: mch70TXmq93ZtvLJ/54utEEmWH/m3YxfMZe87rbL2lI47tl9VB3RvkQYtgYfR3M5z3V6DK25Cw6qMsyyuIF3t2Dt0L4xKRNhynZmf3DMz/WOkfIPTjehPDsr1PvB9gEepy79JhX4I2FfEBJbLJUfhZK3Fl8OjUbVBlbKtyVGgidLSC+R62xjPhxs63EGuGLuV89Hr23LDY0pq1VFvadxvqT9IvGZ1uwGwovimrrkXl7INVaevLWkKOHoIqvo4lD/IoEzyHiu2LtYKlNIKLh9F3EzfrBJZ/byKKoBGv+cAttw5CxFEMZT2Bodwsk3Fc4jf0WyFt+TYSud7NS/HrvM6M9oakELEi+GKnk749CbyGgM3sUMo1rAE5lFakNyAk9npm36m2RSdMTGmkdbamMsp+V+SxkX1Y5GSrXrrdAZ+xXL/JCAtunR3aZYXMIDek4lrzWHqDNd+9wub/pEIgZ73rHNHzFeXbyUzZo1NuFV3veRERextX2hFlUOZjzTk1T9C6kZFIzxBQ01tg+iuvg7FS9+s3L3RDSq8zsKQBe1dgwyt/LAquTDthpIOHaVvhTuUwWkfWlW+hFDjhle2izxr62JCPGOV8Xr2iny7LQi8VGvij2nOnXc0Oflue+w9JgdBm7yYw56Dn/BFfNP3XISON6ouuRCIwZHXestFwTgtWTIqD+PTRt+7/aXtNlMbxm+DBuc5tadl8rJbIdDLRAaKCvH3gKK2yFsrguAyQhyxbQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Sar6xLlyqKCT74hwH/RTIeXzOy52RnWU90uS1TZp+gJQ2kNHcQtmPr9WhiJL?= =?us-ascii?Q?7Dj5Z95xxuuvk8gD8DSCy5gFNNrp/ez2dIpeqEn7BlTRcIS+MTrJ/okVeqsR?= =?us-ascii?Q?SED87BibW40d8ggu93h++14chz/RgSP1tgTEiYfrPuS/tNyLV8Kp2SsgZ2KX?= =?us-ascii?Q?oQX8gWdSlnCbBJCHezWv2S0dSA4XDcqyE9Cb4FWwV9ohosnrnmy+2SFOCxVY?= =?us-ascii?Q?lFaOwG1n1o5+fCa/4DyBXqPR7AaSebktV0IBuiSkXRCRj45SBXf6zy9Ay7ik?= =?us-ascii?Q?vDVK2Qu+9oy/o0hqbARKDVuWcMiyRLTyni6iWghE/oJDfCEguNppEjRA3Wjt?= =?us-ascii?Q?VXoyLMIqVIGzwPTZN11aYjIEMGs3fVh5ImPPqAGBNMcQJyYPWu8MFFRXfEcl?= =?us-ascii?Q?Pxp2bK7XTaEMgRTHK14MieI0RfHwk690q7RYSbW97QVLFDCGREDRCSCRwDdV?= =?us-ascii?Q?tIKTRx1tEdryFM6+sBeuZYEc6q2E3KLTeumvnP4xugTrMuAPMilNwkAb1SKs?= =?us-ascii?Q?w3/z+1xrd0p1qvuXJYokw3Si20UVsOTaFHSv5VIhOW29A3jHVH5NGoO2aHkN?= =?us-ascii?Q?f6iJI6a488juDPzc2OFnKCMrArEgvRBz4JwQgcZajSPhrM4ofZ+BfZkExphA?= =?us-ascii?Q?BrR9/9fQTJ7W/7HkO5WeQNg3X/9GWRS9oAQHLtur+Hkr2DtMqrzEWViXplhT?= =?us-ascii?Q?DLjhf0X7+GgjH9IjQp7L5ihFDTx4TTCAdjJd1dXv88PwTP9qoq+9PzNkFSh7?= =?us-ascii?Q?I5HG3oZWuU3L0hM4u3ejgeKctzwq8ew0UGH6vDaTH2ta4T2aXohlRqOwYphH?= =?us-ascii?Q?3dJBBNZJjxPgbqrH6LHY1ZcJ5YyHqaLwBaqa2NJMvmprWLNidhs1hJ+xf3xF?= =?us-ascii?Q?V6qwt/JTOiHP54BZDYZVw1+hBAldnBkAsav2hALpamR0fI0tk/CnjEfdAzm7?= =?us-ascii?Q?rhB/1mWH3/0GTsWC3cxeC+7erLkuYcU/d9vKeWjJKA1gBMawkuz7fyeYikCv?= =?us-ascii?Q?vrhCaDjJrAOU8+998b8VOWoQH4vDj/nbZB8WjlN2OdW35IXh6CGqcBGlsSDo?= =?us-ascii?Q?xnJU8m66YnR9jx9zeMAt21b3lVaZ3pY3ET3DYivHWIvJuY2JRIm+OQXBfbl9?= =?us-ascii?Q?gbEwh8BU9qz6xUysnFknGDCpGd2bBU1QouZXCHGuKPt6AFk+DDTrODzD7YRk?= =?us-ascii?Q?Su7GhaDwyXiBSX1x4USr383mgfYTpL9S1W8hqyElIpyKJ/vVTAa/YtvMBuM9?= =?us-ascii?Q?Xlz+gqa/HFThof6WQjaUwL4jk8NHkPTAEUFayOBalSpbCdqVoHsT4FRBiv8l?= =?us-ascii?Q?+bTVt7TI4wZNv813Y3umfhs4iCqk13MOriTaxvWJn3TUtbg6wwmX4ryTRGFu?= =?us-ascii?Q?dBWVnGLohAoQNuZvuuC9YYufCNL40Txaihzu0/hkAVUKYLS56GVG0bc7yTML?= =?us-ascii?Q?h3YqR3k99nv9cy96k5DnMbD3uWJwfL3zdaZxQ4+TeO5n/elohODOyrai87qW?= =?us-ascii?Q?O71FbM/Ixj67MnZsqvskOpLN541uYODL9etazF7e3MA8xyOKJXAi/TlFWq7/?= =?us-ascii?Q?+/t848jShhx0WqVZfW7S3pYVnSdo5adSSM74HxC2?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95fd833b-353b-4a80-803a-08dc38222bfc X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2024 05:57:39.7511 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AmJ/tmo6xZ1B17OEAUKd5K0uTK9tLTDIvvNvSOnblVG3gZImjKxs6VTp50gaHqDATzfEFHq/6p8b8R9w8Njulg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5288 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ZwCsbjhlfXYefZmhDoEhBr4kx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JrBvo+rf; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Jiewen Yao > -----Original Message----- > From: Shang, Qingyu > Sent: Monday, February 26, 2024 11:06 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen > Subject: [PATCH v4 3/3] SecurityPkg: Update ReceiveData and SendData func= tion > description >=20 > Refer to Uefi spec 2.10 section 13.14, update the parameter 'MediaId' > description for EFI_STORAGE_SECURITY_COMMAND_PROTOCOL function > ReceiveData > and SendData. >=20 > Cc: Jiewen Yao > Signed-off-by: Qingyu > --- > SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > index 0fb6b1bf41d5..1ee55105e435 100644 > --- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > +++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalPasswordPei.c > @@ -49,7 +49,9 @@ EFI_GUID mOpalDeviceLockBoxGuid =3D > OPAL_DEVICE_LOCKBOX_GUID; > function shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the callin= g context. > - @param MediaId ID of the medium to receive data = from. > + @param MediaId ID of the medium to receive data = from. If there is > no > + block IO protocol supported by th= e physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to u= se for the > execution > of the security protocol command.= A Timeout value of 0 > means that this function will wai= t indefinitely for the > @@ -148,7 +150,9 @@ SecurityReceiveData ( > shall return EFI_DEVICE_ERROR. >=20 > @param This Indicates a pointer to the callin= g context. > - @param MediaId ID of the medium to receive data = from. > + @param MediaId ID of the medium to receive data = from. If there is > no > + block IO protocol supported by th= e physical device, the > + value of MediaId is undefined. > @param Timeout The timeout, in 100ns units, to u= se for the > execution > of the security protocol command.= A Timeout value of 0 > means that this function will wai= t indefinitely for the > -- > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116091): https://edk2.groups.io/g/devel/message/116091 Mute This Topic: https://groups.io/mt/104581211/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-