Re: [PATCH] SecurityPkg: Debug trace package integration to enable debug message capture on all targets.

["Yao, Jiewen" <jiewen.yao@intel.com>]

Hey
First, please include Bugzilla link, so that we can have background.

Second, it is weird to me that you change the INF only.
I don't understand.  Is that a complete patch?


> -----Original Message-----
> From: Reji, RencyX <rencyx.reji@intel.com>
> Sent: Wednesday, December 8, 2021 8:22 PM
> To: devel@edk2.groups.io
> Cc: Reji, RencyX <rencyx.reji@intel.com>; Zhang, Qi1 <qi1.zhang@intel.com>;
> Kumar, Rahul1 <rahul1.kumar@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: [PATCH] SecurityPkg: Debug trace package integration to enable debug
> message capture on all targets.
> 
> We are introducing a new feature where we will be using a device to collect
> debug messages
> to extend capability of debug beyond current scope. We are required to extend
> capability of
> debug library by changing debug macro expression and collect debug messages
> for all target
> such as Debug, Release and Silent.
> 
> Cc: Qi Zhang <qi1.zhang@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Rency Reji <RencyX.Reji@intel.com>
> ---
>  SecurityPkg/SecurityPkg.dsc                                 | 1 +
>  SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.inf | 1 +
>  SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf                         | 1 +
>  SecurityPkg/Tcg/TcgPei/TcgPei.inf                           | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
> index 73a93c2285..0f1b3d62e9 100644
> --- a/SecurityPkg/SecurityPkg.dsc
> +++ b/SecurityPkg/SecurityPkg.dsc
> @@ -72,6 +72,7 @@
> 
> MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockM
> emoryLibNull.inf
> 
> SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBoot
> VariableLib.inf
> 
> SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisi
> onLib/SecureBootVariableProvisionLib.inf
> +  ExtDebugLib|MdePkg/Library/BaseExtDebugLib/BaseExtDebugLib.inf
> 
>  [LibraryClasses.ARM, LibraryClasses.AARCH64]
>    #
> diff --git a/SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.inf
> b/SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.inf
> index 653dc1f64f..0b8c6af3b0 100644
> --- a/SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.inf
> +++ b/SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.inf
> @@ -38,6 +38,7 @@
>  [LibraryClasses]
>    PeimEntryPoint
>    PeiServicesLib
> +  ExtDebugLib
> 
>  [Ppis]
>    gPeiLockPhysicalPresencePpiGuid                       ## PRODUCES
> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf
> b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf
> index 06c26a2904..a11cf661ab 100644
> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf
> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf
> @@ -55,6 +55,7 @@
>    ReportStatusCodeLib
>    ResetSystemLib
>    PrintLib
> +  ExtDebugLib
> 
>  [Guids]
>    gTcgEventEntryHobGuid                                                ## PRODUCES               ##
> HOB
> diff --git a/SecurityPkg/Tcg/TcgPei/TcgPei.inf
> b/SecurityPkg/Tcg/TcgPei/TcgPei.inf
> index 2e3e7e0575..90d55e7256 100644
> --- a/SecurityPkg/Tcg/TcgPei/TcgPei.inf
> +++ b/SecurityPkg/Tcg/TcgPei/TcgPei.inf
> @@ -52,6 +52,7 @@
>    ReportStatusCodeLib
>    Tpm12CommandLib
>    PerformanceLib
> +  ExtDebugLib
> 
>  [Guids]
>    gTcgEventEntryHobGuid                                               ## PRODUCES               ##
> HOB
> --
> 2.34.1.windows.1