From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.13277.1638975922556618222 for ; Wed, 08 Dec 2021 07:05:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=pTVj2psi; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: jiewen.yao@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10191"; a="301228078" X-IronPort-AV: E=Sophos;i="5.88,189,1635231600"; d="scan'208";a="301228078" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 07:05:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,189,1635231600"; d="scan'208";a="543226092" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 08 Dec 2021 07:05:21 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 8 Dec 2021 07:05:21 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 8 Dec 2021 07:05:20 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 8 Dec 2021 07:05:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I2rBIhoUhKVcAJ/Go+9LHfRGgmR2DKQzNIy5daD7Nd20drAxRX2PFHBGURNtkiGWRHrMSElbD/MBqrq3By+yr1Eo/P/CuhVCkGlw8zvgZmA7dHSHRqY1KxBT/vXCk6D1XZhJQgnjAuc2hOlvin54sNkweiq24oTSClYFlA2bEmemzu0BwRS1z9rU9B8E+/8gad/U749ZzQiboj8Ufcbu0z0k0ayltB8gtu7eIoIZolbl2qDdBnBSqSJ4Na0fe9r1ULi9iKY2cPmLwqBnp1tY0cgncOtyo1xuji3OZRvVpnLbuRzmBlu7A7ae+kg3ehTKYSr89qqFoigafOYyykAC6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Awm3ZggFZy2/SAbJX8rsKSyU4EQl9PjiKvchuUW7azM=; b=X36oKgBiYYiaTgDaoRUbGe9nNd3dfFeKz0G4rorleU8P2416hnrD9nWes7W6yOT5gG8H17QBKQbE2Gb7rkDyRzPSPq/zmCpo6QpU+T4AyrM1DgYLGzZPrzMHIByI6qZO/EK7QGon+yDJ5iuyU38+Rj2VBx5cQ8JHiEWi8MlmxABXHq4Y49NBo3yiOGdEfTqCZmSY0kdYBC8qcThq6WtgXF0jHHrmZWR9oXvILj22s521VbDi0XiihC2OZ4iaXYLiphU9x3Pn38YFYVfzCXhCnJGCZ8rQWD03/FSHqx/eggWkhWigT3o0RveABgN4wtkHMnIRaQZEy5PKOFyxAvPrnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Awm3ZggFZy2/SAbJX8rsKSyU4EQl9PjiKvchuUW7azM=; b=pTVj2psiYHSnvU51cRbXO6/4JYVvILyz4MM1zgHVbJb3Y+Tf4GrunhmSpGcdhTP0q/vnYRwexU2Q2WsfwxFQn9ZPOJL5Pf+pZGxYORusz0Sk17BGkXo6v0FiZtvyv33gwykOxBOyFhDvvh5gz00ks2taT/2dv4/HIRNeVvgiE2U= Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by MWHPR1101MB2077.namprd11.prod.outlook.com (2603:10b6:301:4d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.13; Wed, 8 Dec 2021 15:05:18 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::447f:7fbc:72f5:fbae]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::447f:7fbc:72f5:fbae%5]) with mapi id 15.20.4778.012; Wed, 8 Dec 2021 15:05:18 +0000 From: "Yao, Jiewen" To: "Reji, RencyX" , "devel@edk2.groups.io" CC: "Zhang, Qi1" , "Kumar, Rahul1" , "Wang, Jian J" Subject: Re: [PATCH] SecurityPkg: Debug trace package integration to enable debug message capture on all targets. Thread-Topic: [PATCH] SecurityPkg: Debug trace package integration to enable debug message capture on all targets. Thread-Index: AQHX7C5C2ir1iXjdL02eBwRimmZt5awosRaA Date: Wed, 8 Dec 2021 15:05:18 +0000 Message-ID: References: <20211208122203.1704-1-RencyX.Reji@intel.com> In-Reply-To: <20211208122203.1704-1-RencyX.Reji@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c8a9ef7-6aa3-4f76-752b-08d9ba5c25e6 x-ms-traffictypediagnostic: MWHPR1101MB2077:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1u6SUurDMgWmmMAMJn40evwRaHvw5rQgGMwrFtARwciPAmi00T4J+MTQlRRV9jlXluK46iQnLLGqWNWr/sq8jtoxNnFU0iaWATMN+iLnGgW1FZWkTLA2PxuWc+C7Rm0Qb4+M4TvCFubcdbFxllD4YvWpmdpJTPA8u9ZFA0yY1a3u9jo1tnkhfjh24OBxSILPotTuOtF1OP7N7K4w0kfJtkq9gkhnRmfnUfpNjFrUTc3kVwb9xPcP9apkKYzhn58qmUacy3eccb+4xswEgeMAHzeJdFbvX9pjWBCE09TP9C8wQ3V/7023zx1BCdjuOJTcvWB2vGk4iig6Nhe44LErToPbqkU4vq/H0kfzRCJcWbelhM3eFuMfbhtVNvADOhXsBXldvtZCUb12Hv/wG/kb0GWBb8E9anH+ZaCJTkqKalp9SQRM4H+jtrM+zqUE9sQZjD/Ap0IYPchfYKnTXmDZq7cTJ8rg84161vDBHdhsTI3eZdweiNwtIhcoKxN4n4E0R5NlzgSwi8ZtoD/mCRhf4ZINMnkT5C+910aP34IaL1JALHkqjF4iuG32L157Xrz9e3J35OAuqVd+lekmrC5pDP3mUCBa4brRvQU3DPxycU2H2VHoQ2XyQsitCjYYTPvoSOQj6/GJy1D/in5p3deonyggITOVXiKH8Xn//UBHV8+uYnIOU+trSDZOfgEfnjFihvl07DEXLkCwrt9Qt127tg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(8676002)(6506007)(53546011)(38070700005)(186003)(66446008)(26005)(52536014)(66476007)(38100700002)(122000001)(66556008)(64756008)(66946007)(2906002)(5660300002)(76116006)(71200400001)(9686003)(83380400001)(54906003)(55016003)(4326008)(110136005)(107886003)(15650500001)(508600001)(86362001)(19627235002)(33656002)(82960400001)(7696005)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QkuoxW1APXqPp43CrmoG5llEBeDCynHZ7E3qBnxx36KSFQZ7qPMjMLBimO/s?= =?us-ascii?Q?0g7wOVYBF4jRQlWtOYujWq2L14/bhaAoFtMQ67oKZRQT8vFB/ssSSRjQ6ytn?= =?us-ascii?Q?WEew1eczMrb4Dx2C149gSuzRxepOa3AGOidonUFWr+ewiMJ7gOCwGxjOkbol?= =?us-ascii?Q?mHZNyEstfBwAOZt3Ket4xqsWKfhhdlvtmwzlTrbP04fc1DpqM8EF4edA6fEM?= =?us-ascii?Q?nKMyj7DmDP0I62uvt37zJmbYd43dkHFjeW5fwkqW9Jmy1F5/pKy+Wz9LEe+t?= =?us-ascii?Q?fHgM1GeyFQ8fa18EMr/Xzfmlbd+pgMsvRvTyi4wsnNpr76M4Szr0XRv+G9bT?= =?us-ascii?Q?06Vn93pR96ldkddfrf/wjFuhwAxgehUstxpsOanNYtBPzfgadTEarll6p2Lm?= =?us-ascii?Q?hP/S5bMGMBiIA178EqXKs66J8Oklmmwet1E8eB0eLCEKdFdxNdQvacV8BnIV?= =?us-ascii?Q?PXe7AT5Ku2LtwDMFaRb3CgBG0Iq7GyzglfNPIfdaVmIt9TLyvkgEMALohup+?= =?us-ascii?Q?p1CwwT8iqYlSitBMnS20UN8bDClp5qELnCfLw50uZCbOUGcszx2a2P9Vfgkc?= =?us-ascii?Q?FEVCJT+3HG/L4CEfJbyFox8v9INf7Nlzrm1NoW+2DwfAOtiO9Rw6x0O2+4ln?= =?us-ascii?Q?DqOiwI2bXvnJaBPZDENY92PXLzISduhm3nuRGDKMRa8UNst4LWAZaIpGRC8U?= =?us-ascii?Q?cZgVwmDaBimtg7ZpKn7ThCo+kdi3tf774CyqLLmBcoXWvE3roxbsxPhq/Yh4?= =?us-ascii?Q?067mWHiyKqH9FjURkGvI005UZ8aeCHCcud4k90km/9rcaLbkOjXke6I07KjD?= =?us-ascii?Q?TyPxxeMI5dHDPQw+SpgLo+VqtXvUGuXGx5SdKtDwGZPArvNpJEX1tBPyEWs+?= =?us-ascii?Q?Fsd9IF4u+CBiUvOLKDRFSm+WK5Gb+gd9oXFoBmprEJo2+8kvOWWCGd6Z1D+j?= =?us-ascii?Q?BIrZVIot38jya6uYR6rlrE59xRC+3CSCgczchxwIZlJ5+RnSFkWTxPi844U3?= =?us-ascii?Q?J6X019TkDDGfFiRBP+2q/Q8glwRGS09Xi2riXjuD93ICf1Fx9uDFJ6fJAwO0?= =?us-ascii?Q?pWkvjk3tCKiYzegUBao8NNPFKCvM+1/AqIw8X4USQ4ixMF00q9/GxlwXOd4C?= =?us-ascii?Q?pSHN7gYzEuGuz4Xo0grbFavURVNdRgdqtqxo41qaAQ0HJ9XEBxFYlPiiqvB/?= =?us-ascii?Q?eVOtxM8xu0won14ET9lf04eoRwPJ0sykUNHNr618khA2J6f6c9fiCU56jcfR?= =?us-ascii?Q?TzlqKiImCoChOIaMqqtmpArDnozz/z1dGlBgZt7P9jx6lhuT6Ch4EJYMjTTO?= =?us-ascii?Q?mZPeklSVq/a458t0WKpPsi2anX7tI1IC0SFdJEzQwa4GTpSr2tRTRtcol8iD?= =?us-ascii?Q?B7CO+ohkEoZrITANGMgNFhJ8CGDWjK8HwpaTFbFjQ0njC3vya0Lna8M7eLqX?= =?us-ascii?Q?APJSaPqOyPW46wzhUUjM/gbnosVxiOKPUjJLf0mWgOBSLvEcuXfMYnyMIpie?= =?us-ascii?Q?VRtXH0WIDoOpxJlq50rn0+V2YBKiBwg+C47cJQui93i7nlTPZhT5L7Jx8a7Z?= =?us-ascii?Q?gjtjne++sMhaLGgEz5m1Xr1L2zc+5AteNNullY51J7FflDO/M7u8GWKWO6Ai?= =?us-ascii?Q?1oCiC+fel1gl7KvOfQXIkhY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c8a9ef7-6aa3-4f76-752b-08d9ba5c25e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2021 15:05:18.3858 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wtftfNRqxE4UZ2d3ZAWjwpCF3rX9b2qA2E2iNCAbE7crPQF8TKlpi+Vo0r+6+kHRXt+FuxIWsUsfQ/xLK3vM5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2077 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hey First, please include Bugzilla link, so that we can have background. Second, it is weird to me that you change the INF only. I don't understand. Is that a complete patch? > -----Original Message----- > From: Reji, RencyX > Sent: Wednesday, December 8, 2021 8:22 PM > To: devel@edk2.groups.io > Cc: Reji, RencyX ; Zhang, Qi1 ; > Kumar, Rahul1 ; Yao, Jiewen > ; Wang, Jian J > Subject: [PATCH] SecurityPkg: Debug trace package integration to enable d= ebug > message capture on all targets. >=20 > We are introducing a new feature where we will be using a device to colle= ct > debug messages > to extend capability of debug beyond current scope. We are required to ex= tend > capability of > debug library by changing debug macro expression and collect debug messag= es > for all target > such as Debug, Release and Silent. >=20 > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Jiewen Yao > Cc: Jian J Wang > Signed-off-by: Rency Reji > --- > SecurityPkg/SecurityPkg.dsc | 1 + > SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.inf | 1 + > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 + > SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 + > 4 files changed, 4 insertions(+) >=20 > diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc > index 73a93c2285..0f1b3d62e9 100644 > --- a/SecurityPkg/SecurityPkg.dsc > +++ b/SecurityPkg/SecurityPkg.dsc > @@ -72,6 +72,7 @@ >=20 > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockM > emoryLibNull.inf >=20 > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBoo= t > VariableLib.inf >=20 > SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProv= isi > onLib/SecureBootVariableProvisionLib.inf > + ExtDebugLib|MdePkg/Library/BaseExtDebugLib/BaseExtDebugLib.inf >=20 > [LibraryClasses.ARM, LibraryClasses.AARCH64] > # > diff --git a/SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.inf > b/SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.inf > index 653dc1f64f..0b8c6af3b0 100644 > --- a/SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.inf > +++ b/SecurityPkg/Tcg/PhysicalPresencePei/PhysicalPresencePei.inf > @@ -38,6 +38,7 @@ > [LibraryClasses] > PeimEntryPoint > PeiServicesLib > + ExtDebugLib >=20 > [Ppis] > gPeiLockPhysicalPresencePpiGuid ## PRODUCES > diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > index 06c26a2904..a11cf661ab 100644 > --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf > @@ -55,6 +55,7 @@ > ReportStatusCodeLib > ResetSystemLib > PrintLib > + ExtDebugLib >=20 > [Guids] > gTcgEventEntryHobGuid #= # PRODUCES ## > HOB > diff --git a/SecurityPkg/Tcg/TcgPei/TcgPei.inf > b/SecurityPkg/Tcg/TcgPei/TcgPei.inf > index 2e3e7e0575..90d55e7256 100644 > --- a/SecurityPkg/Tcg/TcgPei/TcgPei.inf > +++ b/SecurityPkg/Tcg/TcgPei/TcgPei.inf > @@ -52,6 +52,7 @@ > ReportStatusCodeLib > Tpm12CommandLib > PerformanceLib > + ExtDebugLib >=20 > [Guids] > gTcgEventEntryHobGuid ##= PRODUCES ## > HOB > -- > 2.34.1.windows.1