From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0D1E87803DF for ; Sun, 29 Oct 2023 16:25:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=SVRaUKe08xNhh0Pu2k8ZLBvxbIdaprk6vvLw2NlCgwA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698596742; v=1; b=DzjcK/7iqgxtORobM4DL7Y7sCkrXkC6Q/sm7muFeL7+fiUnD6up4WK6jKx/mkjmcQC8v9ZK4 BbZusbsgE0btkAjdhI8EfDR3NlM6/9Q6pl8xZ+s5zuraC91zfvClQQtGJ1/wZ8a9NFEXGOkqzr1 IIHsaIqItub/DJHHNn3CnU2E= X-Received: by 127.0.0.2 with SMTP id IS1aYY7687511xLJMDE2Zvde; Sun, 29 Oct 2023 09:25:42 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.75462.1698596741648592155 for ; Sun, 29 Oct 2023 09:25:42 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10878"; a="387774219" X-IronPort-AV: E=Sophos;i="6.03,261,1694761200"; d="scan'208";a="387774219" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2023 09:25:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10878"; a="760062612" X-IronPort-AV: E=Sophos;i="6.03,261,1694761200"; d="scan'208";a="760062612" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Oct 2023 09:25:39 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Sun, 29 Oct 2023 09:25:38 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Sun, 29 Oct 2023 09:25:38 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Sun, 29 Oct 2023 09:25:38 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Sun, 29 Oct 2023 09:25:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i85oRUfG6TLjtpH266a6V1AtCHgSQN8CZutsBtma83vx/PCXh0HlUvRIsZzYwXb716He1Jsv+g5pLi0p4kvrYXEKGlhR3parhNA2gcoIf2KkhihUbVctuZZvPJkQeIGbo2WXqtMhIY5vn/bbdFsIoajaLwgQSGZ0q72HSwOmSegU7NTpNzHSdi9aTRlbxOzVwxIeFBjABNfRrYWEH02bECv1BBOx9rg1T16zUNEcM8Epvczo0mb1s4Iw/kA5zunaXkaSncAPkNwG8ra6uJ7fGE2EQbQgiTPLFRQCVod4Gm3N9BroUcg7r6UtP/mgSkXdsugPvwFZu9hJmR8kpjJN2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NDXr4c11Xks112VDTTS6FO/30VlZLPHNx2yVoAJRMHQ=; b=nHTMg65rjztvQ9xesSij/lju0BU6h89J1x8nZN69zeXXrRKAn/ZkCzoSS29Y61lqX8xZn8Br/UOLKYDsIM3gArTFhbXXgbZLqzX0vxvCq/Zk2Bl0tDMCQSt3FeqqCmaCIkJ99IpCr/5S+/y8KTYp2RRe//EY09OhKMUE9HqYJGQxipM/gWQNhCrjpNTF0Zp/ahIHOMn/ez5fJLU+v7zHic2JjGfxPvzM69IEwgE6lmwlMqEMF2kg5HoIB4CKQkxafFJ/y4b/5D8OTzXhRMQg8K9oGxPHArO3wvq6UrTWInYwt4ZI3dWNjDtMPCob2/bm8Aab7f/nmZmyn84XLX4FhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BL3PR11MB5681.namprd11.prod.outlook.com (2603:10b6:208:33c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Sun, 29 Oct 2023 16:25:35 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2f2f:41ab:b556:7257]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::2f2f:41ab:b556:7257%3]) with mapi id 15.20.6907.032; Sun, 29 Oct 2023 16:25:35 +0000 From: "Yao, Jiewen" To: "jejb@linux.ibm.com" , Laszlo Ersek , "devel@edk2.groups.io" , "pedro.falcato@gmail.com" , "Kinney, Michael D" CC: Andrew Fish , Leif Lindholm , "Warkentin, Andrei" , "West, Catharine" , "Bi, Dandan" , "Daniel Schaefer" , David Woodhouse , "De, Debkumar" , "Dong, Eric" , "Jiang, Guomin" , "Wu, Hao A" , "Wang, Jian J" , "Justen, Jordan L" , Julien Grall , Peter Grehan , "Zhang, Qi1" , "Ng, Ray Han Lim" , Stefan Berger , "Hou, Wenxing" , "Lu, Xiaoyu1" Subject: Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members Thread-Topic: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members Thread-Index: AQHaCeM1LrZM/wTLG0uaCBqhn9AFpLBgCBiAgABc0PCAAGR3gIAAHeTwgAAHVwCAAAJN4A== Date: Sun, 29 Oct 2023 16:25:35 +0000 Message-ID: References: <20231028192330.1031-1-michael.d.kinney@intel.com> <99615ab9-f669-5ac8-fafd-f154e8af5da8@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|BL3PR11MB5681:EE_ x-ms-office365-filtering-correlation-id: 6bdc36dd-3afc-4fe3-1019-08dbd89bae35 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Hjxlps3SJ/z6D6w94N1QQGVCuieDONNNyTsanSgxhuar7qFFqqlk/L4Y/+N5AMyqwz93Q7VcyTFaOKpse35vFzfiHKfkdVrVKArxR59/pcP3Maa5ivWMY7ch4sjJJ/KLeAtOcALz49e06pcqmBInR7mU3UL6Rr3E7xSxIcoWulV1PyhW/cyXDmiHiKT7yOnTBT62NDFVSwONRInNLpeBu71Yv8O31Vx209VdyVqrUwAIl/hCD5zcoiwqD5zrnDHn83kdjZMMdMlLok1QceQjeh24zMeeYXe0V+jlyr94CVJCaI8g5KC42A+fq8+ZHpNRyu5yuplkJStKW3mbuSBLjrOTNvLLCAWXPdHII0Nw9eziVUaIs1pydY7lBitLNQgd6T2QJwa2GsPJnhXLCXHwXP1ubIjjxyEczsiwV06ZizGHqkjGmMU7slaQAEIAS/ifQ3Dw4axMp9JclqksZ7Pq5IF3tWuwCE1/VPG80jRe3cIAhAScBw+nmKd73/6eq/oc1yvL44jZnLn2yI0Qq8gECCfgEaCYHL5R0UraJWew93Es+v7CPujV3uTXfmNDZ+W20Wnd4KMkb69Hp5RS50NcWohp79umb9qDG9InqoswixQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ifQYgGlO4F1bRv8CoVYod5j/kkgo1jg27HpU4fAY6Neb8nDSurUSmcHVf1uj?= =?us-ascii?Q?IgaIqN4x91TjpdFcCyvbOdT2S8Nmi3o3mjJB7d0OBoEen0iaxQs/AQg+PGm+?= =?us-ascii?Q?YS/2USrPvfptDgMD1Awpx9wHNb46Wa0yO4fjkUGnrACYds7bUtqUO8HUJCIV?= =?us-ascii?Q?ZC8nUaP7eXM/hqXwm8eRKw3Tz8v53ERP3KSDlQvrKYuIpNOd6J0OwJ4w9vGq?= =?us-ascii?Q?/JZ+uwmJ43ZESpj/gUjPUfedxtdkguByqXVqpbGOQYk8T+SaKpVu27sySUTw?= =?us-ascii?Q?mmKrsyA1vQAxoVgbJtuXnW0SWMTHSJLFmG7+VZ8DhJeOGFHq0ddDduj4dEGp?= =?us-ascii?Q?5WVIVRT8Muga4FPav0/AqJhfANNJhVb/+frKEbHHrvu6eEe1k6XNtUL/wtwK?= =?us-ascii?Q?sMqfEy+6BuWSKeLBhRj5RtmToPD9hlUXITejDt/RCA97M2tri1GzJv4EyB1f?= =?us-ascii?Q?jj22jRzZ0r3pS3VPyy4PVoQj06mBWJLkYWDrCabmAmyIavl1M7+jN3qM7DG9?= =?us-ascii?Q?VwJLVfvSFdgEPBSvUZle044VrCaaNGYSsb0x2Eq96SrrecziYzn9g36wOf6c?= =?us-ascii?Q?lx+P53lvFqej097CeNizYH9BzHQ9V/rsYQtnn7IZt2P6672XRFsJ7D2eMXTc?= =?us-ascii?Q?enLVfl3WBSwfqfDe1R5qeDWl/QKk1oJyu3p2LNN/u1TYp+uEIrpM9Bz4XF5D?= =?us-ascii?Q?dTzSwv59NweXU7+fKmpgsnaOkpzALsdYXS7lOK3RdEAWcjb2/XzQ661i4SLl?= =?us-ascii?Q?8FlsnH8fJMt3XVbCHd8oRp4vr+xx7AOpiBsUDND4QaoF/mE8pDLewujj52wM?= =?us-ascii?Q?aVhIENhmChtwD06ctRLq7MxujxzhwKcvuAygKpZjufepYV5GcX2PrTXwTdqI?= =?us-ascii?Q?x55/eY80DO6k5o2eMCqkjzrA3hafox4PtG+gDbXr+H9L6nLz3sr12Bo7Sp0I?= =?us-ascii?Q?X/iClFJo471zKmyi5qAB5VgfWks21f6ylHuNJRjzaP0GqgqW9uxIaOcWxNvq?= =?us-ascii?Q?s9N8ARs0UIvC0JEczl9saEty1RYPdJzeyhItbHO1rIahDfLbh6j9DLTHyHYi?= =?us-ascii?Q?fbkbRNcUL0Nz8NeXAOMDtxFoCG8c5mfuWEXv4XNnPfgN8m3yM9RZ64qBCBTY?= =?us-ascii?Q?e/5WXFZS+GIPkdTmFosExG5PrZpfFEMFOqRlMwFg1lzaf98z6wLBS7lkdVom?= =?us-ascii?Q?Fs0kODede80nkqGlHf3u9EBq6JZ6PcKsvJETtJztCd4+CXSPVvMEn8VDKtqD?= =?us-ascii?Q?iW3/As8nMOus93J+f7zPb0FF+toU7LI/eke2RZlD6XEh/G4sfTORdXsyirz9?= =?us-ascii?Q?Kmlm9EsLIqokSbtqoi15somntKICNU2Y0kgipbNIWRqBqp4hPhrajEDqBsQW?= =?us-ascii?Q?XPzFaEYD06pezi8kMdGsRS+hRSNC8svKwrlJvJO/0JxQ2A0J5b0KbQeUWt9S?= =?us-ascii?Q?dTMIAcFCAFlsPc8Y6qhXXCgHxy8N2HbU/WbBsqEevJ0OQzJGBkZhcbDzlu3p?= =?us-ascii?Q?VlqzQsanXJiKnNW5pDkIleB1oTIyuH7YB05fzZc8IWhKxkSCZb+8T1tWZQOQ?= =?us-ascii?Q?6EEETRVCwkBlzrYe9xXBShdlh0AzLyTF0Edyq8sK?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bdc36dd-3afc-4fe3-1019-08dbd89bae35 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2023 16:25:35.6825 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z8ebdv3R96z+Cfv2D4r9HXsvf1MnNWUhBtcS+8b7MR/XlSAymJ6T+cMRbAbeINV/G54KMCrJbGmfUm9MzxcuOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB5681 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RHITX9MvMDo5bDB1iHusFBzex7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="DzjcK/7i"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io OK. Maintainer should do code review. I have no doubt on that. My confusion is about "reviewer" role. What is criteria and what is respons= ibility? Are you saying that "reviewer" just means that someone raised the hand and = said: "I want to be notified", and there is no expectation that he/she woul= d review the patch? I would like to understand more on how that works and what that means. Would you please give a URL for the reviewer definition in Linux Kernel? Thank you Yao, Jiewen > -----Original Message----- > From: James Bottomley > Sent: Monday, October 30, 2023 12:02 AM > To: Yao, Jiewen ; Laszlo Ersek ; > devel@edk2.groups.io; pedro.falcato@gmail.com; Kinney, Michael D > > Cc: Andrew Fish ; Leif Lindholm ; > Warkentin, Andrei ; West, Catharine > ; Bi, Dandan ; Daniel > Schaefer ; David Woodhouse ; > De, Debkumar ; Dong, Eric ; > Jiang, Guomin ; Wu, Hao A ; > Wang, Jian J ; Justen, Jordan L > ; Julien Grall ; Peter Grehan > ; Zhang, Qi1 ; Ng, Ray Han Lim > ; Stefan Berger ; Hou, > Wenxing ; Lu, Xiaoyu1 > Subject: Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on ac= tive > community members >=20 > On Sun, 2023-10-29 at 15:42 +0000, Yao, Jiewen wrote: > > > I'd say that's pretty close. A reviewer role is a request for > > > keeping > > > the reviewer in the loop. > > > > [Jiewen] I am disappointed on that. > > To me, that is NOT a real reviewer. See below description on what is > > "code review". > > https://google.github.io/eng-practices/review/ > > https://about.gitlab.com/topics/version-control/what-is-code-review/ >=20 > Well, that's what someone's view of what a patch review should consist > of, not what a reviewer's role in MAINTAINERS should be. >=20 > In general, you really don't want to force people to review patches, > because you'd like a reviewer to be familiar with the area and > comfortable with the patch. So are you saying that anyone listed as a > reviewer in a particular area should be capable of reviewing any patch? > and further that they should be expected to review every patch? > Because that's definitely not what the R role in the Linux Kernel would > mean. >=20 > I know that's not what happened to me in Confidential Computing, > because I had a very specific area around SEV and SEV-ES secret > injection and really had no familiarity at all with say the memory > acceptance patches. >=20 > > Our definition seems more like *a notification receiver*, instead of > > a real code reviewer. I would say, it is a very misleading > > definition. >=20 > Actually, I wouldn't, but then I'm more coming from a Linux Kernel > background. To us, the reviewer list is simply a list of people git > blame might not find who might have the expertise to review the patch > but on whom there would be no expectation that they would review the > patch. >=20 > James -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110271): https://edk2.groups.io/g/devel/message/110271 Mute This Topic: https://groups.io/mt/102245264/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-