From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: Rebecca Cran <rebecca@bsdio.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH 1/1] SecurityPkg: Add missing break in Tpm2TestParms
Date: Wed, 10 May 2023 00:13:01 +0000 [thread overview]
Message-ID: <MW4PR11MB58725EF12F5C42184F988D228C779@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230509164459.1715438-1-rebecca@bsdio.com>
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
Can we add this in 202305 stable tag?
> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Wednesday, May 10, 2023 12:45 AM
> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Wang,
> Jian J <jian.j.wang@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Subject: [PATCH 1/1] SecurityPkg: Add missing break in Tpm2TestParms
>
> Add missing break in Tpm2TestParms.
>
> Reported in https://github.com/tianocore/edk2/issues/4073
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c
> b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c
> index 9db301ec9a90..f0e6019a47be 100644
> --- a/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c
> +++ b/SecurityPkg/Library/Tpm2CommandLib/Tpm2Capability.c
> @@ -743,6 +743,7 @@ Tpm2TestParms (
> return EFI_INVALID_PARAMETER;
> }
>
> + break;
> case TPM_ALG_SYMCIPHER:
> WriteUnaligned16 ((UINT16 *)Buffer, SwapBytes16 (Parameters-
> >parameters.symDetail.algorithm));
> Buffer += sizeof (UINT16);
> --
> 2.39.2
next prev parent reply other threads:[~2023-05-10 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 16:44 [PATCH 1/1] SecurityPkg: Add missing break in Tpm2TestParms Rebecca Cran
2023-05-10 0:13 ` Yao, Jiewen [this message]
2023-05-11 1:46 ` 回复: [edk2-devel] " gaoliming
2023-05-11 3:34 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB58725EF12F5C42184F988D228C779@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox