From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"dionnaglaze@google.com" <dionnaglaze@google.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/3] MdePkg: Add TcgSp800155Event3 type info
Date: Thu, 2 May 2024 00:43:11 +0000 [thread overview]
Message-ID: <MW4PR11MB5872628F7D0957131846C7C18C182@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240501161010.372470-2-dionnaglaze@google.com>
Thanks Dionna.
Almost good, except you create a typo below:
> EFI_GUID ReferenceManifestGuid;
> - //
> + //
> // Below structure is newly added in TCG_Sp800_155_PlatformId_Event2.
With typo fix, reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
Thank you
Yao, Jiewen
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dionna Glaze
> via groups.io
> Sent: Thursday, May 2, 2024 12:10 AM
> To: devel@edk2.groups.io
> Cc: Dionna Glaze <dionnaglaze@google.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Liu,
> Zhiguang <zhiguang.liu@intel.com>
> Subject: [edk2-devel] [PATCH v2 1/3] MdePkg: Add TcgSp800155Event3 type info
>
> TCG PC Client Platform Firmware Profile 1.06 revision 52 of December
> 2023 added a new event signature and extended information about where a
> reference measurement document for the firmware can be found.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>
> Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
> ---
> .../IndustryStandard/UefiTcgPlatform.h | 40 ++++++++++++++++++-
> 1 file changed, 38 insertions(+), 2 deletions(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> index 61bd4e4667..54bdf3a339 100644
> --- a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> +++ b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> @@ -451,6 +451,7 @@ typedef struct tdTCG_PCClientTaggedEvent {
>
> #define TCG_Sp800_155_PlatformId_Event_SIGNATURE "SP800-155 Event"
> #define TCG_Sp800_155_PlatformId_Event2_SIGNATURE "SP800-155 Event2"
> +#define TCG_Sp800_155_PlatformId_Event3_SIGNATURE "SP800-155 Event3"
>
> typedef struct tdTCG_Sp800_155_PlatformId_Event2 {
> UINT8 Signature[16];
> @@ -463,7 +464,7 @@ typedef struct tdTCG_Sp800_155_PlatformId_Event2 {
> // 16-byte identifier of a given platform's static configuration of code
> //
> EFI_GUID ReferenceManifestGuid;
> - //
> + //
> // Below structure is newly added in TCG_Sp800_155_PlatformId_Event2.
> //
> // UINT8 PlatformManufacturerStrSize;
> @@ -478,9 +479,44 @@ typedef struct tdTCG_Sp800_155_PlatformId_Event2 {
> // UINT8 FirmwareManufacturerStr[FirmwareManufacturerStrSize];
> // UINT32 FirmwareManufacturerId;
> // UINT8 FirmwareVersion;
> - // UINT8 FirmwareVersion[FirmwareVersionSize]];
> + // UINT8 FirmwareVersion[FirmwareVersionSize];
> } TCG_Sp800_155_PlatformId_Event2;
>
> +typedef struct tdTCG_Sp800_155_PlatformId_Event3 {
> + UINT8 Signature[16];
> + //
> + // Where Vendor ID is an integer defined
> + // at http://www.iana.org/assignments/enterprisenumbers
> + //
> + UINT32 VendorId;
> + //
> + // 16-byte identifier of a given platform's static configuration of code
> + //
> + EFI_GUID ReferenceManifestGuid;
> + // UINT8 PlatformManufacturerStrSize;
> + // UINT8 PlatformManufacturerStr[PlatformManufacturerStrSize];
> + // UINT8 PlatformModelSize;
> + // UINT8 PlatformModel[PlatformModelSize];
> + // UINT8 PlatformVersionSize;
> + // UINT8 PlatformVersion[PlatformVersionSize];
> + // UINT8 PlatformModelSize;
> + // UINT8 PlatformModel[PlatformModelSize];
> + // UINT8 FirmwareManufacturerStrSize;
> + // UINT8 FirmwareManufacturerStr[FirmwareManufacturerStrSize];
> + // UINT32 FirmwareManufacturerId;
> + // UINT8 FirmwareVersion;
> + // UINT8 FirmwareVersion[FirmwareVersionSize];
> + //
> + // Below structure is newly added in TCG_Sp800_155_PlatformId_Event3
> + //
> + // UINT32 RimLocatorType;
> + // UINT32 RimLocatorLength;
> + // UINT8 RimLocator[RimLocatorLength];
> + // UINT32 PlatformCertLocatorType;
> + // UINT32 PlatformCertLocatorLength;
> + // UINT8 PlatformCertLocator[PlatformCertLocatorLength];
> +} TCG_Sp800_155_PlatformId_Event3;
> +
> #define TCG_EfiStartupLocalityEvent_SIGNATURE "StartupLocality"
>
> //
> --
> 2.45.0.rc0.197.gbae5840b3b-goog
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118484): https://edk2.groups.io/g/devel/message/118484
Mute This Topic: https://groups.io/mt/105845524/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-05-02 0:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 16:09 [edk2-devel] [PATCH v2 0/3] TCG_Sp800_155_PlatformId_Event3 support Dionna Glaze via groups.io
2024-05-01 16:09 ` [edk2-devel] [PATCH v2 1/3] MdePkg: Add TcgSp800155Event3 type info Dionna Glaze via groups.io
2024-05-02 0:43 ` Yao, Jiewen [this message]
2024-05-01 16:09 ` [edk2-devel] [PATCH v2 2/3] SecurityPkg: recognize sp800155Event3 event too Dionna Glaze via groups.io
2024-05-01 16:09 ` [edk2-devel] [PATCH v2 3/3] OvmfPkg: add sp800155Event3 support Dionna Glaze via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB5872628F7D0957131846C7C18C182@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox