From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id B5CDC7803CC for ; Thu, 2 May 2024 00:43:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pPA19/9/5azkTPlsw14OrJX8y4U+tSwj04VPmUA4QZ4=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714610601; v=1; b=kbzQhZ5U0mNcGkd42ZD1OYfC7tGxdN8XIyVifshLde+XbSPdiDXXkbvjkpZDGyvzb71Y7uvR dBqMhdT5Sq6EgSiKJrPASsB+R5PdQpASakgpauIaiBc8rjgj4t7aORsh3DSyEi5kBXD0x7d9YKD 2GkuGXS27Iwmdwh7x8/iKjkNhKmqo30K2gElXQ3qfw2NuZcvcNbSwMQL7IH0LrCFsOBrBpg7CzX NAsmYZJpvFfSVBT/9wm7PYl71k/Mg+BFUZvIIrHMdZz2k+Ib79846YqRi6u1hrtvt9Cn0hoOatq Oa9HRNw1K5PTPcIMuQYTM2Fi55x9JWuRTt+MHzDQhk5MQ== X-Received: by 127.0.0.2 with SMTP id r9wvYY7687511xmXHKj1bU9w; Wed, 01 May 2024 17:43:21 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mx.groups.io with SMTP id smtpd.web11.2581.1714610600516551429 for ; Wed, 01 May 2024 17:43:20 -0700 X-CSE-ConnectionGUID: qnvMK69NTQyU1CRN6l8n+Q== X-CSE-MsgGUID: GVPZD+OoQJC5GAndF7UvPA== X-IronPort-AV: E=McAfee;i="6600,9927,11061"; a="21051686" X-IronPort-AV: E=Sophos;i="6.07,246,1708416000"; d="scan'208";a="21051686" X-Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2024 17:43:20 -0700 X-CSE-ConnectionGUID: EitFVByWRHCqmzxNUo0SHg== X-CSE-MsgGUID: 89cqeK/0S3arrPBo3/Kt8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,246,1708416000"; d="scan'208";a="26959579" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 May 2024 17:43:20 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 1 May 2024 17:43:19 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 1 May 2024 17:43:19 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 1 May 2024 17:43:19 -0700 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by IA1PR11MB7728.namprd11.prod.outlook.com (2603:10b6:208:3f0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.35; Thu, 2 May 2024 00:43:11 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::be3f:5a4f:5180:2ba9%4]) with mapi id 15.20.7519.035; Thu, 2 May 2024 00:43:11 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "dionnaglaze@google.com" CC: "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" Subject: Re: [edk2-devel] [PATCH v2 1/3] MdePkg: Add TcgSp800155Event3 type info Thread-Topic: [edk2-devel] [PATCH v2 1/3] MdePkg: Add TcgSp800155Event3 type info Thread-Index: AQHam+KSv4SakQlFOUCMGxRSOKTAXLGDAWSg Date: Thu, 2 May 2024 00:43:11 +0000 Message-ID: References: <20240501161010.372470-1-dionnaglaze@google.com> <20240501161010.372470-2-dionnaglaze@google.com> In-Reply-To: <20240501161010.372470-2-dionnaglaze@google.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|IA1PR11MB7728:EE_ x-ms-office365-filtering-correlation-id: 55c2f4f2-e19e-4ca8-8f6a-08dc6a40d835 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?q08gUz5t5gT0GmluGO72+MHZEERlxtwNhJxx+kOiv9Uu+JfzZ5JUvRuq1aAh?= =?us-ascii?Q?IHv8cYwtqz5XL2aSt6N8CP7sFg1CIEUmuST9hAn2JPXKHZdxo36R+oPPwHFk?= =?us-ascii?Q?SNN+i7+fygT0Pj/QuyRZuG0uzaFekRn9HfdD9n1ffCjdjXp3x3U70Hm9r3SB?= =?us-ascii?Q?3q14Nhn2LJWPRSCTNli4hKF0VdcQtnhescsF+G7SwRJVSUfnK3FB/SWwH+J7?= =?us-ascii?Q?rJD8aFEJtpTw73Lq8Lo1BEYTMzK8+1FwTgsUFRy0ETAvvovA+wDUTw3wAZF3?= =?us-ascii?Q?HSqElQ5YuUe8oExLFcQexV4HTFps0Z1clQrv1Bsm1SAsUF+M9fFmFWGYPxoF?= =?us-ascii?Q?4Kigls7KMXUKnAaBHtqoe33lJSpArQc/bV7WacbyYIvj4ieEFxixNWMH9W9b?= =?us-ascii?Q?BM8B0QOgx6JD7trW5U8r5QcLtM8o0lGcPS2MsTSBLCFUsbsh6/k0CNTTtczR?= =?us-ascii?Q?cLgvjlRsKzjDKFCYE6am2JeOdZTGLWfQ53VbIvqibljRl9AwkanV68U0mgKm?= =?us-ascii?Q?Xghhy9Q18lC/LUDA1+is63NRVDnXIm0AY30OsgmH5R9vqlZe05Vurs0N86fb?= =?us-ascii?Q?MKq5VN+34MMDKMzAqishlibVSDj5Zs6U4giIrLzkXkFwgJIbUI+1YObWcyWx?= =?us-ascii?Q?x9TgefYg4JBpTc/O05BEwfbhK0rcHJ/jycxHsbSpmzVyxIeS6rnTPzpbhzLZ?= =?us-ascii?Q?NhuJlPfr6c9IsowUDy8q4QBV2AjJclAdsfRJKTZAPug9hL7vivIGCVSVSn80?= =?us-ascii?Q?wRlATVFElgyXbK++oiq9WwTAimsFDlOlax+qV/ojxuBB1WoThQaXQMpHYKJb?= =?us-ascii?Q?gj0OYEz485pZPrR2nJ3Pi1Gmny0/vFL4g+Fni1DOQ07BHcP9JQIpAnrnt285?= =?us-ascii?Q?nq27Kuis/b1IfL9Az5jU8+otA+rOaJRPJ4tiCPzwx4Iun/ZdQwP37DaguYyO?= =?us-ascii?Q?lJpKdAbQcLMboNW5EAgyMDe71tzClkvtYNGJ03nNxHk6ly6JWSIy9kEHmRo0?= =?us-ascii?Q?4uHBt2yWbrQhCfyzhxMqTK+Q/mERGwYYr4npUE5LHgMrKeAi+6PNIAsWeH8j?= =?us-ascii?Q?T+KqIo8sO2Cq0s6gaBDyaP3hBZ2/rreg54SsnMrQfZ6gqlMHbQDUfHBGJ+RA?= =?us-ascii?Q?ov3iFHIGI2QKfzogXFr3MFFmNFH0w0wQ8BLHZgh7i+eKuJf1lA7MoSCa/j37?= =?us-ascii?Q?Lk9c3vf51I9UPa2elLFfCG/rz/YFQc3RcptCaD3kRgm8MEUpTr/lc/lI0mJM?= =?us-ascii?Q?L5JS3c5lB0nxXSjwfqLpbZ4dRyNamNwuG+vjZbuPBjs3wUYBvNLi4uU1QvvO?= =?us-ascii?Q?iQQ=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eGeewcZ9vRn2HaelwRECP0edHF0DD64uIpfXmvdoUVYWKw1IoJNNm4TDVgeq?= =?us-ascii?Q?tpcVaqK/5yIx3UjPJDuvgrqktl5+kLIx8h2EFrO3qalGtxznPqRmGKuMLRqJ?= =?us-ascii?Q?kLhXrxGSEE9XK84EL+FOv4subpq0nPd6qYmgpuj+2HqTeLzKxP87yGHhPhXr?= =?us-ascii?Q?GwDeb/16pjMftUWiD8DG/KMSQIzIpKM7DM0XVrTwFnzUcDnTNtJ75F63jMRX?= =?us-ascii?Q?rxuAJkYyG7mE0sWmI25V4neOHUpBuWbMsrhrQ+GOnDW6wzuWwFCfUFvIspWj?= =?us-ascii?Q?n3NNB1DyPlPeJ4/7tYrSVTCHi/EnLxLuJcL/NLsdVe/w6SGIeJwBwSZCzU+R?= =?us-ascii?Q?uUTJSLZAXfn32G4xY5jodrLdpSc5yf2DpfUYENaH2kByXDhKdHbqAQ3HZ0GE?= =?us-ascii?Q?RksA717FzBVUxIm3ntBK8Sx4f4qlwI798Y3sPplknfGBAsHdBN7hS23VLEYi?= =?us-ascii?Q?WiuGeIQsDv6pgaEO63Ou07anHWDYyF21Hu6Ftvqlv7mWlSvaoJqvVhTnXaWC?= =?us-ascii?Q?9zmX6OmQpmTCUSbBSHga+ENsrOjABf3XY7jqShEfenTPvzEW5wDdd6DiFrj1?= =?us-ascii?Q?C+F2ETwd8uQvjuf5mEmFMpxpk9SZLsEQjSqL2WAYe1nMsoaeyS9cMFcyyqHy?= =?us-ascii?Q?aFgmAZYxAw/guVrGI3Ouhf773gjn43xR24RIy6rG4y4pOVYxLsFA3qOe0oHg?= =?us-ascii?Q?ksp9RXbtwVIxK/Y9W29MwvR1RA2wSe3lNudzx0Anj8rCGhxcIGPVoubGJSd2?= =?us-ascii?Q?f8UcPJUG2a189LZe/PpG21m414BfClk1w783rCApDBjIXYESQ49Ml1jrPGf6?= =?us-ascii?Q?QYohOyytKXkK6S1C4VFJdvuXzNC55dUkbssnoVgyMNt6Zit1Q7ikx/b6yTjK?= =?us-ascii?Q?jq+7FZBv/0CWmRlfspmaS9Aehi+l7scdcOUcJJ/DGTUZd1Qke8V6hrYHMLPl?= =?us-ascii?Q?o06jY/EK7iW85xAe9+OZ+/DFox5oUzZqDhhwjmiaNxXxioXCzqGTSXbTr2f/?= =?us-ascii?Q?Gb0noOhMxHd5a1N++RcE9u2vUzNLqbielJRmW3UeyX8cRLX38q4s+PY37V5W?= =?us-ascii?Q?U6JGktfkyVlQAXxPe+SNxBjvQdix4dEsPnQtQHxpH2DDWWbaciGw8qTgqqLA?= =?us-ascii?Q?ziCdap9UYcvc+WhWIhdxP5UrkSD+d89Qn8xgOiGwGAEcwNgfvGwTpRLmSKFK?= =?us-ascii?Q?VwdeNZXkhJo3wuHiVHulSfhBy8wdUqKYHWg8OeJQub5LYiXTuKDnLHEFsyrA?= =?us-ascii?Q?TDUoZ0QY33cpU8oru7Sggz+624as3vjSnUXyPRJcioU/jpDejfTn1nEeGItf?= =?us-ascii?Q?jSQWvhRYzgX3unR46tiisxXn7Tbz4npMywjQKp7BivNQF1KO3l8vQnZrLYOb?= =?us-ascii?Q?2BtucPFUXWWaF9+phD8i8RtHwOTym9/eu2mZRmV9F4/rJf25ysZ5rU9znJ7A?= =?us-ascii?Q?Fvbif1liMM4HHyT/Te17Cwew+qIdXq85EPOKcNO4kZ1yzumCwPOo5tcQjmFL?= =?us-ascii?Q?8MggytLSmRYLb43OWum5+9XTRBeNX0uMktMbXfbx+jCIf95Zxq7/ZQmr2MVT?= =?us-ascii?Q?vIbPRiisMY0jNG67Yq+4YOaInN/S/qeop2IGBc3f?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55c2f4f2-e19e-4ca8-8f6a-08dc6a40d835 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2024 00:43:11.7033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J/L7Q7iMlT7FSJQpD0IIh/MyH4s4G9Wa9CXwIsN/mLa263c4ONSbSQ9b5mOJT7uQ6z6+wR5ccxr2HA1FjUghBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7728 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 01 May 2024 17:43:20 -0700 Resent-From: jiewen.yao@intel.com Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4qfFSP9xwJPvfF8xpWzqBvR0x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=kbzQhZ5U; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks Dionna. Almost good, except you create a typo below: > EFI_GUID ReferenceManifestGuid; > - // > + // > // Below structure is newly added in TCG_Sp800_155_PlatformId_Event2. With typo fix, reviewed-by: Jiewen Yao Thank you Yao, Jiewen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Dionna Gla= ze > via groups.io > Sent: Thursday, May 2, 2024 12:10 AM > To: devel@edk2.groups.io > Cc: Dionna Glaze ; Kinney, Michael D > ; Liming Gao ; Liu, > Zhiguang > Subject: [edk2-devel] [PATCH v2 1/3] MdePkg: Add TcgSp800155Event3 type i= nfo >=20 > TCG PC Client Platform Firmware Profile 1.06 revision 52 of December > 2023 added a new event signature and extended information about where a > reference measurement document for the firmware can be found. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu >=20 > Signed-off-by: Dionna Glaze > --- > .../IndustryStandard/UefiTcgPlatform.h | 40 ++++++++++++++++++- > 1 file changed, 38 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h > b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h > index 61bd4e4667..54bdf3a339 100644 > --- a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h > +++ b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h > @@ -451,6 +451,7 @@ typedef struct tdTCG_PCClientTaggedEvent { >=20 > #define TCG_Sp800_155_PlatformId_Event_SIGNATURE "SP800-155 Event" > #define TCG_Sp800_155_PlatformId_Event2_SIGNATURE "SP800-155 Event2" > +#define TCG_Sp800_155_PlatformId_Event3_SIGNATURE "SP800-155 Event3" >=20 > typedef struct tdTCG_Sp800_155_PlatformId_Event2 { > UINT8 Signature[16]; > @@ -463,7 +464,7 @@ typedef struct tdTCG_Sp800_155_PlatformId_Event2 { > // 16-byte identifier of a given platform's static configuration of co= de > // > EFI_GUID ReferenceManifestGuid; > - // > + // > // Below structure is newly added in TCG_Sp800_155_PlatformId_Event2. > // > // UINT8 PlatformManufacturerStrSize; > @@ -478,9 +479,44 @@ typedef struct tdTCG_Sp800_155_PlatformId_Event2 { > // UINT8 FirmwareManufacturerStr[FirmwareManufacturerStr= Size]; > // UINT32 FirmwareManufacturerId; > // UINT8 FirmwareVersion; > - // UINT8 FirmwareVersion[FirmwareVersionSize]]; > + // UINT8 FirmwareVersion[FirmwareVersionSize]; > } TCG_Sp800_155_PlatformId_Event2; >=20 > +typedef struct tdTCG_Sp800_155_PlatformId_Event3 { > + UINT8 Signature[16]; > + // > + // Where Vendor ID is an integer defined > + // at http://www.iana.org/assignments/enterprisenumbers > + // > + UINT32 VendorId; > + // > + // 16-byte identifier of a given platform's static configuration of co= de > + // > + EFI_GUID ReferenceManifestGuid; > + // UINT8 PlatformManufacturerStrSize; > + // UINT8 PlatformManufacturerStr[PlatformManufacturerStr= Size]; > + // UINT8 PlatformModelSize; > + // UINT8 PlatformModel[PlatformModelSize]; > + // UINT8 PlatformVersionSize; > + // UINT8 PlatformVersion[PlatformVersionSize]; > + // UINT8 PlatformModelSize; > + // UINT8 PlatformModel[PlatformModelSize]; > + // UINT8 FirmwareManufacturerStrSize; > + // UINT8 FirmwareManufacturerStr[FirmwareManufacturerStr= Size]; > + // UINT32 FirmwareManufacturerId; > + // UINT8 FirmwareVersion; > + // UINT8 FirmwareVersion[FirmwareVersionSize]; > + // > + // Below structure is newly added in TCG_Sp800_155_PlatformId_Event3 > + // > + // UINT32 RimLocatorType; > + // UINT32 RimLocatorLength; > + // UINT8 RimLocator[RimLocatorLength]; > + // UINT32 PlatformCertLocatorType; > + // UINT32 PlatformCertLocatorLength; > + // UINT8 PlatformCertLocator[PlatformCertLocatorLength]; > +} TCG_Sp800_155_PlatformId_Event3; > + > #define TCG_EfiStartupLocalityEvent_SIGNATURE "StartupLocality" >=20 > // > -- > 2.45.0.rc0.197.gbae5840b3b-goog >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118484): https://edk2.groups.io/g/devel/message/118484 Mute This Topic: https://groups.io/mt/105845524/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-