From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.3621.1674000942506712064 for ; Tue, 17 Jan 2023 16:15:48 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=D//asRLt; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674000948; x=1705536948; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xlBCc4tgOnlkVTHJYP8yG4F5yDADnR2hDntme9Rixys=; b=D//asRLtfsLiFPSOfSQcttN8QlNywUrsMmGMlSOImgw0ODgNoaECcqCI 580GPozspsc8FScl4sWkqo0reLUcryMm9riSZNpOXKiBSVvqgKf30lj9F CkdADsOnQ0+zhfYP6C2cmOqB5CVFrHNueiV5eQyfeCA3rXL7GOjbrYVA2 GASmfXdXRSS35dwhisVJoB5pEwl4FtIEO5yBvOixBlHQmyf1lATj/rCG+ 8MHFJFAm0Gz1dnuWCrwmIwY8VzlXrzzR6SGl3S7qHBR82cDXqTfidyiYw Q2QcsoSupSqP13NqoxXjq+/rFkSJPdzvpPQK2VIzQtqTqFGlTXecRnES4 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="389359248" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="389359248" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 16:15:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="833349989" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="833349989" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 17 Jan 2023 16:15:42 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 17 Jan 2023 16:15:39 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 17 Jan 2023 16:15:39 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 17 Jan 2023 16:15:39 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 17 Jan 2023 16:15:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nAp5YSFGU2aSwdJJuEbXPr487ExhxdHqCkmcxt6HqaLKSPcCz5KUKdCVKTaI3p0ZSP/0JzVJqgv5jGlKKgpa/ZqBTc079XPs7vsoxtE2cc1O7/yPy0WWMcyaWHmtMnVpHzweaDJ6Ft/IY1AWRPJK9ImgBzAS1oLMHfRwcl3z3XWvOaF6+5rl7nV/TKiqZrNEOKs9gATwajP5H+GdeyHBbcIsfMvGUwkxXTS68qhVKaVQp8ubVsVqotYJ4CQD3y0rmCPb+2ifmI/IbxeAGAmqZeJk0i7cIK0R/JWm2b6fqjgCtZTC189ypw1ZZykQST2dSIxROE8HsqW9+R5HA6+VzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AWw+24R29Yg/i6+MUtntszjl5MH4BBfwrGgTGT51rnk=; b=WMibAIFrkPB9vL/XRJjp2qo4uFdBPpdTK8LgxcOSQnaHrLt25+gxcdVooToRIqgCBXcUaHOwbmq+YENOTcS362Y9oWHllkal98RJS1PKJ++fPTBiRl5MDTLFP/N+2Db/0WJsph/d1hSgeGbKbVJZFMJ9q5N0T5Ub/BOe7YEopW4fSPa5+vZW0417t6gGPec/0Iji595QdEGyC6gzIeQTPfTQnb9WKW5KRPs+tUdUFeYtMrEaH06Sc+hOn1B1AdzYfkONhLh5WzLpNnDZf8DmSYdBdC/3Ob04vqT/rb5TLpiMayXTLVSv+0bLcnPo8damHvCMuqcoRzoUs0RYvgQS8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BL3PR11MB6313.namprd11.prod.outlook.com (2603:10b6:208:3b0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 18 Jan 2023 00:15:27 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%7]) with mapi id 15.20.6002.013; Wed, 18 Jan 2023 00:15:27 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to PCR[1] Thread-Topic: [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to PCR[1] Thread-Index: AQHZKs7xJtpZ6d6g0k+jZM5GgVTjhK6jTjcA Date: Wed, 18 Jan 2023 00:15:26 +0000 Message-ID: References: <20230117235326.600-1-min.m.xu@intel.com> In-Reply-To: <20230117235326.600-1-min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|BL3PR11MB6313:EE_ x-ms-office365-filtering-correlation-id: c9b03eb1-83c4-456e-ed4f-08daf8e919cc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Zdkk2dohbnra5OI/rltKBjOvrV3n7IX2qyvrzYDCPRupLAnjy6zQgzFTsR7vsCNai8jfMPe5It4gBgcqvhsDpc69vR5saeK+iUSjUb9V/iS7XtJ6pNW59D2nY6S6px8XPDKM+u9ymBr9KgNvDVd1KHZkmR4PdnjGs+3LA8QkQfG49YXu2srrWyr8bs3lHhlQqLC9UcIwOehfQoBh+TnKNhn0D3mTKFY09EuQV5T0aLKA6/lIG+7oaqPDF86mDZv6L1YgWvHIwK8y/bymeVZAAuCuvSgcvu3/AAc5Z5kx2RKd2UVWi0J6Ypw5BWcURVIsI5cD/i3e/mOe7Bc/PBa/MCL/EkLIfA8Wz7nesaRku3Nk9XUadb0D5ErfrS5Q3s3cwbf1qYqzYaR2yxxkwAYqPTYMphDbb1HAjQqk+bOfp2UufhoCVuDQCw+Eovzlll6fYPAzyLioWETKs/NFerJPbYIdCBuUzHllAL+SWMjznmdZLxGTkOvd0/0flj0256iRhwPdlimGYTHLP8XJLtuidDADkbyanc8+igNYm+TN5VL/0qhbvpNCkFWsjsvtG34xQrFtEoCb2a5ucLaaWAtuHkZti1l6uOxXExXsGS8BlSb2j6nSAWCvRz7CdB/WZUgXRW0FkN/jiEKprmLTWcku2STdWVn2CebCKWE2jChBJeeC2FQklZ1pt7vwFv1SsX/wHetgodedf8n1aAggw9NEvg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(346002)(366004)(39860400002)(376002)(396003)(136003)(451199015)(26005)(186003)(6506007)(478600001)(9686003)(107886003)(7696005)(71200400001)(33656002)(66946007)(76116006)(66476007)(122000001)(316002)(64756008)(19627235002)(8676002)(4326008)(66446008)(110136005)(41300700001)(83380400001)(8936002)(52536014)(55016003)(2906002)(66556008)(15650500001)(38100700002)(38070700005)(5660300002)(53546011)(86362001)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RbjtOt3NJ80zeo/LIhwyAWKzMRUlNRuWyzCdqEYeWQiO6jeRcKKa4vN2080W?= =?us-ascii?Q?SQs0x+YV5n47klW1K/53ihd5Zab6+adGDumL9ENbwx7tmQtN6PshcqO8i0SP?= =?us-ascii?Q?dX5giXxnDuTxS7FkpdhtwDV/LKaiP2u9gaAoFQIP1W7znhzfKZonr6rN0B3v?= =?us-ascii?Q?Mvyqw5b2GOhAjMwLMPSWzakPEmgPYgq2vIVqJ2fZnXPyoIjAIeKIKCG5KUAi?= =?us-ascii?Q?pJ1mVfX0E6u9rdNMOHD32eoXs6Gi6ss9QPCfGxCU6AJZ2s8eLey5Vdrh5usX?= =?us-ascii?Q?0EpOK+IWVqLY06hZHXOe2GA23ubORDI95alLOR6pVcke6+Nj2VAd+YiTZkvN?= =?us-ascii?Q?9Emjf4jBnKXvPtfazCDVpBzSGWaxKVwMjoYCOqRrmv50QaWNyQ8ZkiV8/i1I?= =?us-ascii?Q?UL7ITKL2kK8OAp6hBlBIDDFNb2f/gr9pJ2ogqgabF/gev7jzmKtODFxBHNwT?= =?us-ascii?Q?t6ze1HA5cfvBa8OiEE5ysM4oC8j7oNAFx/22TbK0RY5awhy6pyvXmXkMSsgN?= =?us-ascii?Q?pwywDJ+hOjlrrz/qleNRvIpFAAEsKdkGbjL8dueG/lrAEc8ue4IXl5tblj8b?= =?us-ascii?Q?2HeumEJ8KpnAZaBqfHkoUKnOBNaATUbRUvMIe1OqOYECekkzQoZyG9mb+CYZ?= =?us-ascii?Q?mmPjOOUXJTjd2rUjtfHyutSYPQ0YYy41iEYUWt2u21bFHcrwnu0Y43P393nW?= =?us-ascii?Q?EDPVWlqcTprKsESY0FfTpjIjQRvhV2VvtecR4HJejBXQ0oGaTuCpVku4f53C?= =?us-ascii?Q?wYme5blA3H5hApOWZnTkdmZQt91ZzPx593ffeKoY5fDyH9WsG3xE8sO2UVZD?= =?us-ascii?Q?fOTc7N3JrGdxHDhrNO5qrhJLvaLYrr71jVDB6m4rJilAbgbCWsXDfN1QJvq2?= =?us-ascii?Q?U54o1uiyfaBSvS8DJnhgbzzmVf6V96hCRmomBa/I9aPz5CPBCFfw7asfIkl/?= =?us-ascii?Q?6KI4lygKzBuA7E5dHbU3z0DfeYvk+8rvFzGiIfpMKF/fOgqXgQJ52fcX6Oth?= =?us-ascii?Q?iUdv6IgAZHG6q9UBmeGcdScFx7iyhGDcCWg+IEyE7tsx9suIB9Jh8YCdvoMd?= =?us-ascii?Q?7fDFGf1EIDoAcbcXzVr2dfNvNXWHIq2GUg9qwyzTxhKUDIxZQ4AZExsm0mOx?= =?us-ascii?Q?2+Qi73PGfzTGkJ7DRN3i+4JE7VOmbACnVh7LslmBUkebzrRzzXlx+cuNDwzp?= =?us-ascii?Q?nQgJQZQyrf3kWPdeFaPcnh8pjCxG2sbd1yPf1tBAOas6pCqS3ng6+u+bHbXE?= =?us-ascii?Q?n8Y4lD3X3a3/UbdDfR6/H1VEM0uqBbOuJ6jv5GRL1vShF4XkezurBCBlnmE3?= =?us-ascii?Q?WL/3/Ic7hPJDEiVUVzY74+0NmrPRRj1Jg44BicuhkAxwMTIm4vk8xHTsw8lx?= =?us-ascii?Q?F6z1NMs4uc1yLVWUGDORAdnya/c0K71/49NF206kp2RwJ05LbUhUu4N7g8cf?= =?us-ascii?Q?TNtz0Vc/iD0CdcLDGTi+T0bzQUHqQP5Uz3isQ1M/Zcq7QFEkckJ8tAEqK6ka?= =?us-ascii?Q?HeS/ul1gQ79LasZGtmKrgWG6bsvzqemUXHfZy9llPYN1FaF7vZpV/YdYoa+U?= =?us-ascii?Q?UWrc1O1HQ5LxagXW1pxKCOvuOqxAMc6X4NvaTbUR?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9b03eb1-83c4-456e-ed4f-08daf8e919cc X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2023 00:15:26.9962 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eMQ4fJiplNgw6UrUXnUVlbcLM3qg5zNSUXneEABXujN5meLrI7qCCIszy9f9ZaBVeBYMp2tmSm9cupGvimX0wQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6313 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Xu, Min M > Sent: Wednesday, January 18, 2023 7:53 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Yao, Jiewen ; > Wang, Jian J > Subject: [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI boot variable t= o > PCR[1] >=20 > From: Min M Xu >=20 > According to TCG PC Client PFP spec 0021 Section 2.4.4.2 EFI boot variabl= e > should be measured and extended to PCR[1], not PCR[5]. This patch is > proposed to fix this error. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Reviewed-by: Jiewen Yao > Signed-off-by: Min Xu > --- > SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) >=20 > diff --git a/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c > b/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c > index d19923b0c682..59341a8c0250 100644 > --- a/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c > +++ b/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c > @@ -1873,12 +1873,8 @@ ReadAndMeasureBootVariable ( > OUT VOID **VarData > ) > { > - // > - // Boot variables are measured into (PCR[5]) RTMR[1], > - // details in section 8.1 of TDVF design guide. > - // > return ReadAndMeasureVariable ( > - MapPcrToMrIndex (5), > + MapPcrToMrIndex (1), > EV_EFI_VARIABLE_BOOT, > VarName, > VendorGuid, > -- > 2.29.2.windows.2