From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zhang, Qi1" <qi1.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>
Subject: Re: [PATCH V3 0/4] CryptoPkg: add more X509 functions.
Date: Wed, 12 Oct 2022 06:43:27 +0000 [thread overview]
Message-ID: <MW4PR11MB587269795F75F4A6653330B28C229@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <cover.1665549018.git.qi1.zhang@intel.com>
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
Merged https://github.com/tianocore/edk2/pull/3470
> -----Original Message-----
> From: Zhang, Qi1 <qi1.zhang@intel.com>
> Sent: Wednesday, October 12, 2022 12:36 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Qi1 <qi1.zhang@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1
> <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
> Subject: [PATCH V3 0/4] CryptoPkg: add more X509 functions.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4082
>
> This patch serial is to add more CryptoX509 functions.
>
> Tested by:
> 1. https://github.com/tianocore/edk2-staging/tree/DeviceSecurity.
> 2. Unit test: CryptoPkg/Test/UnitTest/Library/BaseCryptLib/X509Tests.c
>
> Review PR: https://github.com/tianocore/edk2/pull/3464.
>
> V2 change: rename X509SetDateTime() to X509FormatDateTime().
> V3 change: rebase this patch serial with the patch serial
> "CryptoPkg: Add EC key retrieving and signature interface."
> So the merge order is Ec -> X509.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyu1.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Qi Zhang <qi1.zhang@intel.com>
>
> Qi Zhang (4):
> CryptoPkg: add new X509 function definition.
> CryptoPkg: add new X509 function.
> CryptoPkg: add new X509 function to Crypto Service.
> CryptoPkg: add Unit Test for X509 new function.
>
> CryptoPkg/Driver/Crypto.c | 432 ++++++-
> CryptoPkg/Include/Library/BaseCryptLib.h | 374 ++++++
> .../Pcd/PcdCryptoServiceFamilyEnable.h | 34 +-
> CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 1036
> +++++++++++++++++
> .../Library/BaseCryptLib/Pk/CryptX509Null.c | 429 +++++++
> .../BaseCryptLibNull/Pk/CryptX509Null.c | 429 +++++++
> .../BaseCryptLibOnProtocolPpi/CryptLib.c | 415 +++++++
> CryptoPkg/Private/Protocol/Crypto.h | 392 ++++++-
> .../BaseCryptLib/BaseCryptLibUnitTests.c | 1 +
> .../Library/BaseCryptLib/TestBaseCryptLib.h | 4 +
> .../BaseCryptLib/TestBaseCryptLibHost.inf | 1 +
> .../BaseCryptLib/TestBaseCryptLibShell.inf | 1 +
> .../UnitTest/Library/BaseCryptLib/X509Tests.c | 631 ++++++++++
> 13 files changed, 4167 insertions(+), 12 deletions(-)
> create mode 100644
> CryptoPkg/Test/UnitTest/Library/BaseCryptLib/X509Tests.c
>
> --
> 2.26.2.windows.1
prev parent reply other threads:[~2022-10-12 6:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 4:35 [PATCH V3 0/4] CryptoPkg: add more X509 functions Qi Zhang
2022-10-12 4:35 ` [PATCH V3 1/4] CryptoPkg: add new X509 function definition Qi Zhang
2022-10-12 4:35 ` [PATCH V3 2/4] CryptoPkg: add new X509 function Qi Zhang
2022-10-12 4:36 ` [PATCH V3 3/4] CryptoPkg: add new X509 function to Crypto Service Qi Zhang
2022-10-12 4:36 ` [PATCH V3 4/4] CryptoPkg: add Unit Test for X509 new function Qi Zhang
2022-10-12 6:43 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB587269795F75F4A6653330B28C229@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox