From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.17322.1665557018990172829 for ; Tue, 11 Oct 2022 23:43:39 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QU/5naVx; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665557019; x=1697093019; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hIS4jE+zUnKb0NR4fMfVL6037xpKoJAPzg7LWBJuTHE=; b=QU/5naVxOJpzhurvMFB0uyYRTyXm53J4HaZtIG/EJ3MFEpoFbfcELwN2 WfXRk0LM7M5yQNZY4tc4MhsgDzQ0jUMnVzlWg9MDgqEUiB/eeR0I1+Toy AAAXJ8HppffyH0vB0yOa/KsEYBNcnlBWtaklZqTS41KkCeKLbMX0ijH4H hLFpcL2wc1F7VhiOlR3hrZhfl7wg5Uc9tGq9AzzOlro6/E7itBikQRlbC LC2J6ktKXtrkd9kCMlUrs9lLOE3vxmK9ZAU2nWoMdIk2vWpgtAWeBspSf msHYYOVVlOnKsUT0HbIGMQQcNZUf4Oxo7p0D3/0jU+zgJRQ40jmBLxxeS w==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="306342747" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="306342747" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 23:43:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="604437911" X-IronPort-AV: E=Sophos;i="5.95,178,1661842800"; d="scan'208";a="604437911" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 11 Oct 2022 23:43:30 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 23:43:29 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 23:43:29 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 11 Oct 2022 23:43:29 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 11 Oct 2022 23:43:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kvlwBAuEWxRpHVoHHKEMIdeoBa408ZaOKvBVzVhtKBRnSXGjjz6CAXq4jTEVywKtSxhLdytgGw3rXp91Wd6ypIPFikAj9Dak3ZDvRXGb3+qsMSb7pRQMlV869PsCJ1lnhKBrP6EfHj/YpQqWn5RDi1ctPzi7Dld3AjfhL8MmKn2tV8xNEjVcwIyuQswTBRwS/HFKwLIh2ketoRJ8oRVFkror60WGoBOJAZ223IbZLb71VfgxnmgoZnG8vfvnmPuxNoSYEW6+aKlbqcJTWxJoX0U+YH0SL96FJSkQv6eNKt+NusUcc2W2qJSDj5nxdJQdGyEcxZRCY36WlslXORM2KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YmDlRWd+MXYGasZrNAtjPnxHxFjXgR+dVWwe6zexwck=; b=dh8Sa4XFVKVrust5fuYYpXSfsOK8XoIIL6hKRfJvE8GX8XxYI5+R6NKMyBN3Z/WmVrwPiAsmJNv2YwY7AxzhoNQhDNOTza8crUzTTQknN5YliyeX7G3z3Wek823oNIBRN1mKrZssPNG2hEjJ/f4Yf7YqxKcx+KYANAjeXYtjXaqsq5tPcP73ZCh2zsz3/Z+VqZH7UuDGU2SObY4vK9f1sZr3Jk5nqc3KiOi23F6+erQbrgjIAty+lACrAOKAOVLBG0lNUApDjFCGzB6mUnXv/Jpd+HvS2CkqtmTXkY49kWB2WV5mGHoABj2jB5+kilI08s+v4fafSbQJ6Pqb2kXZhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by PH7PR11MB7097.namprd11.prod.outlook.com (2603:10b6:510:20c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Wed, 12 Oct 2022 06:43:27 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::76b0:750c:a322:5acf]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::76b0:750c:a322:5acf%6]) with mapi id 15.20.5709.015; Wed, 12 Oct 2022 06:43:27 +0000 From: "Yao, Jiewen" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" Subject: Re: [PATCH V3 0/4] CryptoPkg: add more X509 functions. Thread-Topic: [PATCH V3 0/4] CryptoPkg: add more X509 functions. Thread-Index: AQHY3fQtyc2zEN1/UkKMiseL15Lb264KT8hg Date: Wed, 12 Oct 2022 06:43:27 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|PH7PR11MB7097:EE_ x-ms-office365-filtering-correlation-id: 1e75d144-eb6d-403a-2fa2-08daac1d116a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d2o3RhHcsxWFlp+AUvqpkhPRCT4sX0a64CXqEayuX/cki2UGzd6yiCqJ42S3nYa9SqNb/ak9RTY9WigJ96xQ83bW1zwwYWKn8M5E7NOJ542VZ08wK2GNPKg7LSr9h8K6l1zUs5bg894SWV1W74DLgzxFMT7SZeUJ5kJ2m6G/5A+oiFUBOeS4fQOToIiN62huNuN8M54pDQuFMRE69AUmng3weCbjTnLuzafaF7EHTeHQnrrk29VFZxedw0mW7BQ/+/LCBkHfveicVZbIw7UEH/0CWQUjdSoerFKm6oO+1+AWTo9CSQ2zLNhgiBEA7uQ10kqwdIlOKo4JFvGEz6y98O6odkxkbrLSpUnlkIi/lpi54HfNeJpvF4fs9r5oLQhwzenogGIBb3ZxL4nwvV9o5AXoMnjSPcOR9ll7IgVhb7qaUgXC3bJovBcxavNvvuBwz9bRvQagLIhEzkIDiUJjdnnS0Jd/v5T7P8aFmO80eFkDQsVabN1nEl0SogTp3pH+ga8V/MkOBn1BnTbKoRTFQSqGjEZ7uT30oqwkpjvW7Jims9tj9/98OoXqdrB4cZmC3oekkR2XHlYFA+LZoFVpwdawVu+NNyXsuOcHRARqnUyGKsZzBqTskPuFGgNTVEhujOMVfviwsN5IqTqr7J4mwG4G/XiSbU8ayf/WBQH0BOAwqBTZi9pIH2OeUTqkC5wZ/dDzla4Nnixxhh2Pk29E44/MrLFJQmfMFMRAcTNc9zZKMYHW66GKRmZRp8Nbefv4ZBqojEp7DZZFkJK9gfjm6gSxL+2VtyuliDMHq9rbeNOuT4u9X9e/sOND5qMoPvl1rnRXtv4+BYvEj3yRfKjdCQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(376002)(39860400002)(346002)(136003)(396003)(451199015)(110136005)(33656002)(86362001)(122000001)(26005)(38070700005)(186003)(38100700002)(2906002)(83380400001)(82960400001)(316002)(107886003)(66446008)(53546011)(19627235002)(5660300002)(4326008)(52536014)(6506007)(7696005)(71200400001)(54906003)(64756008)(76116006)(9686003)(66556008)(8936002)(41300700001)(478600001)(55016003)(66946007)(8676002)(66476007)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?E/G3rxBTzj7lNagGpzopOapqsEIHT8TdFS1DQehaLd3IdSWwB8mvU/axup7e?= =?us-ascii?Q?ezUybOTSa0w+1RqHcF02ZkW+K4MjQYypwCLQ5m2Bzqm2GUzlo/VBpBwpf1EU?= =?us-ascii?Q?cKNSs0lt0hoFrhTqKPNeVfu7ZLv3XQk5t+sBj2L9EFLCmG/fvKra6d4p/e7j?= =?us-ascii?Q?FqW1So5G5snk3FZeTP1lorynmB61o7UMT8RWgDOW1dCGAu/gykf7Z7+UvEC4?= =?us-ascii?Q?EkJeGP3GoUJhjwU1Z8pdtoO+fP41Zrub7QD17FRRqK5N/LlUJaenJgyF6HFD?= =?us-ascii?Q?Hea1ofBKidkB1mjFNCJy41fOwATyk3zjxqUraHcX4Ejtf/a11JIdE3YktmTB?= =?us-ascii?Q?3I0Uvmg6inHGjAWVk0WbfmiG3ChnfZZ2eYqFlrwLXDx2UAi3pwMyFsREfUEA?= =?us-ascii?Q?8EkHd/Xfzn/wanZyJv8gMikVdOQjVpdAtNq3O4exe15zkOZCBhp00EXWOy7w?= =?us-ascii?Q?v0ilmOyaLXA5YmjJiic/hojNtJ8iLdLL+900RDGrz0H1N2nRLBBwyrRyMGVm?= =?us-ascii?Q?BptGn/Mi51RuOiCI9/X2yPI6hYGJTN1RHIPIg2SYLF9HUGsMNybICzdUnHyd?= =?us-ascii?Q?aAZ43Ic73SiFksEaw3bcRgyfrEs2XGWfAIP9ptu1YXkJitDA++2Qlji1K3Ys?= =?us-ascii?Q?jFZCI5JA58Q3xc46OQrEyqeroB0t25WCa9TZP1o2b2bsc7A7X9VVOksGPN3p?= =?us-ascii?Q?6KK63r6hf/cmRKp6SgczjPJ4HfCdV8w8GDx40r7GdutxTLWulf8DXviwEcno?= =?us-ascii?Q?3kNu0AHw5oHRu6yMXxf5YpMByBU0TIna8gFwiB7kB2nQkuPn8ikeOy/8XwDP?= =?us-ascii?Q?oprt3arc5x6B7qflgnKpDSe1Xkt3KwdquoDAE5xqVkwn+vTS9SLr7oJlhT6f?= =?us-ascii?Q?ARSExNn2ULDb2nbxPv+w0WT/E/wLUBtVL4K2PfrBqpgBg6yDQREn8T9cmBDc?= =?us-ascii?Q?lH1Lz6EMheNPAJpMoQFftVIgRAUygHqzsIQ+pRuOilzXbXtzikb9aMohEsJB?= =?us-ascii?Q?izdqEWhCK29oI4Dxt4wii+2ewJjSJdPz4ScGPp1YE0/hq56iquw7GePesmnX?= =?us-ascii?Q?LjDv5piOlv6hu9EAL7fSvURnICNHzi0O6NmV3fnl4LX0fcarUkUUsPDZnyze?= =?us-ascii?Q?d89D5pKSrsYvtWvjzv6nQr/rrEDWl5+ftm/o0/+SfbYgHSwoNHJIHUhZ6pVz?= =?us-ascii?Q?+xr1vcabvjeryvGDP/wTMwrRn0oiHiRvJNjWC//OlxIHj2gd3Oiw9v1PfgGH?= =?us-ascii?Q?SVlCvwp7o2/hOlh3rrYfVlMicsNMdTcvUCWblmQ50THtRAizTvO+b1cbxK+D?= =?us-ascii?Q?bH2Bvr57RPqYlwMIz0SEc2cCjQRBxl7vUNmAYvEpDU79YkiqfHkSWQ+16WDV?= =?us-ascii?Q?38R29xn481TKRyD/ZdXBq3AN99DJ6HnlMDJwrps0nIAesfO5/66jNHIu+6oo?= =?us-ascii?Q?CZRV0JCnOmvXdiFNAOnlxjPKe5AbeiqYyXRQ9oGAjlXwMZVloav/KewovkRP?= =?us-ascii?Q?hPpw7y3dTWclhnuK3jw6fZKp0vE+aBBdtN+acemFZk1aYw9J78rLqw+dYAPo?= =?us-ascii?Q?nFLViOoQZ0eBPxsep+KkFsNVA8w6jEr66ksrlcjv?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e75d144-eb6d-403a-2fa2-08daac1d116a X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 06:43:27.2391 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /jvpc5Aro1VOVHX9BkVxL0sasvL6PpR2iDsx+bhUgKT6rkgSngqtOn/ki06msrilaCpLXfpsDUTxAHg5mexbKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7097 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao Merged https://github.com/tianocore/edk2/pull/3470 > -----Original Message----- > From: Zhang, Qi1 > Sent: Wednesday, October 12, 2022 12:36 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen > ; Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin > Subject: [PATCH V3 0/4] CryptoPkg: add more X509 functions. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4082 >=20 > This patch serial is to add more CryptoX509 functions. >=20 > Tested by: > 1. https://github.com/tianocore/edk2-staging/tree/DeviceSecurity. > 2. Unit test: CryptoPkg/Test/UnitTest/Library/BaseCryptLib/X509Tests.c >=20 > Review PR: https://github.com/tianocore/edk2/pull/3464. >=20 > V2 change: rename X509SetDateTime() to X509FormatDateTime(). > V3 change: rebase this patch serial with the patch serial > "CryptoPkg: Add EC key retrieving and signature interface." > So the merge order is Ec -> X509. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Signed-off-by: Qi Zhang >=20 > Qi Zhang (4): > CryptoPkg: add new X509 function definition. > CryptoPkg: add new X509 function. > CryptoPkg: add new X509 function to Crypto Service. > CryptoPkg: add Unit Test for X509 new function. >=20 > CryptoPkg/Driver/Crypto.c | 432 ++++++- > CryptoPkg/Include/Library/BaseCryptLib.h | 374 ++++++ > .../Pcd/PcdCryptoServiceFamilyEnable.h | 34 +- > CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 1036 > +++++++++++++++++ > .../Library/BaseCryptLib/Pk/CryptX509Null.c | 429 +++++++ > .../BaseCryptLibNull/Pk/CryptX509Null.c | 429 +++++++ > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 415 +++++++ > CryptoPkg/Private/Protocol/Crypto.h | 392 ++++++- > .../BaseCryptLib/BaseCryptLibUnitTests.c | 1 + > .../Library/BaseCryptLib/TestBaseCryptLib.h | 4 + > .../BaseCryptLib/TestBaseCryptLibHost.inf | 1 + > .../BaseCryptLib/TestBaseCryptLibShell.inf | 1 + > .../UnitTest/Library/BaseCryptLib/X509Tests.c | 631 ++++++++++ > 13 files changed, 4167 insertions(+), 12 deletions(-) > create mode 100644 > CryptoPkg/Test/UnitTest/Library/BaseCryptLib/X509Tests.c >=20 > -- > 2.26.2.windows.1