public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"kraxel@redhat.com" <kraxel@redhat.com>,
	"Li, Yi1" <yi1.li@intel.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
	"Lu, Xiaoyu1" <xiaoyu1.lu@intel.com>,
	"Jiang, Guomin" <guomin.jiang@intel.com>
Subject: Re: [edk2-devel] [PATCH] CryptoPkg: Add b_print.c which removed floating-point to OpensslLib
Date: Mon, 21 Nov 2022 13:18:45 +0000	[thread overview]
Message-ID: <MW4PR11MB58726A202A2161890682D41B8C0A9@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221121092153.p4umhcaptgoxf3ra@sirius.home.kraxel.org>

Right. Size is the biggest concern, because some platforms already have limited space based on our internal survey. If we migrate to openssl3 directly, then we have no way to build these platforms.

One idea of size optimization is to use MACRO to disable some features in openssl, if they are not needed by UEFI.
It could be the MACRO already defined by openssl, or we may add new MACRO to make it smaller.

Thank you
Yao, Jiewen

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd
> Hoffmann
> Sent: Monday, November 21, 2022 5:22 PM
> To: devel@edk2.groups.io; Li, Yi1 <yi1.li@intel.com>
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, Xiaoyu1
> <xiaoyu1.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>
> Subject: Re: [edk2-devel] [PATCH] CryptoPkg: Add b_print.c which removed
> floating-point to OpensslLib
> 
> On Mon, Nov 21, 2022 at 08:31:19AM +0000, Li, Yi wrote:
> > Hi Gerd,
> >
> > Cool! I noticed your patch in openssl3.0 branch.
> > Because the Tls cert time check needs to be solved as soon as possible,
> > I will cherry-pick your patch to 1.1.1 branch instead of updating edk2
> openssl to 3.0. The latter seems to take a long time.
> >
> > By the way, I remember you are already working on upstream openssl3.0,
> right?
> 
> Tried, yes (that's why it is fixed already in upstream openssl3).
> 
> > How is it doing now, I can help with some work if needed.
> 
> The blocker is that openssl 3 noticeable larger than the 1.1.1 version.
> Which is according to Jiewen Yao not acceptable because it wouldn't
> fit into the flash layout for existing roms.
> 
> I don't have any good idea how to move forward with this.  My old WIP
> branch is here:
> 
> https://github.com/kraxel/edk2/commits/archive/openssl3-v1
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 


      reply	other threads:[~2022-11-21 13:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19 16:27 [PATCH] CryptoPkg: Add b_print.c which removed floating-point to OpensslLib Li, Yi
2022-11-19 16:32 ` Li, Yi
2022-11-20  2:18   ` Yao, Jiewen
2022-11-20  4:30     ` Li, Yi
2022-11-21  6:23     ` [edk2-devel] " Gerd Hoffmann
2022-11-21  8:31       ` Li, Yi
2022-11-21  9:21         ` Gerd Hoffmann
2022-11-21 13:18           ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB58726A202A2161890682D41B8C0A9@MW4PR11MB5872.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox