From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.1724.1667846880746210327 for ; Mon, 07 Nov 2022 10:48:00 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=CJygkhJ5; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667846880; x=1699382880; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=I/8JdrVD98SSxhRTWR/aNOCz+3QYIYo95lidvcf9CqU=; b=CJygkhJ5roGkQsF0JKfJHHe1tS5N+2gbnYV2K2DdaZ56+zeKMN9EbrGz F7dfB4vp16paHp7yvxyFw8Y8WHbwAy4PmznGXkWKD9tld5QsheAD8zWtR aonz3vJnPkqQNu4t7M9lxx1HhLfBvEQuHpcGL0I986GpnfYrtOQK8kEid WEzxiky8rA5QabCJPrevGnzrK2/g+iXK0RIpcMl7NjcYTYQTNDaw+X9OB Iwj+IRhTExYE9Nl47Ttbd8j9FQD5bL5wprz/655sxxeqBDZyiGbs74uiA 4rZcyV17+c/Pymyo28N+6YYpNbqZQFVuB5oWp3zjcKFoUW3oTnE1VOchF Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="298007195" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="298007195" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 10:48:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="613975050" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="613975050" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 07 Nov 2022 10:48:00 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 10:48:00 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 7 Nov 2022 10:48:00 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 7 Nov 2022 10:47:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W5nm5mhys8XQq0mVmQ7AETQ3DBoK6g7ZFmWaqtEmtBnkoAIOCOl4Ql31rSGrZpoh/7jTpnuIdVmvM0X6Plq6jBqa5/FEDX9V7bMU3rZ72Xb9A552SjYSGi0Eh8Epl7cPO9RkgLGL664MFnDMEGmR0c6p/LDUGu5dPdCte/8AzlqmgYhtdmLaf74CRrhZuNMaWw6AvugbNnq0FZ0tkU+sDbEG/+QCUofvRP/qyAYa47n5v3XEDU0/StqPIWQ82UoicgMZ8a3wiK0ErWz8IBsBRt3f/l9UL1X3klr/mSMybR7I979HO6fOL/8mz6M7aeLwbr2z5Gm9dJ6Bklv8Jp92sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0xujjnxL9NNmcEPxpNqyQNgjuh484UDGxoQs9JliQ7I=; b=ZeDcc4mcAk1vMPD3SXkMmUyjTWqHlMXwUH/H1ogXxVuGHgoRQrxHb58dJwC30rlxslxVxee2OLhPSXJPeUs1u0K+R9FRCx223Jcd672j39n8HNa+spibIKXyJEK8vKtS7brKX+oM8maeqHVXJFPXz+5oExjuEIMXiYTFkt/eIsV5IGsawokUxkllUqmdQm3pFsto7IS8PjGpkwfuSS1qinDPN8eThp7Ybzr1hL9lcuFAiXIPTmZ1rN2VN3VkhES2jaYfQZubAaoWLBzGa0gumDvEQWfhQ2txRNEfbz8IeI6+oC62bh9iBq/gHEqNtRDpBhskfT2pul8eFAEqR7Nd2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by PH7PR11MB5817.namprd11.prod.outlook.com (2603:10b6:510:13a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 18:47:57 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::666a:6f66:597a:7620]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::666a:6f66:597a:7620%9]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 18:47:57 +0000 From: "Yao, Jiewen" To: "Vang, Judah" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes Thread-Topic: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes Thread-Index: AQHY8tf+g2zM0QJ2c0KJBPi20xF8bK4zyr6ggAABk2CAAABTQA== Date: Mon, 7 Nov 2022 18:47:57 +0000 Message-ID: References: <20221107183640.3470-1-judah.vang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|PH7PR11MB5817:EE_ x-ms-office365-filtering-correlation-id: c081d52d-1662-462b-5c3b-08dac0f0969b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mPEcm7WPdSzJsob0ISYEsnTvigreExi2J3v3JFWPEcaoqdt6PjVnRFiLo+DYmafxABbp+NDrmEdDXwWydgjFXBblxJ/bsRp1WOF3NFixidpp3MmI8yA/YJsXFXsSBfh246PK96ZHl4OYOjpWpzNHBU46nhFfiMF319Ts++XCcp++klcZ77Ld03gnxrEFdV+uSD7V4iiABh9GCR8HVizJAF2JawMYOqyreNzaMQ2mx9CzV6G3zBq+WMgRfrUZKRfPU7d/Xyd+5LXydcCYxx+AI8nN3HPCLyLuG8NDGRRluRc6/WgrpFTILaNDDCz1kQHHo+o4G1m/C1Xg0CiitEgbITIxfXaTgE7H9rR6WacrBfavCLidbxQZp3ARrohvc7sKjEbkTqFHZjJqfNZ/kt96PgoXh1ILn+Y/4mS6CAB4HeW6AYtHL3d29ItDfu5F3j8Dh9UvGvwVlY5YWgM+Q4lqg/J0LCU7gvWAOze9jQc9Oyjnl0vybZK6MvcP2z5fssELQuPb/bICX+9N6p80bch2Sg/JP4qeqsWNX3gcgwKWHrGk6CpJzMGDasSmpFYo0bTFgLqZaxommT59/h8mA8ZuZlc9A1SvMd92nubTsnVT19c1yl8R6DfZm1M1AQ7FHjLIrUKaFzvU26MYhjtp8WAZnitO4oY2BUAZv+OXqe8PpLNQDta2d78m0VxBxX85hSQ6rr591l+nvuKJoBiC7Nr53uygtk/zV2qnlrvQQ3cMslDUUfft4y2U89y1bnc59HN/n75bqFP1a38z52beTlyoCDNcVA9lBazz+0F+WISsIrwri6f/SJzFfPat1OpYTSf3liABp7EvuFinqxEDGNS0iw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(346002)(136003)(39860400002)(396003)(451199015)(53546011)(186003)(26005)(9686003)(7696005)(6506007)(122000001)(83380400001)(2906002)(55016003)(66476007)(8676002)(478600001)(110136005)(316002)(5660300002)(38100700002)(71200400001)(966005)(41300700001)(52536014)(8936002)(76116006)(66946007)(66446008)(66556008)(64756008)(66899015)(33656002)(38070700005)(82960400001)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xffcGnUV+QhjS38w5KyN4YZr8Qe1o3yVpcV0085RB3ypJ8I6eKRFbIZ3PRmb?= =?us-ascii?Q?IMneTqFPp/+56z733Ms1jZ54iRE539EZaS22PSqoP6vrDbotYspjbrSPP3B1?= =?us-ascii?Q?evWqEfu4KiSFbhAcv4T8uJxq+FVKYKFBEdPxwTj5HBPqsuhMb1xv3ye2/EK8?= =?us-ascii?Q?kHRkf1j+Dk8lrJW05EXypYqHdEvMFIYaK20fGf6UFM3I3oDeHxy/uAGepSuj?= =?us-ascii?Q?W11b9tmeoi2twrnligs5zIJh8p2KovwzGol5FAg0JheoxP6ENBwE52jSxmvt?= =?us-ascii?Q?UoXg8y8Y1pbSyXhJvyMPL4wF4gwLRkB1iq9Lcic+z/WUNgWojF+pntqlNzVB?= =?us-ascii?Q?WRCcvRDHqkDcdJVHLHAWOdYmp+aHMmLHUaw2fyEmzfAZsdLJxn86Zq66VUbT?= =?us-ascii?Q?Wq+Z/cj2+ndquQMiWjYTS7Mlz+wUoNNQxHZfjZfGVlY6EIA4sUTt/YQQJ6Yf?= =?us-ascii?Q?FxGhGeOya3mZBUP+CS8hZdJIafEz8GZsWKl4ZuxIEiRDvQBzcQx+baHwyJvo?= =?us-ascii?Q?QvGXeyDA8T7v65s222kTlzqFDO4mGPYQVUucAocG3Rvr/bLRybLE23dCnPwL?= =?us-ascii?Q?eNwiVEInzJPxa6G7OxsOQZLBMAVAbTZAd+E+e5FB2RMqSGAiA9aXRvXEWcGy?= =?us-ascii?Q?YR/0YLwmuprXwvjsgPxTE7w+ICi53nsSZt6W1sFP7H9mVLI2CNUP9ho9SeUe?= =?us-ascii?Q?oCRquZogPIorAplugUPfspTKGqORzaWE5sgBSs79JaQh54utnfTkAkAyYN8W?= =?us-ascii?Q?nX+HAmOgwc9h/VQDt6Ww20bukU86UGZtMUa45heNOYMCEtt/2MJKKRvrBc+Z?= =?us-ascii?Q?Edrb5erKgPGwTLowqdt1oW2haxlh56XXtzBN+csvMmH9JS85wFp6Qf21wQW/?= =?us-ascii?Q?0RSSq7ywsYezBdMO+cu7gPQqQ8fBMV4INsUi8RXN3harbA2V7Et3672rNMIl?= =?us-ascii?Q?CvYA58ziwqcDCMTca1SxqPqikFiudwcJupsRrthGo4Yc4FdYt2KGtychzhR6?= =?us-ascii?Q?t93voJNxB1T+pgWh3WlVLW6sq+fACm8+NlWJG0UcbNSi5GL9na+r5qrf+N1f?= =?us-ascii?Q?4ESsGfDNBI7L3XT5DczbNPuQ4jPUQYnO1plRPhHR9Zp05xN9UnfbFrR/YZko?= =?us-ascii?Q?UhuI7h4DVghd743+D3rCUdXuSc+RQhkkJ2nO53y7Edhm8vOfBcRIPc1KsoMc?= =?us-ascii?Q?EaxzdT+xBPmJDyfdxhWJNKgWtXzHWrf0RYYTbVNGdvBByZIC3+qkM7/DD/Yr?= =?us-ascii?Q?3cl2ksq3KTyMCYI+MH2Dp8fh8leylXNcczD0Tlo3MqNeqmRSBucTOYTELviE?= =?us-ascii?Q?wbMVgEeBylV4UDMxGcLA7aXtOsmdWN/6gdx6wyrYBMjYBbBroh+1FYdsbEyh?= =?us-ascii?Q?kMLmdPuYpxbq+JuSqFwO/q+fl/aFTwfl3NTkgVeyIS4wxLaJNLgmw2sdBsk0?= =?us-ascii?Q?vdvkHDDDg/vcsXyBgudsEUAHSAW1fPcVhn/+QKUNVdGN+7VqnvvfSekIdyXu?= =?us-ascii?Q?NLTY8Dy3dhaloLe+s1IWTdWKa6ZTzKZODeucqH9vsrmsgMV6inXf1sTFlIKA?= =?us-ascii?Q?rYuW3WKWRAqMd6BHqOgtOF+Z1QO04QQhyHhdrBwq?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c081d52d-1662-462b-5c3b-08dac0f0969b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2022 18:47:57.7169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8OxR0U69Zo5l0IGlirVPwpu3RiCsjJEqC9jEJjObexfM8Egu855p0vgSIw/cQrmNikH3hlsEEteG4lvNkEdlEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5817 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Also, please ensure your patch can pass tiano CI. I cannot find the PR to CI for those features. Would you please point to me= ? Thank you Yao Jiewen > -----Original Message----- > From: Vang, Judah > Sent: Tuesday, November 8, 2022 2:45 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes >=20 > Sure, I can do that. I will resubmit as separate patches. >=20 > -----Original Message----- > From: Yao, Jiewen > Sent: Monday, November 7, 2022 10:42 AM > To: devel@edk2.groups.io; Vang, Judah > Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes >=20 > Hey > Would you please split this patch set to two different one? They are two > different HSDs. >=20 > Please aware that we are in software freeze phase now. >=20 > I suggest we include 3991 in this release, because it is an important bug= fix. >=20 > I suggest we defer 3992 to next release, because it is feature enhancemen= t. >=20 > Comment is welcome! >=20 > Thank you > Yao, Jiewen >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Judah > > Vang > > Sent: Tuesday, November 8, 2022 2:37 AM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3991 > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3992 > > > > There is a #define to deprecate Sha1 functions but not all the Sha1 > > function are wrapped around this #define causing a build error. The > > fix is to wrap all Sha1 functions with the #define. > > > > Need crypto AES to be supported for PEI phase and need crypto KDF to > > be supported for SMM phase. Update Readme to show AES and HKDF > > defaults. > > > > Judah Vang (2): > > CryptoPkg: Sha1 functions causing build errors > > CryptoPkg: Need to enable crypto functions > > > > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 ++++++++++- > > CryptoPkg/Readme.md | 26 +++++++++++----= ----- > > 4 files changed, 29 insertions(+), 15 deletions(-) > > > > -- > > 2.35.1.windows.2 > > > > > > > >=20 > >