From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.7376.1649906335745214350 for ; Wed, 13 Apr 2022 20:18:56 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=D2C+ErJs; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649906335; x=1681442335; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FVIKX/Zva+uNtiDAKu/95dFZ7aCrZDiuC4V5ldiJzdo=; b=D2C+ErJseBF7bLqPt7F3YQNS9yPt4hiYDgKmziZUxRoBxKyIXnqt5b8x mDfgGZUMfS4mP9MTq/h4u5IQXjAjPvhpncckewIObmZ6dXS0HcqAp1O9e 7RMwLjryWe6Hi7Chudlrsx7Jr1gBxOuFYwGEGVMnmnQVwsmTDs6oteBt2 SwrEqB5nFwOv7GrHeN7XgtcQwGvOnG72Vn2y6shTFAEFIFU4aDT3e/3uw /DlXNlwoCQ61XDZOCP7VufFDce2IeoyA9r3TSjT9AUds8koiNaz6veWBT QJAIrXKOM1Dsv0R/QKp1sSRaiL1wsLCyjwXTOb88cUNhP2uptnwvGS+Jy Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10316"; a="250124149" X-IronPort-AV: E=Sophos;i="5.90,258,1643702400"; d="scan'208";a="250124149" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 20:18:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,258,1643702400"; d="scan'208";a="725180512" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 13 Apr 2022 20:18:55 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Apr 2022 20:18:54 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Apr 2022 20:18:54 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 13 Apr 2022 20:18:54 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.44) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 13 Apr 2022 20:18:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JHboVZeLL3SVwFdjg/7gYMmiYbGAsLi4P4yG3hig9jVxn51LYU4/K32oy8UBx156gYdRF9EhrgmEMLaXxMvgl29ORU/QQAZCn0Bv2kDB30E2KsgTEebQWgVJmShKM5fIVzVd9YOezFnv67JsM9hpsIdPbw4uBeiVmeQBOmi10DOSsuv1guHq1tHb8vj3lJgBEwuhCu7zfNS5SkNAvhImj9Bw1CDsiumFX4C3vpC4M0ElTtCOU9DGopw2VKaJOJIdgs8wqojRzLlmGI6/9HaxwF25Qmn3siNFkGyjhHl4ep81l/B29j+MBpiyoDkvUjglQ4rIe6EtvW3nXs1we8lwRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Au6vDJFZykN/m2u0PUdzrblG1qMl2/RWq4XPeBGFt4Y=; b=UoQ5JdaOxh6+dJT7bH/8LBv1wDW/schwarkbFpKt19OFNGDyyjKDbm4evh14a0UHFuYAQxtZwWDc7E0CZqPzqjunbLMahVYxpRDuPUMLoIwBiQOBrNf5943quZN1vGHx5XUTlBQf3YkYiiZN/gUwFF+tfEpcEqdapT5JK8scFjDZYqZsey0chxdkGQSB+y3tphvTVyGVFrmdhE2/rIxXkX5SGph+CronW1WLTJkq6ERptimWv8ozYXIdcan7mwS8jj7E9RcHQj7WyF964d9etHwNPU8y3PD48Bx+k/LswgzTIyW/Hvf3xNGx4uA7f/ttM9lakgelOwud2cIXwmJZmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by MWHPR11MB1984.namprd11.prod.outlook.com (2603:10b6:300:110::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr 2022 03:18:52 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::198e:ea23:c83b:b93a]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::198e:ea23:c83b:b93a%4]) with mapi id 15.20.5164.018; Thu, 14 Apr 2022 03:18:52 +0000 From: "Yao, Jiewen" To: "Li, Yi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a customize-able way Thread-Topic: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a customize-able way Thread-Index: AQHYTv8sEInIZOqBVkC7j4+YyPwqSKztZN8AgAAGPQCAAVNtgA== Date: Thu, 14 Apr 2022 03:18:52 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ee72b250-31ba-48a4-37b4-08da1dc5804a x-ms-traffictypediagnostic: MWHPR11MB1984:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FfbPBQzuIr8/hyA9rLoeY2i52gzN5EFQlM3VuInizlTFzkTy9geapjTqEn6F4tYwg6kIN/2imQcIz353sOG5cF3YfEyiaP1OxnOoZTYh5XO8yVaNMAXFeqFIolCpTxt508oGUpcKAsYmCL0rjE22qnuIdVHCYb2U++gUKW4eAfEBDNPlIGU36+xRJWPJcIrTW0Z0xIW1wFp+fKRh3FIA8dCs2wu6eRXnCp59X4c+3HrivSv5uWn+oSjeB06fYyjy2rEBiEk152umPOPpBcXOy4llLnto9u08McL8nN8/RvkC8RkJM7bhiCK03rzfPiHEzricA72TpbRMFwSMhsuqmqiUJXKoyuQkkHntYh1zUcpjfxplHMpC+48oi8B87tZhN43Vat3shpDChCMpV/wyhCZ6Nvm7IVpWawL6SpmaAz03CVn1b8BCjbWpmdeA9JwWhJyaObrJ+antxItzC3cI7ifJbQK3+Zpr8a50Swpg3EUais1uggsnNQlYMbhrL6Q7zxgUq6hBy3SojbwDVxtsbU1ImxhTV9b4tRnD5i4allax+y/oerIAv6OpepolEKE2bFspcxTrZQJ7q6QkZGpWQiQ8D39UrU5ogKJFqgSx1g807+KnN6k+m8jmOzKWcTCGwfzm0487xf1aktpsIN2sTrKvX4BlmFS1GUQVFIykwaJyiFLO0Dli92ufgyN8v8n5nfxrE3IIOBvnxb+0Z0W3kiuZO/bEt/HcwCGVQVUEU7ABhkp0VUu1Wo1ecGjB46gu x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(7696005)(76116006)(508600001)(82960400001)(53546011)(38100700002)(6506007)(8676002)(64756008)(66556008)(66476007)(66946007)(66446008)(966005)(55016003)(83380400001)(107886003)(52536014)(86362001)(8936002)(186003)(26005)(122000001)(33656002)(5660300002)(2906002)(110136005)(38070700005)(9686003)(19627235002)(71200400001)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3BZPAGyQyEueTLqYjF0K99AMClbDpqI7ZTASihbD37ZP2F6aAsX4OcjpwlzA?= =?us-ascii?Q?SACnPdSsltSZx2sOP8/WKom5XRlLL7voDk028KiqPYXGl/MvD1xr+g3zgyTM?= =?us-ascii?Q?wKDKPmqzXrwPq0N4Boq8pTam2CWQfQuugDojGem+v88qCWORBafKFhU0AKbw?= =?us-ascii?Q?VGVIEN6GDU2k4qexT64+QXOOqoS7xgXUCol2mZUjUhE+MCl5zyU4yw++6Pvo?= =?us-ascii?Q?I1Kifqm0XyCCP/YUNBGyQLAG0Q5XBQKIfEAG19uUoDZrh+1YUBRa1eUzljeN?= =?us-ascii?Q?OkF7gA9q2B8QQD4VMV019O3tt3rsqhF4U0ckVLeLMADuDEwvJ75r/St391za?= =?us-ascii?Q?2E8gbq+Om9nLkjFAFgqRdEdUA/rj7gKRHWBtcxDhFEvEqiA9mBN4JHdrZliT?= =?us-ascii?Q?n7hwDffWYSCSsWvkzE1+GlkxyJETakZdpF2rHlbogEmcpVtjmHQKdFCsruzS?= =?us-ascii?Q?klC/spTCRw9NWBmfycI235kOKYeBp4hYdgr119dQ2BtJYtmaG/nlcRbIXAvP?= =?us-ascii?Q?HG0letNIL1YAE/1T6vFu556gRE2tv62py/mFL2QdBsWlf1rHYxWDwp3Pt8la?= =?us-ascii?Q?mNpY97H9AbcchpPethHDd0BlT94DN1zHSVb9sI1UCC6QrKHeltAc7CBBZQ29?= =?us-ascii?Q?p9Qmk9mTvls/9H3Art7fsT1hnrPXPqGnMBFvOqeaPWVJan9+iSi4y/4r27ZF?= =?us-ascii?Q?L831AoEf4aue88NWEXvnGvJ6wf3U0HEHGJXIgqd7I8i3R+oEMmy0L5iQEuKp?= =?us-ascii?Q?9gl9YtnKiU8aot9FGvMus7xneNkO5fW6wv59hcBvcezdpgnhZ8A2Q/dAaGZd?= =?us-ascii?Q?SbP9RsGkvKm1GGTkVGi/z9XyrmuJRTT3ZkAEtX0gT58ECsrxeMVbeiCWGXUI?= =?us-ascii?Q?6rN1IK+q1NuNjb3+NRECO4GauObecPC4WR1Bgmk3uXbhLxpKYlV3BB9GQn7W?= =?us-ascii?Q?ArcdYwYhX5jpWdiaO+QscmknYUPCSKPh60KgI0Yk8j3b2cW5AdeXyp7+b56i?= =?us-ascii?Q?dFd5EaI/EfiXu6+8gDzSYwTVF8F8rJ/cimzerIbhDRJRVkudMBSgYZmfkPRD?= =?us-ascii?Q?lfdIqv+NSiUjR/CEPqwD1N77qY+Fy8C+Zsizm1kzPQDq8GrYS9SbpWnNB8CW?= =?us-ascii?Q?fzxmRsiULtsWP9uTLYata46ZmksFgrbe3SD4wAcY8v72NltmAkq6rfzhj1B7?= =?us-ascii?Q?S1QrJhce/fmMsU2fm99hhyADiwWu+futOhtKK+OvKT5f/OSI840+0YpSUZ4F?= =?us-ascii?Q?3UD7oKgR5AUleN93I+pe9WZBzeDPvDroAXIfuTMsAk8miOB2NcAD7nh2+NjX?= =?us-ascii?Q?Qe83qHSDjb0Xe8OKI0c6KITi5jKkQwud2JK0iVXFmhjHWAsVw0tf0qU9s2nP?= =?us-ascii?Q?taTNw6Hv7/AQL4U8kC3xWXM/Aoiy?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee72b250-31ba-48a4-37b4-08da1dc5804a X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 03:18:52.3206 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oQ3dYqpuDzWBwcKfOldWLFZQNTgS18DeoCOFukWm5IP1cEtNMUaxRZg+4v+TzzuQrbw2B44kXJbS+PH9vkSWvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1984 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks. The v2 series merged - https://github.com/tianocore/edk2/pull/2777 > -----Original Message----- > From: Li, Yi1 > Sent: Wednesday, April 13, 2022 3:03 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Wang, Jian J > Subject: RE: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a customi= ze- > able way >=20 > Thanks for review and have re-sent patch series. >=20 > -----Original Message----- > From: Yao, Jiewen > Sent: Wednesday, April 13, 2022 2:42 PM > To: Li, Yi1 ; devel@edk2.groups.io > Cc: Wang, Jian J > Subject: RE: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a customi= ze- > able way >=20 > Thanks for the contribution. Great progress on adding ECC. >=20 > With PcdLib removed and "no-ec" removed, the series is reviewed-by: Jiewe= n > Yao >=20 >=20 >=20 > > -----Original Message----- > > From: Li, Yi1 > > Sent: Wednesday, April 13, 2022 2:24 PM > > To: devel@edk2.groups.io > > Cc: Li, Yi1 ; Yao, Jiewen ; > > Wang, Jian J > > Subject: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a > > customize-able way > > > > EDK2 has Enabled a feature which allow SOURCE section in INF files to > > use Pcd to customize source files list. If Pcd equal to FALSE, this > > file will not be compiled. > > https://github.com/tianocore/edk2/commit/ > > bf9230a9f3dde065c3c8b4175ccd32e44e8f0362 > > The patches add a customizable EC feature to CryptoPkg by this feature. > > > > If Pcd equal to FALSE(Diabled), the binary size will not be changed. > > > > Size diff(Bytes): > > | CryptDxe.efi | CryptPei.efi | CryptSmm.efi | > > Before | 815,616 | 540,544 | 563,712 | > > Diabled | 815,616 | 540,544 | 563,712 | > > Enabled | 1,008,352 | 721,408 | 744,832 | > > > > Cc: Jiewen Yao > > Cc: Jian J Wang > > > > Signed-off-by: yi1 li > > yi1 li (3): > > CryptoPkg: Add instrinsics to support building ECC on IA32 windows > > CryptoPkg: Reconfigure OpensslLib to add EC algorithms > > CryptoPkg: Make EC source file config-able > > > > CryptoPkg/CryptoPkg.dec | 4 + > > .../Library/Include/openssl/opensslconf.h | 10 +- > > .../Library/IntrinsicLib/Ia32/MathLlmul.asm | 98 +++++++++++++++++++ > > .../Library/IntrinsicLib/Ia32/MathLlshr.asm | 78 +++++++++++++++ > > .../Library/IntrinsicLib/IntrinsicLib.inf | 2 + > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 50 ++++++++++ > > .../Library/OpensslLib/OpensslLibCrypto.inf | 50 ++++++++++ > > CryptoPkg/Library/OpensslLib/process_files.pl | 2 +- > > 8 files changed, 289 insertions(+), 5 deletions(-) create mode > > 100644 CryptoPkg/Library/IntrinsicLib/Ia32/MathLlmul.asm > > create mode 100644 CryptoPkg/Library/IntrinsicLib/Ia32/MathLlshr.asm > > > > -- > > 2.33.0.windows.2