public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] Question about limit size of OvmfPkg NOOPT build
@ 2023-06-12  6:52 Li, Yi
  2023-06-14  7:45 ` Yao, Jiewen
  0 siblings, 1 reply; 2+ messages in thread
From: Li, Yi @ 2023-06-12  6:52 UTC (permalink / raw)
  To: devel@edk2.groups.io, Ard Biesheuvel, Yao, Jiewen,
	Justen, Jordan L, Gerd Hoffmann

[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]

Hello all,

I am working on OPENSSL30 upgrade of CryptoPkg.
The upgrade of the OPENSSL submodule will increase the size of binaries and break the CI build check: PlatformCI_OvmfPkg_Ubuntu_GCC5_PR (Platform_CI OVMF_IA32X64_FULL_NOOPT):
https://github.com/tianocore/edk2/pull/4391/

The size change is hard to avoid, can we skip this build of GCC just like we did for VS2019?
https://github.com/tianocore/edk2/blob/8314a85893f5b75baa0031a5138028188a626243/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml#L112-L123
OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml#L112-L123:
    # This currently creates a very large image which is too big for the FDF declared range
    #   Ovmf maintainers suggest to skip this build for now.
    #
    #       OVMF_IA32X64_FULL_NOOPT:
    #         Build.File: "$(package)/PlatformCI/PlatformBuild.py"
    #         Build.Arch: "IA32,X64"
    #         Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=1 BLD_*_SMM_REQUIRE=1  BLD_*_TPM2_ENABLE=1 BLD_*_NETWORK_TLS_ENABLE=1 BLD_*_NETWORK_IP6_ENABLE=1 BLD_*_NETWORK_HTTP_BOOT_ENABLE=1"
    #         Build.Target: "NOOPT"
    #         Run.Flags: $(run_flags)
    #         Run: $(should_run)

Regards,
Yi



[-- Attachment #2: Type: text/html, Size: 4509 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [edk2-devel] Question about limit size of OvmfPkg NOOPT build
  2023-06-12  6:52 [edk2-devel] Question about limit size of OvmfPkg NOOPT build Li, Yi
@ 2023-06-14  7:45 ` Yao, Jiewen
  0 siblings, 0 replies; 2+ messages in thread
From: Yao, Jiewen @ 2023-06-14  7:45 UTC (permalink / raw)
  To: Li, Yi1, devel@edk2.groups.io, Ard Biesheuvel, Justen, Jordan L,
	Gerd Hoffmann

[-- Attachment #1: Type: text/plain, Size: 1632 bytes --]

I think it is reasonable, due to big size issue in NOOPT.

Thank you
Yao, Jiewen

From: Li, Yi1 <yi1.li@intel.com>
Sent: Monday, June 12, 2023 2:53 PM
To: devel@edk2.groups.io; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
Subject: [edk2-devel] Question about limit size of OvmfPkg NOOPT build

Hello all,

I am working on OPENSSL30 upgrade of CryptoPkg.
The upgrade of the OPENSSL submodule will increase the size of binaries and break the CI build check: PlatformCI_OvmfPkg_Ubuntu_GCC5_PR (Platform_CI OVMF_IA32X64_FULL_NOOPT):
https://github.com/tianocore/edk2/pull/4391/

The size change is hard to avoid, can we skip this build of GCC just like we did for VS2019?
https://github.com/tianocore/edk2/blob/8314a85893f5b75baa0031a5138028188a626243/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml#L112-L123
OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml#L112-L123:
    # This currently creates a very large image which is too big for the FDF declared range
    #   Ovmf maintainers suggest to skip this build for now.
    #
    #       OVMF_IA32X64_FULL_NOOPT:
    #         Build.File: "$(package)/PlatformCI/PlatformBuild.py"
    #         Build.Arch: "IA32,X64"
    #         Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=1 BLD_*_SMM_REQUIRE=1  BLD_*_TPM2_ENABLE=1 BLD_*_NETWORK_TLS_ENABLE=1 BLD_*_NETWORK_IP6_ENABLE=1 BLD_*_NETWORK_HTTP_BOOT_ENABLE=1"
    #         Build.Target: "NOOPT"
    #         Run.Flags: $(run_flags)
    #         Run: $(should_run)

Regards,
Yi



[-- Attachment #2: Type: text/html, Size: 5448 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-14  7:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-12  6:52 [edk2-devel] Question about limit size of OvmfPkg NOOPT build Li, Yi
2023-06-14  7:45 ` Yao, Jiewen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox