public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Xu, Min M" <min.m.xu@intel.com>,
	"kraxel@redhat.com" <kraxel@redhat.com>
Subject: Re: [PATCH 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor
Date: Thu, 15 Dec 2022 02:02:48 +0000	[thread overview]
Message-ID: <MW4PR11MB5872735B88FAA13DEBDF628F8CE19@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MW4PR11MB58723FCF3E7D2B97D52AFCB08CE09@MW4PR11MB5872.namprd11.prod.outlook.com>

Hi Sebastien
CI failed, https://github.com/tianocore/edk2/pull/3769
Have you run CI before submission? Please take a look.


> -----Original Message-----
> From: Yao, Jiewen
> Sent: Thursday, December 15, 2022 12:20 AM
> To: Boeuf, Sebastien <sebastien.boeuf@intel.com>; devel@edk2.groups.io
> Cc: Xu, Min M <min.m.xu@intel.com>; kraxel@redhat.com
> Subject: RE: [PATCH 0/3] OvmfPkg: Make IntelTdx work with Cloud
> Hypervisor
> 
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> > -----Original Message-----
> > From: Boeuf, Sebastien <sebastien.boeuf@intel.com>
> > Sent: Monday, December 12, 2022 5:04 PM
> > To: devel@edk2.groups.io
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Xu, Min M
> <min.m.xu@intel.com>;
> > kraxel@redhat.com; Boeuf, Sebastien <sebastien.boeuf@intel.com>
> > Subject: [PATCH 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor
> >
> > From: Sebastien Boeuf <sebastien.boeuf@intel.com>
> >
> > The IntelTdxX64 OVMF target wasn't working with Cloud Hypervisor on TDX
> > platform. This was due to the way the OVMF code expects Cloud
> Hypervisor
> > to rely on PVH to retrieve information like memory below 4GiB as well as
> > the ACPI tables.
> >
> > This is why this series takes care of identifying when running on TDX in
> > order to handle things differently. For the memory below 4GiB, it falls
> > back onto the CMOS to retrieve the correct information, and for the ACPI
> > tables, it relies on the HOB to obtain every table individually before
> > to expose them to the guest OS.
> >
> > With these two use cases properly handled by this series, it is now
> > possible to use the IntelTdxX64 target to build an OVMF binary that
> > works both for QEMU and Cloud Hypervisor on a TDX platform.
> >
> > Sebastien Boeuf (3):
> >   OvmfPkg/PlatformInitLib: Differentiate TDX case for Cloud Hypervisor
> >   OvmfPkg/PlatformInitLib: Transfer GUID Extension HOB
> >   OvmfPkg/AcpiPlatformDxe: Differentiate TDX case for Cloud Hypervisor
> >
> >  OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c      |  8 +-
> >  OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h      |  6 ++
> >  OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf |  2 +
> >  OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c       | 87
> +++++++++++++++++++++
> >  OvmfPkg/Library/PlatformInitLib/IntelTdx.c  |  5 ++
> >  OvmfPkg/Library/PlatformInitLib/MemDetect.c |  4 +-
> >  OvmfPkg/OvmfPkg.dec                         |  1 +
> >  7 files changed, 111 insertions(+), 2 deletions(-)
> >
> > --
> > 2.34.1


  reply	other threads:[~2022-12-15  2:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12  9:03 [PATCH 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor Boeuf, Sebastien
2022-12-12  9:03 ` [PATCH 1/3] OvmfPkg/PlatformInitLib: Differentiate TDX case for " Boeuf, Sebastien
2022-12-13  0:04   ` Min Xu
2022-12-12  9:03 ` [PATCH 2/3] OvmfPkg/PlatformInitLib: Transfer GUID Extension HOB Boeuf, Sebastien
2022-12-13  0:05   ` Min Xu
2022-12-12  9:03 ` [PATCH 3/3] OvmfPkg/AcpiPlatformDxe: Differentiate TDX case for Cloud Hypervisor Boeuf, Sebastien
2022-12-13  0:05   ` Min Xu
2022-12-14 16:19 ` [PATCH 0/3] OvmfPkg: Make IntelTdx work with " Yao, Jiewen
2022-12-15  2:02   ` Yao, Jiewen [this message]
2022-12-15 15:11     ` Boeuf, Sebastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB5872735B88FAA13DEBDF628F8CE19@MW4PR11MB5872.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox