From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 56A5E740037 for ; Tue, 29 Aug 2023 23:43:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=eKClqm7wwqZwZxfl1RebvwWh9RRHkYEyCJyfinm+++0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693352626; v=1; b=Fv2Ljbn57szc6/GC72OZb0Rqlzgvdw52nZ2CfaS0WxWK6TQGQlAtUvpELjuJAmp45nI3fpZ2 8zysB9VAbHeYVHuqgKiJoTrSBc6daL1ja5+8yvo3WBN7wczWlaNZUAEBm7k+ChoOiH0Cx4Z7on8 4JoCOGCaK2PdsQwnp7WaYdfQ= X-Received: by 127.0.0.2 with SMTP id FemyYY7687511xQrhdNZ9B5q; Tue, 29 Aug 2023 16:43:46 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.2551.1693352625973575491 for ; Tue, 29 Aug 2023 16:43:46 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="360504125" X-IronPort-AV: E=Sophos;i="6.02,211,1688454000"; d="scan'208";a="360504125" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2023 16:43:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10817"; a="862407109" X-IronPort-AV: E=Sophos;i="6.02,211,1688454000"; d="scan'208";a="862407109" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 29 Aug 2023 16:43:45 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 29 Aug 2023 16:43:44 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 29 Aug 2023 16:43:44 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 29 Aug 2023 16:43:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SvBk3G8NMsrwFj/AbBnEyYsRAjG6AA1QRg1Lu8GrWqtO0doO0tuoffI2YqmgeFdY6C2Cjd9mlwduWaxizkvsVp8zXkEnywETy3cgxQh5wRTnXseIE/mq7/pUvu09SYASOSwKcf5ICSICaDmY2Xk8QJvsYvQcId/SLhH30jaM/R1lMwe73pPsfNIrqwGYdldZsBavk0aPrXnzl7/hsPvuRMQwGWUlxgNKOxfRcWWl6hdV+FLQAH4jdK9JjNVJdEk0iSxSCXKiwHuTa9wEfCxkRdRg1Hbj0+ZmaMI8Rjo7fZ518s5SiceetJp1mvW/00oZx4TfOod3j/1AcefHeHI8yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UgYCZpEVZNNSZ69ogzfa+13BSJf6/89USSGfNHTUm1A=; b=Rjn1AlofqZseLWIn+91xRcr435gSDhQ4rD6jdLEBm4+WHsUrpahTAS2/6VLEd8Mukw+SuGU3gwfdBlaBU8Om5gzt5lMYs9OGJa38LCVzeKmfeG1IGuJq532943SApeH3cY5Aib11qfwA78BaJV/QbIojnCBK/9AHO4zterGMBNuS8lea9KGWDmUAZ7jul26yyHEPhLLXKgGA8Wz6aftKroxmUkSCM7vZGmdD/6As/ArCNPodNJaURGVDJtg6Wy0ezZAXFRHVk4wlgcaQRDbAPIdp2FkGw7T49wy+1eu2xPuUDYXJ0Wk0YkzcptD2arex5q2iRG/iaImCETAL4g1F8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CY8PR11MB6988.namprd11.prod.outlook.com (2603:10b6:930:54::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.35; Tue, 29 Aug 2023 23:43:37 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b%4]) with mapi id 15.20.6699.035; Tue, 29 Aug 2023 23:43:37 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: Make mTcg2Protocol static Thread-Topic: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: Make mTcg2Protocol static Thread-Index: AQHZ2s5/plhL1u0iQUiOaPIJ8/cgILAB74+A Date: Tue, 29 Aug 2023 23:43:37 +0000 Message-ID: References: <177B99510AB70F56.12117@groups.io> <24eb8e60-7ead-ad03-483f-6d9b6a999c5b@linux.microsoft.com> In-Reply-To: <24eb8e60-7ead-ad03-483f-6d9b6a999c5b@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|CY8PR11MB6988:EE_ x-ms-office365-filtering-correlation-id: e895a8bb-c0ce-4abd-ce7e-08dba8e9c422 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: dc1SFU4ZAMvfjnbvxiC1ptfbY8TSSI44lJ7iQSk25WbnzL/5zZRlft3pcsa94bpTRVu6B4xYXUamB0ox0bmGo+MM0zy0MpAs0TzZPkOLPua9kiqwGWvwl/0Q0/ntDOFRkCjmEWsrm6JHVO+b9cXI9/3ttYY0LSRgwX5K+9KVXz4Km988vsVlKfosVyHgFqluzSkeDh1EoO4Q3qDkNN+2q2s6MCqlMeAfM5sU+28/9kQU9EQxbkgOW+1jhBzW+RW9GU00Zxh2cWmXnmr3wBnhwhn/wkFKf60jLGt8KI+rpO/ubhKcCzx89SmJDH+m90AILYxREJIPIODpkO0W/b/HRYNhDDfQGDhVu1h5wz7nSuCJfq560+R5iao80YZwN8rhDt1Q0FfTS+HairxkycgDOsZNVQC8czD8jSDfqD3PECqqlzvNJGqydaeu1CHLd0mQT9KHgCjEHVOpPs3U3BFtitH4vBtb2HwuvYtdLLccBJeOGSBZJgjZpLyaRBTZKembOd6BOZN074zqKEpgTWQemYFp9MrcE8mk/3whweFYCbOEFt91atwnr9TgonX9YaigCrQr2Sms0LWI2KJX4rYo/P+7M0x3C08EmfuSREI3NGWqJY2tX3ISu0SMa6hWYVkB x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x6m42Ze24PqS6qqY7dIX+QhpqeBtwJ36tT5cKlDR5qYSxQpuhNJsNU5YcoS6?= =?us-ascii?Q?gpw4ZUMc5rR23Rv8Nzy2bS44VPDzcZxX086M6xxaZZdh68Uf9EN7ivkVGmaz?= =?us-ascii?Q?ZN3KMljDcZvYIdxNiK4IPrfDb5uk2gTKIBWoIzVqiIGrevpC1/ummFU+jAOT?= =?us-ascii?Q?lZJzRmPfCOZ/9+v9Mytm6408c5jWLwhpMNkMwKCZtO9I6TMD07PSOwsM9ZDJ?= =?us-ascii?Q?yUy0P0oJgB7O48aamm9hF5mkvgcrjEwTF8H2n/UbDMCcwqGuoBHatIGNZ2Xe?= =?us-ascii?Q?yY9G+UTgPxNAybT2wrdT1K8Sm8ib/6SB2J8vDvnz17wR7I4+P9IaA0aCdY+I?= =?us-ascii?Q?I/VOlB+8EIN4acFX5K6KiimM/Q7/PTA6xnogkJI1tUiDUt8/nkydhMw3dJoT?= =?us-ascii?Q?jRQT/mHvilcB6QYok3wR7dXEXFfCsrShc+GsMWx80s5jz6iGod1elzmMPfSd?= =?us-ascii?Q?I5glodIhOMAgT420UaWxOaNRBmGE5bcKWvOmKXktKAEqhe41laUOuHX0Ul2I?= =?us-ascii?Q?WkvgCpzIgn48i7xwZskbxAh6ATO3LF2w9chBVWfPK9/qG80Lumq16keHqEGZ?= =?us-ascii?Q?AwQSgvE6R7UVv8cJVg6WqYunXA/arRaYMSufw2pDi3pQsM5Q4SEuxNhYZtkL?= =?us-ascii?Q?X+kVo3p4SXPP7kRWjefwI+Otdf8M4Maf4PpWSEolsrvn2l+5gOcTii833GGI?= =?us-ascii?Q?4ZFGqBNbS9bMwMcn10GePkKM3xa5AroEU9NO+6bcnr78CwYduUKeROsU31pk?= =?us-ascii?Q?O2QcgoR0D49u4afKz9SJRNCAXP6mkF7O/nDoGhZHnF2nzoJilYWJiX1w0KiF?= =?us-ascii?Q?4SUr+5CTCL/NcSyDHUw3QYjwk+PkDLSzgi2x8URBnBzYJYoBsKpe1tS8VxzD?= =?us-ascii?Q?dfrVnY+6IzIH4pvDJlmHWdTBIfikr8SXC1nTLHWEvhfuF7tIT/otII8lk11C?= =?us-ascii?Q?2BLOYHyIl9N8WNU4mD+zlU4UERQ59ARyw7m+zZIjc134ziTdTM95b8Zcwe7C?= =?us-ascii?Q?OTtKDxBlpf241MN/zWF4wI210V+vDzRLoYJwfnBeTtvk7OtaqjbKSY1J2gd1?= =?us-ascii?Q?nJ4mpmM9mYsqWikm1LzWXLa8ecABvob7E7VlQ/O7qGdAu/ngqriYbLvhQKQW?= =?us-ascii?Q?jXJP6k5uox000MosgmrWHWAZyx55UdvcDRDmEJMzmjDrUdccRXwffAGGseyN?= =?us-ascii?Q?+11HI8c15l6wOwj32mr2A2rpcFBmTU6KXPhROB6HMgpb6c0QO0EybXvXf99q?= =?us-ascii?Q?ye9TOit3QxJQso1UBsF39r/n/aT5JQITIYEbTzhRehK5WyQo9V3kbIzh5Dox?= =?us-ascii?Q?qJmJ8WE2dCnqufCsG05ThX8vaXkUVEuaO2sR0wXWZKhpWq3Ti+8eVZWrjBuN?= =?us-ascii?Q?SsBoh0xb4P13+kuwFxZ+ahc9Dx0zljqXKDVhGohn6+LAcugFS0f+1homigL/?= =?us-ascii?Q?YOU9GjgNTDy6sGzcPd/dgNQdMBzT1FrNA//gHQCa7NYmzAzRicMiICfKF3qb?= =?us-ascii?Q?KRUbclpPPCTfM5sELOfwgknWR1cHary44Z9JAF3prHAz0oCj4kVS8FOn8qox?= =?us-ascii?Q?2pdydbnMjgHYgVHdh060oUPzKPeaGKwuJNFA99nJ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e895a8bb-c0ce-4abd-ce7e-08dba8e9c422 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2023 23:43:37.4177 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dmDH+ODEcl00YVgTLKp3IyytSNKm2fQY/1iDg54I8PKBVcbWYflj40hNdgT5GVd/JQ3hguYX10d0WUTeLND/ng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6988 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7h3c9guILoLrKxSm2WYdcdtAx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Fv2Ljbn5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Jiewen Yao > -----Original Message----- > From: Michael Kubacki > Sent: Wednesday, August 30, 2023 7:14 AM > To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian = J > > Subject: Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tpm2DeviceLibTcg2: M= ake > mTcg2Protocol static >=20 > Hello, >=20 > Can you please help review this change when you get a chance? >=20 > Thanks, > Michael >=20 > On 8/15/2023 11:50 AM, Michael Kubacki wrote: > > From: Michael Kubacki > > > > The global variable has a common name that can conflict with other > > TCG modules. For example, Tcg2Dxe has a similarly named global that > > is of type EFI_TCG2_PROTOCOL instead of EFI_TCG2_PROTOCOL*. > > > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Signed-off-by: Michael Kubacki > > --- > > SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c > b/SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c > > index 3c8cf4fa117a..c792b1d67b06 100644 > > --- a/SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c > > +++ b/SecurityPkg/Library/Tpm2DeviceLibTcg2/Tpm2DeviceLibTcg2.c > > @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include > > #include > > > > -EFI_TCG2_PROTOCOL *mTcg2Protocol =3D NULL; > > +STATIC EFI_TCG2_PROTOCOL *mTcg2Protocol =3D NULL; > > > > /** > > This service enables the sending of commands to the TPM2. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108103): https://edk2.groups.io/g/devel/message/108103 Mute This Topic: https://groups.io/mt/100760659/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-