From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.4794.1664539510120515184 for ; Fri, 30 Sep 2022 05:05:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=WiKggs+c; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664539510; x=1696075510; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=M3HKfI48ljsfQ6zYJGYeEgLctajCV/WgDH46RIOD9dQ=; b=WiKggs+cNhNbq7OBkp5jF6F6mOQ0DbbQH6v97ESVHihFMFL0h+MCU5/O HwBd3ogJzEAPuTbZmvAehoLMsOpArRMTu/0CZHeaoXOeYZhZZ0z84nzoP ZCgxAI9f5YDjXV824vzc/JA8lBVzN8+lxZgSGZIDKnltMHU7TPhddI+mP 2en/+/UgFHRT7+VsqifuG+cQHA9hYnz7NxQeLwbQ4P5iMmtp0zke/AiJj ht825V15Z0PjD2jOLJlbwwU5cprHl79cooC55JFCDmt9J7TfDMT5Ldhqh vJ50xLPCyizILN7pvQ/jK44acZwu4KcFQGLqUxDpcZIOhfCowut8XcI9M Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="388453951" X-IronPort-AV: E=Sophos;i="5.93,358,1654585200"; d="scan'208";a="388453951" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2022 05:05:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="726836987" X-IronPort-AV: E=Sophos;i="5.93,358,1654585200"; d="scan'208";a="726836987" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 30 Sep 2022 05:05:09 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 30 Sep 2022 05:05:08 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 30 Sep 2022 05:05:08 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 30 Sep 2022 05:05:08 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 30 Sep 2022 05:05:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JnO4ZanTTBNuEnDTYkoMWxHfL+ZB4lUzxi0Y4+h+BWtSu79lxtkWgrEohes3lz5PRVUk2ULslwMKhntTyUNGLjzgxW+h2UBsCWmQcfoNM7MJHqoOkiZSONgRcMZKt2vq6V5oySEoaRTGXwKfp7SZbd7sco2sn9AR/aQRDLCYAKYF8KC+jV6ohAsXI/g1Hv3fakWo8cfC5w0iC8dYCaCPFBwGXcMBaiqnCLmf+xjSnXqt5BKI4//7u2FH76WDxwvP933cGfCkxB2Wwu7iWjqmmJViZ5kAhI6fFHjXDO10WDark6DrNJqXtNjzJPf+aUkHF/oez253Y6NkX/ImeopfdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kf+3VVDNLtd+x/BO+l9kyIoomWAQ2s+TWwlto9N/6rU=; b=NMDg1T0b9xnH8YAOaOCjeFmF9VepZTWzn0Q11J2aO5Z0mis4LbxIZharXS1pO9wJJRsRIPo+6UpHkhMlywlhHPCj4/Y+FOu8F/SXvW1ZWl+c1/Un5/5pTIxhW4+gMxPBGvAaQggfOfkFOqGk0ZfckbbHDZEpVEc1jjpoU+ciJGbtsZ2S5gZPWkPdi4gx2vfQf00AbN/mctS8/hVMhVMGH+eWFX0wcS6zRS/4Q2jg+EkzG+6VB4bQHjQ0JQfrf6Xrk8qcCR0NlZJCznJJ06i6CMD3Fm9R0gQIqtcz+W38mUlQeViPBoi+yx4I56S+JMnrMFf8HwzgmAwMcmQoNVSqxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by IA1PR11MB6121.namprd11.prod.outlook.com (2603:10b6:208:3ef::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Fri, 30 Sep 2022 12:05:06 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%8]) with mapi id 15.20.5676.019; Fri, 30 Sep 2022 12:05:06 +0000 From: "Yao, Jiewen" To: "Gonzalez Del Cueto, Rodrigo" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH] SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands Thread-Topic: [PATCH] SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands Thread-Index: AQHYzlYGnWJuJIFKb0m08vYz5ptt6K337OvQ Date: Fri, 30 Sep 2022 12:05:06 +0000 Message-ID: References: <5f134d299f44f162f7ae7537a0f8c6783210fbea.1663832124.git.rodrigo.gonzalez.del.cueto@intel.com> In-Reply-To: <5f134d299f44f162f7ae7537a0f8c6783210fbea.1663832124.git.rodrigo.gonzalez.del.cueto@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|IA1PR11MB6121:EE_ x-ms-office365-filtering-correlation-id: cb86438b-be3c-4505-b350-08daa2dc03ac x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VdgXL0LHyBS0pLoc//KAZ5NoSW53b2mPlKjrYf+CHZ3Wbn8mxtwCgE9IxmETBr9Etd55VUYSByqD8Z/0yYxHbLayC31usoPd5Wu0wsNFhixMAqEzVSRrB3NmvvM+BtqCEyE/iLSUbljVicDzKPyrlj3hNrfWCzfMTCLBJkCKNX7sSdCsfvpuQoUF34HoqpBnDPkI5KktRI6dZ6/Z0YAmzpXrGlbyg6F31/8bmmCFzzNpogM1g9JOk8celxdoyW5rLnvfOTVLlq/l5oEsH0pERzLWYLpABoqalibqMIFP7exNQ8rVDNVMUuvOTGIxB7bQy6IWmI1nTBPBHQXsBW8p0Fcl2wVF9JQKX3wlT6IhMduL1hwhys7bsf3T02k8MTSi4AyEYrWz1dCLqw32+aBliIMWjeCokim4yE2o3wdo2w03JhFn2qXmpBIuuj2CdO6/7KXCXFj+yZ0ZmZs+Ft72YouCZqLiXSZHRL/HRE0sIyhQ6He4LJbxsuFvFX/Oi4v7N2mTMzrJpHtzThpJ3NEkr/OD0l6a1JFhNKGv+KvgkuCgdTfDGS5NaQHHm+OeKCFmeIAl18jmaMIW6YxjrWHWOFdJvoiTBMNZbCoShwzmq2YIVFtizHJs+f6ihzd3ghTWSYb2D2Tqa2oOgYyttAgIH6TANQ5DYPggxvr4zBknipeke1AELsJQzkDRRpeV3UZVti7GUE2ZnAFmjEObhC2uZHXXB1ddvWMTy1+da+npS811Jr6CQiLzuaAewMJcVgvi8txhKMiqgGRHKoNsHEcdlVRJTWa3RqH8KMXfes44SRpjr/cZ++3s9+HUL6slyDkedGU5mIL+eGvSjjBTartWzw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(346002)(376002)(39860400002)(366004)(136003)(396003)(451199015)(83380400001)(186003)(82960400001)(38070700005)(122000001)(38100700002)(5660300002)(2906002)(15650500001)(41300700001)(8936002)(52536014)(55016003)(966005)(478600001)(53546011)(26005)(9686003)(107886003)(71200400001)(6506007)(7696005)(19627235002)(4326008)(8676002)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(316002)(110136005)(33656002)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HjssKGneWaFkMdZsk2oKmkOiPWYBbKZPLWWS1J22n14iBJdPaEkK8zv80p7h?= =?us-ascii?Q?BIJ8tvSDHYG/oSsR3E4563opkJW8uhvyOLvyV7OYdZPDgHKpVxl7DUFZ/ip+?= =?us-ascii?Q?FA7LnsJ2geVGReRQTZx3PLYjew8GOemRHuJGoCpnXSUnOPKxKbIngNKelmtZ?= =?us-ascii?Q?Rduk2MeE7feHW+nK24mKcb9u38bNGr2WvXCyt+Ixc60utVcuIkJUCSBvpzb+?= =?us-ascii?Q?Cue8fTeVIXg3lRCzZ15JhfkYfGIG9ln4zni+HKMRTeWVSX+lp86izTYJmW1S?= =?us-ascii?Q?5pCQqta9XeItJc5eQZ+Ii7Ch5eJNDJY6P/lvjmfjZEl6sTP/yc2NlaXgs7XX?= =?us-ascii?Q?xecR5TC7DBZBL7Vs+DxB59/I3KVUjhGEg+jUDF+ZLkXfH/j1tu52ZwNZo4WB?= =?us-ascii?Q?uNXC6p4/xqaihyJvYo2qfQ4sFottXhP6ioGbUdyQoECD/DeHxID2VpMrQ36l?= =?us-ascii?Q?wRAnhMdXB1pTVr6vAVMnztSkqd8iKgiL15pltr8um9Y6BWV5+1hdCixLkBVg?= =?us-ascii?Q?xd5oMMEfiBc6norIXidv1q8EF7jr7DdRUSkXvkFToWMJvuoVlCtbV5HVl+LV?= =?us-ascii?Q?39LQlbepMZWlCYSe71QHaanwjFvFn/6YAUoLfRS72l2/j6zWiFrBjU0fr9JF?= =?us-ascii?Q?J/W9fzxTnx5cLMep5hPXSKIV4b7A6uaHtNUF8Hk4MmbMeg0lVXT2NEi0eswx?= =?us-ascii?Q?fSJSpj/NgtDoBq8I+uAQROo9fEd0fQ2SgxcrJK+lRLFF5Y/8nZnZA7EUwXOt?= =?us-ascii?Q?MILIw0WYFnhdrayxVTM5EstxVOQIcKBtKogphOiJaZz3RjvacJ5Dvr9MFEW/?= =?us-ascii?Q?xo/VWNPbFkoL/a8IqosYr2iJKSfdXvezQGi7mpBE8L0sQIern1ZBO+Spi2aY?= =?us-ascii?Q?6G8UkSBVfoT9+mB3VTeiV5lqjzlWEF3pzuYb07EfPjcuLqp9VApdG9E2J3z0?= =?us-ascii?Q?cYl3bSvJf946Tq43sZ/BQTpNykWLH9YJyDsDF2hkzjHNV8DWWoDko9b9qlBd?= =?us-ascii?Q?HJpEZO8z1R5LxIHC/0GmYOH33fYbz7ew6661wOPMc50hB4YqXrqdFDA14RS8?= =?us-ascii?Q?bMyYyqKO6cekorRMeAa1PJkpUsV1fGLhfi//fXe7xIlMIZMNdwsf+6gFX45S?= =?us-ascii?Q?zEmAXkURsLSaNcRhhvaALKIplrafqMpgeOXr1brDXM+4n46Y7GDN7N1ykEIO?= =?us-ascii?Q?m995dlONahvQ3BajpAeQsixULiTYYcqRvBmVzGxDC+JrtRbSoVz9xR1EoTM2?= =?us-ascii?Q?OpWT6cqdn9txHnbTvQsfvW/+oPp85g6wb4pfx0N1ifAPtRN+Dub62BnKbKYL?= =?us-ascii?Q?cr0oXdtD+1CSbHUPhMoXXSzcCozAl2pG4DbV0jNlPU0LIkb9RGEUCCaebQMM?= =?us-ascii?Q?dO0ysDYhbRdS3+3E4Pn1X7PKVPNkefp2QES6z8487bu4Fg4+WkYY3S2SkItA?= =?us-ascii?Q?0T4xOMQETFwn2s4nKadUgJZxVukTq8c+pYRJYe2IRFcpFSerKOQQdkJIxomC?= =?us-ascii?Q?lhiV4ih+sLtTmRiXhYzzo0LPzv37OQbbczRlgQcjU4uv8TKIe2hlcU32hEMM?= =?us-ascii?Q?2CSBLTDVPBbOGpWD39goUwq/z+9Ms6oyXpaQumCD?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb86438b-be3c-4505-b350-08daa2dc03ac X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2022 12:05:06.4188 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aMbRgs4/UQQtMlfl73F4Q1vNpNbT0+6E3Z8fwGeVeRlh6HAvVNKeDkmM3iT8rd3MTRFFdHt/dVtTnr5axrKvTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6121 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged https://github.com/tianocore/edk2/pull/3431 > -----Original Message----- > From: Gonzalez Del Cueto, Rodrigo > Sent: Thursday, September 22, 2022 3:36 PM > To: devel@edk2.groups.io > Cc: Gonzalez Del Cueto, Rodrigo ; > Yao, Jiewen ; Wang, Jian J > Subject: [PATCH] SecurityPkg: Remove enforcement of final GoIdle transiti= on > for CRB commands >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4077 >=20 > Following the design described in the TCG specification, > the driver implementation of the CRB protocol does not require > enforcing completing the transition to goIdle at the end of a command > sequence. >=20 > Signed-off-by: "Gonzalez Del Cueto, Rodrigo" > > Cc: Jiewen Yao > Cc: Jian J Wang > --- > SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 13 ------------- > 1 file changed, 13 deletions(-) >=20 > diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > index 840265292a..1f9ac5ab5a 100644 > --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > @@ -381,19 +381,6 @@ GoIdle_Exit: > // > MmioWrite32 ((UINTN)&CrbReg->CrbControlRequest, > PTP_CRB_CONTROL_AREA_REQUEST_GO_IDLE); >=20 > - // > - // Only enforce Idle state transition if execution fails when > CRBIdleBypass=3D=3D1 > - // Leave regular Idle delay at the beginning of next command execution > - // > - if (GetCachedIdleByPass () =3D=3D 1) { > - Status =3D PtpCrbWaitRegisterBits ( > - &CrbReg->CrbControlStatus, > - PTP_CRB_CONTROL_AREA_STATUS_TPM_IDLE, > - 0, > - PTP_TIMEOUT_C > - ); > - } > - > return Status; > } >=20 > -- > 2.25.1