From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.15948.1682586638239554531 for ; Thu, 27 Apr 2023 02:10:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=CHtwOPie; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682586638; x=1714122638; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lDdjVPCmkRoAomG2ZUOwqwjeIlNRHuzKbsr34Q2asso=; b=CHtwOPieBhYqE71bPL9MS0FWulFz6PxUClEknHP9y7nP0Z4bJkwJd0/x SaJWxIIxq5ib6VF/5kremarBQ91+bIlDdex0H9JBzhnzppPzHMaqoEnT7 o6vvNK67/P6mq1CdJQX/leBt2nzc3EHk7DXgiVGVRnX6Q2Fsrzx4oeMUC lq06rGhn8bweLZvds07CKl0L5tV+O+3hDUSs15QDBvkRRA3iBcbF8BI9v wVkAnhGNE9mTmH/dhFdTfqTsvGMVUr2dXStwkG7J5ZSRXlYjJmJDBzKjU iAeN6+YZ545eKpFP0bbgD+LmZdM/n4O8slNBkrcx33wilN82vcedASOR3 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="331632999" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="331632999" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2023 02:10:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10692"; a="724813631" X-IronPort-AV: E=Sophos;i="5.99,230,1677571200"; d="scan'208";a="724813631" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 27 Apr 2023 02:10:37 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 02:10:37 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 02:10:36 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 27 Apr 2023 02:10:36 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 27 Apr 2023 02:10:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gicodb6Uhl+M0e7QA9+t4uG09tQa8uAKsexgB60qmaoaYJ3Kc4mpRKH0fZhHc5tkHrOoNZpXTsn8+zsqoVNpt6gIRNQUoZ9KtIqW9mTLt2SC3LvZUAAmEuT98Zox/mW55eV2vVe24Uvg7/e4H7QdfwJWeNacncqgq9WpiINiSJdV5WWoJUkpigBi1CvTRorHfnGcloxX73swEV59vd4UiIRHyvK78wKaWLXZJ+EP/aG3C0Ve+pet/3fbiIIgh1bRdv055Ba46nh3S0Kcz7owghF6Ba3fnyCuzhbmfeMy8rw/rruK8iXipi/L+vQVag0p70OTmgeZzHJ9FJGayTt/DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gfDM6Gv+zrABgICuPtJVUvdnGyvyY5Kxk7A55ErdHnk=; b=W5jKesUBFhg7jdptqV8nSjsVF5hElNyz3nv4I/keMnHAvjXV3NuIEvKvgDk079lsI35rzW/qJiYLugaKcAlv/CpJ/H634QDXIj4aypIp71Nvq/hnjKoyouPyk8KHQrb6xSSdlHeeTVAK6ctpYmTF4hPDrspJmaNkK2Klf4xN/1u76QTp4Dd8As+qcuURGrDWbIrMWc6WxdG+4rrUtSoGN+a1U3rME9zSakCu5mASIpzmuafbXXaCK4Xld13T76oEebaeJxS0RnRgrhEsrcHVKFE/JzJ2tn2y0DVgp0p9MOnq6XSZZQjAO9lsxv543b7FF+wag0QKHcR27qqusgoutw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by PH7PR11MB6474.namprd11.prod.outlook.com (2603:10b6:510:1f2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.34; Thu, 27 Apr 2023 09:10:34 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::48e9:aeb0:c365:388]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::48e9:aeb0:c365:388%6]) with mapi id 15.20.6319.022; Thu, 27 Apr 2023 09:10:34 +0000 From: "Yao, Jiewen" To: "Lu, Pen-ChunX" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib Thread-Topic: [PATCH] Release build in GCC5 has warning message Wreturn-local-addr in HashPeiLib Thread-Index: AQHZeNXMJtPvBOVXr0GNyctV11trcq8+yAdAgAACU4CAAAYY4IAACeIAgAAEDTA= Date: Thu, 27 Apr 2023 09:10:34 +0000 Message-ID: References: <20230427065830.29735-1-pen-chunx.lu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|PH7PR11MB6474:EE_ x-ms-office365-filtering-correlation-id: 2f865e76-8f42-48f5-d5c7-08db46ff41fc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: keCO1dbqbHg9iF8L5hArrKwq6degv4u26upu8kkHhSGcgYpzw54mPdCsnUw5yGY+A5qUStnTrNQnYoMo2cLMvtCq9GYCUGLymIZTBNIE4qDpJEayYq1FfI2eNTvWvfU+4unhF9RXrxO7+oTiEHOSV9qbfjegV91HpQKlmmiKUPR5N1VaRtbEIJprYpKtjJ4jY7p31BrDwnLEiPHdqoGlmmnlIsggY+kU1h8y93LtlWU9Go2Yv7jdQHX3tANNGA31ges4sGGhtsZeV3dHjDVRRaUM4KNYdbC+tHY9/4FRuTVfwZRsO0r72mCUN5Xj2TX6HA//qGaEucLUV6iqetZg0l+pGn5j6cG2dlT1+k1lBlXdVhxbpCOaHyJmug4S8V4nKKIUMPUlBiQbzov7EbXpIw4ekH/ADQ6tT5SEfVNYOOlnlkCuPbu2/fmdZbEcFicgmHbF6pm8APHW4P44V77r3RjnqpT+mOSNwYSik+pylziTZotIaIyzgzJx++/cwgR9UVN2WPMgmwE5x6v35A7qtr90Av9pXppyW9Wk0DCL86Q2tWV2cS5lCJGyZo0nPnxCM4fkWHFFgPdmLb6RGxsyv+iKsHz3R0GiTBDTIxWb7erxzVJE3a6oXw6Oj1L42UYT x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(396003)(39860400002)(366004)(136003)(451199021)(66446008)(83380400001)(76116006)(53546011)(107886003)(71200400001)(110136005)(26005)(7696005)(186003)(9686003)(6506007)(478600001)(5660300002)(55016003)(15650500001)(52536014)(33656002)(82960400001)(122000001)(66946007)(2906002)(86362001)(41300700001)(64756008)(66476007)(4326008)(38100700002)(66556008)(8676002)(38070700005)(316002)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3DaXInvwD6ZWqsP0DgmsXThFbO3W5LTLlh3cK/B1In6VXy10dQNp/F067qgF?= =?us-ascii?Q?OXCzkEwdomskhNFXiH3KrUVn5DAhrRTBapHizGH3oBJP/K1n768c+iSrhuhY?= =?us-ascii?Q?9z1xiDw+/Z+ugoIdVozZ/7dXlPt9gyiwFKCtRmRwye7dTh9mYovU3yPfIecb?= =?us-ascii?Q?cvMylNlak0rNPuQV0gAuNA3Pe1vvCBKtxCbo2dQyu7giPfN6ZBesmRftf42y?= =?us-ascii?Q?6ze395Y6+CCt+SSX9rDm8ae/pT2NYESUs0BHuKrdvaZXZcIY6zUKC/3FomuZ?= =?us-ascii?Q?564SeFOo4gS6oM8EycTMStpZRInutun9FHOnb/KnrU2OsOP29I+STGkKO76p?= =?us-ascii?Q?OzO8NmfV5VvKMW64UcWBK6yiqFdAqjJoeqhKH6K5/B1rsRBAkVEoQqVV8Z7a?= =?us-ascii?Q?j8UfYAcLnFcw0UDmh6QVIG9gzwQBRp4n1DqxJmWxg2N3BBZNDbQan3lzHNXt?= =?us-ascii?Q?KkEzSir03E9Z1S2zJz/sn9IGaQJyxdOaKBw8C8R7GzYZ2UXCdj4UBCehwAzG?= =?us-ascii?Q?oegDcJT+Adbxs1Xdk6jrm0yn1njyY6zrh4gz4PDUvY1WC9g0PUcclD9jXk8o?= =?us-ascii?Q?FLbq8LfAUFFRXLJvfPqVpSNU3w0UpA1I4caYknHwFUfse7kr2OFMTv9mGm8/?= =?us-ascii?Q?vcUFrYt0f6wONbrw+B1ksl48HAbTO9kT7e4pAM0Jtxgu/ER72QQ6LJIMcygT?= =?us-ascii?Q?LeXOMeuZIvMFoWyXRb+JxGYS/FIMnXwpldzFPEE/UiCqj4R9M89gsKiUD1Pc?= =?us-ascii?Q?X46yyXXFRbRegnOITWGSCs9dk/892vpnFyt/Yfe5qqgrVFqOTmCMAtbDtHGr?= =?us-ascii?Q?xc79Nr6SxOx3coIvEp1gpX9oMkq+4gM/BNEKCQbeVF57Ems7NThs9tLWn+7+?= =?us-ascii?Q?FO12GxNSmFrJ19jurB9zfIaF0xMjzcZCmmpcSUTRPU8zRleCCCAOdbepPnZQ?= =?us-ascii?Q?DepKdN4gLZk86T+vQOlnnBmNr5o9b1+O9tALjENViZZO8zfMHObpKrWE/GoQ?= =?us-ascii?Q?vCzh8ZAEpETOWmPFKhJ5i/hUieXqmMWAhUaPsS7WW+3DaUpO6VnMDd4GCByI?= =?us-ascii?Q?YIR95eYamUUcGujJjQ89qYE9FbRvWkRwKt6DQihldQsiC7OfIbwHIEbGMEzk?= =?us-ascii?Q?9QiPivz66NlInzAEPZ01oA6u0UhJ6ehZbEKJTg8yxvT6YlWCLCZKF3LAwSjT?= =?us-ascii?Q?Dhwvg785vbVbSTVWCNyOTPBjh5K1lad/RVe17/FIlbNIsGdPT/BlofTk4VvH?= =?us-ascii?Q?ndPm9BxXtDt9Hs/rRAd5FdVn1NkD5NpEOw7UbTlvLmlKzS8oNASwZeFjw178?= =?us-ascii?Q?9Qre5fIkmP7fGV50aJ4bTrJkQrcZhJZE2IFU86/6moXJiNGpwGot/VpwMhDj?= =?us-ascii?Q?RQPQ3EbfrmtBJfg8AsvO8PwFA6nfFq4p9GHDgx5WOlQbjo5nOtkEimaoWAyS?= =?us-ascii?Q?Qc+6wQ4q6qjIashvnn05zyEHGAQT8b0MLr3VPmNwJ9IKdvy8jQXlViCZSWlJ?= =?us-ascii?Q?SuBMeH8bKGVk7TzoaaDRJwVDYzn5L3eE7mEVL7W2x8dDygrNcxyPfD2mvyat?= =?us-ascii?Q?bQ/SCuuN9FLgYBB4mI3NoeiwEVhsKd3S1M1D35B4?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f865e76-8f42-48f5-d5c7-08db46ff41fc X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2023 09:10:34.0581 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f1o3mS8tC4uLe3YBT51+YVl08hGQwEEQAoMT5xXDMyUiV0wfzTnm2DdBmBviek4tPTtMPMMKLbYLmz00xSV1dQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6474 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This seems false alarm to me. Unless you can prove there is real issue, I don't think this is right patch= . Nacked-by: Jiewen Yao > -----Original Message----- > From: Lu, Pen-ChunX > Sent: Thursday, April 27, 2023 4:55 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Wang, Jian J > Subject: RE: [PATCH] Release build in GCC5 has warning message Wreturn- > local-addr in HashPeiLib >=20 > Theis patch just wants to remove the warning message in GCC5 release buil= d > just like attachment. >=20 > -----Original Message----- > From: Yao, Jiewen > Sent: Thursday, April 27, 2023 4:21 PM > To: Lu, Pen-ChunX ; devel@edk2.groups.io > Cc: Wang, Jian J > Subject: RE: [PATCH] Release build in GCC5 has warning message Wreturn- > local-addr in HashPeiLib >=20 > Could you please show me how this function returns *local variable*? >=20 > return BuildGuidDataHob (&mHashLibPeiRouterGuid, > &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); >=20 >=20 > I don't understand the analysis. >=20 >=20 > > -----Original Message----- > > From: Lu, Pen-ChunX > > Sent: Thursday, April 27, 2023 3:58 PM > > To: Yao, Jiewen ; devel@edk2.groups.io > > Cc: Wang, Jian J > > Subject: RE: [PATCH] Release build in GCC5 has warning message > > Wreturn- local-addr in HashPeiLib > > > > Hi, > > It means the code might be possible return local variable address > > when we used the function. > > So I allocate a resource to local variable to avoid this. > > > > Best Regards, > > Joe Lu > > > > -----Original Message----- > > From: Yao, Jiewen > > Sent: Thursday, April 27, 2023 3:51 PM > > To: Lu, Pen-ChunX ; devel@edk2.groups.io > > Cc: Wang, Jian J > > Subject: RE: [PATCH] Release build in GCC5 has warning message > > Wreturn- local-addr in HashPeiLib > > > > Hi > > I am not sure if I can understand the patch. > > > > Would you please clarify what the problem is in the original code? > > > > > -----Original Message----- > > > From: Lu, Pen-ChunX > > > Sent: Thursday, April 27, 2023 2:59 PM > > > To: devel@edk2.groups.io > > > Cc: Lu, Pen-ChunX ; Yao, Jiewen > > > ; Wang, Jian J > > > Subject: [PATCH] Release build in GCC5 has warning message > > > Wreturn-local- addr in HashPeiLib > > > > > > CC: Jiewen Yao > > > CC: Jian J Wang > > > Signed-off-by: JoeX Lu > > > --- > > > .../HashLibBaseCryptoRouterPei.c | 17 +++++++++++++--= -- > > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > > > diff --git > > > > > > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > > ei.c > > > > > > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > > ei.c > > > index eeb424b6c3..bf7a5fc65c 100644 > > > --- > > > > > > a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > > ei.c > > > +++ > > > > > > b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterP > > > ei.c > > > @@ -84,11 +84,20 @@ InternalCreateHashInterfaceHob ( > > > EFI_GUID *Identifier > > > ) > > > { > > > - HASH_INTERFACE_HOB LocalHashInterfaceHob; > > > + HASH_INTERFACE_HOB *LocalHashInterfaceHob; > > HASH_INTERFACE_HOB > > > + *HobBuffer; > > > > > > - ZeroMem (&LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > > > - CopyGuid (&LocalHashInterfaceHob.Identifier, Identifier); > > > - return BuildGuidDataHob (&mHashLibPeiRouterGuid, > > > &LocalHashInterfaceHob, sizeof (LocalHashInterfaceHob)); > > > + HobBuffer =3D NULL; > > > + LocalHashInterfaceHob =3D AllocateZeroPool (sizeof > > > (HASH_INTERFACE_HOB)); > > > + if (LocalHashInterfaceHob =3D=3D NULL) { > > > + return NULL; > > > + } > > > + CopyGuid (&LocalHashInterfaceHob->Identifier, Identifier); > > > + HobBuffer =3D (HASH_INTERFACE_HOB*) BuildGuidDataHob > > > (&mHashLibPeiRouterGuid, LocalHashInterfaceHob, sizeof > > > (LocalHashInterfaceHob)); > > > + if (LocalHashInterfaceHob !=3D NULL) { > > > + FreePool (LocalHashInterfaceHob); } return HobBuffer; > > > } > > > > > > /** > > > -- > > > 2.31.1.windows.1