From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.4811.1663914705055265291 for ; Thu, 22 Sep 2022 23:31:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=dKKmNcxC; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663914705; x=1695450705; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uNOa6MWxXD28xJ7fi2E/YSSwUML1QooRCKi08gvsnHk=; b=dKKmNcxCr80yakmwAParc4FUYvWZOuMjUTM+UlFruih/PS7NZDi0bCZb W/diHRLXG7g2VJPuNxTWL9PJ1ZSCYDM/juOBqfOOUduycXj1CKfNUOayU 0EZtkXCvIjUGHz7BVrAbYSnddd/cPKujS1ni9LhBPe4t4YfrOVxOVc0eY 6UGxzs3EHYKxra58qHYACrvkjSh+1KHTb0pOzjqSbghAO/oRoTkL7ZMk6 w9rCEoqQX1YjeQuWFGAjdS6BZiGjGBiFC25dDhexyGpN48S3tTpMD9ri/ dznhp8loQP/T/+GYncPSelxnj+KB8xOR1dQhb0EEZQzmSrou10PJvSh4t w==; X-IronPort-AV: E=McAfee;i="6500,9779,10478"; a="364538502" X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="364538502" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 23:31:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,337,1654585200"; d="scan'208";a="571272195" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP; 22 Sep 2022 23:31:44 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 23:31:44 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 23:31:43 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 22 Sep 2022 23:31:43 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 22 Sep 2022 23:31:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XggCj/3Ix3ov5Fbg3XIKbblz/CrVrQGWHlUfS4TOa/O6TcW0MEptVpuIYQXA5c1IUmcp6Rc8A1zmli2mveZPUvDj0jb9mFLBsbq7TJ9W0aVIjmmzOa7uShm9ykP9PRG857IbcYU4cychMKcwF+tHgct/fzf5IxmLQoWM11psY4eZVfsixCLK8wVecIbUSwUpC+ARclVLnuTi9hpmggK/AImDuFmQTN13Am15pTeZcXjfRf90BjWM9++gm7g9xiaJ3/T1TJK78KXUKFeBfVB3c5IYvFRZPCfhpQw2nkdKTqBujJIT4dpNQnHRiRMYQZW95OT8tM/+tsnH0m8fnr1pzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w9MZw+JqtwIQKMSOWN/WDP+mHrsqwbu8TOKGFq0+Lj0=; b=lrvuzim58+wR7Jl/Jc/MFv+jLS3LD45xmdmdBgmckDuXJfCwl4p2DVaa87q3nY7cjp8wSm4kKZP5kSI5ZQJzzE2Rg9mbXV2c84LZER5J/HWbQdsRWLIPUsU5LaezB5SWOGvBT72eDvdwwtanYZhkQnMy89s/tCg0qE9duTIHZ2a5V6Ilz64clmFOOl097lQg4qW2ChiJ1YtkvcUSTJ8kKsZugvCf80LO6N9T/5YwM/tx4Wvzi2UMlHyv4oSn9EqYDFH0w1q/NihOCMUuldrU64qcxfMuoFNqgD52aQA7NUpoyW75AdrRcss0bWJyF2rmYWCcrZCna7K8lp3hyu/NCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CH0PR11MB5475.namprd11.prod.outlook.com (2603:10b6:610:d6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep 2022 06:31:42 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::c17d:f1c9:e958:b5e%6]) with mapi id 15.20.5654.020; Fri, 23 Sep 2022 06:31:42 +0000 From: "Yao, Jiewen" To: Wenyi Xie , "devel@edk2.groups.io" , "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" CC: "songdongkuang@huawei.com" Subject: Re: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init Thread-Topic: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init Thread-Index: AQHYyOVFji8FHlhyaE2Gx1IXSmeG3a3smmgw Date: Fri, 23 Sep 2022 06:31:42 +0000 Message-ID: References: <20220915092620.3341564-1-xiewenyi2@huawei.com> <20220915092620.3341564-2-xiewenyi2@huawei.com> In-Reply-To: <20220915092620.3341564-2-xiewenyi2@huawei.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|CH0PR11MB5475:EE_ x-ms-office365-filtering-correlation-id: a747bb68-5146-451c-ed9d-08da9d2d476f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kqzGGaHOWsKq9B5rpjh4cltjZufc7n9TPYolo7nnEYQVzKC3srj7rCJoHLC5YQbaYYkq1bKOR87gBx+at1N9el3JCB7YAcJvKqa9GPrxEsx9t3a0Rt3fa8lhPzZ47L+OceHJh5vWsv/0EBHjQYfv1N2aj/ouLSsGwEUuAS+J9q3fvONgsbmB0een9uGn3Iq4ye4WyN66qdfb1Ika8wkdgHAVIuMaNOpDXLqwe2NyWFZ5HYi8a4oYU/zp95XqaJRHlxP3Jd4PqqGVMYC74wwdsrBTF4KwfIdcKR3t5K/exsF7KGxWN3ZjMMsznRoj3Cp0Ut5juAWKbmyEHh2c9h0Qd58i5Yz79WosXcL5NvB5yMhCPdKam5EyIKUGCJo/WLpKDImeKN6nzNQ/kOFaj5TFMsyD5BTRS9Syye4HWRGEyWPPvN8PhN5jzr7jJl4mntCHAEJ7vjA+7HWrzC3JwlLfesRMPFGX3YoXb53F8IlGLxU/N2CrgzS4Q9l2FPFyLg4KgNKICyqkR9dT8rur1Qr541cvBmEVmiggIoRn/ietjSDlK0xzg3A38+nGJ0mmmtga7whqw8dDTagSzBUxg5ay+KqhYiDwWLWxz8WfEdjdpnfufgOH2JbPYXviztF3uvsxaM3Nyz00Wck5ukSJBFVTJdFmpT3vzpGvNe39Xzn6sbxkJbh+SC0hEN1vpjZN1m3TCYZotofTmBaLRsillj20iXkUozaAZFt7aQMSmMcyCW0jBEIShiHzA9vED2kNn0nzqMLySMl0u07XNQCVgIcFMx6QNRpJmfNOTDYPAZ5H4+M= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(376002)(396003)(366004)(346002)(39860400002)(451199015)(8936002)(4326008)(82960400001)(66446008)(76116006)(66476007)(66556008)(38100700002)(64756008)(66946007)(122000001)(86362001)(5660300002)(38070700005)(52536014)(33656002)(2906002)(53546011)(9686003)(26005)(186003)(83380400001)(6506007)(55016003)(71200400001)(7696005)(478600001)(966005)(8676002)(41300700001)(110136005)(19627235002)(316002)(6636002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IO1FSGpnOfHLP4KJW9ATF7xXyYl5t62wAU+0Ffvny3+dAwLVDGWAkOzQmI2o?= =?us-ascii?Q?hHyuZiJSv6guqqYjxh+Tp3+sNjdhGEyCK5OLmYSILGx4jIeElfoxo1A0zFj3?= =?us-ascii?Q?I+WTBsbzgbIkVdrDGQIPXjDqyCuPrivpJlQqPsrIe4XO8x8ti0dtQmFIXr6S?= =?us-ascii?Q?ec/ArgIFN38DTjijAw8lh4YO2Hex83crg6BNjstqaRTrKOlFVwLtOBz5MN0F?= =?us-ascii?Q?RXufExw10cxma1+jPKTrlXTZrG+RrvyLXEZi7tJ7hHRcYk7LKISd/XlcyvPO?= =?us-ascii?Q?TTBmhq2lGb49iXEKD1Y9JB0Z4rxM9q/oNtMBCkUK7q4OxzaKkD1fHWD3Lglj?= =?us-ascii?Q?jUmj+lUbz17zHAr81IsnA96R+jEkdfVM7q7kPiSn6SZreMnLDsXQqUMcmKCB?= =?us-ascii?Q?sxMPl9shRclQrlB+rsnZBOT883SySvcwXzl2osMlraNO4DqpV6RSABrblc+s?= =?us-ascii?Q?PtmBR2AdmvNVOkcKkSi9bjC2PiMqFPndillq9YVdnv69mHi3LF8ajmlMpGXQ?= =?us-ascii?Q?Njct5/DcfSg/+XMmAYm3pZhghb3FRkLgmAk/fSN0xNS69nPf6paWGvnoVFDm?= =?us-ascii?Q?sGoFgt8XWrYrwuOInDFI7+dokvr98gxAiEC4YhJEeceO60RV6I/x//VpZnr6?= =?us-ascii?Q?vxtUcu44G+eqSyxPtbrb+3ev5RB5QlyDE10/Nxvf4tvhgCFVUuEUHlm6svAc?= =?us-ascii?Q?omQVjSqDyX1fTvlbLJNPpgqYB+E+L4CtirUWSfbHi9POjPcpBGFuKocWjo2J?= =?us-ascii?Q?6sSzBA+N308F6H5o1v5TChZKruF8PyAr8PYnmhnwek1IGQ4eGdwEejj4nrHa?= =?us-ascii?Q?I27QmVa58Nvb8INib1fRId8ANwpTi0bIUyCMy2lWY4KC6PvfqoP+8B/7AP7z?= =?us-ascii?Q?6c/kP7TzWkCQA4Kqb76ZF8Xe1DYtOtUV/2wqQ2KcWClqvKHLTo3riRuQlX8B?= =?us-ascii?Q?/oKCR5KcOLdeD4g2vjBjXQGI2vE3cp52P7Axpx3VvQw+jToXIS7A5xzVBvN7?= =?us-ascii?Q?GP9bC5hoFjdQqqXFIh+p6y6omaLnQHuS78zt5NL/QsbVNxhNFbrcEOjToFhq?= =?us-ascii?Q?RntTQ2adeQRU9CxuLSv2m/UeRv0lPZnhm+jrZYhFLB6kTMng8MyUfRdBN2jM?= =?us-ascii?Q?UuSG5LMVcI1ZwI3GL/VY7Dqc5w+fM5d5/ktII/0+jNBNMJA/P3TOT0mSJmM0?= =?us-ascii?Q?DJr4yAyXOP1X8PUa4jjF7Bku1OgObYjkJaLCKM4mB9GXQbb5EJRtti/3Xh9N?= =?us-ascii?Q?fnMWaX50BcdmxAvZqP47IkoE5cEI+o4ubhkq673dxwd6+zcEfyWWNlT5CPIh?= =?us-ascii?Q?pIFFQN+papTlOqRR97wtdQ2pdx7fO4eid6UYoUwAZJdgCS5b99oMAVSEWZjh?= =?us-ascii?Q?9sxCSfWn6VLPtLU57ZN0Q2KzSeCBrJZ4mCklNJVHS7dllxNdF50fe9SMdFzW?= =?us-ascii?Q?Nvb34YNg9IQ1uXXFsyuQWHVHPthm/+/rh0Sel12BOgAVbUF9LsGEAfaQWaay?= =?us-ascii?Q?9ttc7b/v2E6k3keqSps+WQc/uO32uTKw0vMEVxP12bAYcRzd9oEAdFxCd3tY?= =?us-ascii?Q?JtCkny0wxHfU5cFDSkxpASaEq9+UOybwfbomPyTn?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a747bb68-5146-451c-ed9d-08da9d2d476f X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2022 06:31:42.3172 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J5rRbt9XdYvEgIwMoZe/8aerY8t+cKxOrfH/kCIQsNXnM+lhTKsrHOsgyvbSPm8CUAV8Lt9PCa2bfg7EdwSl0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5475 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao Merged https://github.com/tianocore/edk2/pull/3356 > -----Original Message----- > From: Wenyi Xie > Sent: Thursday, September 15, 2022 5:26 PM > To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian > J ; Lu, Xiaoyu1 ; Jiang, > Guomin > Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com > Subject: [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant > init >=20 > CertCtx is used to be defined as a struct and ZeroMem is called to > init this struct. But now CertCtx is defined as a point, so use > ZeroMem (&CertCtx, sizeof (CertCtx)) is not correct any more. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Signed-off-by: Wenyi Xie > --- > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c > index 3336d2f60a6a..f8028181e47f 100644 > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyCommon.c > @@ -502,8 +502,6 @@ Pkcs7GetCertificatesList ( > OldBuf =3D NULL; > Signers =3D NULL; >=20 > - ZeroMem (&CertCtx, sizeof (CertCtx)); > - > // > // Parameter Checking > // > -- > 2.20.1.windows.1