From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.16587.1673019561217081847 for ; Fri, 06 Jan 2023 07:39:21 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=TUkogNRJ; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673019561; x=1704555561; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=F9TDwchSEYYtP8BxT/Uupi4qBABCJU2rThRt7sbXAsg=; b=TUkogNRJzyAhgN172PwJyQdBDBq+QipGX+V/STlLJ1vJYMqn1FxHP3/G r7WwOLoBw9T9O2Aoywx37OLhwD698pKNFKYCs2ZwFq8YQ3TdUEvG3LAXo 5rDnYBj3hjogQuc6A4mI9xqkjLUzwFBMWkXXHxdgB4l06KCRhfHhu6uOo LbBiThoVIj/Lc+1+OmGTilgPMLZACUGQje1BE1OAYFZAJJzBh5C0ts9sV yYiSaknI2+gqDdlUZsjYIY05a+71EAJuOT1l593t7SkSPe2rPml26TmcC xhZ7uC/qVGhJPVAaRc02wFrr69UJ+v2NCFKXi/bR/7q5aRchLDYuS6ern g==; X-IronPort-AV: E=McAfee;i="6500,9779,10582"; a="310287056" X-IronPort-AV: E=Sophos;i="5.96,305,1665471600"; d="scan'208";a="310287056" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2023 07:39:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10582"; a="633516550" X-IronPort-AV: E=Sophos;i="5.96,305,1665471600"; d="scan'208";a="633516550" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 06 Jan 2023 07:39:15 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 6 Jan 2023 07:39:14 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 6 Jan 2023 07:39:14 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.46) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 6 Jan 2023 07:39:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mVX7nEmM+oFsZ7bzZvZQ3+fVgCeux4BES74mJEMotP7Z62wii0hMnSLKIutm5NVG5QXj9XLs5LiMWutffcA6tlaf63UI5E78M8ElR/5im9pVty/StdliOOTLuWRYvy7OvRTBiDVyVt9Y1uHavyhlhxmHdlmqMN5l6NcLALLo+LVQagsOE5pM002YQFxUab7OjeDN/8ltNDfEUOWii4W758kHX8qkgMsl2EjSeh8FSBSA1ad30EvYMGzAg1IilqxxUcY2KRRIbYgpMHEaNXGzPyQbvE93OyS2fBJOOvC7YtsuOSK69M9ZJfoo9W1fE/+MSMONF7+q8d6F9ZgzMKUkYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c58u4tX9//EcDU7iGtrU1SV5iSuE6++DnOwEqegnA0s=; b=Z+jidJhfmVrfMzQWOCXYwVY7dsk//3KVmzjv/Qx98m9kHxTF2WFUyf0ipQHLMnUVIrNCQBSvCO8coN9XGQtC/WG/7hkZxzG+repdhoEh0vXODuYPwR48Yr43ixlC0aFGZ1zqqqGGL61yjDZFbymhxxmuFx9IvUpmddORDlCFg19kXy8iT915ayIA4vdQCLQ4+EoD+OPqsFlFsUENixb+174tnSw97h0YQqxiGFO2FsvORfRRVb53k7ITq9An6ql2xtcYNrGZLaKM99QX/kyCLLyf3ssdZLhovWRi9G7WMZzHQ5ngsCvh5f2C9Db41LaMaGba7NbJq2csD++Huln4Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CH3PR11MB7819.namprd11.prod.outlook.com (2603:10b6:610:125::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 15:39:12 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%9]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 15:39:11 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann , Ard Biesheuvel CC: "devel@edk2.groups.io" , Ard Biesheuvel , =?iso-8859-1?B?TOFzemzzIMlyc2Vr?= , "Justen, Jordan L" , "Pawel Polawski" , Oliver Steffen Subject: Re: [PATCH 0/2] OvmfPkg: check 64bit mmio window for resource conflicts Thread-Topic: [PATCH 0/2] OvmfPkg: check 64bit mmio window for resource conflicts Thread-Index: AQHZIeQbO78dRd+NGku8+nyX5+twrq6Rhc5A Date: Fri, 6 Jan 2023 15:39:11 +0000 Message-ID: References: <20230106140403.2889131-1-kraxel@redhat.com> <20230106153218.uxvl6vttwes4k4mh@sirius.home.kraxel.org> In-Reply-To: <20230106153218.uxvl6vttwes4k4mh@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|CH3PR11MB7819:EE_ x-ms-office365-filtering-correlation-id: 9ab60410-a2a7-4ad0-cb10-08daeffc2858 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 712hX6RYoBDgRFYzJFF3BPOQ0plx1GJMjMrlHrvb14ezyzWWmJ5YF3B7RxCsDS09N2aT7DKQV+wi8rrDvqcD6j5EfyBN2BzanJ6wI+1AHt4ncfq2Y+MlV4UvjOiBZVkrJJFe6LL2Mt/Kl8Ynlqd3jm2/uAXwmjy0OxfhamwB4QzNI2j+beUd2xyHpOQFLyPaALEJXLQZo+fkdhDERgpH+zjrnrUFpu0qi2mhleVHZCF8TY2fuZDuIVgjuJseFkTxHZSKx5JtiDIuwX52K/wk8F3VJHjzYXOnC9FvDkp/Qjc95+28XCR8WS3P0Z2Cr2eGLAHs8Py6I/t1Uw+6BiII9+2euaWnabXCEdDFwJuAjl7LXEfT1jQdVtaJw5HLAmTFsqyTPRVUdhzbM+pJNMBPdzwez/Ilke8HpVPS1CIdXUw/AbVmvqoLCowE+MiAArA6jkpdSQ6aCa7qzDDlfVsF6UO69mGK74rTTnEYPBKHoH0FTpd+C3J/wuJcheCy44VK6aNOGLCpjkXadLIPraohFT/vQnqo2Gzj1OnaC08DaSAjmJbQYoY8EubXJ4HRCT8hWB+GIan4c0ohGlVDjPV/D+ds4wzJY6BfPnOhl8gevEQ5ATij2NSPRQ4tuqsj3bh94GSj5/j7nXaxpHBUVXWtsLkAspkn/sa9OaQTAzsD0WEY8ds3V+/zRvys1r32CsHkFJBltA+85+N+h3qCR3JjpURo2Qf+mMC0DDQP0Nhgoz0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(376002)(366004)(136003)(346002)(451199015)(8936002)(83380400001)(41300700001)(8676002)(66574015)(4326008)(82960400001)(76116006)(66556008)(64756008)(66946007)(66446008)(66476007)(122000001)(38100700002)(52536014)(2906002)(7696005)(478600001)(26005)(9686003)(71200400001)(55016003)(33656002)(966005)(186003)(316002)(19627235002)(54906003)(53546011)(38070700005)(5660300002)(6506007)(110136005)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?tLYXp/opIRkeGukOswu1ATTW43AUsrxguMvVAzENWPjE16SCMINN96c+7t?= =?iso-8859-1?Q?8aocQ5kHN7oCOI8YKu+WhDWeQw7NnWI1uvddYVUde41bNF7ghQzs7wZbul?= =?iso-8859-1?Q?QAwRCSRaHUEMYUg2vjWnximpimdlXVMZAdFdO4BwjfyvPgkOVG1uCgHqRm?= =?iso-8859-1?Q?2hMq89HxUd8lwE9rVX7Ad+Zs3Pj2jtIXK51gWM1OT8CSYUNG1Yd8CDRVR5?= =?iso-8859-1?Q?D2CWXwEOhoL3CXOZPmML8Rjii8Usvb3fkIKyhNpB/m/viOjQ2rDDF2tvRo?= =?iso-8859-1?Q?UZVz/y16zqgyqS0/qoTk91mPTwpI44AqfyGgbe4ce+KQhepuRZCeIs0vDN?= =?iso-8859-1?Q?5Sp4s3mu2ib/kBJGUqwJmzhoNQul9D8gGVToa5BZGEEWuQHVd4IDPnvPJa?= =?iso-8859-1?Q?ymB2j4vfOq1cNYItMv4qgVkZ2vu7Xt53WES59vEExfzjYCCTlwdLys/S0l?= =?iso-8859-1?Q?F4SCcSqKvgBK9oQUuGYLiAFEEIQVdwKGTJ+Czl8E1gV4p91E+KA6ev+h3l?= =?iso-8859-1?Q?BGKg9cYt7y1mCM5gzLaCVTn5ti8z1yNOadRHZa0Ex1c3SOJP565ktIHpzk?= =?iso-8859-1?Q?mBc/itu+8EDri7RgvYKWuF2Fb8XCbbGIUvzXa0YTN1JVs+sfPvxHF1D73F?= =?iso-8859-1?Q?87cBsk1fWQpK+bhyJMSXcA3+sznmFoVUncOlUaOYb67WmG+9W3T6osNaac?= =?iso-8859-1?Q?IENjkoGHZ5PWarSkJQ/aWgftU6fmiHsZ0E4bf/kxztrWpFmrPFThfZSsGy?= =?iso-8859-1?Q?CHG2ohX/DRewg8VKEc8WLGim8uZwkaERlFRflcCXz4aSCNkpGZON1/BXoi?= =?iso-8859-1?Q?U0B4ECJb4ZXzUXzIwHgcWVokzd98JxtZ4t7dmbdBMiXOLcvSKJhCvrczFG?= =?iso-8859-1?Q?ONe5cLafe9bA2WREesOa8TROMFIQWYg7DQv1z5SPBg0UOJ0SeDDU/nMuMi?= =?iso-8859-1?Q?ojGHvvw3a48P8p8hyG5ZYSR3Yr0XfyIMDHfZceZLjsOosvUwArXKWa4RH3?= =?iso-8859-1?Q?8+/1EMHCeVo6vL13wjumBIV6RXe/GYEhbr6R7Paau9ir7l7ca1I8j7pTX+?= =?iso-8859-1?Q?GSZ0bO4S+3rzW1c+RTeQoORz/7LkCldN8FKzmEDWiGTcWs37gY8Mkh94He?= =?iso-8859-1?Q?xfON/4dhVmL/2PYlM32xOjGo4rw8E/tMlSfQBit+jVICMmL6yfCjjB/iDl?= =?iso-8859-1?Q?quk0UtvricxNJ7iBdnTvX1Rlw1qhZGTKM8q5sbVT0phSkTZFf89Q7P+Qhf?= =?iso-8859-1?Q?aZdnUR3pQUMo3/eGVQ7RJ+WqkcerIzyfgHzlPAX7pW+/QRHAUZBM4Dvwuk?= =?iso-8859-1?Q?dRInQm3DmmUAEkJZbAC5+oBWc/TG7o+990E1xf/7+w01TWL3fccavm/h7S?= =?iso-8859-1?Q?l0VcbjhkLgxPCl4mlMO2acub2436Ek1k6gHaVYvTBaHNiT+7BMd9S+K9Zi?= =?iso-8859-1?Q?lMNZ0qszZgYEaqX8nKlUflQz/vvpq5sqprS9rTQmAJKmgt6a3zVXhkcbKG?= =?iso-8859-1?Q?lPi8m1BYKkg8uAdU0XaFy6vPSfYBsrqCnf/SDMWSlT/n5KeeMVABUFxi6A?= =?iso-8859-1?Q?Iz9FyVE8n+WUtbu5hnL+/gK5fph36vNoTyUxV+xE0rM5MwsXMc4YJmOywJ?= =?iso-8859-1?Q?VCnGkKlrBpgcMN+r5yzCNYtov1HYcxh74R?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ab60410-a2a7-4ad0-cb10-08daeffc2858 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 15:39:11.3582 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ymIDzCln7VpBbsfJt3pXl+jFpPUDnMwsy1CmhWJiQkIDRbvD8BYWXy/mUrIzc0+n7wOuPucSux3McPbXGSWxSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7819 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable I recommend also add detailed information in the code as comment. That can help people who only reads the code directly. Thank you Yao, Jiewen > -----Original Message----- > From: Gerd Hoffmann > Sent: Friday, January 6, 2023 11:32 PM > To: Ard Biesheuvel > Cc: devel@edk2.groups.io; Ard Biesheuvel ; > L=E1szl=F3 =C9rsek ; Justen, Jordan L > ; Pawel Polawski ; > Oliver Steffen ; Yao, Jiewen > Subject: Re: [PATCH 0/2] OvmfPkg: check 64bit mmio window for resource > conflicts >=20 > On Fri, Jan 06, 2023 at 03:14:53PM +0100, Ard Biesheuvel wrote: > > Hi Gerd, > > > > On Fri, 6 Jan 2023 at 15:04, Gerd Hoffmann wrote: > > > > > > > > > > > > Gerd Hoffmann (2): > > > OvmfPkg/PlatformInitLib: update PlatformScanOrAdd64BitE820Ram > > > documentation > > > OvmfPkg/PlatformInitLib: check 64bit mmio window for resource > > > conflicts > > > > > > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 63 > +++++++++++++++++---- > > > 1 file changed, 51 insertions(+), 12 deletions(-) > > > > > > > Mind adding a teeny bit of context to explain why this is needed? No > > need to respin or anything - just want to make sure i understand the > > problem and the solution. >=20 > qemu reserves some address space below 1TB when emulating amd > processors > because that is the address range used by the amd iommu. This avoids > placing the mmio window at a overlapping range. >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4251 >=20 > (guess I should add a link to the commit message ...) >=20 > take care, > Gerd