From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.26697.1649661996662507289 for ; Mon, 11 Apr 2022 00:26:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=JNJlIWBi; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649661996; x=1681197996; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=YpW635TJnWfBGbBeaCbE6MRGcXhRc1n00EUgp6YCXVA=; b=JNJlIWBiJSINYf4IfQn8JkO7lwlFrY6jXuIjvBbFG3w4iz0H/TZtTdMu asj8gIaFeP5pobPqZWiMUWK/QUHrB7d3EvFtomHLIFhHDC4RBwZcRfIU0 m5NE7OLl0CPyf4bSL9BJxp3Hk+6xYjVQneynnmOfc/UyBrwQEQ0WjadwG AUfnvHFrHNzigro2SIQhV+3/Uj4umW2QEfXVBuDSe6F0XnYygQLtFgxrB 0x6RLMfS4tBf8ypoIrcDArZd3IiIsXZ4zNa4Thh6fjPhd2YacrMsVgX71 rfolDCWkQQLmo22UBnZYfftV4VrAoHeRY+JqyiR4aVS+h31QVlJZRlnbe w==; X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="259648407" X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="259648407" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2022 00:26:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,251,1643702400"; d="scan'208";a="551021122" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 11 Apr 2022 00:26:35 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 11 Apr 2022 00:26:35 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 11 Apr 2022 00:26:35 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 11 Apr 2022 00:26:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=obWbiEIybmKSnLy2DhNAfNldSRweMzARbkBHzDAA372YhoXYdJ0jxI83+e89nqcOfj5ZpyVM3rLxwGOdXz6K/X18Ev3X2Q0fpMZE4D3Plum0If+2+6ILJpou4nTvcagLkRH6L6raPSvgSrEomqCZ6iB1f8hal+jQViE2uI1PFhMxzhGtEHFXEGZcslvAM5eiAcE+VsC7vPLZySP4kpxa6wC33nTAEqsvrtWOKQcFxK+sYTF/W8ov1prwCbCOV8wQwaxA7XQeDDPFGVJGitaWznFZpZ86dzlBXCY1vxcCXMmyt1LhWv453kH1DL8JGM1aYTfKsr71U2jf6/BOl0GZTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2XecU7sadIgoeiVDCCaRfofH2eCRRP6ZsdhpZXo4hyU=; b=lysW9awTgMlm9ROKElxzFBjdhKfvmmQBp99MKLlXngPybDJUTGi9Y9JcV+rV03UkJxgP/pd8zYH8wi/OTIfLuQxf/WELIAmDM5UYkO+9uxBfpL3JI0jpNEH/ZLHqeNTLLSnk4Bu56i3eCwik1IW8n13xlAum9WhEvSByp9ZBLpJx59BP3ACzouMrUaVastABUaftr518K0JsxyfO/0Ea9xkthbW8M/YOFkbTAM/TwD2xxB9HvP/1yst//henLABNcEuwDNp6BYPNn4P5CcLSDN0SWRmTF07aFmY21Q258Bjnr0+r2aTkchUa9/6ii5cLR3pruEzMwUXQRcPn0f1kRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CH2PR11MB4214.namprd11.prod.outlook.com (2603:10b6:610:3c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Mon, 11 Apr 2022 07:26:32 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::198e:ea23:c83b:b93a]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::198e:ea23:c83b:b93a%4]) with mapi id 15.20.5144.029; Mon, 11 Apr 2022 07:26:32 +0000 From: "Yao, Jiewen" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , Oliver Steffen , "Jiang, Guomin" , "Wang, Jian J" , Xiaoyu Lu , Pawel Polawski , "Yao, Jiewen" Subject: Re: [PATCH v2 7/8] CryptoPkg/CrtLibSupport: fix strcpy Thread-Topic: [PATCH v2 7/8] CryptoPkg/CrtLibSupport: fix strcpy Thread-Index: AQHYSzoovlO5DkrEO0mGjvDLm0+NGazl7tEAgARd5ICAAAdnEA== Date: Mon, 11 Apr 2022 07:26:32 +0000 Message-ID: References: <20220408111622.3519517-1-kraxel@redhat.com> <20220408111622.3519517-8-kraxel@redhat.com> <20220411065843.i4m3dl4u4pdgqfp7@sirius.home.kraxel.org> In-Reply-To: <20220411065843.i4m3dl4u4pdgqfp7@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 70f12569-2250-4dcd-a4fe-08da1b8c9a2e x-ms-traffictypediagnostic: CH2PR11MB4214:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iWtfGYMFhKmcVBkcU/D13fTbN46kT126tUMpH/GqeEYfCdHollGZWgyLfo2zJeWW8lENk4w209OVNyRles9k0hIui3q+Z+1qCWqT5rr+LXQE0AvsoPJKlT6bZ7NF72I0+jN/Ir0qVQhOo+PU+frg3rpmy7Mlt4HZrd+ACdRnY+yFEFUfGafEIo2G4XkkyWQQh6a22yMrGjFjVQrrjCzMGL7R6bEfLMFv1b0NIcRh4D8WzV5yRsJEdXHjLb6D+/C+bcV3XCZ+maMSrNslvRR9WouFn4/c6BBRIahyA6PFT6kfFP1gfleLmo5P0RUjtuxfDZxD7Lx6aHx6wWsbfX2m6kI7Qq+nFrfG/ni2/EtCB4AvXZ5ks2uwRQ3D4MQn0IUNkADvYlIGEWqvpiLnsmPmZCJFepkarR0lcN9YBDtXS57hGuMNJWIqJzjMhgTNerm6/2D/hSw8vkqvptkos1Y4wB0/vHKwWJsEiY1+JRhACfKsNCiKUstF5Wg59KGPCj7mmrsu8rHqfRFi9U7KfFjH2D2T8x8rGHeNIvaPKtunDuIMFO+9oGtpoDtHrCAcPYBwgPDjDfuWPyWw2ZXHZTLCLILOmMmxBYXt1qDCMHRqmWJXscClFOqQ6Zo49/dRDiL0PfugUAdc7pIMGAmi1yzGxOZx2x70OYa4O1/cOWr1iH0rcqyJ3zofXsM/oIyVFmOFEdL6EXDgKr8F8jvVervFVQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(26005)(186003)(38070700005)(6506007)(7696005)(83380400001)(52536014)(8936002)(86362001)(55016003)(76116006)(64756008)(71200400001)(8676002)(4326008)(66476007)(66446008)(66556008)(66946007)(82960400001)(5660300002)(107886003)(4744005)(122000001)(38100700002)(508600001)(9686003)(33656002)(316002)(53546011)(2906002)(6916009)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UMIxcpm7WheSiIRlX58tTrpiCfGeY5esu7O47xRi5jXDAYI1ZcfyG7HZxHiL?= =?us-ascii?Q?lBgXCIYYkJZLoQYwIc9PJh+k+O6Uf43ryN5I8QXpZJqIS/j13W1i7Rk7SGPE?= =?us-ascii?Q?tOHlTtoV3/Z8hPsg2FesoCjVK0/mCpxpqLBRoINTlIw/N1S2oNDw1OFHyNDD?= =?us-ascii?Q?9nyr5YwAqVjfDyM93PCweFS9ey/WCStzipOGIhQqN3l1iKm9zd8Fj4hwGWVE?= =?us-ascii?Q?W0OYlZC0oXYRIVkP7XMV/8ZcNhXGs9X4BmKLFiiVG34UlaY5HubS3VxVKp1q?= =?us-ascii?Q?eeRQvzHGRKLzWP/u88UzhQyp94idjvk67M0R1DiTkQ3G5+a5RIvuvV3xYd98?= =?us-ascii?Q?OdErRHnTU9gLF/ldudVJzoHTJYHGiYxeClBXkW6VlS4PfHq86W22B3fzPVxx?= =?us-ascii?Q?wepdxO3E4o9akHmu7Vn6nxRcKCym+38peQHuXMvyqfiTqEDvFHWim1d7ZXoD?= =?us-ascii?Q?peGNR1DfrBV004j3DOlecV38fVqI0TCWXBTGvgQa/hsg03REailCC47kzmhx?= =?us-ascii?Q?fal/X/y5UhfJ9vb8cUS1Z/Uaf5WMB2u9hO6JdFWRcx8RrzTJa9sXuU2Xw6oy?= =?us-ascii?Q?ogShZsqO+xQWHasZzGaNsFLmRg+JmnQ7RHMgWzv89tVcNeskVo3ld0F5ETLG?= =?us-ascii?Q?vN3Q0zjCJxJ35FrRAJmYScWjESLH31YTr33iKhd8YbheRlLeiy/hHeSzI8GM?= =?us-ascii?Q?7EEagedl2vSPvX9shTxxuheGsQJXfCM9uIp2Yz6HrtjkzpthD0Z0d8/iITzk?= =?us-ascii?Q?zJ/CZpLJjtf0pW3jlYVqlmxgc825MR4OmXASV3PyEXG+ZoCUIzg+/TxfG73a?= =?us-ascii?Q?JB+mtIXkmnjD7VFa/IIi0q9Zslo13yMwfRoUJKwIHG+1GFYx0N0VQ7RUAGXL?= =?us-ascii?Q?ZwQreUTzmDjAgJsRnsag6/gqjMAv1AoDPYtFncM62YdWCYen1SPJpMyCW8Rg?= =?us-ascii?Q?Uq4sZVUX+JeOROWbheUT3SWZfPgPLIOqla9lfBPhLRKoijZQHdf1WBneEeS1?= =?us-ascii?Q?v5NE1wp/2q3a8Nqpx3rVM6fY6QazDSd4BNCWD5vLF6NxRyvefF5jrNxwnYBD?= =?us-ascii?Q?9KH9u8KZeoBTHw52fqu+nii7xpZVsGDx+p+H0gKtR8VughgZNrM+PS/jaf6S?= =?us-ascii?Q?EzX6xsS7U9D15Ue+zsBi/Y1irlXt3WvPIagId3R6D5SDv5vfc7/1iLmcugdw?= =?us-ascii?Q?KeEDf17gTfdNEIo192Zp+y2Uy9fsbKZqXBSITKZxH+WdDMXTk74HT6m82lZW?= =?us-ascii?Q?11lrjCj0Us2+HjhXWht/ZyLSBCk7QBHDXVhHdJDh/BgGShB3aWt3xlYNOkCf?= =?us-ascii?Q?dXOcrU9EijFn+lPcCJZtN2qf6XRY+rjaTDwWhWuUYFADlHzYf3xGfF6L932M?= =?us-ascii?Q?/izZbvBM1hvOJg3Jz/dzscr8dkcdVtvqrokpNh3ug0miuHeg5PZ2wp0A6d1J?= =?us-ascii?Q?HOrIjImtCyIK4q9x0m72yOAIJp+HmZTO2E0B1v5ZdFtUsS7ERhPSv4yacEJy?= =?us-ascii?Q?gVO3G0wqPY4YsqKm9whgF7C7uhsCuhHLoK56ADIv48XtaV/t1psqkd3zOuSy?= =?us-ascii?Q?ezlZbXZeRPKhd+2rV7Y18c1nYqT0pTx68yiDL57p+pWBGeBpPyVmnHah2ieH?= =?us-ascii?Q?c+pb5dB2UA8voEbzQvgp06y/3EFuiKi5xgCmT6p55gdqaN2g/SnUitTxqvOy?= =?us-ascii?Q?2bItHSTiyAygw6L64OgirZJzuVZib2KBe52C8cingGZGhuIF1cd7fLeI5B+I?= =?us-ascii?Q?PtH70/dX+A=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70f12569-2250-4dcd-a4fe-08da1b8c9a2e X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2022 07:26:32.1528 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 71ZVSY/Fh4wzAUm3XMx6IccTnnZDn4gD6Vj27x+dqjuie9dgnEPntWM+xOtHA25PDr/GBsR5sKjVw1KmaoSUeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4214 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable OK. Having implementation in .h is not allowed in EDKII. Sorry, I missed th= at. Please move it to CrtWrapper.c and drop inline. > -----Original Message----- > From: Gerd Hoffmann > Sent: Monday, April 11, 2022 2:59 PM > To: Yao, Jiewen > Cc: devel@edk2.groups.io; Oliver Steffen ; Jiang, > Guomin ; Wang, Jian J ; > Xiaoyu Lu ; Pawel Polawski > Subject: Re: [PATCH v2 7/8] CryptoPkg/CrtLibSupport: fix strcpy >=20 > On Fri, Apr 08, 2022 at 12:18:17PM +0000, Yao, Jiewen wrote: > > Can we remove inline keyword? > > > > I don't think it is really needed in EDKII project. >=20 > Well, in the header file it is, otherwise we'll get duplicate symbol > errors. >=20 > We could probably move the implementation from > CryptoPkg/Library/Include/CrtLibSupport.h to > CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c, > then drop the inline keyword. >=20 > take care, > Gerd