From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.15686.1655040810510766216 for ; Sun, 12 Jun 2022 06:33:30 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NCVO1y7C; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655040810; x=1686576810; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4mQPu6qFLQjXX/6T8Qgwh9A9g86L87KP5FLus/rgJ2o=; b=NCVO1y7CQmb3zXkqRJDLTvm/JOubHzT9PUEYT3BMuOGvonsrjAbfzv/I gclJwht3GkiKvY+1Hua4gWJ1gJ+iFUM5ci1++Ky+Cq+Vzpp7xHAeOMDFi z8WDx9gr7dFkMKE2NH+MhTT1oDNkIV/YARqNTp8Lf3gecbfm/RR94zxY6 yCiyO5McxRcZU95vJQKR3FD4o5xa+go3067a3bs4lc7CsAwLH8K28ZOxW exqZQ3sa1lYHilyCWfjiHAOOzED54oTEVgXlqJ8BDrXAqaDmpKXATYZ9Y bHi4Gak0YmOD/41/LvboPPYqyCz1BS1KjWak6vR8ax9t3BQDQ6CtVTqwc g==; X-IronPort-AV: E=McAfee;i="6400,9594,10376"; a="364374915" X-IronPort-AV: E=Sophos;i="5.91,294,1647327600"; d="scan'208";a="364374915" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2022 06:33:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,294,1647327600"; d="scan'208";a="711601516" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga004.jf.intel.com with ESMTP; 12 Jun 2022 06:33:29 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 12 Jun 2022 06:33:28 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 12 Jun 2022 06:33:27 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 12 Jun 2022 06:33:27 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 12 Jun 2022 06:33:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bYsWmP8buyj6JJVvYAZVvpQBASXhOFvK1qTSf1zXh2qlc9Y9ynBI0N4ZGM6NGAVX9SJse1Yif/wPC0o353RKztbS7X/w04pwgqvJiykJHdTKID1x9+rzlhdbQnZIEc24sHIWQ8AHAKNdDXo7VkyVsWEesD57CCDvmpJUPlI1K6jX8ejfMML/RKiV+LkHB6ZkP8JJKbtH6XUmKm5vPdAXbtLXmFX5wnPkF8a+Px1E/8Yhh/Gdp7OiOqkwZY4RX8t0H5WmsHwNUnhqMrOtyUbC2sAAk2a2EuCoC274KIiO/m8zWf02u+TV8qOI1lzIvucuJWy9gQ9ofOwpG1/GowfTkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AixBsPMcbVrGZXDK6shENGND08fYDbeBVsnmxFdPbLg=; b=Ua3WwHBwiw+O7lyS8gzSXCUPVf2x534fkqAN0DTYjLol7PbrQ2HFjZubvdzSTr7NpYT6XUel7bZG3tVYb+O2srbnL9RRHrgMbKarwE/AEUaGnktzwSE9fREPMCZgBatFCr3TPgyum0BDaEjtfjYu4ovmtvyjs/SEsdyjZE0/VpwioQQydpfFEmhtNV6PQ9gQESvWbI/INks0QuHKP5BmrVfftDqkGzH56T8o5vK02vmqoLWBkuBu3b8OzUKmh/aqPXJPs5kHur5naIq2/YYY25BHzMEae9lDhjjo+ZQd6EJUwM9Ta1vCxDbAm4LCdQ9c4x9XqihIANSOAHWPfNKNKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by MN0PR11MB6159.namprd11.prod.outlook.com (2603:10b6:208:3c9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.16; Sun, 12 Jun 2022 13:33:26 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::24ae:1cd3:3192:4c7e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::24ae:1cd3:3192:4c7e%7]) with mapi id 15.20.5332.013; Sun, 12 Jun 2022 13:33:26 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Aktas, Erdem" , Gerd Hoffmann , James Bottomley , Tom Lendacky Subject: Re: [PATCH 1/2] OvmfPkg: Use PcdOvmfWorkAreaBase instead of PcdSevEsWorkAreaBase Thread-Topic: [PATCH 1/2] OvmfPkg: Use PcdOvmfWorkAreaBase instead of PcdSevEsWorkAreaBase Thread-Index: AQHYfk8KgCmhh8exlUmlPRl9XlrXl61LxU/w Date: Sun, 12 Jun 2022 13:33:26 +0000 Message-ID: References: <20220612112434.1829-1-min.m.xu@intel.com> In-Reply-To: <20220612112434.1829-1-min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69b354b4-bbc5-4208-6ad9-08da4c78211e x-ms-traffictypediagnostic: MN0PR11MB6159:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2q22omcVyE4H6qW4NCcT+G/JYEf4Cbj4FTrIT26FQ+fGjRuI5CnrX9KOGca8SpXA4X/S2KNbH7TRw+FSOWiltgGIUYYMbRaeO4FtAzie9YaioYWMKg6UnSG8A5UHZAacWx5P/szvACn5E4itBjwaq9riXpE4W257t304lMD7ep3SnkUuCZGDyXrxEGbbEvyltroK57+LPVmGLFZHjjiQ3rQJCcbyt9me4bazFpu1y6E59FSZrw0q/kBsd4E6eYFOFS6AMo1zspNraEb3iyvzsep7xb1XWdX44k7rn1OWBTZsJFDHAZDWV9H5/Ig/mPGsSdnlHttDOYuA1awwSl9a8O4V29S2rY1nX7eZlOpcNp4z3x/UhRgNpziRS6/0NMB9U59XoqwKUPF9VW/cMjVTG+sFPmnwi118DJe5veaTDpG6RwO0GFBC1GduCExrbp2Kk+4QNPrvV9KUu9wPgbaFt4EkbTi8sxJT3dxDddpgEql+fPY8DtD21bUeSoPJjjfTnnLKXnYT0uwtBGT0B80PDhk45xQrYZxRlYAxKnlCDlQegeEWGr+iR32xfpC6pWmcUyPNqKHqb2UseCsHuz3tgeVX+6NHwNM4oaaKWquIfraqtvn59lZzfe5UWDGT8H6/oydVO1QuxRbIeFH9LNhem/wHDjU8QEWIWGzso4m25j97LiL8TG6dgu1/4l2s3G6K/N9s9PWLgf5Q8IXsNcjmKFw5+5yy4eSh0hInO3VGlr8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(6029001)(366004)(9686003)(26005)(38100700002)(7696005)(53546011)(6506007)(33656002)(2906002)(55016003)(5660300002)(52536014)(8936002)(76116006)(122000001)(4326008)(86362001)(66476007)(66556008)(64756008)(66446008)(8676002)(66946007)(38070700005)(83380400001)(82960400001)(186003)(110136005)(316002)(54906003)(71200400001)(508600001)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?chPuClVmJwgnVYikVFavNkA7T1sdO6Pqf52VjDc8v1aGaSbhnUm1Cqs82uk/?= =?us-ascii?Q?u5bBpKePFAJKZgclbIJr5ra+9pj+pIK5uFaovdaJpT3s+Nr/vhClc25Fz4Wg?= =?us-ascii?Q?MusPHmRY+sqsmmY6XNe99f0pTTNPdLmPIaZ+NM6fK0fTcidbePKVfTp7eqPx?= =?us-ascii?Q?5KeeOZ2F15s/+er7hPm5KL7Ec5U7XGQVq3ufSlc0PMoJ16n7ksb5h/3b7aFT?= =?us-ascii?Q?QCCbk4sgGGb8EhoBa4pH2U6+Gcw6hHhr9gIqsE/eS95qtvjsuYmg8PBOBehS?= =?us-ascii?Q?tHFdio+sVfDkykO3RwH6AVC6dEqEd4fSKGuNu482wDVH1Iobn7+wHYMEQX/q?= =?us-ascii?Q?xnWH72x2yh7EcZSZ+u3vLcvJRP0PawxzOVdP/0vEr5IKQBzBEE5Sj3i33Ze4?= =?us-ascii?Q?o2H7dsqdOv1lNA0fioysiHu73utP/llLLYJnDJYllv5klGEAXChYF9giXxRH?= =?us-ascii?Q?/YWjBneE5SzYAmcoWgc65BD1ypLHTJS+gY2gwayzZ1aJpTggBk1myH6Nw5cH?= =?us-ascii?Q?/QFFe7gA432ZVFxNtebjrCKuMLJ9440lZiTWxwzTQz+fpmitFTEEBBTmt5EX?= =?us-ascii?Q?TbMeaLguhAyuCGNmBpHh4qphWTZkUYemJL4y2CcjlgPzGidB1ZKSH16cvgwp?= =?us-ascii?Q?n4vpUwiYouQGG2Mm1m4ABEgej2WmbMAyAW4SdKgPw52cobiaNyOavyLmDkVo?= =?us-ascii?Q?A2nU96HTViAgpyM4adawp99C/q6lAehVIpSjf5JS8G3BU4YwFlaLd1nx9XTM?= =?us-ascii?Q?s8RSNWXXFj8KEm4+lZXk1q4ZDzb2urjWzuAgtzeL1nJF+Vguku20A8Bj/+Ex?= =?us-ascii?Q?ByWzblPPTv1AryPOhtvmKr8pZtG/0D7wY0Twb3O79lmzgv63C4XiZ8opM6Hq?= =?us-ascii?Q?mSct7dktzqTJwHDtbwFnBlfcydEa1lWhXikBmiX3iYILWCGUiGwu1HQ3Zl96?= =?us-ascii?Q?MivwGocOIIIbjYWOBKzFlnPCQVXZfljpzVpC7K09Wyo9Xh6m+1ysDCWoSZHN?= =?us-ascii?Q?IVkQi6o14/djo/JyrA2OtSYGgaUmBFAdR+nmhTRkvuak4SptHKXTjVQXhKtR?= =?us-ascii?Q?OQWMYsZsed7MAtEVJLJyVk9bOfi7G1PZz8WZU5HswEgBgn1/QnkCOoUYA5Xf?= =?us-ascii?Q?apZenjpluBr0c6ZJNf8qnaOQVgotv9G9CNzCofeLRflmOeABjwkGjihGuSsE?= =?us-ascii?Q?JuySDDXFM2Ns1ztBnw5413AU5p1u4SLlpvwXWSGvFW2eZyOIxFyV8AoYWSOU?= =?us-ascii?Q?EBETtyEOirvKTDrXhUMWuC9F6/xFQd6nPxvvJV0IuqDuq9emWjyCChuGnei2?= =?us-ascii?Q?Y82CJjvAZESOlApDsiNWto0O0dmyAOfgMS0Rm5kMPRgKO5YaRLPxhHl4xdKc?= =?us-ascii?Q?/rJb4RTRuzFOe/Pl62x65Pqv6sclvPl84uPLVD8hcyOEt+jjIXe/Kxc8A932?= =?us-ascii?Q?WgEW8+Xh3s3aIK/ZU0T0nTnFdHDwXq6wjHjVlMnA5+o6zISp97xC6qbuPlG+?= =?us-ascii?Q?8qvccg/9mLKKliMp8Y5qLFHNC7Z+uy1GGxVREdHhtBc9cIIJEdXRK/yyigtJ?= =?us-ascii?Q?YAJVsQeoI+KaDoOIE4Nhx0EaAsbiAp0YJLo4ErjA0erlT2YJlgnWyY6lEY1t?= =?us-ascii?Q?Hj2AhPiEHW5o/G1cYZ2XwKrr4eCK+5jV+johL9323+17iWuZZ2WuM4vv3o9d?= =?us-ascii?Q?JHW3L2vm8GSwFDfzvyTlzxTjZk/E9v1fS0qU8RHafwcyCPRzAGg5Gf2oZIRk?= =?us-ascii?Q?z7Xa//260A=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69b354b4-bbc5-4208-6ad9-08da4c78211e X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2022 13:33:26.1149 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uftxTfM6C7cFPsvC+s4+wVThyGkThIs0iDQXFg5K+nfwfOLHL9nU+gVYAcjOpSVKAfx7IWf5Ccv9SY0ZU1B4NQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6159 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Xu, Min M > Sent: Sunday, June 12, 2022 7:25 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Aktas, Erdem > ; Gerd Hoffmann ; James > Bottomley ; Yao, Jiewen ; Tom > Lendacky > Subject: [PATCH 1/2] OvmfPkg: Use PcdOvmfWorkAreaBase instead of > PcdSevEsWorkAreaBase >=20 > From: Min M Xu >=20 > It is an typo error that HobList pointer should be stored at > PcdOvmfWorkAreaBase, not PcdSevEsWorkAreaBase. >=20 > Cc: Erdem Aktas > Cc: Gerd Hoffmann > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Signed-off-by: Min Xu > --- > .../IntelTdx/PrePiHobListPointerLibTdx/PrePiHobListPointer.c | 4 ++-- > .../PrePiHobListPointerLibTdx/PrePiHobListPointerLibTdx.inf | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/OvmfPkg/IntelTdx/PrePiHobListPointerLibTdx/PrePiHobListPoint= er.c > b/OvmfPkg/IntelTdx/PrePiHobListPointerLibTdx/PrePiHobListPointer.c > index 1b41a3983c99..ecd271c0bdff 100644 > --- a/OvmfPkg/IntelTdx/PrePiHobListPointerLibTdx/PrePiHobListPointer.c > +++ b/OvmfPkg/IntelTdx/PrePiHobListPointerLibTdx/PrePiHobListPointer.c > @@ -27,7 +27,7 @@ PrePeiGetHobList ( > { > TDX_WORK_AREA *TdxWorkArea; >=20 > - TdxWorkArea =3D (TDX_WORK_AREA *)(UINTN)FixedPcdGet32 > (PcdSevEsWorkAreaBase); > + TdxWorkArea =3D (TDX_WORK_AREA *)(UINTN)FixedPcdGet32 > (PcdOvmfWorkAreaBase); > ASSERT (TdxWorkArea !=3D NULL); > ASSERT (TdxWorkArea->SecTdxWorkArea.HobList !=3D 0); >=20 > @@ -48,7 +48,7 @@ PrePeiSetHobList ( > { > TDX_WORK_AREA *TdxWorkArea; >=20 > - TdxWorkArea =3D (TDX_WORK_AREA *)(UINTN)FixedPcdGet32 > (PcdSevEsWorkAreaBase); > + TdxWorkArea =3D (TDX_WORK_AREA *)(UINTN)FixedPcdGet32 > (PcdOvmfWorkAreaBase); > ASSERT (TdxWorkArea !=3D NULL); >=20 > TdxWorkArea->SecTdxWorkArea.HobList =3D (UINTN)HobList; > diff --git > a/OvmfPkg/IntelTdx/PrePiHobListPointerLibTdx/PrePiHobListPointerLibTdx.in= f > b/OvmfPkg/IntelTdx/PrePiHobListPointerLibTdx/PrePiHobListPointerLibTdx.in= f > index 2667f841cea2..fe7ee23fdc8a 100644 > --- > a/OvmfPkg/IntelTdx/PrePiHobListPointerLibTdx/PrePiHobListPointerLibTdx.in= f > +++ > b/OvmfPkg/IntelTdx/PrePiHobListPointerLibTdx/PrePiHobListPointerLibTdx.in= f > @@ -23,7 +23,7 @@ > UefiCpuPkg/UefiCpuPkg.dec >=20 > [Pcd] > - gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase > + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfWorkAreaBase >=20 > [LibraryClasses] > PcdLib > -- > 2.29.2.windows.2