From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>, Gerd Hoffmann <kraxel@redhat.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
"dionnaglaze@google.com" <dionnaglaze@google.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"Shutemov, Kirill" <kirill.shutemov@intel.com>
Subject: Re: [edk2-devel] [PATCH v9 0/4] Add safe unaccepted memory behavior
Date: Wed, 25 Jan 2023 16:56:52 +0000 [thread overview]
Message-ID: <MW4PR11MB58727C87D0311B401CF279A18CCE9@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAMj1kXGX39gGdQ+7NZSHQLYv3HQGu-AE7SHnV7fBzzmm0-YJ2Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2093 bytes --]
hello
If this protocol is SEV specific, please also add prefix SEV_ or AMD_ for the protocol name.
________________________________
发件人: Ard Biesheuvel <ardb@kernel.org>
发送时间: Wednesday, January 25, 2023 10:52:42 PM
收件人: Gerd Hoffmann <kraxel@redhat.com>
抄送: devel@edk2.groups.io <devel@edk2.groups.io>; thomas.lendacky@amd.com <thomas.lendacky@amd.com>; Hansen, Dave <dave.hansen@intel.com>; dionnaglaze@google.com <dionnaglaze@google.com>; dave.hansen@linux.intel.com <dave.hansen@linux.intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Shutemov, Kirill <kirill.shutemov@intel.com>
主题: Re: [edk2-devel] [PATCH v9 0/4] Add safe unaccepted memory behavior
On Wed, 25 Jan 2023 at 13:10, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Wed, Jan 25, 2023 at 12:44:13PM +0100, Ard Biesheuvel wrote:
> > On Wed, 25 Jan 2023 at 10:18, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > >
> > > On Wed, Jan 25, 2023 at 10:01:47AM +0100, Ard Biesheuvel wrote:
> > >
> > > > Exactly. And my Fedora kernel has those bits enabled by default.
> > > >
> > > > So I suppose the way forward here is to expose this protocol only on
> > > > OVMF builds that target SEV-SNP, instead of introducing it as a
> > > > generic CoCo feature.
> > >
> > > OVMF builds already adapt at runtime, so this needs to be a runtime
> > > check too. But IIRC the module already checks whenever SNP-SEV or TDX
> > > is active before installing, so we only need to tweak that check to drop
> > > the TDX check.
> > >
> >
> > Sure. But Dionna's series introduces a new CocoDxe driver that is
> > intended to carry shared logic, but we should probably add this stuff
> > to AmdSevDxe instead.
>
> OvmfPkgX64.dsc can run in SEV/TDX modes too, so it is needed there as
> well. We can probably leave it out from IntelTdx (assuming Intel's
> upstream merge plans work out as expected and tdx-guest + unaccepted
> memory actually land in the same kernel release).
>
OvmfPkgX64.dsc already incorporates AmdSevDxe, as do a few other
platforms, so adding it there is still fine afaict.
[-- Attachment #2: Type: text/html, Size: 3169 bytes --]
prev parent reply other threads:[~2023-01-25 16:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 0:14 [PATCH v9 0/4] Add safe unaccepted memory behavior Dionna Glaze
2023-01-13 0:14 ` [PATCH v9 1/4] OvmfPkg: Introduce CocoDxe driver Dionna Glaze
2023-01-13 0:14 ` [PATCH v9 2/4] MdePkg: Introduce the MemoryAcceptance protocol Dionna Glaze
2023-01-13 0:14 ` [PATCH v9 3/4] OvmfPkg: Implement AcceptAllUnacceptedMemory in CocoDxe Dionna Glaze
2023-01-13 0:14 ` [PATCH v9 4/4] OvmfPkg/PlatformPei: SEV-SNP make >=4GB unaccepted Dionna Glaze
2023-01-13 3:46 ` [PATCH v9 0/4] Add safe unaccepted memory behavior Yao, Jiewen
2023-01-13 7:18 ` [edk2-devel] " Gerd Hoffmann
2023-01-13 7:32 ` Yao, Jiewen
2023-01-13 9:32 ` Ard Biesheuvel
2023-01-13 11:11 ` Yao, Jiewen
2023-01-13 11:24 ` Ard Biesheuvel
2023-01-13 11:44 ` Yao, Jiewen
2023-01-13 12:00 ` Ard Biesheuvel
2023-01-13 16:00 ` dave.hansen
2023-01-13 17:06 ` Dionna Glaze
2023-01-13 17:57 ` Dave Hansen
2023-01-13 18:23 ` Dionna Glaze
2023-01-13 18:34 ` Dave Hansen
2023-01-16 10:28 ` Gerd Hoffmann
2023-01-24 22:42 ` Lendacky, Thomas
2023-01-24 22:46 ` Dave Hansen
2023-01-25 9:01 ` Ard Biesheuvel
2023-01-25 9:18 ` Gerd Hoffmann
2023-01-25 11:44 ` Ard Biesheuvel
2023-01-25 12:10 ` Gerd Hoffmann
2023-01-25 14:52 ` Ard Biesheuvel
2023-01-25 16:56 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB58727C87D0311B401CF279A18CCE9@MW4PR11MB5872.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox