From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 474BE780447 for ; Thu, 7 Sep 2023 12:26:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+xUJTfQvO5n7bha6kadaBA+BIAeZyXTp0rsXIMlyvf8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694089607; v=1; b=APohgWxORBk2f5SZNzRTRyV6kQOOwCTzkPml3RQNlgJ7jyEqTXHxQocO3spklNykAZJKooV5 pevGuu3lfp7EkEYfCDrbLV74EGA6L3U6QsNd00RdOzGCpniItGYasYD/b1iCyxxPlNZ3jbI9PbK sWKlMRfkIjrN/gcZcSP76/Pg= X-Received: by 127.0.0.2 with SMTP id hXruYY7687511xtoD4J4ZAjy; Thu, 07 Sep 2023 05:26:47 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.11599.1694089607040992100 for ; Thu, 07 Sep 2023 05:26:47 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10825"; a="441325821" X-IronPort-AV: E=Sophos;i="6.02,235,1688454000"; d="scan'208";a="441325821" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 05:26:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10825"; a="771255130" X-IronPort-AV: E=Sophos;i="6.02,235,1688454000"; d="scan'208";a="771255130" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Sep 2023 05:26:39 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 7 Sep 2023 05:26:38 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 7 Sep 2023 05:26:38 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 7 Sep 2023 05:26:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8FUjKxxCtSVWS2enhgFgJ+QGJK3uNnt6Pm3qT9RVfi6rd5aWojyN5K4nAMd6UfP0zps0/Sr2VleVCM1RYluSHs0etvbtf+SS/OtiHvfec86h1j66uUgiEpmL6Qr07KBGqitog7tHXNTQrlIQxzW3eY0rSLqH0OdDUE8Mrj9jK+ywR+qSxtckjYylqZ4aFyYTr9zEl5HdJSz6lyIBfgkk/wrp38XuKoGIZN438CPN/z9fjYcbfpZ7bavhPJ5iZu/HHsDTuXXPyZofuybp864vQCuwvMiaS0vdTVmOgfyjMvEAYJlfNNByAJCW3j/mVp+EtSqbfwrhq6bC049l7e4YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=85wUtF5qzI7e3q5Ri/GhvpJCptHFmVZyY8ZUEGO2o+8=; b=JQ11snx38UYfbaNYFu2P90mPfoENansUndc55WXJKZivPAvb2FeNh/Ed0T/WiZZCTr0KQ9AQROyTSVNeRVyHOBvFOcGe46VxiVZ8t4SsUZwvjAQjHMRjnuG1+WqIjgg4yEj3XtPDCB3EyHLH4D9/J+rD3N6ruM9/5bbozrkiIAvEaQeUlwOHxSyZVRTaKjbSQuUo9ol0d/WzuJ4D+SQBK327CbGemLInC2LCAduo4VQwmaSnxQuQXz7ZFVYAnPnfCzlWmaaAyJVg8ysgkbNlfQ4CAKcIuykSJ38/mHWTni3EOq1BFyiugISSrp0VfBbyWqtDfmtw1F6Wb4RKFza3nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by CO1PR11MB4962.namprd11.prod.outlook.com (2603:10b6:303:99::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.30; Thu, 7 Sep 2023 12:26:31 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::fdf8:dc0e:db69:f35b%4]) with mapi id 15.20.6745.034; Thu, 7 Sep 2023 12:26:31 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "zhenyzha@redhat.com" CC: "osteffen@redhat.com" , "kraxel@redhat.com" , "marcandre.lureau@redhat.com" , "stefanb@linux.ibm.com" , "anthony.perard@citrix.com" , "julien@xen.org" , "Yao, Jiewen" Subject: Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg:Add variable store is full debug info Thread-Topic: [edk2-devel] [PATCH v2 1/1] OvmfPkg:Add variable store is full debug info Thread-Index: AQHZ4XwfwGs5NLTDoU6UO3sPcTyu9bAPSfjg Date: Thu, 7 Sep 2023 12:26:31 +0000 Message-ID: References: <20230907111117.3559823-1-zhenyzha@redhat.com> In-Reply-To: <20230907111117.3559823-1-zhenyzha@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|CO1PR11MB4962:EE_ x-ms-office365-filtering-correlation-id: c4d3b155-1ee4-4f80-17aa-08dbaf9daab7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 2EgPJcSlxkAUbIoaA4hCp+FjTM+sWbxzH7YqNO/eoT3nQH0mmBBIlFGrFLWSUw4GZBx28U+1BhZ3xPjXZ+l6GrtW5zli+Ncp0QaE1TNevwdmyi4iYcYpuXbSkJCaAq76Pi3G60sKTC4/AYZvZ19/hKkjPi6hi/2VotqPoGzLi6fJpfxEcSqFCcfzy7uD8Hiwu4Wwk3QheQUSZ/cJXiLH5lerZen9UjL5l1Aco+dUjeIK1/gkR5Fq0KTjMSYwuNXfcJLmhfr9iGwXyjrD6DSifiowj6hIylzs4kp0S7m3X9gE+axTfIARRmpcezHrzQJFm3oMQsKpaHAtWE/i8/YdaNHcHRFIwYRRVuNHcN9C+O+qP8euyLKgYAzzmraSr1l8y8/+2eAp6N4raZ+3gToj0KC4I5B/Vf9u9TlbOeCr5hKaSyh1ivT6cThcdRaPyt/p5bQIbxLyXhsg/tFeZMpbOgeWcfBNXQmZlmBZDWpuzGQEbq7kVPSkJ27HG5aNVqMXuXG3je+vO7mkbnC8x+6e+0vnHvJorwyUCoaF+xTI8ZDQOqdroLZg3RZot9zwWmhk7kd87f9cdEM/lJ7FOc9sTUjPBFfwXryGD42NxzWnu1L7QtjxCMwkymwJKn9Sq0SPp/YMPps+VXk+DCWoY5h48A== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?hrwmtmQkfrRwp6UT4cDXHCjY4P2OG4XRQL1p9COVN/K3S01P5tmhU06VnL?= =?iso-8859-1?Q?1Ysoqv1ndKGfrpLLs+HrupD4SX1m+P7CJ8HEfNDLiwsYz56/N6yayFapBC?= =?iso-8859-1?Q?Qfi/6yWTW84dkzEK1bLPKq8z7yUawFL9R30rtIH53YjpmkIjChUlbSl3BS?= =?iso-8859-1?Q?2LK9BKB/BNaAx4U4xD0SOPIAY4Ae5XYnU9b3cUxz7N+I+Nk2nXQ2QrEKsQ?= =?iso-8859-1?Q?txsJTS8fhGkbYbAUfsNr1pcGIreI+pBuUkgoMxep1dwcXEXS9IwXJ73XU+?= =?iso-8859-1?Q?sjeuHfczhSO59EcGYLGtRev/yWlkNC31x3ozTK3ZELLMvrAxG6Lej3fMm4?= =?iso-8859-1?Q?FZivtWHzNZgV1xy6AsUjqqcj2HlYULChaHv1Q4RLaBkrOJzFI0KdiD423H?= =?iso-8859-1?Q?ufrIvXN72EPFOl2vBZlaqcI9dDzMi5fLYpR/6xgnlLTS3fTdIBovl32Wn4?= =?iso-8859-1?Q?ksEGmAN6ZdNZNe5qz6/gTBJ7BTcZGJX5UKRDMJHAFyqSk9YzXoH1Bpsda6?= =?iso-8859-1?Q?rDH7Rq2YTyw9za9JmCwdQLi0oEVeS6Yu0l//6fcmJ1AkbuoHIbTv+va2dT?= =?iso-8859-1?Q?hKWtiMRVTRx/SOgxeJbvIE+EljL4XpJNGiEvQ5FoloHHLyzcFIx5htcoQs?= =?iso-8859-1?Q?6Tk+pX5rTtgZzjzFaObTPyMM9FOF1Abf45SY5C5ks9ZytnFsyKTXuktVhL?= =?iso-8859-1?Q?eP/HY7t4vzF5G9kDwhx4R/spZlkf3UE/905GxVfydRkNQX3GPCm8quDRjZ?= =?iso-8859-1?Q?Jqa0uz/RnCouD0lAikaWgSQ5d01Pi/dZRuB7JaS8x3Nk5o1lTYtrT6wqY7?= =?iso-8859-1?Q?aX1ZytjoJjOJnPSHwP6yVLMLafCqRL+OkliENvT2Bx+Ci1RYuo2AAN2x+l?= =?iso-8859-1?Q?eAPoPNRzNV2Tu3VJ1fggMe4BflRkhcOm89CNMmcFa2GAiGAeZfGv7ShLL4?= =?iso-8859-1?Q?Bbti8kpBSOd6Dg4wrEU40+GbJlwJcS8ipZvDuJEkPyX0vqtbl4WAius/SU?= =?iso-8859-1?Q?S9JNyuVvLh3pVk5TenCYu2kj7aEfyFXE1DsllFQ+Wj7G7LCvJe1pvGPr2F?= =?iso-8859-1?Q?88UJ7/I9LSsqb3vZKj+wokY/CdsNJh2ku582XwP83gDxJ/7n1VoYT0F66j?= =?iso-8859-1?Q?sXYVBjvqtGf0jT+5B/iGz+GhauD3+HtDFU6ZvXwDefI/rrHkZskX2pTK/G?= =?iso-8859-1?Q?W6gloKDKDQltgHvcwjiwGMC0Zi387a4Qw+vN/1mYuFOyGp0peG8YxYa6x0?= =?iso-8859-1?Q?tAKivRcwEdd03T6ke1Y0JHaC8jomq+xH9VzqrovstzrSYgFVkRJoPEnp4c?= =?iso-8859-1?Q?1upWKZif0o0dhMoCzuDBO9e9IcS5HW++e7XgMmOP5mqF/ZuyDrLY3iZ+z0?= =?iso-8859-1?Q?KvLLKoy50oSludXhlBPl1EFPjUYv/kmvbSGzZscUhuNgGWmY/lKY74oDHR?= =?iso-8859-1?Q?boVu4r5OvMAvlVIDX+GVV26m2/uDqlMuS5QBIM9fzk5pq/IM67oyzFRI+s?= =?iso-8859-1?Q?WEstsQL/5/mFWgEd2z0dWadeKFhAX1yrX5NIvQv0AXe5HHNLzxMLYq+I5P?= =?iso-8859-1?Q?WDruQSX5vpsTKo0IfIbyJtf9AVs4He/Enf7G1sD6F+8nfOKiZSXIJ8+XJY?= =?iso-8859-1?Q?EANwnUGNftKtL8a9U3fxfpGv59lqSlZQbH?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4d3b155-1ee4-4f80-17aa-08dbaf9daab7 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2023 12:26:31.1619 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DjjtQBrAX1d4MLPY9ZimUcqGL0Qki8gd4f6CYIm8/eP6Wz2YIk5wQ+2VrpINcoYH7DIQYaXxHOnqrddNkHwv7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4962 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: TXewt13he7IveDBIz5vj7G7Ax7686176AA= Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=APohgWxO; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io I don't think using ASSERT is a good idea here. Why not return ERROR? > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zhenyu > Zhang > Sent: Thursday, September 7, 2023 7:11 PM > To: devel@edk2.groups.io > Cc: zhenyzha@redhat.com; osteffen@redhat.com; kraxel@redhat.com; > marcandre.lureau@redhat.com; stefanb@linux.ibm.com; > anthony.perard@citrix.com; julien@xen.org > Subject: [edk2-devel] [PATCH v2 1/1] OvmfPkg:Add variable store is full d= ebug > info >=20 > From: "Zhenyu Zhang" >=20 > When the variable store is full, edk2 will directly assert. > Add debug information to help users understand what caused > the assertion. >=20 > Actual results: > RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929- > 48BCD90AD31A - 0x00000003 - 0x7E > CommonVariableSpace =3D 0x3FF9C - CommonVariableTotalSize =3D > 0x3FF98 > RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929- > 48BCD90AD31A - 0x00000003 - 0x92 > CommonVariableSpace =3D 0x3FF9C - CommonVariableTotalSize =3D 0x3FF98 >=20 > Synchronous Exception at 0x000000023CA60374 > ...... > ASSERT_EFI_ERROR (Status =3D Out of Resources) > ASSERT /builddir/build/BUILD/edk2-ba91d0292e59/OvmfPkg/Library/ > PlatformBootManagerLib/BdsPlatform.c(142): !(((INTN)(RETURN_ > STATUS)(Status)) < 0) >=20 > Cc: Oliver Steffen > Cc: Gerd Hoffmann > Cc: Marc-Andr=E9 Lureau > Cc: Stefan Berger > Cc: Anthony Perard > Cc: Julien Grall > Signed-off-by: Zhenyu Zhang > --- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > index 8dc2bbf97371..c95c7931a3f5 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > @@ -139,6 +139,7 @@ PlatformRegisterFvBootOption ( >=20 > if (OptionIndex =3D=3D -1) { > Status =3D EfiBootManagerAddLoadOptionVariable (&NewOption, MAX_UINT= N); > + DEBUG ((DEBUG_ERROR, "ERROR: Variable store is full.\n")); > ASSERT_EFI_ERROR (Status); > } >=20 > -- > 2.39.3 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108375): https://edk2.groups.io/g/devel/message/108375 Mute This Topic: https://groups.io/mt/101211889/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-