public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"Xu, Min M" <min.m.xu@intel.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to PCR[1]
Date: Wed, 18 Jan 2023 04:33:45 +0000	[thread overview]
Message-ID: <MW4PR11MB5872859976CAAF7F1D03E50D8CC79@MW4PR11MB5872.namprd11.prod.outlook.com> (raw)
In-Reply-To: <173B3EFE3FEA3093.24231@groups.io>

Merged https://github.com/tianocore/edk2/pull/3920

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> Jiewen
> Sent: Wednesday, January 18, 2023 8:15 AM
> To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>
> Subject: Re: [edk2-devel] [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI
> boot variable to PCR[1]
> 
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> 
> > -----Original Message-----
> > From: Xu, Min M <min.m.xu@intel.com>
> > Sent: Wednesday, January 18, 2023 7:53 AM
> > To: devel@edk2.groups.io
> > Cc: Xu, Min M <min.m.xu@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>;
> > Wang, Jian J <jian.j.wang@intel.com>
> > Subject: [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to
> > PCR[1]
> >
> > From: Min M Xu <min.m.xu@intel.com>
> >
> > According to TCG PC Client PFP spec 0021 Section 2.4.4.2 EFI boot variable
> > should be measured and extended to PCR[1], not PCR[5]. This patch is
> > proposed to fix this error.
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
> > Signed-off-by: Min Xu <min.m.xu@intel.com>
> > ---
> >  SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c
> > b/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c
> > index d19923b0c682..59341a8c0250 100644
> > --- a/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c
> > +++ b/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c
> > @@ -1873,12 +1873,8 @@ ReadAndMeasureBootVariable (
> >    OUT     VOID      **VarData
> >    )
> >  {
> > -  //
> > -  // Boot variables are measured into (PCR[5]) RTMR[1],
> > -  // details in section 8.1 of TDVF design guide.
> > -  //
> >    return ReadAndMeasureVariable (
> > -           MapPcrToMrIndex (5),
> > +           MapPcrToMrIndex (1),
> >             EV_EFI_VARIABLE_BOOT,
> >             VarName,
> >             VendorGuid,
> > --
> > 2.29.2.windows.2
> 
> 
> 
> 
> 


      parent reply	other threads:[~2023-01-18  4:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 23:53 [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to PCR[1] Min Xu
2023-01-18  0:15 ` Yao, Jiewen
     [not found] ` <173B3EFE3FEA3093.24231@groups.io>
2023-01-18  4:33   ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB5872859976CAAF7F1D03E50D8CC79@MW4PR11MB5872.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox