From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.8128.1674016430578366431 for ; Tue, 17 Jan 2023 20:33:51 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=kptLM6dT; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674016430; x=1705552430; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uQdSmgMS108lchO1PRfKAkU1yVefqzm2+YIQj8YwO7k=; b=kptLM6dTbGeb6Csniu+ic0nn2mbyaWnPfgs5nLr/YxnBnYYG3YWoVopW UJd7a1cmTy8TCP4uWGdxBvZN1FoV8RDqovNaT7d8BKXwCWq/Dp7uLvfcP mOA/6aI8HAqCOKgnf1cKyRzjuV5rNSVxPW9046vmu5hbEsW5zSPhZ0jJP HW7EJ6U0T+E8ptqoCP6YrGw4s0bXAPVRIV/LWEQQ9V/c49c8sBr757LfD 7BEHP+JNjY1z1jR5YphqlnQEmdMYXDc45w2wO2p0K4X1AeSwJCQqZFjCC Kj7EH0F+GeCbGCHgdf+ATJ6zihoWlXR1FljkZbWuc9Jq7ZdDn7U1twwKV A==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="387246350" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="387246350" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 20:33:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="722935653" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="722935653" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 17 Jan 2023 20:33:49 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 17 Jan 2023 20:33:48 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 17 Jan 2023 20:33:48 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 17 Jan 2023 20:33:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ug0Db9Ih0irJvBY8Mv1QZzr6ejYBofxs7xfG1OkCcdeR13xv77Je1TrII46Pb0NQZ6s7oXUxMLyCzP1TVlIQVKz22jEbR5O8QtyaD7FvEOtDoSiPcVqMPZOgwN7DPvvyyopjKcF3qVNehVxsIYfXysmarPES4lFwRu0yvcjU9/xOch1G0QyH7fgiYs7HaZdabG32u30Fvq/04f6UXvz/NkGPbvgw9D1p912sWucLoYtDK4ghICGGZQDJBVV1d6fidKFHOVvcaFy7u7apsf53tZZInWIwMUjMbsu1XB/I1KPbGarA/vvUKGQcCu/NqbTbLwleC0Ukv4zExJoGN9fBKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j3cd1mHEUKmu9Bb6yDYbFNvkHGbqVDQdwOWBrH8mspo=; b=l7if53gh/huBPHddb1TYbSScGLt4Hw0p0c6LsRF62BC8aT/mKHOFJgyU698hJvO+R7HuwT8aoGqk37QpOQfA6OkrsL5KdL+rrzjPRHfhS4OKwIljADa1ZQVYFwGKlHvIaTOWZzB6ituSWgMArhrgsRL27NaG2ykV4u3CCcpOyE8itb3lv+a65wQot/dVhGqxiUPq5RgjbZF7eUjL1/OyXWC1QsZ+91Y6cjk5nppYepmoF+k23SaCNB47ONnuCfhPvJ+P/+ND2ph77Ixe4ZVvWygsSYUsU+bLs4dOVSoVaeL2EXTrLEBlMEYOIycJn58tGwuOBFu7fYAqMDe3BUfb+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SN7PR11MB6873.namprd11.prod.outlook.com (2603:10b6:806:2a4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 18 Jan 2023 04:33:46 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::5f56:1bdc:2eae:c041%7]) with mapi id 15.20.6002.013; Wed, 18 Jan 2023 04:33:46 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "Xu, Min M" CC: "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to PCR[1] Thread-Topic: [edk2-devel] [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to PCR[1] Thread-Index: AQHZKs7xJtpZ6d6g0k+jZM5GgVTjhK6jTjcAgABIOyA= Date: Wed, 18 Jan 2023 04:33:45 +0000 Message-ID: References: <20230117235326.600-1-min.m.xu@intel.com> <173B3EFE3FEA3093.24231@groups.io> In-Reply-To: <173B3EFE3FEA3093.24231@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|SN7PR11MB6873:EE_ x-ms-office365-filtering-correlation-id: 653b5b7d-838b-4ac4-c70c-08daf90d2fec x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Nt3//sMmpYvr19sswYxDN640YnougKRvXCpKq5m/DEC05WsvCaXP2dqUHVdyb6EbiGVzDxtVwgderLQ7AbmLwYe2Sj2pqqeYm93x9Jkb8tcZaNcDv2IOnfVQ0nC6D14Ql7Hv4MiD9m1qlTZEZ1ebLdShe7uO1CzM/25ri1CfRmb+mm/yFBILUbdoFGqM7rI0fj+y7UfXFrsMn7ivxvFqKyFScwlwg9v3QWWLlFtaHHEjZnuIIebMe/XW9UZjM5ONuy410uU5OIH/RiJDDd4kBOQrWk6TqeH1qIo4veqMfU8zfF9wCRPz0A2uB5pYIeDY3QjwgGqFXFd5VDqklVOjUFlDHEwFhWF6Rj0hbj41U29XtsuUV6fRruH9eaWOHTs9OKxFinjRwHEV+aKTT4py2O9bOMdPu2VE56qUIEQ+2rTPfTPog5O1qgzvrJlin4qCrbmzGeLh8lNeJsUEGNMQ5ZzzpxnjBqoleGUCyDBuuudHEPumawfoQL6kuueRQ1yw0siWsAxAx3HMI6uWIFGcrErAQLrhLYu9uPeDQEFYXsOKUPmxgn1IZn/WoY/nJfj/PZSfcDJLibrraAqutPMlZrVhCsJmEsNDPYJfihYvB+DMUytQUPoswln8EwfY8yCLmnjqNgMpaBZN6NHba7Wdkg/CMUPrDt8tMfN6CIoNgyDeUHHQ+dchYAKIrYEtGI8UU+YtdhSfSOk4PAgiowuQJaXEyQbXygx6JYVZIFs96a5hXW9OtsIrmY7XxAu0QjfKyDWMzn5P1R+95yAc38lJxA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(136003)(346002)(396003)(366004)(376002)(39860400002)(451199015)(52536014)(5660300002)(966005)(8936002)(66899015)(478600001)(82960400001)(15650500001)(4326008)(26005)(53546011)(66476007)(76116006)(41300700001)(33656002)(64756008)(8676002)(66446008)(66556008)(66946007)(2906002)(6636002)(186003)(86362001)(71200400001)(316002)(55016003)(38070700005)(110136005)(19627235002)(38100700002)(122000001)(7696005)(107886003)(6506007)(9686003)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Di2mqgONXYx03qDFT5+ZuIAXAAL9Tpu+rLQ60in1T99EIkWrK6NG7DByldzG?= =?us-ascii?Q?k6q1nlRzwBZkJgjMA12MItjdUaOd1ohNmqU9Cm4koaY82wk2e/hACUR0q+YA?= =?us-ascii?Q?Lc6c/bVoZuO5c97bEnamTB5hMvEaiNvPXxO6UfBc+OYK5Yu45L7PSI1liLLN?= =?us-ascii?Q?PzAO/SQ8pRHdz5DnP74raEaOcD05yOaBGiK4HSj4P5ta2fp4jutzUrGTQ/jK?= =?us-ascii?Q?3JDPA/OJ8wsjDtUPi2y3y5FsQm+huk4vzKkGPPcqv6ersIPr7ibS4Z1FaLLG?= =?us-ascii?Q?NqLfWSHtgU8FtE0UJD5qSxL7aSPHzRju9sRIs8D9B3xbu8kn6FN0tGJH9RLD?= =?us-ascii?Q?XmZdmaDZHHYepPO9YNYXmXFSuEIdIlyYsx4plWhnX1YlI9p6U0EZ+au9FANA?= =?us-ascii?Q?NOIWAVaGQ1amp1+Y2G831I5e9hZSzHOwvG5xzik/0E6wxgdvccRdMBZJ/1ah?= =?us-ascii?Q?zLJgwTkwcCsBBP3BSNyIVo9JOTCI5TrAiSAyk80XN6628xLOpkNz3CN8BIHl?= =?us-ascii?Q?CUT91m98NNSB4kx/oS57G6WVqwE1pc2NkPs1dD4lbIoNTJJxOVu4kgLIAMJc?= =?us-ascii?Q?wKhfu1o2eanf7wGFUjdG0rUJGKtUgzU+UEEqxD2PEcE27r6bq7NmTMHqDU2E?= =?us-ascii?Q?vtRXzLbTis5D56d9PDuysfulPpUUShrORyMppqoKcXIZJowirrJhTpBd/FzW?= =?us-ascii?Q?1npa1ZPbg1v7NjsCTIgh8EILOJXlHxkSqUIumHeO0A9UXQwOoGoYS2WxxFN+?= =?us-ascii?Q?MpPLyOYkH+PwnlHDZe/TK3U8PEgnXZuyHYFE5vOHYqAEjj2eEm2qUvB3xZjq?= =?us-ascii?Q?m9QEGfsyHHZellaBRIn3ksdv0IjiIy8EVAQxrRSnBsav3IhyEVJ6OsZgfCbT?= =?us-ascii?Q?kvgkgLQgT5dgy6I7/kvrquNxVdeh3EOtsSjKeILDlqJ0gtBDNVH4wVq04L0Q?= =?us-ascii?Q?EzcT2HaZSzx8MAgN+M97aPe0siELI1CzLKc+AUwUzt5GKBI9ug3EgyT4o3bE?= =?us-ascii?Q?MNs7b3LE2dyf1Zwl8uv1zA5dx6/2SJtKnYApjAHOfWnX0ux9iJRpUGgAfpjI?= =?us-ascii?Q?bvlk4K3EcZoAHUcbMnCSrIFMG2dPi0cWAMO2OJVszn8xNwnAEDB4+OBadyIq?= =?us-ascii?Q?Mqi62tQJWjOEJaPL+GOQRwrwCNONc4ct85ar6cv934hGgkY1zVaTL5x7S5RV?= =?us-ascii?Q?h0jC2VxEJp+Oms8wDm8XI/Ml6ECVUwiWPiVgSytUmKeZQI3KNcY/zTuAulIP?= =?us-ascii?Q?j1xVjPzd7tcojpTks6hZuuuGJ5TPuPxF3lwKpCUeM4sWTpOYreXqiqxYyVDM?= =?us-ascii?Q?EZHZjMlIN8XPR+n+Je/lxCFxRM0dCCQbyQBCN3SGz7aAEHpynmgOzeGzKKsJ?= =?us-ascii?Q?DhCwVQWFmWSAJoTRsn3U0fC0cfNDMF4CWLpRZ9ldAemKaG9y0gmFNjJRJ1Y0?= =?us-ascii?Q?AXXgt5vplpPwv6WLlMmVaOZQK6OARUu5gX/WDOJOYxZwiV3dKB9PWllNJtpK?= =?us-ascii?Q?8l7l3i6A4pt7sKRUtt4uHhxgxPK2isJyVQnGc7aaatBMUbF1iA6OAL2CtAi3?= =?us-ascii?Q?YKaGT5I9d2PyBozL99qkfsGzMPrK0JN771FM45c9?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 653b5b7d-838b-4ac4-c70c-08daf90d2fec X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2023 04:33:45.9815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wtKrY7bobPFNuPzdU3hh5p3Dm4NSM4dfX5qRuTLLLP0VE+/ZlGSA0sufjJOl0f3qhMZZw4E/V9SLL6fDHl7nwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6873 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged https://github.com/tianocore/edk2/pull/3920 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Wednesday, January 18, 2023 8:15 AM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Wang, Jian J > Subject: Re: [edk2-devel] [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EF= I > boot variable to PCR[1] >=20 > Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: Xu, Min M > > Sent: Wednesday, January 18, 2023 7:53 AM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; Yao, Jiewen > ; > > Wang, Jian J > > Subject: [PATCH V2 1/1] SecurityPkg/TdTcg2Dxe: Extend EFI boot variable= to > > PCR[1] > > > > From: Min M Xu > > > > According to TCG PC Client PFP spec 0021 Section 2.4.4.2 EFI boot varia= ble > > should be measured and extended to PCR[1], not PCR[5]. This patch is > > proposed to fix this error. > > > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Reviewed-by: Jiewen Yao > > Signed-off-by: Min Xu > > --- > > SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c > > b/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c > > index d19923b0c682..59341a8c0250 100644 > > --- a/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c > > +++ b/SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c > > @@ -1873,12 +1873,8 @@ ReadAndMeasureBootVariable ( > > OUT VOID **VarData > > ) > > { > > - // > > - // Boot variables are measured into (PCR[5]) RTMR[1], > > - // details in section 8.1 of TDVF design guide. > > - // > > return ReadAndMeasureVariable ( > > - MapPcrToMrIndex (5), > > + MapPcrToMrIndex (1), > > EV_EFI_VARIABLE_BOOT, > > VarName, > > VendorGuid, > > -- > > 2.29.2.windows.2 >=20 >=20 >=20 >=20 >=20