Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to support new resource attributes

["Yao, Jiewen" <jiewen.yao@intel.com>]

Thanks. Not urgent. Let’s wait.


> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, May 27, 2024 3:12 PM
> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>; Lin, Du
> <du.lin@intel.com>
> Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Gerd Hoffmann'
> <kraxel@redhat.com>
> Subject: 回复: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to
> support new resource attributes
> 
> Jiewen:
>   If the patch is urgent to be merged, I will help add push label to merge
> it with current process.
> 
>   If the patch is not urgent, it can be merged after TianoCore Code Review
> is switched from email to GitHub Pull Requests on US Tuesday.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yao, Jiewen
> > 发送时间: 2024年5月27日 14:43
> > 收件人: Lin, Du <du.lin@intel.com>; devel@edk2.groups.io
> > 抄送: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann
> > <kraxel@redhat.com>
> > 主题: Re: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to
> support
> > new resource attributes
> >
> > I have approved it.
> >
> > What is the process to merge? There is no COMMIT button or PUSH label.
> >
> >
> > > -----Original Message-----
> > > From: Lin, Du <du.lin@intel.com>
> > > Sent: Monday, May 27, 2024 2:23 PM
> > > To: devel@edk2.groups.io
> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann
> > > <kraxel@redhat.com>; Yao, Jiewen <jiewen.yao@intel.com>; Lin, Du
> > > <du.lin@intel.com>
> > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to
> > > support new resource attributes
> > >
> > > Thanks for the review and approval. Could you please help merge this
> patch to
> > > the upstream? A pull request has been created for this patch:
> > > https://github.com/tianocore/edk2/pull/5644. Thanks.
> > >
> > > BRs,
> > > Lin, Du
> > >
> > > -----Original Message-----
> > > From: Yao, Jiewen <jiewen.yao@intel.com>
> > > Sent: Thursday, May 16, 2024 5:37 PM
> > > To: devel@edk2.groups.io; Lin, Du <du.lin@intel.com>
> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Gerd Hoffmann
> > > <kraxel@redhat.com>
> > > Subject: RE: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to
> > > support new resource attributes
> > >
> > > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Lin, Du
> > > > Sent: Thursday, May 9, 2024 1:27 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Lin, Du <du.lin@intel.com>; Ard Biesheuvel
> > > > <ardb+tianocore@kernel.org>; Gerd Hoffmann <kraxel@redhat.com>; Yao,
> > > > Jiewen <jiewen.yao@intel.com>
> > > > Subject: [edk2-devel] [PATCH] OvmfPkg: Update VMM Hob list check to
> > > > support new resource attributes
> > > >
> > > > Encrypted and Special Purpose resource attributes are introduced in PI
> > > > 1.8 Specification. This patch is to update VMM Hob list integrity
> > > > check to recognise these resource attributes.
> > > >
> > > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > > Signed-off-by: Du Lin <du.lin@intel.com>
> > > > ---
> > > >  OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
> > > > b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
> > > > index b6085eab44..19e9b1bf54 100644
> > > > --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
> > > > +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
> > > > @@ -643,6 +643,8 @@ ValidateHobList (
> > > >
> > > > EFI_RESOURCE_ATTRIBUTE_PERSISTABLE |
> > > >
> > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED |
> > > >
> > > > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE |
> > > > +
> > > > + EFI_RESOURCE_ATTRIBUTE_ENCRYPTED|
> > > > +
> > > > EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE |
> > > >
> > > > EFI_RESOURCE_ATTRIBUTE_MORE_RELIABLE))) != 0)
> > > >          {
> > > >            DEBUG ((DEBUG_ERROR, "HOB: Unknow ResourceDescriptor
> > > > ResourceAttribute type. Type: 0x%08x\n", Hob.ResourceDescriptor-
> > > > >ResourceAttribute));
> > > > --
> > > > 2.44.0.windows.1
> > > >
> > > >
> > > >
> > > >
> > > >
> >
> >
> >
> > 
> >
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119278): https://edk2.groups.io/g/devel/message/119278
Mute This Topic: https://groups.io/mt/106326545/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-