From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.7195.1667313482762241600 for ; Tue, 01 Nov 2022 07:38:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=HS41p7hp; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667313482; x=1698849482; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Oq8/saJzocIe5EL5o1l+suCTBpfksM671NWFSyRkbHc=; b=HS41p7hpNeNnOTFPAelBk4kf2LJrLrjk6U01huOpWA+omiXEGy5uCVLL 6OcfIe5cAx8wjz60q54/gFLk+t3Oa1UbxjMoZSN5r/00cf2TckpI/87tf n7oMt4OOf9oDJjEjk72703FO19Pwt2aDjyUUaCaF28t3t9XUB2kzM6hWl h/qEESH7tArXrEmQ88ZbhiEVUBbVxXrrZjfGwtl+xGUIq1mTRraUCGTTq PXFrbFiEKckb8V9NMQkZ/v7Lm2qTfptz7ParFTd6oZOC5hrYhuxGp7wh+ XiKRq6NyVseKa+nczaUhdnd62s4Y+LTLZ0O55Yavba0gpo8PTOE20Lp5R A==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="371228296" X-IronPort-AV: E=Sophos;i="5.95,231,1661842800"; d="scan'208";a="371228296" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2022 07:37:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="628586697" X-IronPort-AV: E=Sophos;i="5.95,231,1661842800"; d="scan'208";a="628586697" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 01 Nov 2022 07:37:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 07:37:23 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 1 Nov 2022 07:37:23 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 1 Nov 2022 07:37:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TcqreORURcXAXScKq3FILg8j1i38YWFEL24l4tcPS7it0Esh6bwJiap5qt25UM7+IPWcscRW/qkKKylDAzyl+dy9/iWQKc2H4WwhJCt8dtT8m07Ao6vwAcHwQr9GAacE1ablWBjFocQckRoNwbYKyhvbUR57Xcw+0XjF+c9djRgWWBoABPCawBjzlTaBTbF1vrc97WchIYcnK12iXvuzsWGN3+rYpAk0cuZVC/nP2fEXUmhP14efWKyKEWT/4+pfOPhr2l9V1TkbunSF74Lze+9Ic08HDedsyOITKQ5oO1bNKYfOSO8p8/ZVFUNxVOEhZcCNwDaEalCdwO7P/Wp4Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jrrRRz/tpIty6QJRLgVR4xJollLCU0FvBeAurjABS5Q=; b=oVgMzjA49dCL999RXT3JrywX8F1kd8ELHhW2z6P2LRD28IQjnSuySwJGa8SMnnnfn3Dm1L0liUtTaQZupmfz+7RgAIwdoxYLod5QNQdrpIJQWaIzVDrr93rBcnBa9cnYJrUfW7U8bHHEtQMMVsZSezaAm6OW/CF+jcBnMQLJ10fgPVEo3zk3OTH2abhdOLg7pnEqA/D3cwO0dnpjxnzAno47fsGOIsJyOSDnXiigUTJFzYZKcytnvUFHu3YsqVfmY0TZ9akiFb0Rh+X6srwNxsixyrDtv5Sji/4kN0FzzyNOoZ4/7i4jy5lWtLdkVJDRr2ThZglT+TrWOtDOO4ssjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by LV2PR11MB6072.namprd11.prod.outlook.com (2603:10b6:408:176::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Tue, 1 Nov 2022 14:37:21 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::8a27:e262:8996:473]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::8a27:e262:8996:473%9]) with mapi id 15.20.5723.033; Tue, 1 Nov 2022 14:37:21 +0000 From: "Yao, Jiewen" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" Subject: Re: [Patch 1/1] CryptoPkg/Test: Simplify BaseCryptLib host based unit tests Thread-Topic: [Patch 1/1] CryptoPkg/Test: Simplify BaseCryptLib host based unit tests Thread-Index: AQHY6v+e3bovdWFOMEiJ/hZTwmdEjq4qKNiw Date: Tue, 1 Nov 2022 14:37:20 +0000 Message-ID: References: <20221028190034.1642-1-michael.d.kinney@intel.com> In-Reply-To: <20221028190034.1642-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|LV2PR11MB6072:EE_ x-ms-office365-filtering-correlation-id: 28138d0f-3998-43fd-b7fc-08dabc169577 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XOYPWOugUWC1y2QcycLdIk1G8CPBMCqJxOTCqQVwjS7YYakXLep0LA8jn8tCztZVD10IoRt4mO9BM3l3emUQV1Uw6g4K2mUV8P3KR8hUQyoZwswVtGkkWZ7tbYjlW8yuAGWbTqbsrkv2H+t6lnVEHsoLN5i6vftOVEXoS7TsMOzGh+w+QsPZF0DQsDfSRSdyI91mxpHymCIXHbSTH7pdCozJGavT/pOvI6UB41XX+gDV+Lc9voC8zxz3Gu+RCQfqHxnYY09v/UUKwk5XqoeSyL7J4xNiJVxF2SGOiF1rnLpFHeBLLRT0BJ/IUGWbCdFwUDgOsIUrH6CRK+ywvMHriPwsyFfqXUQZfHL0D1HmTzestQU+XCxxGnw8DLAQySO/Fs+kn502l09WKOvbDpSDm0yIigOgJmWXUwt9LTUVUCbblhksocid9qNfY+vksEjKjtYxn75a7N7CKUzaHyUiYW8ypCLrBtOEgyKIMDrCmCQ2lLs92ILGGbK8LIFlTgNeeEgJjpBpv+F9lVYN5ixCxtUPdZTF3zojVLPYeHY4u650KulxddeGhIQKJXCDbos+TNhpw0X0lP6E6wsX6Go+ZFrPwwvHurUF9X/HhF0Dm8BA+AihKkoEbqFdcE5UhjPk2TuXRsnZgU4fyy61Tfs/iA4RNqzi8GP5eMgOArubBtVUXTRe+LHjOzUmIEPCOwU2LhYu3WVhkUrIyy2+ohO06lW7HfjDUmI71eIrLPoWX5q67M/fec34F3Hoq6OJj7B5kFdGcMV+ZTq8jT/fu+mgGYuyB9IYnlcE+F+zdgeCqyk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(396003)(376002)(39860400002)(366004)(451199015)(55016003)(66446008)(53546011)(66946007)(122000001)(66476007)(66556008)(64756008)(9686003)(26005)(38100700002)(52536014)(2906002)(186003)(83380400001)(38070700005)(8936002)(41300700001)(76116006)(33656002)(19627235002)(71200400001)(316002)(5660300002)(7696005)(45080400002)(54906003)(110136005)(6506007)(82960400001)(107886003)(966005)(8676002)(4326008)(478600001)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?K1gcVsPKndy3+ztJO+GwYFjDytYyKkN7tkjKeO3uee1Qru3Juc85MXQSbeiM?= =?us-ascii?Q?vxLfrJncMNJWAtpYk3I7t8XfElRV5uZ/hROYDQ+r20mz7FGOsIf6gpdYs/Lt?= =?us-ascii?Q?uQcpykgIG3eLXaoNUy/hI9TzrAz+Y+UIIqgWwwpwofDqKandj8Mw10itfSKX?= =?us-ascii?Q?YFQOEQrDxvPGte1xfcgPuO7rXxeu/Ge0G2k9AP6EeW7uUacMGvpgoXUI2CMf?= =?us-ascii?Q?XC/EHNo6Ns/XH/sr4CWPSnp8gyRnGJ1MBwF/6ver+4gZfhcoDZixYouxel1H?= =?us-ascii?Q?psZifhmCqxj8MZlX6cxhW0wfgLat5kry579GNkqkbeeZ0UHO9Pvcj4T4KJi3?= =?us-ascii?Q?UJZiCK2wS1ZR4QyjCaElFlJCMFVd3Td++P6rKqdHWMwL4JCqXEHgw4qklHzQ?= =?us-ascii?Q?OyAF9NE2xOfoUpJZ7l133W9jPHNBlLCp99JTz2eiKZ4ywCmYSkDnaKuafA79?= =?us-ascii?Q?GJVkPo/Rtvd89ZWXnQjEHvMF29jAUAX8CX1eiDqyx7RGUm2TuXZo3FnRhn34?= =?us-ascii?Q?+S7aP1g0ANi+UDG+/xwHxmZHU83iqHX+4dHJe/ba8KU7lNES1BWVemFxPR6i?= =?us-ascii?Q?Nn6zWA6iP4CDsyLkl3cnBkbKb3v3KNZWNeX5DFtvGezU2SBH/cq1b53DTZlt?= =?us-ascii?Q?GBZsuTEvHt0AC4d0Tl6TJ/p7ZohU3LKi0KBverl5kJlVVq26nVF9fmFNMqbb?= =?us-ascii?Q?JT221yGRQ402nwc9557WIxlW45TvtbU6hAvS9VcqT1uYq+YS9NI6etL+yL5K?= =?us-ascii?Q?sk1SpnNVB0V7jw5gwXqMxTNd1D5tldqgTyJaTf3eJmjcaCkza0EM5r9cPWzW?= =?us-ascii?Q?S/4lwgfl27MUt5rd/qLzjSC/INmt47l6gIl0hr2QpyD3NxP28qBnE4rF5UZq?= =?us-ascii?Q?3iHmO561VO9VD3lamyAkwKSeHx4AhGIS1VzhNByrYTDbkKjgsUHxR6YFXFcP?= =?us-ascii?Q?sRGhMEF5zqdtkU2p/J3VQalNiMFbjuR+WUh96U1Jud8w/vYcnNkKTlIugFDB?= =?us-ascii?Q?iTzmbTLIHfamt6Jen8PhuJV+3kW4BXlTFY6IL8ojES3A1zkCgxjm3neok5bJ?= =?us-ascii?Q?DdpXe7aUUPko/gPfj8o6m4XYFjOh3PjPe51WNwt4Wpz19O5uVb1jd846QAR9?= =?us-ascii?Q?fq29GuDPG6ak47sdWtFVs5Qmn72qUeE7OTKo0m4R2r6kFqkcV9Q+NQV/de8U?= =?us-ascii?Q?kgKm+kse4c4+JggD2c64SO4DYynw/s8I8HAX/D+6DA4Yy6mQ3RwF1A2riWBi?= =?us-ascii?Q?5sIMs6MKvVvhCk9ntSAhomPefY0skp+u3cba4oa6dK1kGcpmZwtwSNXfYLH2?= =?us-ascii?Q?OLGxff3/DHGxMnWI2ndahPtHYE067Ou4ah21eyZemc7BhfnsNdh1yG0aDZKL?= =?us-ascii?Q?Ikcsy88gD8L1j/rE9mvTKOofzCboD50NurtaEa4f57Gdac/ZVCNMQU2Xo7HG?= =?us-ascii?Q?IA88Vb+I2QKsTn4aPzwGern9ZiUogDe9+IQNzIih7dF1imNv27BQwTdMzzXf?= =?us-ascii?Q?0COsyKyxIbPn2nYjTO88jKzVVvRnROvPVPOOx/DD5+F694F4+MTL8nCmqluq?= =?us-ascii?Q?+wAva2ZlLkpM1z0Ai+ZxSCb+fRVUmQTUOsJIMrom?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28138d0f-3998-43fd-b7fc-08dabc169577 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2022 14:37:20.8987 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V9p0/CjlnNmXNKeRflhxgEWQ7619FP9LMtINl1HuKR0wQOrp1xWygtagSQHZr8TNvfGNEgo+p3zV3DH9RdjMNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB6072 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Kinney, Michael D > Sent: Saturday, October 29, 2022 3:01 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Lu, Xiaoyu1 ; Jiang, > Guomin > Subject: [Patch 1/1] CryptoPkg/Test: Simplify BaseCryptLib host based uni= t > tests >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4130 >=20 > Remove TestBaseCryptLibHostAccel.inf and instead use FILE_GUID > override in DSC file to run the same unit test INF against > OpensslLibFull.inf and OpensslLibFullAccel.inf >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Signed-off-by: Michael D Kinney > --- > CryptoPkg/Test/CryptoPkgHostUnitTest.dsc | 10 +++- > .../TestBaseCryptLibHostAccel.inf | 56 ------------------- > 2 files changed, 7 insertions(+), 59 deletions(-) > delete mode 100644 > CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHostAccel.i > nf >=20 > diff --git a/CryptoPkg/Test/CryptoPkgHostUnitTest.dsc > b/CryptoPkg/Test/CryptoPkgHostUnitTest.dsc > index 369a1cb69939..3ed3e9b75d84 100644 > --- a/CryptoPkg/Test/CryptoPkgHostUnitTest.dsc > +++ b/CryptoPkg/Test/CryptoPkgHostUnitTest.dsc > @@ -20,7 +20,6 @@ [Defines] > !include UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc >=20 > [LibraryClasses] > - OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibFull.inf >=20 > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.in > f >=20 > MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTab > leLib.inf >=20 > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchron > izationLib.inf > @@ -33,8 +32,13 @@ [Components] > # > # Build HOST_APPLICATION that tests the SampleUnitTest > # > - CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHost.inf > - > CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHostAccel.i > nf { > + CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHost.inf > { > + > + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > + } > + CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHost.inf > { > + > + FILE_GUID =3D 3604CCB8-138C-488F-8045-18704F73E734 > > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > } > diff --git > a/CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHostAcc > el.inf > b/CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHostAcc > el.inf > deleted file mode 100644 > index 9d0fcfd3577c..000000000000 > --- > a/CryptoPkg/Test/UnitTest/Library/BaseCryptLib/TestBaseCryptLibHostAcc > el.inf > +++ /dev/null > @@ -1,56 +0,0 @@ > -## @file > -# Host-based UnitTest for BaseCryptLib > -# > -# Copyright (c) Microsoft Corporation.
> -# Copyright (c) 2022, Intel Corporation. All rights reserved.
> -# SPDX-License-Identifier: BSD-2-Clause-Patent > -## > - > -[Defines] > - INF_VERSION =3D 0x00010005 > - BASE_NAME =3D BaseCryptLibUnitTestHostAccel > - FILE_GUID =3D B1AED64E-B53A-4D69-B0BA-60EEDAC47A6B > - MODULE_TYPE =3D HOST_APPLICATION > - VERSION_STRING =3D 1.0 > - > -# > -# The following information is for reference only and not required by th= e > build tools. > -# > -# VALID_ARCHITECTURES =3D IA32 X64 > -# > - > -[Sources] > - UnitTestMain.c > - BaseCryptLibUnitTests.c > - TestBaseCryptLib.h > - HashTests.c > - HmacTests.c > - BlockCipherTests.c > - RsaTests.c > - RsaPkcs7Tests.c > - Pkcs5Pbkdf2Tests.c > - AuthenticodeTests.c > - TSTests.c > - DhTests.c > - RandTests.c > - Pkcs7EkuTests.c > - OaepEncryptTests.c > - RsaPssTests.c > - ParallelhashTests.c > - HkdfTests.c > - AeadAesGcmTests.c > - BnTests.c > - EcTests.c > - X509Tests.c > - > -[Packages] > - MdePkg/MdePkg.dec > - CryptoPkg/CryptoPkg.dec > - > -[LibraryClasses] > - BaseLib > - DebugLib > - BaseCryptLib > - UnitTestLib > - MmServicesTableLib > - SynchronizationLib > -- > 2.37.1.windows.1