From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 771DDD8027A for ; Thu, 30 May 2024 00:41:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KmLIF/Wi5YbOxvN9z2Iz8L5qzHDgG75XivGfAP710OM=; c=relaxed/simple; d=groups.io; h=From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1717029685; v=1; b=gtiLuTpCMgUorayx7Wwju3fgQ2Sdcw4vbuiXHQAQldqcHzrztgc1SMfeRQZeHOpAE3fuurvS aovhoOtgH+VRdg/DV8y35la2zchFuyH09vAIS8O4uDauT0JRfzBiH787cWOpOTV24mwkuPVmIA5 AvkCZE1ichgatXDl1LqRUgxT9lFT+Th1aTlf0BJpH7TM3vdrsSwPZKK2NCqCwWDEhMqbRhHRejR z9G8ikub9JfqB9TWXp9JCtUcWJ0mLMTsBy0n67hTXA939RNdTBwFgrD5T0nie7fCju0bBOqJ1Qy ecqnBCay5btvYB8nBXY6Ny3FnUs+X6dYEO8a4WlG8RHeg== X-Received: by 127.0.0.2 with SMTP id ip0VYY7687511xMqR83Ryc6P; Wed, 29 May 2024 17:41:24 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by mx.groups.io with SMTP id smtpd.web11.5113.1717029683442247989 for ; Wed, 29 May 2024 17:41:23 -0700 X-CSE-ConnectionGUID: 9GEMnWvHT1epzVS6ZHlHnQ== X-CSE-MsgGUID: XWjEF7EtQ2W8/ePrnkpqIQ== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="13705487" X-IronPort-AV: E=Sophos;i="6.08,199,1712646000"; d="scan'208,217";a="13705487" X-Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 17:41:23 -0700 X-CSE-ConnectionGUID: UFi4WExsTr2Ts5/ArNidIw== X-CSE-MsgGUID: oaoD3jlcTKiOdkNRw18f6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,199,1712646000"; d="scan'208,217";a="40058053" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 May 2024 17:41:24 -0700 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 29 May 2024 17:41:22 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 29 May 2024 17:41:22 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 29 May 2024 17:41:22 -0700 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by SA2PR11MB4891.namprd11.prod.outlook.com (2603:10b6:806:11e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.19; Thu, 30 May 2024 00:41:19 +0000 X-Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::6444:ca4c:aa3e:f8d2]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::6444:ca4c:aa3e:f8d2%4]) with mapi id 15.20.7611.030; Thu, 30 May 2024 00:41:19 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "abner.chang@amd.com" , "Kinney, Michael D" Subject: Re: [edk2-devel] GitHub PR Code Review process now active Thread-Topic: [edk2-devel] GitHub PR Code Review process now active Thread-Index: AdqxKDms81p5Mq2lRy6LTkfbwilSAQAiifSgAAkO3cAAACPRHAAUdsbQ Date: Thu, 30 May 2024 00:41:19 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=True;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2024-05-29T10:24:25.0000000Z;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=0;MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5872:EE_|SA2PR11MB4891:EE_ x-ms-office365-filtering-correlation-id: 14e0ed3b-fb02-45b5-411c-08dc804138d3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?B3xz694t54dmHp9XMa0BWPfzsIKAKS3TEo2DfRR29WYKSS39iWRq6XPB/u1+?= =?us-ascii?Q?gnQ+KHsOCmhJy/mbo7eVqpBVnNdDd9Z6EL44Ay/FGN5D4Y+9ttvEQpViKAgw?= =?us-ascii?Q?RCQsSr58Ue0IiIMZO50FqNRXW8WaJ8FQTvfzOVREi0ILMS3tlVgGubyTomKx?= =?us-ascii?Q?e7hEd2Se30hLGRqqRS3QZRu7Np1QLokH3ZKY5L1HhFvfHt8zKVJKkZEYEZf2?= =?us-ascii?Q?Mn0JcESu3SgRWhSP9PE7qDJNCGrCwSKvY62WKztoVnTBPyQWyfz5pg2Tw1UP?= =?us-ascii?Q?ryChgLjHIW3ZfGSCtb7Ne0t0NaIB5oWCr6C6tohNITyAVth5jFgLcf42XYmj?= =?us-ascii?Q?ag9TWbWNoJwAwol7SvM+A0pIfYe2arhpZ87pf4CaeJypzKS4dPZQK9/KVZv+?= =?us-ascii?Q?VqBFkDVCjvvQ8N/bl28UQjWRgmZdwQ/m/hNptAOe477WY+1FS86ZWBt75iS6?= =?us-ascii?Q?V7C1UpGgCdK9R17BdFX3dsrfyN15wuQNwL8kqzExNJyO/crJlpzk2BwxgKm1?= =?us-ascii?Q?20qOG6/RfEBPYT7q1UO+emochXaRo0LJOV1yswnf64pBqzNjBcNeHAWBy9Rg?= =?us-ascii?Q?uqpBNAQoSuPBzE8Hw4ZiYhwG6oR3VCG3shqeT1D83jImYWQBVTjHs4z6yjvJ?= =?us-ascii?Q?YD9Fo+4QlnYQ//z+LvgMQ3mIpGyid+qVOSgtqVyKJb/OIoYxb5l+Cm0aJTF+?= =?us-ascii?Q?NTZ/l1l7chsn4MO0MU4R0jO7mdQ6TMEvyutQ1xUL6aEmKFYwRDKwpHklSwDN?= =?us-ascii?Q?K49jAIvr9IsG08p8jG6/M+jjUpWYLirHKut40U/HtaJ1kTZa7zlZZfgQZD/s?= =?us-ascii?Q?qMtrGD6szqonWhpXWr8P78ouGVz8yVgXABCkpCoAQVYa0JyMeNEJUSEb2QMR?= =?us-ascii?Q?4ppl4JFmQaQgAtM6W5C+MgnA+oMStJn3R9C9oj27fOHQ9vquWdlqwaV5AeoD?= =?us-ascii?Q?iZl4QoEN6wUL8Fj2gUJee+1Lm5JT8gIqucTo/kPHCakdFc1PhhEwh5wA2P9d?= =?us-ascii?Q?ucGzBp/VzLvCpdbAIuov+/VAE+OD/vAQgnJ2q00QyuLOEgRofSMzUjTy7Cxx?= =?us-ascii?Q?wTbTpI4HeZs9OKwmXYT88sXirqFRdZS6dD9zzFzwDEiseOePx21xpeptrRVG?= =?us-ascii?Q?Rtxdqe9EOl8X587Yi+ovipMrQXTGTM88afOMxNfsQ+bCwZQN9iirXO6b3kQD?= =?us-ascii?Q?BWLFEK+gDov/S5sFRcKeMGV7n8YndGtHDGz9QtH39QMTXxjfO6NILF5lH/CP?= =?us-ascii?Q?afKBNoFzwSbrb8Ppg6V31fn/hgq18UNkNI8fNC5Q4hPi5LoryFaMuM4/QUzJ?= =?us-ascii?Q?oxI=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nPcBbl1bYrluSmN5ILtqY6k3R6531+JlzMFjM4jlSzX0UJTeeNHR8x7yv9mS?= =?us-ascii?Q?q4w/1diBM9CIPzQ3WAkAmN+zPXzsbGG6IRgfCgUCdMkAErUcD583jG9kE3Uk?= =?us-ascii?Q?2d1tSapKm26/KnFJQ/ineRuxod7cR8OL0DqsdYAc19XsGRV8fHpq06G6FT8D?= =?us-ascii?Q?ks9ZorEyg0YpOsMeEefPKKud9cuFVxwgwzGMfPMNFrqt7DUh65jBNEjbzsZx?= =?us-ascii?Q?o6ZDzUAgyTGzWxNTyOMgKEBFx8HYEkr+BUE0CGQ4mABV1Z6o6Kytw2JDU4Cg?= =?us-ascii?Q?b9mi7oLBTZ3DuhB+qBmQRcDpAdvOaqMsy/GKkc9q0Er0gsDPI19d7slNuXIS?= =?us-ascii?Q?124UohxsNl+6/RBqy9+dLKb8YUPKMzBkAzCwKn+9gcJFlC9S6J/zjiVrJNMq?= =?us-ascii?Q?an3SN7/Dr7JfnOIRRXNGiMJqfjDqzZL7Sjx9f4YUJKTZVKA2bV1UBgxS731q?= =?us-ascii?Q?JoAyjSDshN9wu2CnehnvlaQLn7Ch+Ufw0CPb/4c9fMHeXbKOVxWaLcfB69nG?= =?us-ascii?Q?sQebtn7PRmicz+YlE/a31nZOQIfaKwrtyxdtG09uSldr36ZNwCgR0RJxKn2A?= =?us-ascii?Q?iK4+1Mh757z6wuqZWjcoUMUaTeLd63vS+A42W2v98lKbqsWrVKqFR6sSrjxN?= =?us-ascii?Q?JjLYQVgWCPReVHEkZHukffqzJmINv19d3TA+/90dZ9HKg2cuQ9x5UJtrPl6n?= =?us-ascii?Q?+WHmJBEs3Sshs/fG36OdkT+34w0lFhJ/+TV7FAvo5KwC54iw5EGng5xkCwCK?= =?us-ascii?Q?q5yBDU830RzheXPn9zdDxTsrIUKwgbV0veJZB4U6v+9rMjVJICMGNSekSdND?= =?us-ascii?Q?pcmXvX6VdcBv0I5ouxTs4COWBsMSw0EnYdxBIbZUSTdMYvG7yUi6JFd9g1Ne?= =?us-ascii?Q?Fum97UaZ0s6Di+55qw641LUhlUpsOhVcVh0cTtUNE8RHExrCtkAYOr4U290i?= =?us-ascii?Q?GK3xPMXzm59JxvQrfjypJyI7FzlsMwhrRWhsQoZcQNUft/pkfnmUs+61XD3f?= =?us-ascii?Q?PXSX08BFREE/PIjPUcGcpezjffTGhxHV+l/1rmTpTMvzo09wW3U39rjvFhA2?= =?us-ascii?Q?sup/fO5GzIq0jmFaUr2w5fftRWne3emG5/aLfRq9oIv2pUA6JVVD+O7X0arz?= =?us-ascii?Q?tQ8Gw2/dhqfI1QF25jMp7nYjoYh0KpZ3JPbjbfAEcmDWZiZL9ORC0uauv5KY?= =?us-ascii?Q?+uBFCAgYHJoh48K0/DPG8KGOLLKxzGcw/lrITzO+XMEgpb7bRY+55+efTKhg?= =?us-ascii?Q?oBpXtKVptMu3guOUgdlQQMF81Z+Uscw3cQompUwUTyBtUheYryokmfFnY7ql?= =?us-ascii?Q?ojChl2cZFF1a8qLOEI6WSUI2gOKjAGyVdOyNVtGemnzKKuNvNp/ZBYhzPVLC?= =?us-ascii?Q?pCAtcpcIrJlrbSHN5A5Ab5whPgXViba4uTsMS4Cg8nGAZ9UUdXA8Z3E4dPFV?= =?us-ascii?Q?ecHDkf5+HrpeJRHd0ufPJSP3lnZ4RPP0qYruKjLabxp5+P922U9pSsdMY/3V?= =?us-ascii?Q?Wwhr6nFPJnspslHuhkP8qMoVyGuw8E9Uof8uO6tQaLOMP8QmasBTw+R2hna2?= =?us-ascii?Q?xu5HWPLzFY94cvPK7INMtqeL7vebqhrDNYMJR80m?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14e0ed3b-fb02-45b5-411c-08dc804138d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2024 00:41:19.3854 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QHFqEuxQGLOD+FGhc3vw57hFQTSIwRZsiqSUTpnutY09xa0GSarbbyjTbz2zzLALtDSxnVJI6GdWb4iQIqRiOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4891 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 29 May 2024 17:41:23 -0700 Resent-From: jiewen.yao@intel.com Reply-To: devel@edk2.groups.io,jiewen.yao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IXz2c8TxbIsRA1KXAtA1dQ4hx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR11MB5872898243365A6BD9DD1A9C8CF32MW4PR11MB5872namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=gtiLuTpC; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) --_000_MW4PR11MB5872898243365A6BD9DD1A9C8CF32MW4PR11MB5872namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hey It is great to see what we have moved to PR process finally. Just tried today, and I confess I made a mistake - I forget to add PUSH lab= el, but just click "Rebase and Merge" button directly when I see it. And th= e patch is merged successfully. Using github native approval and merge process is very common in all other = projects I have worked on. I am not sure why we still use PUSH label. Shoul= d we consider to retire it? Or, if we cannot get rid of PUSH label, then I think we should disable "Reb= ase and Merge" button. (For me, I cannot help to click the lovely green button when I see it.) Thank you Yao, Jiewen From: devel@edk2.groups.io On Behalf Of Chang, Abner= via groups.io Sent: Wednesday, May 29, 2024 10:48 PM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Kinney, Michael D Subject: Re: [edk2-devel] GitHub PR Code Review process now active [AMD Official Use Only - AMD Internal Distribution Only] Thanks for the clarification, Mike. Thanks Abner ________________________________ From: Kinney, Michael D > Sent: Wednesday, May 29, 2024 10:44:41 PM To: Chang, Abner >; devel@e= dk2.groups.io > Cc: Kinney, Michael D > Subject: RE: GitHub PR Code Review process now active [AMD Official Use Only - AMD Internal Distribution Only] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Hi Abner, Yes. The plan is to apply to all repos. We want to use it on edk2 for a while to make sure we get the settings and process correct, then we will expand. Mike > -----Original Message----- > From: Chang, Abner > > Sent: Wednesday, May 29, 2024 3:41 AM > To: devel@edk2.groups.io; Kinney, Michael D = > > Subject: RE: GitHub PR Code Review process now active > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Mike, > Wondering if we also plan to apply GitHub PR process on edk2-platforms re= po? > Or other repos under tianocore? I found there is another email thread "En= able > GitHub PR, protected branches, and 'push' label" on edk2-platforms, but n= o > further discussions then. > > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io > On Behalf Of Michael D > > Kinney via groups.io > > Sent: Wednesday, May 29, 2024 2:54 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D > > > Subject: [edk2-devel] GitHub PR Code Review process now active > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > Hello, > > > > The GitHub PR code review process is now active. Please > > use the new PR based code review process for all new > > submissions starting today. > > > > * The Wiki has been updated with the process changes. > > > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II- > > Development-Process > > > > Big thanks to Michael Kubacki for writing up all the > > changes based on the RFC proposal and community discussions. > > > > We will learn by using, so if you see anything missing or > > incorrect or clarifications needed, please send feedback > > here so the Wiki pages can be updated quickly for everyone. > > > > * The edk2 repo settings have been updated to require > > a GitHub PR code review approval before merging and > > all conversations must be resolved before merging. > > > > * A PR has been opened that removes the requirement for > > Cc: tags in the commit messages and is the first PR > > that will use the new process. This PR needs to be > > reviewed and merged to support the revised commit > > message format. > > > > https://github.com/tianocore/edk2/pull/5688 > > > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message- > > Format > > > > * Please use "Draft" PRs to run CI without any reviews. > > Once ready for reviews, convert from "Draft" to > > "Ready for Review". > > > > * For active code reviews that are almost complete and will > > be ready for merge in the next few days, the submitter may > > choose to either complete using the email review process, > > or switch to the PR based code review process. > > > > * For active code reviews that are expected to take more than > > a few days to complete, please convert to a PR based code review. > > > > Thanks, > > > > Mike > > > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119372): https://edk2.groups.io/g/devel/message/119372 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MW4PR11MB5872898243365A6BD9DD1A9C8CF32MW4PR11MB5872namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hey

It is great to see = what we have moved to PR process finally.

 

Just tried today, a= nd I confess I made a mistake - I forget to add PUSH label, but just click = “Rebase and Merge” button directly when I see it. And the patch= is merged successfully.

 

Using github native= approval and merge process is very common in all other projects I have wor= ked on. I am not sure why we still use PUSH label. Should we consider to re= tire it?

 

Or, if we cannot ge= t rid of PUSH label, then I think we should disable “Rebase and Merge= ” button.

(For me, I cannot h= elp to click the lovely green button when I see it.)

 

Thank you

Yao, Jiewen

 

 

From: devel@edk2.groups.io <devel= @edk2.groups.io> On Behalf Of Chang, Abner via groups.io
Sent: Wednesday, May 29, 2024 10:48 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2= .groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] GitHub PR Code Review process now active

 

[AMD Official Use Only - AMD Internal= Distribution Only]

 

Thanks for the clarification, Mike.

 

Thanks

Abner

From: Kinney= , Michael D <michael.d.kin= ney@intel.com>
Sent: Wednesday, May 29, 2024 10:44:41 PM
To: Chang, Abner <Abner.Ch= ang@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: GitHub PR Code Review process now active

 

[AMD Official Use Only - AMD Internal Distribution Only]

Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.


Hi Abner,

Yes.  The plan is to apply to all repos.

We want to use it on edk2 for a while to make sure we get the
settings and process correct, then we will expand.

Mike

> -----Original Message-----
> From: Chang, Abner <Abner.Ch= ang@amd.com>
> Sent: Wednesday, May 29, 2024 3:41 AM
> To: devel@edk2.groups.io; = Kinney, Michael D <michael= .d.kinney@intel.com>
> Subject: RE: GitHub PR Code Review process now active
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hi Mike,
> Wondering if we also plan to apply GitHub PR process on edk2-platforms= repo?
> Or other repos under tianocore? I found there is another email thread = "Enable
> GitHub PR, protected branches, and 'push' label" on edk2-platform= s, but no
> further discussions then.
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: devel@edk2.groups.i= o <devel@edk2.groups.io&= gt; On Behalf Of Michael D
> > Kinney via groups.io
> > Sent: Wednesday, May 29, 2024 2:54 AM
> > To: devel@edk2.groups.io<= /a>
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> > Subject: [edk2-devel] GitHub PR Code Review process now active > >
> > Caution: This message originated from an External Source. Use pro= per
> caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > Hello,
> >
> > The GitHub PR code review process is now active.  Please
> > use the new PR based code review process for all new
> > submissions starting today.
> >
> > * The Wiki has been updated with the process changes.
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/= EDK-II-
> > Development-Process
> >
> >   Big thanks to Michael Kubacki for writing up all the<= br> > >   changes based on the RFC proposal and community discu= ssions.
> >
> >   We will learn by using, so if you see anything missin= g or
> >   incorrect or clarifications needed, please send feedb= ack
> >   here so the Wiki pages can be updated quickly for eve= ryone.
> >
> > * The edk2 repo settings have been updated to require
> >   a GitHub PR code review approval before merging and > >   all conversations must be resolved before merging. > >
> > * A PR has been opened that removes the requirement for
> >   Cc: tags in the commit messages and is the first PR > >   that will use the new process. This PR needs to be > >   reviewed and merged to support the revised commit
> >   message format.
> >
> >   https://github.com/tianocore/edk2/pull/5688
> >
> >   https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message- > > Format
> >
> > * Please use "Draft" PRs to run CI without any reviews.=
> >   Once ready for reviews, convert from "Draft"= ; to
> >   "Ready for Review".
> >
> > * For active code reviews that are almost complete and will
> >   be ready for merge in the next few days, the submitte= r may
> >   choose to either complete using the email review proc= ess,
> >   or switch to the PR based code review process.
> >
> > * For active code reviews that are expected to take more than
> >   a few days to complete, please convert to a PR based = code review.
> >
> > Thanks,
> >
> > Mike
> >
> >
> >
> >
> >

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#119372) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MW4PR11MB5872898243365A6BD9DD1A9C8CF32MW4PR11MB5872namp_--