From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.3253.1649832119548368964 for ; Tue, 12 Apr 2022 23:41:59 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RFIsl9ro; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649832119; x=1681368119; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gx9WAlXX5VYHDMr5jemlC0yC8TuE4cxiBlYUfN27ZkE=; b=RFIsl9rops6gFghSWSdOfRwBqYZPB5lwiLF4UoZIhfZpFeL55GX8oC/X XDmaC3/QCIlH+ORqhrU/Oh/aKF3T9jd/Ut3AtIj8xLesLJeap67mmnzYx eAMJX5TlcYwG1E743w2SKefxKBUYaGDz+/ZJweom5xOHTqDX5UCk6vZJ0 sLjIKr8sIMO4r5TUhF8YMyRYBNX8AsPRTBdd/FgJW5IWHD1v2Z2terlSd ZOIvM8ASd8ULWWb9sDENvw8grzF92VicFFiPsh0y2MKUnytobQZioeMmB DsVUliB28SZSy5Z8J4/BSfgb/ng+FZxeaF5DtjJAqGIXWwsDnDxj46/Zu g==; X-IronPort-AV: E=McAfee;i="6400,9594,10315"; a="349026162" X-IronPort-AV: E=Sophos;i="5.90,256,1643702400"; d="scan'208";a="349026162" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2022 23:41:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,256,1643702400"; d="scan'208";a="724779356" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 12 Apr 2022 23:41:58 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 12 Apr 2022 23:41:57 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 12 Apr 2022 23:41:57 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 12 Apr 2022 23:41:57 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 12 Apr 2022 23:41:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T3ttskegXvmdbWQzjz2Nclb44sxhdDpXaCvj/RgSVAazhICvJcuKTtMxjs/CU7x7VM6Zy3S5AyjXzcDTnqRGd+RHYUnuq6vRZhaOh1X+FmeqlZf464uebwYwF3PldU+QTx33lRmOFgFWjZYZpa0jYpdWdvQiuj1zZt31ttezmSGUjZcRd8VV2kZuIF8b8MOuDQdK79wMOOeJS1wS+wHR9lQx003gpR5MRGbbfodT4jExVFQBT2AHasJPqub3E3t03iypwQtGpeE4mwagROeCpMTKOp4RGg2FCqWEZAlaDEzqvAnN7Z/IqkgO2lZ4DUZ0/ZNSuT+pK5x9dlYwSQ7aAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6+AY9hnAJmpfz5WOxN4CuFQ+M+t2s3vWH0s7K1/+yWs=; b=cnEHzPgunvtjqojapcPSMG8ZFLTXXCxEH8lozsQJcWPpUiZ9JWr9M58mWC252ZqS/GlNhJsyP9P4XNE5xd80ONM8BT5ykCT4/PhZNwkKaIHnoNnO9znlPakG/zkZ56YG97lAsOsknRbdE2qskdF78H2AwTJhgEcEtfc/fdN4C505dX6NjOUPwjuHEOF16epoYjlAJ0zmkNAt+VjbTjIAx7H70jN8uNPyNW020xH+lNMPgq12bOgj0U3JyrZ25K/XQgTvyW5Uz8KLZSEwSvPA6M+TnEp4OT+9u6nSFtrUSwMg11Jc0mIwR2kiwRHUDcgAGlGX8eINY4rAM8eUaXJqHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by DM5PR1101MB2090.namprd11.prod.outlook.com (2603:10b6:4:51::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr 2022 06:41:56 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::198e:ea23:c83b:b93a]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::198e:ea23:c83b:b93a%4]) with mapi id 15.20.5164.018; Wed, 13 Apr 2022 06:41:56 +0000 From: "Yao, Jiewen" To: "Li, Yi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a customize-able way Thread-Topic: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a customize-able way Thread-Index: AQHYTv8sEInIZOqBVkC7j4+YyPwqSKztZN8A Date: Wed, 13 Apr 2022 06:41:56 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4af6390b-be60-4e0e-2953-08da1d18b3fd x-ms-traffictypediagnostic: DM5PR1101MB2090:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d9y5t9HI7GUYmicDdRvfo81R7rBA4Ar9ufJfR1CaZ8G6jWbFJcHzBaeEFejGM/FkjAXYnnE2UoBjd1RR4j5SVBTz054hp8ylil7h7sRJxSYX6PAiYHaIRucu6D+GdI2sBPemzeXSOMtBRWodGScw9WliXYBNpbodtuAIHJQOhcxNsRZ4WN48FPCDIr5jTWPCy0irxkqQPFsmRqRm/f2fqpMjfp2sJQkAEKvAMyD3riG6gufiY7o5D8m9kSIKr692qVnJimDzdfLL4EhKVCcVUViNrgGk9fbZIouCPjXAU+XBq/eNxNV0frRqPHZ/mleb85gRFfq7H2h0tbhgH9jcFn0k0Khj8OT0iC6PuTNqDtNhq7V6iWUD0Oe6VdnivAsURbnjDGmeXm9pBe5g9VmBcqkOYUbdtYUJ9scoQppb5k+LoiQVF68xFJ98q1qOhUJtR4OEKxzuA8hMXcdnPlPB2XiJy3QKTymtzyoDkdnoY0ukIb6tEZl8IbkHCQS0ySb6/X6zGjaxRRsDKkqiFLqmyMwu1VKL3fCvr91lqdZ4rkIG0FYnAvVhuo61uS6ICEcjxRZvN2lYaLRTFZGgQrsBkWunU4Yiky3vfzCnnhBFboiSPWLX+0rMady48Mr2MYuJ9tVh6tMTB4dKe+IQcG3MROrBcS+AdNhhQBf6Mtrs3I0XDCoDnoMxe1kfqryZv4hFr40mfZqyysS4e84FgealYW/Sw35P5tUABWz3RfXeFjnbw82Zq8Q9i4TxZ/1QODImg0c0vp9kc1l/zInh1XB7HbWyIeGv/0ySjtxS/a+vPqY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(33656002)(4326008)(38070700005)(8676002)(107886003)(26005)(186003)(5660300002)(2906002)(55016003)(83380400001)(966005)(19627235002)(316002)(64756008)(66946007)(86362001)(76116006)(508600001)(66556008)(66446008)(66476007)(110136005)(52536014)(53546011)(7696005)(9686003)(82960400001)(6506007)(71200400001)(122000001)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VI01/pDYwMiRWDgJwh3OPKrS8izP8c2lJieFOyfkV8Ee9cx0NU+NTBiMqEWY?= =?us-ascii?Q?IdBPlKdkdBFRg39kmLopa9owmiopWUDF3rulUy3QVvQxoOZ4jQafKqZZKnTs?= =?us-ascii?Q?KOTlSTW2Wc6d7bUDokuv/sClfU9luOOuexOYuYyHGSCsvasfB0pKW/gPDgpw?= =?us-ascii?Q?nJ5XAD/6TULQ8+Z3BccJNBVHz2MttXS/b1VKr6ilH/PW3oUey9dI9EI/uZAx?= =?us-ascii?Q?4rtAx0aUiRI2Rz/An3Zno2H/EM2srXEZM7N9eD1Trcu93fS1upvUUP115Hsl?= =?us-ascii?Q?s1magNvIL34rJYvl7H5Ywuu/7BCTmqz1T8u5a+A+BtYVEp3LQmsvcH9sKr+P?= =?us-ascii?Q?hJr4ucPQyVIaP9gFpq1sG6sYBEm9MvMDdrQ2sVVBy03x9bIhKCIyAiSxB/Oi?= =?us-ascii?Q?vzXpzoWm2qWnjkAT2lbB8pkRqg9rumQjtJzEtyq5zTKI+0/COrQ8TA+tBjgf?= =?us-ascii?Q?CHSsZW0QwrD0TUu/9eDMTCI0XD4q98WhHtnY1PJCd3BzOpFD/fL4h1T9mHfQ?= =?us-ascii?Q?P/1xtEIVOhw6LVsV/5JYSJ9XPX49YgjhPO3DM4opBFTxfc0NkL7cddJCc18n?= =?us-ascii?Q?1QI7Uk0IJvpWue/itVvLFuWBlqXRj6YO0dWErSodSyn7XgKE+isOGozINCbT?= =?us-ascii?Q?FNU1eoysg2fXRhDruc+8oSOe4f5oZP0a3Mxa3O9rW4eO1G0rYLQI1Sf3c9ow?= =?us-ascii?Q?fBQID4roJjkvyKwhufsiHtHicsUSDybemnTGqUWBjp9wRrmAEumqkWQRTEmK?= =?us-ascii?Q?QSeWIKrb4EqkbC+GscuDBzrL5JW8MRPN2k5J0EjIBeG2tGGkSJSRDSAO8iRX?= =?us-ascii?Q?x46dV+rpVskNpbiqE8Fb8WKd6qz19LgZn0bzRDAZ+3ZACahWHD/PDErys2N4?= =?us-ascii?Q?btx4E/7XPYDnyO1AZS8ifmRe16TsWXqwjkD0ufTYK760A5ZUvtAjmlPyHvyN?= =?us-ascii?Q?A+VYGGSXTzS85KTjDKRtm0y45IkgaZYE0CaNqE2HjUEQOiGPlSgMcf4m7z89?= =?us-ascii?Q?cj0/w8s0ruRaBKPhH6GXhTlHAyscLWfbFI1XcTWWIbaeKFDKeoIUWDqTHuYv?= =?us-ascii?Q?s8JNSJVsDhpDp/9KAORxoelrVeylGPTD+C53djr2ijSt544tFx3uQUjZdg4F?= =?us-ascii?Q?MfhE60eIGfOGTo4zDbwFoJgUpWqCWluPjDEfysK0EE9+2rhEyEQB6h04g2xY?= =?us-ascii?Q?7vCmNr/mBlhGc6zLCBiTBvUTTIMBCHEfCoL+A5O16lEn1mPZoqPyqO/ZMyXO?= =?us-ascii?Q?lFZfvntWrblWxkkFiZRtOTE4rN3ehRdy2l4l5jPoIzEgWX3YuQLizV1KWPO4?= =?us-ascii?Q?0VqTNL8ZRLDhcoxN5jUBBLrDEsHQRztRPVjxlBeJE1EBKVdLaOyFmHAXFs4g?= =?us-ascii?Q?PaIhloSGW0d1lkZ4Yi+h6kHxw99gM7kU53U9ckOUjN0BPz1D7d5Tc/6DfpJ+?= =?us-ascii?Q?zD4fQCqziv6c1y83BiFON+yBmTLOuaKe8eNwa1PdMdBJDr5rDSzjzqaLEwDJ?= =?us-ascii?Q?oGl4CxWdBVIpD6FdPklr7zIWLVsKZMQqrxz3wlRuABgyZjIgKn47MnpY/7Br?= =?us-ascii?Q?w5FF75G7exzJr3hnWasNJm59t0CLhOFKekwyHFSuxPE0/TfFdT5K2r97Ky8k?= =?us-ascii?Q?KomXulWWHdr7AywDh0AoAOmx8Lne8LjUbtQbmb2/CBhiSyjeMsJH6Xnofzer?= =?us-ascii?Q?ypN4eBybPLbRVwxu/bsvy/9DTBGMDDAkxdRk53DYcOYfuFQKzmpsXtaizAKC?= =?us-ascii?Q?m9C25p1JIg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4af6390b-be60-4e0e-2953-08da1d18b3fd X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2022 06:41:56.1699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bERVzMzVYdFkxEpRjV7XxhMvM2ITjUhehZh19udDiHFzQNIWyAyq4DYPINaDUD604KZnd0qBT+SMvbZ1KCtkWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2090 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the contribution. Great progress on adding ECC. With PcdLib removed and "no-ec" removed, the series is reviewed-by: Jiewen = Yao > -----Original Message----- > From: Li, Yi1 > Sent: Wednesday, April 13, 2022 2:24 PM > To: devel@edk2.groups.io > Cc: Li, Yi1 ; Yao, Jiewen ; Wang,= Jian > J > Subject: [PATCH 0/3] CryptoPkg: Enable ECC in openssllib by a customize-a= ble > way >=20 > EDK2 has Enabled a feature which allow SOURCE section in INF files to > use Pcd to customize source files list. If Pcd equal to FALSE, this > file will not be compiled. > https://github.com/tianocore/edk2/commit/ > bf9230a9f3dde065c3c8b4175ccd32e44e8f0362 > The patches add a customizable EC feature to CryptoPkg by this feature. >=20 > If Pcd equal to FALSE(Diabled), the binary size will not be changed. >=20 > Size diff(Bytes): > | CryptDxe.efi | CryptPei.efi | CryptSmm.efi | > Before | 815,616 | 540,544 | 563,712 | > Diabled | 815,616 | 540,544 | 563,712 | > Enabled | 1,008,352 | 721,408 | 744,832 | >=20 > Cc: Jiewen Yao > Cc: Jian J Wang >=20 > Signed-off-by: yi1 li > yi1 li (3): > CryptoPkg: Add instrinsics to support building ECC on IA32 windows > CryptoPkg: Reconfigure OpensslLib to add EC algorithms > CryptoPkg: Make EC source file config-able >=20 > CryptoPkg/CryptoPkg.dec | 4 + > .../Library/Include/openssl/opensslconf.h | 10 +- > .../Library/IntrinsicLib/Ia32/MathLlmul.asm | 98 +++++++++++++++++++ > .../Library/IntrinsicLib/Ia32/MathLlshr.asm | 78 +++++++++++++++ > .../Library/IntrinsicLib/IntrinsicLib.inf | 2 + > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 50 ++++++++++ > .../Library/OpensslLib/OpensslLibCrypto.inf | 50 ++++++++++ > CryptoPkg/Library/OpensslLib/process_files.pl | 2 +- > 8 files changed, 289 insertions(+), 5 deletions(-) > create mode 100644 CryptoPkg/Library/IntrinsicLib/Ia32/MathLlmul.asm > create mode 100644 CryptoPkg/Library/IntrinsicLib/Ia32/MathLlshr.asm >=20 > -- > 2.33.0.windows.2