From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.11179.1654601633707842798 for ; Tue, 07 Jun 2022 04:33:54 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=emZtTAgX; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654601633; x=1686137633; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NhCtfq4HKWAOBHTPFAkMI8PwZzVAr94T9ZGJlkWniac=; b=emZtTAgXfclZFcawNxI+TxXu6NdG7CTQQxACMGBKkOrwYZpcwwWjhqGh 285GXGsgbRxm4zQgnXz44tWcEF57RX8G1A/6OXrzLuVfz25f/4r9u2Zdx QQMj0Jc7TYp5UuM+8M63e/SL1K8YmWy3FAqFoDXW0GIJA3X0Y711DvLP/ 6SskHj5QL8lmsnbozDbpheQdYBUpLUS5Y/xEvPDa7IkEV8u1vNomlBz/y 3T8p4l2lE5vgjooGbTsFgAayrHDjzW0aXCtCSrKkTx+nMJWgJgB8XhYWe 5KQvFVMsuBWFxBTFKjseVvxk3h2QMOaaqZ3nRcPkKQ58Dyi/40Cu/qvZ9 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10370"; a="259469945" X-IronPort-AV: E=Sophos;i="5.91,283,1647327600"; d="scan'208";a="259469945" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 04:33:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,283,1647327600"; d="scan'208";a="532565852" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 07 Jun 2022 04:33:52 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 7 Jun 2022 04:33:51 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 7 Jun 2022 04:33:51 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 7 Jun 2022 04:33:51 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 7 Jun 2022 04:33:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=frWAS0r4C690PNK0VATaA4z8iEqcfkIyBJZcAFyijuOiRSJ9nvrtfyWMcD+1EI6pMiNDP4BmSIstPZzUZ+1lQqVRUqVA67TgspjgebT0FJ7QiNLzeOhFv+EFPh77CP89t5HWGzUG8RND9o95aHmex8Be2cBFxoV65VfuwqimdQyIUpSlso+pGIfGzGyX286J1RcYL38BljB/x/gK04xA6+dUuhiiHjrCC0przlx2CzCJeALpmV8d+T0QfOtCn5qhP/pM0/euDjFDFR6sVY+vGBpmvrWk5XHzg/gAeDNDYUFFcMtaQjSTKjXrFxUkjeiAdN6yEZe9nWb9rt2wfeDZCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yQ4flf8R5NCEH7CEBjw+m1KkEpDGeZerkWWYLHnj10w=; b=X14TcZG4jBbd6EUeLcyk0JAR5HqFKFoKfY4eErz7SqlXv5axadSnBnGDpwB5tXaxUJUL8wNvtnL3qsqS9s5JhG1ooPVvUdcj485zN14gE9Cas6HHD9r8pDaXkSi7YFD3CxKMW7yBgEg0phh1Z4QWSKgxOTQ9C43GKHDi1a5MzY9+mZDSLrRWhDvqrzxGFxi3+WRrWsLbQigH3UIH5Vrs9U1qM8Q+2DExx+oAFZ+ftFcGuHJgwQnZ6YDvZ1ftwlqXflfVDWyrdF0Du4YVGpkck4g35t5EjSZkGRIEh0OXQygats1Z+3za7HCYom+Wk5i65O08fuiYkOzvNBn/CJkXWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by MWHPR11MB1421.namprd11.prod.outlook.com (2603:10b6:300:24::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Tue, 7 Jun 2022 11:33:48 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::24ae:1cd3:3192:4c7e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::24ae:1cd3:3192:4c7e%5]) with mapi id 15.20.5314.019; Tue, 7 Jun 2022 11:33:48 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "Xu, Min M" CC: "Wang, Jian J" , "Aktas, Erdem" , James Bottomley , Tom Lendacky , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH 0/3] Introduce SecTpmMeasurementLibTdx Thread-Topic: [edk2-devel] [PATCH 0/3] Introduce SecTpmMeasurementLibTdx Thread-Index: AQHYeHgEaWeph+dVlU+NIGI+XLaRZq1AEaTAgAPCSeA= Date: Tue, 7 Jun 2022 11:33:48 +0000 Message-ID: References: <16F5977C8286B4B6.24312@groups.io> In-Reply-To: <16F5977C8286B4B6.24312@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8306d72a-06c7-4c1e-575c-08da487996e7 x-ms-traffictypediagnostic: MWHPR11MB1421:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fO6K15IEen8QL+qfYQB9e7NQP3Z4Fx52RZSc3eKZrCyRAMxWypmZDfVBGl00LY1/BsFXUA6MUBce5HLJYvrXqxbsqF7W18G9lcEkkG/Ycb3H7TpwleTVMGkz1k6plXWtC5He1OkpyLs1HIBuE4j0c+nViEmUC48KvG3D5sfrEI6NIn0mIdnon98yL7hH0l4veTuQdwu3lIoiYU8Q0hcKnmnfjC4ASFbvp4R/MqKHiC1s1+qpPYbkpCIjqp0aaZDpnZ9E0IIA46xbnIVH+qVrshIGOxscXEnXugeddWWfl1Mt64AphqAQmPa9PIS/sj4Q6mC4lG2KyvG+uMlVA+/d+nttktHjZkjPjujdg+/Fs+ijvLcRLeBSwVH6F4go7CaxdPhGFIEO6WGZLiBuc85OJ0uj+iLysTkRXm8gfR9wRhjAFHQgyjHAVCZO2Go+SpjVkNKtyp81FmL8Aaxyl47PKdSWkdeLsQykdVbB7BY79cg3+hWh+MrLswV7hiOZCobRgvymxvg2YERZ0ubuSYKg4BGQ5KAsINhg4ke5fvGrnIvLE79szG2U0JT3fElDHuC5xuGkbgdd2hQnJfBUjio1eHfbIDN0FRZVglItpXH5BKC+/gQ569Cyk+LbCDK39We/17HLWcd47QNQT4njjy4cZ6aFkU5ZODmNoAOzufabaSFbk647OlSJ/dj/E+Ip2JLj+xOz3DhaqdDZZsp6tmf7cf16REQG/otCZtYJjxldSjLy7c2lgwVA8J4q2jcLDr0I8oUSRTejerVtALNQzSwXdRp6/9ptoTasSTIc5HKmdYNueQINH/pVhvdrsojD80iQnXPXGeCfG9/zpaBpmhV/SjFp/6ArSh49C7e3FsrN3/o= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(64756008)(55016003)(6506007)(6636002)(966005)(53546011)(38100700002)(54906003)(83380400001)(7696005)(2906002)(5660300002)(52536014)(4326008)(82960400001)(71200400001)(38070700005)(66446008)(122000001)(316002)(8676002)(33656002)(19627235002)(186003)(508600001)(110136005)(66556008)(8936002)(76116006)(66476007)(66946007)(26005)(9686003)(86362001)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qPrFA5jxM3EkT0k5EzegQ6A4LHRUexNRPOWEg9uPAfivv1FqGKeSK5gYIaC9?= =?us-ascii?Q?33Djv6W+jAjV9YFzAmDqGv4sERSiIBVfGYUGFnULAOEitZENgbKAvw+wcoli?= =?us-ascii?Q?iXCBCPPOFcNmMU3zMKrJiHvJkAT0pbHeyF7ArYcP1xKu39ZLM9I2orX51NXs?= =?us-ascii?Q?pciqIOckl9E4affDBgnw88tBP4+g4AFl3Ozy0gpSeesEq+OQbucro3+nfcLV?= =?us-ascii?Q?QkzdonAYfEdR5G+3haVR7ESvwzidxt6JEuPpz9ScrxywQmik/EQYzNh18Mc2?= =?us-ascii?Q?mH9PSAXHkeomo5QJn8QVLX0uUPG1URIEdfn10lRmy6R4z7iQfOZvtUUQK0k6?= =?us-ascii?Q?ZiTlt+axNSUdmrPkTh8QUFlQ/WVN6T/kkgglXrzhptzsQ34LjA2nXN/eycaJ?= =?us-ascii?Q?2Q9mdBbVED0BYv7Qo240euMDjoxik5jr9FcfxLN10Fp9FkcCkbRCNJcRpbLA?= =?us-ascii?Q?Flh90Cj1wJ4Tz54O4opUhE5qU/Wnf+wj8dgxPQhi1UPeXsNMbuxG5yPc9Lxq?= =?us-ascii?Q?Lt/fdkIo1Bnq8ixeutoi/20iH0gsTGcZqyNVmyplRTGVL31lfYOzR4tl6uLY?= =?us-ascii?Q?yboW9yEdYKaoYjV6ek/jcRIPsvbGAMRlVMTzRxRgW0pnZtggg48B8zUYi9A0?= =?us-ascii?Q?6yoAzexOYgK4qEL9P+DzbLOnIkBYuv4mqywy4VWtDirKTJQ1AG79f0eIYOOj?= =?us-ascii?Q?8WWNiV+Vy//ZfX/pWZGXrQaCZ+jYaVJSHL5WAYAVERjE95lp7S/oTGjOiqCl?= =?us-ascii?Q?AdHLVOS/X0G3XS5c3la7I/6tKo9jhIAJGBG90GG+NJrRQ6du/9uIDaN/KCc/?= =?us-ascii?Q?xurhu2bXXhcU0HB6N10vziyh8jHkjRKSsit8BhwfJSZAo3vXGgMiWjE/v/5K?= =?us-ascii?Q?Cm8RQqOTr+e1dUGwBTUxmBZdJQzRdqC/a2Y+mpSZrkaGRPi1BBC7j/zlY/pq?= =?us-ascii?Q?NK0XbnvQ6i5dKTj/7JW4SdFvOwYXcyOhjTEgwxTDHvie0GZHspS4UCJD/Lah?= =?us-ascii?Q?0kgw0+CBYe82JKr+SJM6o2hARGFvtRfU0UJc9CB5Ac98ibHLH5/bXGqq/pLp?= =?us-ascii?Q?4JpRU03grdk6HT7IfWQjjIiw53emrpeN/9POmJjf4f+UD74z9dJ3wWNsZOgH?= =?us-ascii?Q?lZv7zzC/b/lzueUn/CbfnYhZ2FoUPCAymkUaQUusHb+r1b4A73cN0X7jmzfu?= =?us-ascii?Q?ZL5/HY1Ef/Nl+o6JMNSGpXIhEicJlRuzTvoz5odK7qbgqIlA9pAerWkTRUrn?= =?us-ascii?Q?JzPs54CRxfDsVANTJDd+FR0RQULsuTDJXs/hoQ4RaounJJ05El05ZhbfgvaK?= =?us-ascii?Q?AY/z8wmmf/1L1QTdNQG/+exuXMOCAoqWe1/qEU6qLwl8AtuqdM0iMc9XdWWG?= =?us-ascii?Q?yIAfY/iUp/rUwFcL7dsXXv0swSFt8jQOKMtUwJ81ebXBjuwsLl/DFciETgm8?= =?us-ascii?Q?I22t7joNfifJvqweCe5N8rwxhNuLJBA6iulQTKQ4/2xnpScZCUfgLvD2hObe?= =?us-ascii?Q?dE4VR8uGjMJ2gnei7wPsvT9ubaPLm0P6pVpX64KUKDz19LUuj7+NL3+Lq5wb?= =?us-ascii?Q?auKIbgN7WdsedRn1wczGEiXh1NYkwIz5qJNjX0ruXvs4xFcOqH0ZGQ84Xt/j?= =?us-ascii?Q?iczqUh2LvtQ7B3Tn50EHhg4s45ALNWNeDLvUOOmHH1neVBq+TpACXSTVNQpl?= =?us-ascii?Q?mIx+0Bq3Mn7ttBMeo6gteV+uTbTdg94NryB9QvQHIzuA2h3Jmvjg09ilXXoZ?= =?us-ascii?Q?yxGPLDnQsw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8306d72a-06c7-4c1e-575c-08da487996e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2022 11:33:48.6176 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6b41S6ilGFjtmHn2Q0ThafsEJQD9dcbnkmVE5lcyXL9XeckwmqvNwPGbHwKvKuEAG71Fctf3k3rVIH2K+xV/jQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1421 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged https://github.com/tianocore/edk2/pull/2951 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewe= n > Sent: Sunday, June 5, 2022 10:10 AM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Wang, Jian J ; Aktas, Erdem > ; James Bottomley ; Tom > Lendacky ; Gerd Hoffmann > Subject: Re: [edk2-devel] [PATCH 0/3] Introduce SecTpmMeasurementLibTdx >=20 > Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: Xu, Min M > > Sent: Sunday, June 5, 2022 9:03 AM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; Yao, Jiewen ; > > Wang, Jian J ; Aktas, Erdem > > ; James Bottomley ; Tom > > Lendacky ; Gerd Hoffmann > > > Subject: [PATCH 0/3] Introduce SecTpmMeasurementLibTdx > > > > SecTpmMeasurementLibTdx is an instance of TpmMeasurement lib in SEC > phase. > > It provides RTMR based measurement functions for Intel Tdx guest. > > > > Commit a708536dce introduces SecMeasurementLibTdx which provides the > > same > > functions. But it is not an instance of TpmMeasurementLib. > > We have updated DxeTpmMeasurementLib (which is an instance of > > TpmMeasurementLib) to support RTMR based measurement. To make the > > design > > consistent, SecTpmMeasurementLibTdx is introduced. After that > > SecMeasurementLibTdx is removed. > > > > Patch #1: > > Introduce SecMeasurementLibTdx > > Patch #2: > > Update OvmfPkg to support MeasureHobList/MeasureFvImage with > > SecMeasurementLibTdx. > > Patch #3: > > Remove SecMeasurementLibTdx. > > > > Code: https://github.com/mxu9/edk2/tree/secMeasurementLib.v1 > > > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Erdem Aktas > > Cc: James Bottomley > > Cc: Jiewen Yao > > Cc: Tom Lendacky > > Cc: Gerd Hoffmann > > Signed-off-by: Min Xu > > > > Min M Xu (3): > > Security: Add SecTpmMeasurementLibTdx > > OvmfPkg: Implement MeasureHobList/MeasureFvImage > > OvmfPkg: Delete SecMeasurementLibTdx > > > > OvmfPkg/Include/Library/SecMeasurementLib.h | 46 --- > > OvmfPkg/IntelTdx/IntelTdxX64.dsc | 2 +- > > OvmfPkg/Library/PeilessStartupLib/IntelTdx.c | 186 ++++++++++ > > .../PeilessStartupLib/PeilessStartup.c | 1 - > > .../PeilessStartupInternal.h | 36 ++ > > .../PeilessStartupLib/PeilessStartupLib.inf | 2 +- > > .../SecMeasurementLib/SecMeasurementLibTdx.c | 340 ------------------ > > .../SecMeasurementLibTdx.inf | 30 -- > > OvmfPkg/OvmfPkg.dec | 4 - > > .../SecTpmMeasurementLibTdx.c | 176 +++++++++ > > .../SecTpmMeasurementLibTdx.inf | 34 ++ > > SecurityPkg/SecurityPkg.dsc | 2 + > > 12 files changed, 436 insertions(+), 423 deletions(-) > > delete mode 100644 OvmfPkg/Include/Library/SecMeasurementLib.h > > delete mode 100644 > > OvmfPkg/Library/SecMeasurementLib/SecMeasurementLibTdx.c > > delete mode 100644 > > OvmfPkg/Library/SecMeasurementLib/SecMeasurementLibTdx.inf > > create mode 100644 > > SecurityPkg/Library/SecTpmMeasurementLib/SecTpmMeasurementLibTdx.c > > create mode 100644 > > SecurityPkg/Library/SecTpmMeasurementLib/SecTpmMeasurementLibTdx.inf > > > > -- > > 2.29.2.windows.2 >=20 >=20 >=20 >=20 >=20