From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web08.23309.1639239229289788446 for ; Sat, 11 Dec 2021 08:13:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.com header.s=intel header.b=OJUut7zO; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jiewen.yao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639239229; x=1670775229; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=kVdfHJViL6ZTJ7PQHIDWiWI/NRhlemqd8nibdYsyIxc=; b=OJUut7zOeyf/Q8UGmrMIgVPE5CZ2rqWt/dcYfFy5RIo+ZWZWNLnOg7sk NzrxkjBYS9UUb2wlPsRDSJb+xsXlaVpadiOcOfQ4g+gUDu2o0ogSDYaB6 kelJFYA4jbFIBRhMw4tj+m1XObYmUBeDfTLKOHemtWXVrGlW1pn0OPOD5 XBMZG1Pkn1ka04IY7zV5s8CVi3fXhn1WOAHXDIi1nIEj+0LmxoSrdQOgZ RkBl5DlHdVl5rgKGvYhN++PkOzAeuJn4uVa3oxVKW73OKcT8PyAFLqOsm EhL7uPCT0fixngqZWfr6at0n+qzylw0UwOLjlFYU3xmw35XzS2+7rVYmd A==; X-IronPort-AV: E=McAfee;i="6200,9189,10195"; a="262659425" X-IronPort-AV: E=Sophos;i="5.88,198,1635231600"; d="scan'208";a="262659425" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2021 08:13:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,198,1635231600"; d="scan'208";a="660201619" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 11 Dec 2021 08:13:47 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 11 Dec 2021 08:13:47 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 11 Dec 2021 08:13:47 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sat, 11 Dec 2021 08:13:47 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sat, 11 Dec 2021 08:13:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m3WKuc5HpRF+QHXYRdsqUdKKBVT79cDbij9h6IoYhlWE+ksLMzCNVc2CFT3hNqnn8Ko3zsF765lg1hhwbM5cNgR4OnJpMbIOheEass6BI2StBKBCoSQ2+EX/uv+qgp3sqVCRXOY4L2hI88cHTufWbljPcOUjQypDEX8fhvoJjvCipqe868poxSI0uw5a2shKaKn7BSruj0Dj38thpeTvOAmwrBYjixG+HeKrusMI/UjbZQrfewH4CYXEtEIC7+2J2jSyKxKn29XJwAwuHhFuP7SwwIHSwHwJP3AgZW5OunXqk/tWaafcEAjcRnfXa8atTLqUng8ZeJkYQ6P1pJfD7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kVdfHJViL6ZTJ7PQHIDWiWI/NRhlemqd8nibdYsyIxc=; b=mhxYtfe20ceooundEYiD5kO0EJA0iASm+G6Fng04k1kTsNu/Cy1MQsbu638iLIlfr9MIrMc+Zw/bkJueaoztLELe8lLapiAUaUKwKOgFmogpDqKxP33/50E1i0LukRegPeeRRHIu1ZOmuBR7DPnahcLYGVaK/X3LN+2o8XpSSwubBvq5M0ZmKPvxP5OgNdc7wXeysmPjlX6pr1tN3lgIpVppq/HehxIJFZgvR9eKMhxy7zASdMsfBBdaSgf7MF3y/EcAsV0iT35uW4PxneTzxWKZsOEX4v8hYVxmVIsrzyqLfGPD1XOLONJjKu8iTHRo45pIGW8jTt6LYlux6C8H1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kVdfHJViL6ZTJ7PQHIDWiWI/NRhlemqd8nibdYsyIxc=; b=GmNbv5ojvu5CkQHBl3Y9VqO7Uhw7pYt+isTXr7DjDT+qzsLxc1zTVWjSaQwvFOpdQrocMGPkDlKzUox+qq+kYvGv94QRmzYPZfEeqRZZKJm46XgHpOm79oN7eKyZioxIYSwUPpnZp0acLrPCVxeHT0A97XFLHoLJYRt+jMBqkig= Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by MWHPR1101MB2173.namprd11.prod.outlook.com (2603:10b6:301:5a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.15; Sat, 11 Dec 2021 16:13:46 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::447f:7fbc:72f5:fbae]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::447f:7fbc:72f5:fbae%5]) with mapi id 15.20.4778.012; Sat, 11 Dec 2021 16:13:45 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Yao, Jiewen" , "kraxel@redhat.com" , "lixianglai@loongson.cn" Subject: Re: [edk2-devel] [PATCH] OvmfPkg-EmuVariableFvbRuntimeDxe: Support Access To Memory Above 4G Thread-Topic: [edk2-devel] [PATCH] OvmfPkg-EmuVariableFvbRuntimeDxe: Support Access To Memory Above 4G Thread-Index: AQHX6puAOit9zcnH6USns6PwKmgUZqwtdF3wgAAKedA= Date: Sat, 11 Dec 2021 16:13:45 +0000 Message-ID: References: <13a7bcbac5bbc7f9cd6a26d6d8ac4eb30f059ec2.1638759596.git.lixianglai@loongson.cn> <20211206121859.vqw2jfpxdagi5hvw@sirius.home.kraxel.org> <16BFBD5C8AF150FF.19089@groups.io> In-Reply-To: <16BFBD5C8AF150FF.19089@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a1fd7e8-5ea8-4206-a543-08d9bcc1355a x-ms-traffictypediagnostic: MWHPR1101MB2173:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F9eFpUHTX+k/Y00hm9RdFlGC/XSmiLT95SWMelb/KDKcZpBw+nXb6JwbKj8obhq8admofmrqR3DftrvSP0PMPNpYXeER66gr0CuUbnj3l7stXznYUKnHmpYAFGx9rO2Z1jzD8VM7NXnCi67UnoihZBGTsmKJeCQyw8T530SBI3wtBarZRmCQIky5VtdolqUiW9RNSAW/0b83SqycoRcprVrc8KxPhn6eLAW3XMb6F4RJiuTe6WpDqK0E6YvBquNzu+y/ntJGGvBnKE8uI4sbJYbIZp/ciKGGa3o9yl3y6+7mSTgcIpsUCbU8UU1xBDtGFAe4ixocfqDHH4z/ukxac3T+7gG9Q47G9E78vUZjkcM0zeJe21lS6e69MfEbKgL6RlUkdaZixm4V9tQ1TxxAP8tup/JocEeA/Ab0zZTPxuNMe9q2MO7UVXRB2XyCBSMbs/h0YT4Y8smm0BvcoOQozjbMYp/zkMme79U67LaFNHoQBS8kZ1KuHfnHP40XO43RFc8mEENcQLF5/beWGMTWlV6I8yO+WMH9UH1ASny1bICu+UgEIRUB2EJqHReDoL/tEKZz4wHqIX65ONRqRU1Mnml6ueFucVX1gIVNMPzCMyvT6Z3dU+X4w85+fl/mPhSSWeAGJA9Ey8GJs6uLFxqcty1NTUjE/w59T+bH6DKcJK5PMPzFQDO+eGlnt3+sDuQJcUsQm/Ft5JOaK1kCdOnRr8xT6k9hMkKW3Dxp48FGvKiDOCUZIeoT1iIBaWkRlQmlV5E05dNj3dtfr540LiwmTYAnAEk8TKkd8cinZ6965w3kLi65FX5C3Da4CL8pJIF0dLwyrKjgXqom5XS+blS10HHbS7Su5gdQqztvM2ypKLc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5872.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(122000001)(316002)(8676002)(9686003)(55016003)(83380400001)(966005)(7696005)(38100700002)(19627235002)(33656002)(26005)(186003)(82960400001)(6506007)(53546011)(86362001)(76116006)(8936002)(508600001)(5660300002)(38070700005)(66476007)(66946007)(64756008)(66446008)(71200400001)(2906002)(110136005)(66556008)(52536014)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0MfUvFZRX0IfUnllnoflZrdHfgYT6nKIGiHQ0XkLStr2CbtNFXgSmYcqPaFT?= =?us-ascii?Q?srARCBRqXtfduH+P6UltaBnNQaGn4rg3Hs6S9C4RZcQIgb06zc8a7Jw4DrxY?= =?us-ascii?Q?XSYo7svqVsmN1gmsKLMz4B67kkMMrEkjg1SssKNh2VkJ8Smyiug8L39o9OjJ?= =?us-ascii?Q?xhEjY2iwAyaw7HHZu9BSIYnxY7loPSXy/YAWuHjRr0jwnygEDxgpa8uB55yI?= =?us-ascii?Q?NfsZgnhO+mgYxVH8TtP6H1xUAxHeiBo2ZMlKv9O+lFVLz9yRW9NX+8ptNKFn?= =?us-ascii?Q?HlQvWiKCsgYWEfzwxkhrQ/kZ10WUux2lI7rX5NMS+VUGldjG7fShj7Y2gj+6?= =?us-ascii?Q?oVhNMrvNgG7krwfOOrwOzz+V10Rv+pCtEUXbCn7RuhEkAMVZlrZdITdDQ8Fk?= =?us-ascii?Q?y8+dPGINOwbqIb2drS1EfheFl66AhwJ+OWPbmBKHP39iGMqoB7c/4whVCcM8?= =?us-ascii?Q?Lbnl2ix619sA16Pjbh/rS9ACrnePhgIGaB+es2o417+I+096oRFrpxyMJ18x?= =?us-ascii?Q?4yIn0oUCoF5QjeE6HyvJaNGPBmWyp/GoJUv+qQyw9SnXLCqvIucircB3nuap?= =?us-ascii?Q?L9gc/rk0tCHMBXl2s+dPJnV5yLKQf4bwFibvKY4FmN0qWWmHEF3cUYUv//y/?= =?us-ascii?Q?GZQN12qsFscLvHZiUXdMOq2aZnNIamib29wOZkgQ+iW0APLDPk2C7nq182eT?= =?us-ascii?Q?bFSD862+9RC1LCPKoeABENGGB0F8VCRvqIkRSBvGmHUfC3wN1gFtYlpVOcpb?= =?us-ascii?Q?ZKo66TaBj/EFvDf4lcCtQE1CepJFWZm83soVHj4kVxLGyrsd9T76QjL2Hd80?= =?us-ascii?Q?/QpRBFG7KpDNZ8lSO5ABSt0hyG71trZUi1naxvC7mGEe7cR2ETIfSPxKS8Gh?= =?us-ascii?Q?V9pp1uAN93FyH2h877fE8VIK36wszA+E8hFo596vOImPYq+ppj3QTVwu2TNN?= =?us-ascii?Q?niBPVVjpja6Gn80QgkjWxjZof98T4npPb11Yi4GLhYLYNp8H2UISIXtbPmEP?= =?us-ascii?Q?xWNeLgvkrDJOOaJ/sEzDnBxj5Nn5gynMSkaphrkS8yXyuJQU0jxpX/2gPaY4?= =?us-ascii?Q?kMFaLRbQKsRFkgj5rx6aTKm9XNo28LBWZv1OtHmp8WDQ1qtP6lAaJqK1oeY/?= =?us-ascii?Q?4PxdFXkO5irGLO4Vgio8NAZY4iTXdOmAh2LniZm7XTQ+VI2794Ro8KCqXVm/?= =?us-ascii?Q?ST4nrVdSH7l9IJC8JNL50NT7f4wlmbO8ivl7TdjO8H29MhEhRxrh2I79CaeB?= =?us-ascii?Q?FgFURpaluW5O0LuEZQmuCNMqhKw9nng7/2Ny7K06iykkJ+v0uxs9G0vBbzSr?= =?us-ascii?Q?Y0JvEjnmm6sZahBvtAVWHZ4eOmVyLSRIsQqaqncpPrbCn12TbojFs7PnWtCH?= =?us-ascii?Q?R1375gTXXG5hyZIEctGCQ2nha8Gn3W4+ZNsETY+X1qsdU+ztKqVXV/Bcvw+k?= =?us-ascii?Q?8e4GSkT0ArSRUBfhD9Ds/p3urDPWz3Ol/hB7UogmPWMWgZlTCi77wUS60Fsv?= =?us-ascii?Q?z9BfUi2rdUSyIxAzf96TLwS08blMLX7theYCAeQ7c0sEGKIRa+fBtA9fA2qe?= =?us-ascii?Q?Dtf6w6n+7lbQKr/lDyj2JWThhYksFvskoDQ5YdLsHn9ZqhHCVf+wtx6jgmXL?= =?us-ascii?Q?cAzuT/7O2nrCIJI9lASJOM8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a1fd7e8-5ea8-4206-a543-08d9bcc1355a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2021 16:13:45.8370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bZ+2Zq++Nfxi5ni1uf6FLqOCHlojnd5xU6+g8MxQmC56yC5DY08a7ttTbGAcQMLpPH/aU9LQTCLhmS87A/BCzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2173 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged https://github.com/tianocore/edk2/pull/2290 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewe= n > Sent: Saturday, December 11, 2021 11:36 PM > To: devel@edk2.groups.io; kraxel@redhat.com; lixianglai@loongson.cn > Subject: Re: [edk2-devel] [PATCH] OvmfPkg-EmuVariableFvbRuntimeDxe: > Support Access To Memory Above 4G >=20 > Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Gerd > > Hoffmann > > Sent: Monday, December 6, 2021 8:19 PM > > To: devel@edk2.groups.io; lixianglai@loongson.cn > > Subject: Re: [edk2-devel] [PATCH] OvmfPkg-EmuVariableFvbRuntimeDxe: > > Support Access To Memory Above 4G > > > > On Mon, Dec 06, 2021 at 12:00:33PM +0800, xianglai wrote: > > > In FvbInitialize Function, > > > PcdFlashNvStorageVariableBase64 PcdFlashNvStorageFtwWorkingBase > > > PcdFlashNvStorageFtwSpareBase will not exceed 0x100000000, > > > Due to truncation and variable type limitations. > > > That leads to the NV variable cannot be saved to the memory above 4G. > > > > > > Modify as follows: > > > 1.Remove the forced type conversion of UINT32. > > > 2.Use UINT64 type variables. > > > > > > Signed-off-by: xianglai li > > > > Reviewed-by: Gerd Hoffmann > > > > > > > > > > >=20 >=20 >=20 >=20 >=20